Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157104947
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2454
@srdo Can you explain how can the drawback scenario you describe in your
[comment](https://github.com/apache/storm/pull/2454#issuecomment-351428500)
happen? When activate happens, refresh partitions
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2460
+1
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157842966
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/internal/OffsetManagerTest.java
---
@@ -55,12 +58,12 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157831079
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -115,26 +115,30 @@ public KafkaSpoutConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157831049
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -115,26 +115,30 @@ public KafkaSpoutConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157831266
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -204,33 +226,70 @@ private void initialize(Collection
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
@srdo this is the master version.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157930206
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157930210
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157930231
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java
---
@@ -71,6 +75,10 @@
1
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo can you please do one last review. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo it should be good now. Can you please take a look. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I am working on making unit tests pass and then will squash and
create master PR. Can you take another look in the meantime. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r151886343
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -292,17 +292,21 @@ private Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2426#discussion_r151887752
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -718,7 +718,13 @@ private static void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2427
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2426
+1. Thanks @srdo. Can you please squash the commits before merging. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2438
@arunmahadevan @HeartSaVioR @srdo this patch has been merged into master
and 1.x-branch
---
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/2438
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2438#discussion_r155007745
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -242,9 +242,7 @@ public void nextTuple
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2409
@HeartSaVioR there is not one major project that does not require
contributors to merge commits. It takes a few minutes and it makes a world of
difference in terms of making the git log easy
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2451
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@arunmahadevan I am looking into this now. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2448
@Ethanlm can you please "Quick Fix" with "MINOR: " Thanks.
+1 after fixing the commit message.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2448
@Ethanlm yeah, I noticed it right after my comment. Somehow I had not
refreshed my PRs view. If it is easy I will change the commit message since I
am about to merge something. Otherwise we will just
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r155909342
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -359,7 +356,7 @@ private Builder(Builder builder
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@srdo aiming to getting this PR merged more quickly I created a
[PR](https://github.com/srdo/storm/pull/1) with a suggested fix off your
branch. If you agree with the fix, can you please incorporate
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156223919
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -186,12 +182,13 @@ private void initialize(Collection
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156220249
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -395,7 +387,7 @@ private boolean emitOrRetryTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156208523
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -186,12 +182,13 @@ private void initialize(Collection
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156208684
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -223,29 +220,24 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156224126
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -395,7 +387,7 @@ private boolean emitOrRetryTuple
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@srdo although some of these methods have been deprecated for 2.0,
customers that are currently in a 1.x.y version will likely use this version
for a few years. We will have to maintain this codebase
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2393
@HeartSaVioR for 1.x-branch
---
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2394
1.x branch storm 2787 ks init flag
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache
1.x-branch_STORM-2787_KSInitFlag
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012506
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012458
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012467
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012486
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146997432
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2385
@govind-menon why is YSTORM-2725 prefixed by Y? Should it be STORM-2725? If
so, can you please fix the typo. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146996683
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146996955
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146997051
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013419
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013385
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013717
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -255,26 +255,25 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013620
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -125,8 +125,8 @@ public void open(Map<String, Obj
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147014032
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015173
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015407
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015438
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147016997
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147022902
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2387
STORM-2787: storm-kafka-client KafkaSpout method onPartitionsRevoked(...)
should set initialized flag independently of processing guarantees
You can merge this pull request into a Git repository
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2393
STORM-2781: Refactor storm-kafka-client KafkaSpout Processing Guarantees
- Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE
- Refactor method name from
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2394
@HeartSaVioR for 1.x-branch
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2464#discussion_r158205889
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutReactivationTest.java
---
@@ -0,0 +1,145
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2464
Can you please squash the commits. You can merge after.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253569
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253597
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253552
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
@srishtyagrawal Thank you for the code review. It is much better now.
Besides my two comments above, I still wonder if it would be better to point
the links with the description of the Kafka properties
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253611
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r186887493
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
true
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2667
+1
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r187100160
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
true
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
+1
@srishtyagrawal thank you for your nice and helpful contribution. It will
benefit a lot of users.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185160807
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168182
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185163739
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168807
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185161496
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168952
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168669
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185167619
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
@erikdw I am reviewing this now. Sorry but I was away the last few days.
---
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2380
STORM-2781: Refactor storm-kafka-client KafkaSpout Processing Guarantees
- Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE
- Refactor method name from
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2381
STORM-2784: storm-kafka-client KafkaTupleListener method onPartitionsâ¦
â¦Reassigned() should be called after initialization is complete
You can merge this pull request into a Git repository
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2387
@srdo @HeartSaVioR I have incorporated the code review changes of the
depending patch. It should be good to merge. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2380
I have squashed the commits and addressed the early return issue.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120269
--- Diff: external/storm-solr/README.md ---
@@ -97,6 +97,29 @@ field separates each value with the token % instead of
the default | . To use th
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159121022
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilderV2.java
---
@@ -0,0 +1,127 @@
+/**
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120398
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -153,4 +160,15 @@ private void failQueuedTuples(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120315
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -88,9 +92,11 @@ private int capacity() {
@Override
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120320
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -128,6 +134,7 @@ private void fail(Tuple tuple, Exception e
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120430
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/SolrFieldTypeFinder.java
---
@@ -70,13 +73,22 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120287
--- Diff: external/storm-solr/README.md ---
@@ -171,7 +194,7 @@ Querying Solr for these patterns, you will see the
values that have been indexe
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120311
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -88,9 +92,11 @@ private int capacity() {
@Override
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120406
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/config/SolrConfig.java
---
@@ -54,4 +65,7 @@ public int getTickTupleInterval
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119896
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119938
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119878
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158573100
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutAbstractTest.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo done. Pls check and I will squash the commits right away. I would
like to try to merge this in today. I will update the master PR with everything
squashed already. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158572508
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo It should be OK now. If you have further requests lest's file a
refactoring JIRA and include in it refactoring some of the unit tests for
better code reuse.
---
601 - 700 of 782 matches
Mail list logo
