Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/commit/0c9a8a47513fa6e47d25ddc3650531a6619f089d#commitcomment-12343448
@dan-blanchard the topology upload functionality created a security
vulnerability, so we removed it until we can provide a more
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/644#issuecomment-124560610
@arunmahadevan Quick question (I haven't done a full review yet): Is there
a way to make this work for Timed rotation policies? That one of the most
widely used rot
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/644#issuecomment-124612279
It took me some time to follow what's going on with this patch, so I'll
document it here for the benefit other reviewers.
It operates by using the co
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/653#issuecomment-125960027
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-130444965
I have a few things that I think need to be fixed before we publish this.
But rather than enumerate every last little thing and ask you to fix them, I'd
rather ju
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-130452561
@harshach I'm not suggesting we create a feature branch, I'm suggesting we
change the way we publish the site to make it easier for people to contribute
to. I
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/644#issuecomment-131192881
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/684#discussion_r37129089
--- Diff: bin/storm-config.cmd ---
@@ -83,10 +83,10 @@ if not defined STORM_LOG_DIR (
)
@rem
-@rem retrieve storm.logback.conf.dir from
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37897758
--- Diff: external/storm-solr/README.md ---
@@ -0,0 +1,188 @@
+# Storm Solr
+Storm and Trident integration for Apache Solr. This package includes a
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37898067
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37898379
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37898773
--- Diff:
external/storm-solr/src/test/java/org/apache/storm/solr/topology/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37899232
--- Diff: pom.xml ---
@@ -169,8 +169,9 @@
external/storm-redis
external/storm-eventhubs
external/flux
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-134693551
I left a few minor comments. There are a few .gitignore files that can be
removed, and the documentation should use the Maven shade plugin, instead of
the assembly
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37901014
--- Diff: external/storm-solr/pom.xml ---
@@ -0,0 +1,106 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/711#issuecomment-136884363
+1 Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-139618704
+1
I will merge this into a new empty "asf-site" branch and work with INFRA to
setup git-based publishing, which will eliminate the extra svn step
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-139621217
@harshach This has been merged into the "asf-site" branch. Can you close
this pull request?
---
If your project is set up for it, you can reply to this emai
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-140895741
@revans2 @d2r @knusbaum Can you guys summarize all the issues this
addresses? It looks like it covers a lot. I noticed that at some point an issue
with shading was
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-142992324
@revans2 let me quickly check to make sure the release process works with
this. Be aware that there will be some commits as a result that I will revert.
---
If your
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-143020062
Unfortunately, I'm -1 at this point since it breaks the release process
(Maven release plugin) and I could not find a workaround.
The main problem is th
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/741#issuecomment-143020557
-1 (for now) for the reasons listed in the comments on #736.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-143268083
@revans2 The release process for pushing maven artifacts is:
```
mvn release:prepare -P dist
mvn release:perform -P dist
```
That prepares
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/764
STORM-950: Update website for publishing.
https://issues.apache.org/jira/browse/STORM-950
This pull request builds on the previous work:
* adds a people section
* cleaned up
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-144190863
@revans2 That seems reasonable to me. Let me make sure that works for
deploying to Nexus and get back to you. If it works then I'm fine with these
changes.
---
If
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-145092203
I did some more digging and figured out that the following commit:
https://github.com/apache/storm/pull/621
is what broke the packaging for flux
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/736#issuecomment-145139265
+1
Thanks for your patience @revans2, and for bearing with me. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/741#issuecomment-145142851
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/780#discussion_r41063314
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/FailedMsgRetryManagerConfig.java ---
@@ -0,0 +1,7 @@
+package storm.kafka;
+
+import
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/780#discussion_r41064149
--- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
@@ -39,6 +39,8 @@
public double retryDelayMultiplier = 1.0;
public
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/777#issuecomment-145146770
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/776#issuecomment-145148520
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/772#discussion_r41065490
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java
---
@@ -53,21 +61,62 @@ public HBaseBolt withConfigKey(String
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/772#discussion_r41065530
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java
---
@@ -53,21 +61,62 @@ public HBaseBolt withConfigKey(String
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/772#issuecomment-145152697
To @revans2's point about backwards compatibility, I think we should make
batching optional and default to the old behavior. That way users won't be
surprise
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/771#issuecomment-145155047
@HeartSaVioR Publishing is still svn-based, git based publishing is not yet
enabled. I will update the README when git publishing gets turned on.
---
If your project is
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/770#issuecomment-145155118
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/769#issuecomment-145155436
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146341025
Should we consider overloading and deprecating vs. renaming to preserve
backwards compatibility for the short term?
---
If your project is set up for it, you can reply
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/784#issuecomment-146677423
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/783#issuecomment-146677802
+1 Nice catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/782#issuecomment-146677901
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/61#issuecomment-146684243
@d2r Yes, I think this pull request can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/71#issuecomment-146684414
@d2r Thanks for the reminder. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ptgoetz closed the pull request at:
https://github.com/apache/storm/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2913
+1
---
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/950
STORM-1395: move JUnit dependency to top-level pom
https://issues.apache.org/jira/browse/STORM-1395
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/955
STORM-1399: Blobstore tests should write data to target so it gets reâ¦
â¦moved when running mvn clean
https://issues.apache.org/jira/browse/STORM-1399
You can merge this pull request
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/955#discussion_r47971375
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java
---
@@ -76,6 +76,7 @@
@Before
public void
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/954#issuecomment-166366554
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/962#issuecomment-16775
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/964#issuecomment-166693980
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/984#issuecomment-168754322
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/985#issuecomment-168754927
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/981#issuecomment-168792176
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/979#issuecomment-168794540
@d2r I'm fine with updating the instructions. If I remember correctly (it's
been a while ;) ), it was to make it very easy for new users to see a topology
ru
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-168801983
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/976#issuecomment-168802302
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/974#issuecomment-168803581
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/966#issuecomment-168805521
+1
@d2r Did you create a follow-up JIRA for new multi-lang tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/951#issuecomment-168808016
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/936#discussion_r48782534
--- Diff: pom.xml ---
@@ -204,7 +204,7 @@
0.2.4
3.3.2
0.9.0
-16.0.1
+15.0
--- End diff
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/936#issuecomment-168812437
Minor nit, but several instances throughout:
Can you update the style so that all `if` blocks are enclosed in `{}` (even
if it is only one line)?
---
If your
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/970#issuecomment-168813390
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/885#issuecomment-168816433
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/465#issuecomment-168825799
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/599#issuecomment-168829281
-1 flux-wrappers add convenience multi-lang spout/bolt implementations.
Arguably, they could be included in flux-core. I'd rather go that route than
set flux-wrappe
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/651#issuecomment-168831787
@mooso Any update?
@rsltrifork Would you be willing to make the change/PR based on the earlier
comments?
---
If your project is set up for it, you can reply to
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/667#issuecomment-168877269
I agree with @d2r, or would at least answer that, yes, we should hold off
on cgroups support until the jstorm merge. I believe that @revans2 might have
already covered
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/477#issuecomment-168881795
Ping (mostly to other committers to solicit review/discussion).
This is not a bad idea.
---
If your project is set up for it, you can reply to this email and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-168884966
I'm all for adopting a code style guide for all languages (Java, Clojure,
Python, etc.), but I'd rather see a style specification documented first, then
foll
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-169059247
@d2r Good point. I know there was some work done around moving to idiomatic
clojure and making style consistent, but I don't think we ever put together a
style guid
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/929#issuecomment-169060207
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/988#issuecomment-169060886
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/983#issuecomment-169063324
+1 Confirmed that `back type.storm.messaging.AddressedTuple` is not used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/982#issuecomment-169065098
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r48869637
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -92,11 +94,19 @@ private void ack(Tuple tuple) throws
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/975#issuecomment-169068835
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/991
STORM-1406: Add MQTT Support
https://issues.apache.org/jira/browse/STORM-1406
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/storm storm
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/991#issuecomment-169145828
Initial commit for code review. Further documentation to follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r48976235
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttOptions.java
---
@@ -0,0 +1,334 @@
+/**
+ * Licensed to the Apache
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r48976202
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r48976364
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/MqttLogger.java ---
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r48976420
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/bolt/MqttBolt.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r48987203
--- Diff: external/storm-mqtt/core/pom.xml ---
@@ -0,0 +1,153 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r49006394
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r49160828
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/trident/MqttPublishFunction.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/991#issuecomment-170105203
@satishd, @arunmahadevan, @HeartSaVioR Thanks for your reviews. I believe
I've addressed all your comments. I've also added documentation.
---
If your project
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/939#issuecomment-171028002
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/963#discussion_r49506460
--- Diff:
examples/storm-starter/src/jvm/storm/starter/StatefulWindowingTopology.java ---
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/963#discussion_r49507663
--- Diff: storm-core/src/jvm/org/apache/storm/state/StateProvider.java ---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/963#issuecomment-171044220
+1 aside from 2 very minor nits, but the feature is sizable so I'd like to
see additional committer reviews.
I'd also like to see this included
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1003#issuecomment-171045749
@revans2 looks like this was originally #996, which had the requisite +1s,
but needed an upmerge. I think @caofangkun just opened a new pull request and
closed #996
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/475#issuecomment-171048834
Unless others feel strongly about this change, I think it's okay to close
this.
---
If your project is set up for it, you can reply to this email and have your
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/608#issuecomment-171049571
@bourneagain Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/1008
Merge changes from {master}/docs to {asf-site}
JIRA: https://issues.apache.org/jira/browse/STORM-1468
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/1009
STORM-1468: remove {master}/docs
JIRA: https://issues.apache.org/jira/browse/STORM-1468
The content of the {master}/docs directory is now in the {asa-site} branch.
You can merge this pull
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1009#issuecomment-171126186
Assuming lazy consensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1008#issuecomment-171126410
Assuming lazy consensus, but would appreciate review in case I missed
anything.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1009#issuecomment-171126632
See also #1008
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
401 - 500 of 774 matches
Mail list logo
