Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1468
I'll also point out that the "if other Apache projects do it, it is oaky"
stance is particularly dangerous. PMC members must understand ASF policy and
not rely on what other projects d
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1468
I'm okay with automating the merge process, just not the way it is
implemented here. Perhaps we shouldmove the discussion to the dev list.
---
If your project is set up for it, you can reply
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1642
I have a few style-related nits, but I've refrained from pointing them out
because the style(s) in the codebase are all over the place, and the style is
inherited in some places. If we want to get
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1691
Just to be clear, that wasn't a criticism. I just wanted to point out that
it is important that we know the provenance and license of all code that enters
our repository.
---
If your project
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1691
This a fairly large commit that seemingly includes code from other
projects. That's fine as long as you can document what code was copied, and
what the license for that code was.
---
If your
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1711
@asmaier Could you create a JIRA ticket for this and update the title so
it's prefixed with the JIRA ID?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1691
@raghavgautam Nope. All is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1711#discussion_r80280538
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ByteKeyValueScheme.java ---
@@ -0,0 +1,33 @@
+package org.apache.storm.kafka;
--- End
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1732
+1 Thanks for catching this @HeartSaVioR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/1745
STORM-2174: Initial Base for Storm Beam Runner
This is an (very) initial pass at laying the foundation for a Beam runner
for Storm. It currently only supports local mode, and is incomplete
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1740
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1693
@arunmahadevan I will review. Before you start working on a prototype beam
runner, let me push what I have to a feature branch. I have a fair amount of
the basic scaffolding you would need
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1744
Nice (and a lot of ;) ) work!
Nimbus.java is a little unwieldy, but I understand why. Maybe it can be a
target for some refactoring later on.
+1 (Note that I haven't manually tested
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
Okay, that last commit answered a lot of questions I had regarding
packaging. ;)
+1 I was able to build a distribution, unpack it, and run the drpc service.
---
If your project is set up
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r91586225
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/runner/jpmml/JpmmlFactory.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1781
@mkoch1 Thanks for addressing the license issue. The way you handled the
borrowed code looks fine, the important part is to leave the original copyright
statement, which you did. Thanks for pointing
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
@revans2 Okay. Let me review the packaging changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1816
Looks like a good start, but it really needs some documentation. It would
also be helpful to include a sample model + CSV data, without that it's not
very clear how to run the example.
---
If your
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1816
Also, what about unit tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1803
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1818
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1746
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1765
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1821
One minor nit: It would be helpful to construct the exceptions with a
message explaining what happened.
Other than that I'm +1.
---
If your project is set up for it, you can reply
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1136
@vesense Any update on this? It looks like pystorm/streamparse are waiting
for this to be merged.
cc @dan-blanchard
---
If your project is set up for it, you can reply to this email
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense @HeartSaVioR Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1821
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92243287
--- Diff: external/storm-pmml/README.md ---
@@ -0,0 +1,104 @@
+#Storm PMML Bolt
+ Storm integration to load PMML models and compute predictive scores
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92244506
--- Diff: examples/storm-pmml-examples/src/main/resources/Audit.50.csv ---
@@ -0,0 +1,51 @@
+ID,Age,Employment,Education,Marital,Occupation,Income,Gender
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92257368
--- Diff:
examples/storm-pmml-examples/src/main/resources/KNIME_PMML_4.1_Examples_single_audit_logreg.xml
---
@@ -0,0 +1,259 @@
+
--- End diff
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1812
+1 Thanks for the update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1783
+1, but I agree with @HeartSaVioR that the new cache configuration options
need to be documented before this is merged.
---
If your project is set up for it, you can reply to this email and have
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
+1. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1745
@revans2 @arunmahadevan Thanks for the review. I will merge this to the
beam runner feature branch so others can submit pull requests against it.
@arunmahadevan Yes, the GBK implementation
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1786
+1. I haven't done any manual testing of this patch, but I reviewed the
code and it looks good.
I wouldn't mind seeing more javadoc comments in some of the new
classes/interfaces
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1801
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1802
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1786#discussion_r90311211
--- Diff: storm-core/src/jvm/org/apache/storm/testing/CompletableSpout.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1764#discussion_r90317672
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java
---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1765#discussion_r90317167
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java
---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1764
One question about the for loop in WordCountTopology. I'm +1 once that's
answered/addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1765
One question about the for loop in WordCountTopology. I'm +1 once that's
answered/addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1781
Unfortunately this patch uses Cassandra-unit, which is LGPL licensed, so in
it's current state we can't accept it. For that reason I am -1. We've run into
this before, and I've lobbied the Cassandra
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1786
@revans2 Thanks. Still +1.
(One procedural nit: Rebasing/squashing on big PRs like this can make
reviews a little harder. E.g. After you added the javadocs I wanted to review
just
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1765#discussion_r90534501
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java
---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1584
My apologies for letting this go without review for so long.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1764
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1845
JIRA? Rationale?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r93312373
--- Diff: storm-dist/binary/final-package/src/main/assembly/binary.xml ---
@@ -446,6 +446,29 @@
storm*jar
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1816
@hmcl Do you plan to add unit tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1974
+1 @revans2 Was #1972 cherry-picked to the 1.x and 1.0.x branches?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/2018
STORM-2416: Improve Release Packaging to Reduce File Size
This brings the binary distribution file size down from > 200MB to ~79MB.
You can merge this pull request into a Git repository by runn
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/2017
STORM-2416: Release Packaging Improvements
This reduces the size of the binary distribution from > 200MB to ~79MB.
You can merge this pull request into a Git repository by running:
$ git p
Github user ptgoetz closed the pull request at:
https://github.com/apache/storm/pull/2017
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106933223
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
storm
org.apache.storm
-1.1.1-SNAPSHOT
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2018
@HeartSaVioR Yes, that's my plan. I prioritized the 1.1.x branch since it's
needed for the 1.1.0 release.
I'm not sure we want to apply it to the 1.0.x branch since we have a number
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/2064
STORM-1114: Handle race condition in Storm/Trident transactional statâ¦
Handle race condition in Storm/Trident transactional state when ZK nodes
have already been created/deleted. This impacts
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131180462
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131180727
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2250
+1
Minor nit: It generates html, but not an html *document* (i.e. missing
head, body, etc. tags), but that's just a few print statements that can be
added at merge time.
---
If your
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131191016
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132748013
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/DisruptorMetrics.java ---
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132746643
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/ReliableWordCount.java
---
@@ -0,0 +1,121 @@
+package org.apache.storm.starter
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132746702
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/ReliableWordCount.java
---
@@ -0,0 +1,121 @@
+package org.apache.storm.starter
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132746674
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/ReliableWordCount.java
---
@@ -0,0 +1,121 @@
+package org.apache.storm.starter
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132746791
--- Diff: conf/defaults.yaml ---
@@ -293,3 +293,28 @@ storm.daemon.metrics.reporter.plugins:
# configuration of cluster metrics consumer
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132747934
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -139,6 +139,9 @@
@isString
public static final String
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132746948
--- Diff: storm-core/pom.xml ---
@@ -700,10 +707,10 @@
org.eclipse.jetty
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r132746888
--- Diff: external/storm-autocreds/pom.xml ---
@@ -15,9 +15,7 @@
See the License for the specific language governing permissions and
limitations
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/2203
STORM-2153: New Metrics Reporting API
See JIRA for more information:
https://issues.apache.org/jira/browse/STORM-2153
You can merge this pull request into a Git repository by running
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@erikdw Of course! This needs to be documented, and if accepted (or likely
to be), I will do so. But if there's community consensus around NOT accepting
this patch, I'd rather not waste the effort
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@HeartSaVioR
> Do we plan to close all of sub-issues after merging this patch?
No. I'm proposing a alternative. The RocksDb license issue is a blocker, so
I'm proposing we m
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2232
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2234
Thanks @vesense!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2241
Let's not be too hard on the Heron community. Yes, in the past they've not
been exactly friendly in terms of marketing and technical claims, but now that
Heron is incubating as an Apache project
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
> @ptgoetz Suppose we deprecate the built-in metrics, are they deprecated
for public API or also Storm codebase? If we would want latter, we should have
alternative way to collect metrics (ma
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2234
@omerhadari Could you remove the wildcard imports? I'm +1 once that's done.
Also do you mind creating a corresponding JIRA ticket for this and updating
the title of this pull request
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2060
+1 Sorry for the delayed review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2088
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2111
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2329
+1
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@HeartSaVioR
> We need to document how to use new metrics and its reporter, and also
need to have patch for master branch (maybe with removal of metrics V1 public
API).
A
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@arunmahadevan
> Currently this patch addresses registering custom metrics and sending the
metrics out via reporters and does not send any metrics to nimbus right? Why is
disruptor metr
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141137596
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141137280
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141131796
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/AnchoredWordCount.java
---
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141924200
--- Diff: storm-core/src/jvm/org/apache/storm/metrics2/Metrics2Utils.java
---
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@revans2, @HeartSaVioR, @arunmahadevan Addressed review comments.
Also note that this is a feature branch, so it's open to pull requests from
anyone. If there's anything you'd like to see
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@revans2 I agree with you regarding getting the metrics naming correct. In
fact I think it's one of the most important aspects. I'd like to get as much
input/collaboration from others as possible
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141922507
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@revans2 Added rudimentary sanity check validation for metrics reporters
configs. Because reporter implementations may want to have their own custom
config keys, we can't really cover everything. I
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2409
@HeartSaVioR Thanks for the review. Addressed your comment and fixed
another issue discovered in testing.
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@HeartSaVioR Thanks for the update. I pulled your changes into the
metrics_v2 branch.
@revans2 I'll start working on naming conventions and disallowing certain
delimiter characters. If you
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@HeartSaVioR Agreed/understood. We can squash on merge and cleanup commit
messages.
This is a feature branch. You can commit directly if you want.
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
> Looks like we compose metric name and lookup from REGISTRY every time,
even without executor ID and stream ID. I can see more calculation should be
done after addressing, but not sure how m
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157056998
--- Diff: storm-core/src/jvm/org/apache/storm/metric/IEventLogger.java ---
@@ -31,32 +32,54 @@
/**
* A wrapper for the fields that we
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157056272
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompan
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2459
+1
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2447
+1
---
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157091241
--- Diff: storm-core/src/jvm/org/apache/storm/metric/IEventLogger.java ---
@@ -31,32 +32,54 @@
/**
* A wrapper for the fields that we
501 - 600 of 679 matches
Mail list logo
