Github user curtisallen commented on the pull request:
https://github.com/apache/storm/pull/361#issuecomment-97934446
@revans2 now we throw NPEs if the values are missing. Leveraged guava's
`Preconditions` . Let me know if you need anything else. Thanks!
---
If your project is set
Github user curtisallen commented on the pull request:
https://github.com/apache/storm/pull/361#issuecomment-97487810
@revans2 Thanks for looking at this. Before we didn't throw any exceptions
when the config was incorrect. I added this
[line](https://github.com/curtisallen/storm
Github user curtisallen commented on the pull request:
https://github.com/apache/storm/pull/361#issuecomment-97513938
@revans2 agreed, the concerns you brought make a lot of sense to me. I
should have some time later this week to fail fast ;)
---
If your project is set up
Github user curtisallen commented on a diff in the pull request:
https://github.com/apache/storm/pull/361#discussion_r22474338
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -41,6 +41,14 @@
private String _topic;
public
Github user curtisallen commented on a diff in the pull request:
https://github.com/apache/storm/pull/361#discussion_r22474024
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -149,4 +158,19 @@ private Broker getBrokerHost(byte[] contents
GitHub user curtisallen opened a pull request:
https://github.com/apache/storm/pull/361
STORM-603 Log errors when required kafka params are missing
https://issues.apache.org/jira/browse/STORM-603
I was upgrading our topologies to storm-0.9.3 this
[commit](https
Github user curtisallen commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-59975061
Any chance this can make it into v0.9.3-rc2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
