Re: Request for holding off commits to storm-client module

2017-07-27 Thread Jungtaek Lim
Now pull request for STORM-2306 is up, and it looks like requiring several weeks (months?) to be verified. IMHO the effort of rebasing is unavoidable (though we could put effort to minimize), especially pull requests were up already. Unfortunately, that's about who takes the load, and I don't

Re: Request for holding off commits to storm-client module

2017-07-24 Thread Roshan Naik
I am fully ok with rebasing. I don’t expect development on Storm to cease while the PR gets reviewed. Its only changes to storm-client are likely to require to be done differently or not needed at all for the new system (like some fixes that went recently into Disruptor). So only for changes

Re: Request for holding off commits to storm-client module

2017-07-23 Thread Jungtaek Lim
Hi Roshan, I guess rebasing could be necessary even while in review phase, so personally I'd rather see the PR first even it has merge conflict between origin master branch, and have review process with changes in PR, and address once review process is done. If you want to hold off commits just

Request for holding off commits to storm-client module

2017-07-23 Thread Roshan Naik
Storm Devs, My PR for STORM-2306 (messaging subsystem redesign) is almost ready. Not surprisingly, this PR brings extensive modifications in storm-client module and touches lightly on some others. Just finished manually rebasing my local changes (to ~90 files) from an old version of master