Github user yasserzamani commented on the pull request:
https://github.com/apache/struts-site/commit/8caf5affd5c5539843e82c99a98f10ccf80fcf13#commitcomment-24460748
No problem :) I see.
Lukasz Lenart <notificati...@github.com> ÙÙشت:
argh... sorry,
Github user yasserzamani commented on the pull request:
https://github.com/apache/struts-site/commit/8caf5affd5c5539843e82c99a98f10ccf80fcf13#commitcomment-24459427
So, struts2-archetype-blank.md's layout should be set to default too; The
above layout provides a back to parent link
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts-site/pull/15#discussion_r140228542
--- Diff: source/maven-archetypes/index.md ---
@@ -3,155 +3,146 @@ layout: default
title: Maven Archetypes (WIP)
---
-#Struts 2
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts-site/pull/15
Fixes "Maven Archetypes" (initial version)
Thanks a lot Regular Expressions ð
You can merge this pull request into a Git repository by running:
$ git pull https://
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts-site/pull/14
Adds missing internal anchors in "How To Help FAQ" page
Sorry, this fixes my #12 mistakes.
You can merge this pull request into a Git repository by running:
$ git
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts-site/pull/13
Fixes link of "Googleâs Patch Reward program"
In home welcome page, when visitor clicks on "read more" of "Google's Patch
Reward program" section, he
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts-site/pull/12
Fixes links in TOC of "How To Help FAQ" page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yasserzamani/struts-si
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/167
Finished. I tested on heavy concurrent load using Servlet 3's async API
several times. Before last commit, the response of some requests was mixed-up
with others! But now all of them are right
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/167
Ouch! In #164 I refactored JSONWriter as a static member of JSONUtil. As I
guessed, it fails to generate correct response in concurrent loads :(
Please give me a few time. I'm going
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/167
I'm in no rush, I just wished to know. thanks for your works ð
---
-
To unsubscribe, e-mail: dev-unsubscr
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/167
WW-4034 Allows to use custom JSONwriter
Wow! I really enjoyed this work! thanks to S2's nice design!
Just a small query about documenting it please. While documentations
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/164
In second commit I added a control in such planning to also resolve
[WW-4034: Allow to use custom
JSONwriter](https://issues.apache.org/jira/browse/WW-4034
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/164
WW-4846 Does not traverse/include proxy info in JSONResult
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yasserzamani/struts WW-4846
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/153
> Thanks a lot :) I see now what's going on but have no idea why :\
@lukaszlenart , as I debug, the trace is `object factory creation` then
`set1 (inject it's 1st property)` then `s
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/153
:) Yes I know, just a bit worry about backward compatibility between minor
versions.
I also am studying your sample and @lukaszlenart 's pr to understand what
is going on as I think
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/153
@aleksandr-m , I modified `ObjectFactory` as below
```java
...
private List myPrivateInjectQueue;
...
@Inject
public void setContainer(Container container
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/153
To keep `backward-compatible` if is very important, I think we may have
following:
```java
protected Object injectInternalBeans(Object obj) {
if (obj != null
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/147
WW-4805: Adds constant to control proxy member access (support-2-3)
Ports #146 to branch support-2-3.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/146
Thanks! I am working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/146
Thank you. Would we need same for support-2-3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/145
@lukaszlenart , it seems it was occurred just on your local PC during git
fetch and there is not any issue with github or original apache repositories.
Please revert your local changes and try
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/145
OK, I tried JDK6 which firstly has failed with heap out of memory message
at `Running org.apache.struts2.components.UIComponentTest`. But when I replaced
JDK with a 64bit version and `-Xmx2048m
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/145
Thanks! I did not try JDK6. Please let me check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/145
Yes. All done by coping just raw texts then delete or edit them. I was
aware that merging will mix things up and is confusing so I avoided.
Do you have trouble withe mirrored github
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/145
Forgot to say I did not any cherry-pick :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/145
ð When I was in my branch `master`, I checked out my `support-2-3`. Then
I pulled apache `support-2-3` then pushed into my `support-2-3`. I confirmed
via github that my `support-2-3
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/145
WW-4805 Ports some of PR #142 changes to branch support-2-3
Ports only security related changes of #142 to branch support-2-3
You can merge this pull request into a Git repository by running
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/144
WW-4744 WW-4694 Removes annotation search to commons lang 3.6
During resolution of WW-4744 and WW-4694, I duplicated some works with
annotations into Apache commons lang. Now, they just
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/143
WW-4794 Fixes wrapField's where clause
Removes wrong `!` from `wrapField`'s where clause.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
@lukaszlenart , Yes with pleasure. I should come with a new PR but on
branch support-2-3, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
Thank you @lukaszlenart , I got your point but what about when user uses
Spring but not S2's Spring Plugin? i.e. when user does not want to define
his/her actions as Spring beans but wants
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
*I forgot to emphasis that after my third commit, `isProxyMember` just have
to search two Spring interfaces which includes a few members.
---
If your project is set up for it, you can reply
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
> But isAccessible is called quite often even for rather simple actions.
So what do you recommend? Adding a cache? or something else you think about.
> Also it would b
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
However, in my next commit, I try to check if `member` is belong to Spring,
which decreases search space and improves performance. Currently it checks if
`member` is not belong to user's config
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
I think it's not a problem. It's complexity is O(n) where n is MAX(number
of inheritances, interfaces or inner proxies) which are usually small.
---
If your project is set up for it, you can
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/142
Blocks ognl access to class members of Spring proxy
Fixes what I sent to secur...@struts.apache.org (3/15/2017)
You can merge this pull request into a Git repository by running:
$ git
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/125
@aleksandr-m , not me but my workmate has used it as an ID for each jsp. I
do not know his work details but in general, he then uses this ID to decide
where he should place the result after
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/139
WW-4800 Executes aspects when chaining AOPed actions
These fix some bugs in my previous PR, #135 which passes the unwrapped
object of the proxied action to the `reflectionProvider.copy
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/135
@lukaszlenart , I updated with @aleksandr-m reviews. I hope it is ready for
merge if you pals agree.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r115767804
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114156448
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114155980
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114115750
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114115598
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114115548
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114115352
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/135
WW-4105 Unwraps Spring proxy in actions chain
Resolves [WW-4105](https://issues.apache.org/jira/browse/WW-4105).
You can merge this pull request into a Git repository by running:
$ git
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
With thanks a ton to @aleksandr-m , as I checked that unwrapping Spring
proxies works with reflection without any needed dependency (like @aleksandr-m
mentioned above), please let me close
Github user yasserzamani closed the pull request at:
https://github.com/apache/struts/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
I checked too. It does not work as expected on proxy classes ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
However, today I found I should improve above pseudocode to following,
because maybe user himself has extended a class and wants to use method1 from
extended class in action1 and use method2
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
# Eureka!
Thank you! I have found it. We can know the config time class of the action
without any new thing with something like following pseudocode:
```
methodName
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
> Remember that issue that you've submitted to security list? All actions
are affected. With this proposal bean attribute must be added to every action
configuration in the applicat
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
> What do you mean by that? There is no bean name.
Users may set `class` attribute to a 1.class name or to a 2.bean name. I
meant I think it is not nice to use `class` attrib
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/133
@aleksandr-m , thank you for your reply.
> I'm still against adding bean attribute to action configuration. It is
not intuitive.
But I think using attribute `class` for b
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/133
WW-4105 Considers config time class in actions chain
I think it is `ready for merge` and does not break backward compatibility.
The added `bean` attribute is and should be optional always
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/125
Below is my new design which may be helpful as an example for whom is
affected. Those are about access to
`%{#context['com.opensymphony.xwork2.dispatcher.HttpServletRequest'].requestURI
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
@lukaszlenart , Yes in my opinion, Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
â
All copied Spring's code including what I was imported in previously
merged [PR#117](https://github.com/apache/struts/pull/117) removed ð
After merge of [LANG-1317
PR](https
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
> Do we need custom annotation utility at all? Can't we just use existing
libraries e.g. Apache Commons MethodUtils?
Thank you @aleksandr-m !
I am working on it. I star
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
I also wait for ASF LEGAL part's answer but after some study, it seems I
was not allowed to do such work ð If so, I think I have to write my own
utils at where @aleksandr-m mentioned; re
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/124#discussion_r107110525
--- Diff:
core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java ---
@@ -150,25 +166,32 @@ public static void addAllInterfaces(Class
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
> We must rather ask ASF legal body, you can post an issue in JIRA (see
above)
Thank you. As I could not find similar issue, I created [Merge others codes
having same lice
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
> Yasser explain why he did that
Thank you for your review.
`AnnotationUtils` is not a new class but to avoid reinventing the wheel, I
copied and merged some codes from Spr
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
I close this as more general, better, cleaner and robust resolution is
implementing [WW-4751](https://issues.apache.org/jira/browse/WW-4751)
improvement which I am working on :)
---
If your
Github user yasserzamani closed the pull request at:
https://github.com/apache/struts/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/124
WW-4744: AnnotationUtils supports non-public methods
With these changes, AnnotationUtils also has equipped with an internal
cache. Mainly, getAnnotatedMethods and all it's usages have improved
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@aleksandr-m , Thank you for your time and comments; please let me know
what do you think about below; I would like to be sure about usefulness before
starting implementation
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , @aleksandr-m , thank you for your comments. Today I did not
have enough time to prepare more dangerous security issue example but until I
prepare one in comming days, please
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@aleksandr-m , as an example, consider when action proxified with another
technology like Spring and the user assumes that Struts2 only operates in it's
borders, but currently, Struts2 does
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , thank you, so I will add only one attribute named `bean`.
if specified, we use that improvement, elsewhere current behavior. i.e. we will
keep old behavior but with some
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , Yes, surely attribute `bean` is, will be and should be
optional. Also there are no problem with actions which used attribute `class`
as a class not a bean name
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , another thing where I need your recommendation is, after
this improvement, all users have to convert from
```xml
```
to
```xml
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , I love to implement that but as changes may occur in
several places from Core to Plugins e.g. JSONResult, I decided to get your
agreement and confirmation if you also agree
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , this could be postponed to resolution of
[WW-4751](https://issues.apache.org/jira/browse/WW-4751).
---
If your project is set up for it, you can reply to this email and have
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/119
[WW-4741] Do not force session creation on locale read operation
These changes prevent Struts to create session for request when it tries to
check if request's session has pre-putted locale
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
I improved this PR with an interesting Unit Test which prevents similar
issues occurrence in future i.e. it checks if `chaining Spring AOPed actions`
always works. This Unit Test reproduce
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
@lukaszlenart , I am not able to mark this PR with a label `Ready for
merge`. I think because I should not have write access to this repository.
---
If your project is set up for it, you can
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/118
ð PR re-based with last master and ChainingInterceptor equipped with an
optional param (editableClass) which user can set to a custom class (or
interface) fully qualified name to restrict
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r101312503
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r101302678
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r101285251
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r101103182
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r100990614
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r100990118
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r100774641
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on a diff in the pull request:
https://github.com/apache/struts/pull/118#discussion_r100774158
--- Diff:
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
@@ -160,7 +160,20 @@ private void copyStack
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/117
Thank you. I got it and will fix it by update my eclipse Preferences.
And what about the new codes and comments? some of them are copied from
`Spring` framework which itself has `Apache
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/118
[WW-4105] OgnlUtil improved in order to only setting properties defined
With these changes,
[OgnlUtil](https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/117
[WW-4694] annotation processing improved
With these changes,
[AnnotationUtils](https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/116
[WW-4528] handling ChainingInterceptor excludes and includes lists
With these changes, they will be handled as comma separated String like
what ParameterFilterInterceptor do.
You can merge
Github user yasserzamani closed the pull request at:
https://github.com/apache/struts/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yasserzamani commented on the pull request:
https://github.com/apache/struts/pull/49#issuecomment-139486524
@aleksandr-m is genius. Using token tag with different names in same JSP
page handles this need perfectly.
---
If your project is set up for it, you can reply
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/49
WW-4539 Support list of tokens to prevent CSRF attack in async requests
Nowadays, modern web applications use JQuery, and so, they can send
multiple async requests in parallel to the web server
94 matches
Mail list logo
