[jira] [Commented] (SUBMARINE-276) Submarine runtime class config should be defined in the new configuration class

2019-11-12 Thread Zac Zhou (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973083#comment-16973083 ] Zac Zhou commented on SUBMARINE-276: [~leosun08], As the issue blocks development

[jira] [Comment Edited] (SUBMARINE-276) Submarine runtime class config should be defined in the new configuration class

2019-11-12 Thread Zac Zhou (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973083#comment-16973083 ] Zac Zhou edited comment on SUBMARINE-276 at 11/13/19 7:35 AM: --

[GitHub] [submarine] jiwq commented on a change in pull request #91: SUBMARINE-66. Improve TF config env JSON generator + tests

2019-11-12 Thread GitBox
jiwq commented on a change in pull request #91: SUBMARINE-66. Improve TF config env JSON generator + tests URL: https://github.com/apache/submarine/pull/91#discussion_r345554660 ## File path: submarine-server/server-submitter/submitter-yarnservice/src/main/java/org/apache/submarine

[jira] [Commented] (SUBMARINE-66) Improve TF config env JSON generator + tests

2019-11-12 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972411#comment-16972411 ] Adam Antal commented on SUBMARINE-66: - PR created for the new repo. > Improve TF c

[jira] [Work logged] (SUBMARINE-66) Improve TF config env JSON generator + tests

2019-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-66?focusedWorklogId=341920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341920 ] ASF GitHub Bot logged work on SUBMARINE-66: --- Author: ASF GitHub B

[GitHub] [submarine] adamantal opened a new pull request #91: SUBMARINE-66. Improve TF config env JSON generator + tests

2019-11-12 Thread GitBox
adamantal opened a new pull request #91: SUBMARINE-66. Improve TF config env JSON generator + tests URL: https://github.com/apache/submarine/pull/91 ### What is this PR for? * The goal is to update the TensorFlow config generation. Also some of the tests were doing some manual JSON thin

[jira] [Updated] (SUBMARINE-290) Update submainre DEFAULT_RUNTIME_CLASS

2019-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-290: - Labels: pull-request-available (was: ) > Update submainre DEFAULT_RUNTIME_CLASS > ---

[jira] [Work logged] (SUBMARINE-290) Update submainre DEFAULT_RUNTIME_CLASS

2019-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-290?focusedWorklogId=341827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341827 ] ASF GitHub Bot logged work on SUBMARINE-290: Author: ASF GitHu

[GitHub] [submarine] pingsutw opened a new pull request #90: SUBMARINE-290. Update submainre DEFAULT_RUNTIME_CLASS

2019-11-12 Thread GitBox
pingsutw opened a new pull request #90: SUBMARINE-290. Update submainre DEFAULT_RUNTIME_CLASS URL: https://github.com/apache/submarine/pull/90 ### What is this PR for? After SUBMARINE-255 merged, we rename our runtimes to ``` org.apache.submarine.server.submitter.yarn.YarnRuntimeF

[jira] [Created] (SUBMARINE-290) Update submainre DEFAULT_RUNTIME_CLASS

2019-11-12 Thread kevin su (Jira)
kevin su created SUBMARINE-290: -- Summary: Update submainre DEFAULT_RUNTIME_CLASS Key: SUBMARINE-290 URL: https://issues.apache.org/jira/browse/SUBMARINE-290 Project: Apache Submarine Issue Type:

[GitHub] [submarine] tangzhankun commented on issue #87: SUBMARINE-267. Initial job server which defines REST skeleton

2019-11-12 Thread GitBox
tangzhankun commented on issue #87: SUBMARINE-267. Initial job server which defines REST skeleton URL: https://github.com/apache/submarine/pull/87#issuecomment-552819425 @yuanzac @jiwq , my local build doesn't have this dependency convergence issue. Could you please help to clone the code

[GitHub] [submarine] adamantal commented on issue #64: SUBMARINE-67. Add tests to Localizer class

2019-11-12 Thread GitBox
adamantal commented on issue #64: SUBMARINE-67. Add tests to Localizer class URL: https://github.com/apache/submarine/pull/64#issuecomment-552804712 Thanks for the review and commit @jiwq and @yuanzac ! This is an automated me

[jira] [Updated] (SUBMARINE-67) Add tests to Localizer class

2019-11-12 Thread Zac Zhou (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou updated SUBMARINE-67: -- Fix Version/s: 0.3.0 Resolution: Fixed Status: Resolved (was: Patch Available) Iss

[jira] [Work logged] (SUBMARINE-67) Add tests to Localizer class

2019-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-67?focusedWorklogId=341768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341768 ] ASF GitHub Bot logged work on SUBMARINE-67: --- Author: ASF GitHub B

[GitHub] [submarine] asfgit closed pull request #64: SUBMARINE-67. Add tests to Localizer class

2019-11-12 Thread GitBox
asfgit closed pull request #64: SUBMARINE-67. Add tests to Localizer class URL: https://github.com/apache/submarine/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[submarine] branch master updated: SUBMARINE-67. Add tests to Localizer class

2019-11-12 Thread zhouquan
This is an automated email from the ASF dual-hosted git repository. zhouquan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new d2045ce SUBMARINE-67. Add tests to Localiz

[GitHub] [submarine] yuanzac commented on issue #64: SUBMARINE-67. Add tests to Localizer class

2019-11-12 Thread GitBox
yuanzac commented on issue #64: SUBMARINE-67. Add tests to Localizer class URL: https://github.com/apache/submarine/pull/64#issuecomment-552800379 Thanks, @adamantal for your contribution. Thanks @liuxunorg and @jiwq for your review. I'll merge this PR shortly. --