[GitHub] [submarine] pingsutw commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG

2020-03-13 Thread GitBox
pingsutw commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG URL: https://github.com/apache/submarine/pull/226#discussion_r392250288 ## File path:

[GitHub] [submarine] pingsutw commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG

2020-03-13 Thread GitBox
pingsutw commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG URL: https://github.com/apache/submarine/pull/226#discussion_r392085834 ## File path:

[GitHub] [submarine] yuanzac commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG

2020-03-12 Thread GitBox
yuanzac commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG URL: https://github.com/apache/submarine/pull/226#discussion_r392007909 ## File path:

[GitHub] [submarine] pingsutw commented on issue #226: SUBMARINE-84. Set random port in TF_CONFIG

2020-03-12 Thread GitBox
pingsutw commented on issue #226: SUBMARINE-84. Set random port in TF_CONFIG URL: https://github.com/apache/submarine/pull/226#issuecomment-598194732 @liuxunorg Thanks for the reminder. update it. This is an automated

[GitHub] [submarine] yuanzac opened a new pull request #227: SUBMARINE-428. Add job table in db to store job status.

2020-03-12 Thread GitBox
yuanzac opened a new pull request #227: SUBMARINE-428. Add job table in db to store job status. URL: https://github.com/apache/submarine/pull/227 ### What is this PR for? We have to store job status in db. So that we don't need to get job status by k8s/yarn API every time. ###

[GitHub] [submarine] liuxunorg commented on issue #226: SUBMARINE-84. The environment variable TF_CONFIG hard coded port number "8000" will cause distributed training job's worker fail to start

2020-03-12 Thread GitBox
liuxunorg commented on issue #226: SUBMARINE-84. The environment variable TF_CONFIG hard coded port number "8000" will cause distributed training job's worker fail to start URL: https://github.com/apache/submarine/pull/226#issuecomment-598171034 @pingsutw PR title is too long.

[GitHub] [submarine] pingsutw opened a new pull request #226: SUBMARINE-84. The environment variable TF_CONFIG hard coded port number "8000" will cause distributed training job's worker fail to start

2020-03-12 Thread GitBox
pingsutw opened a new pull request #226: SUBMARINE-84. The environment variable TF_CONFIG hard coded port number "8000" will cause distributed training job's worker fail to start URL: https://github.com/apache/submarine/pull/226 ### What is this PR for? When there's no network

[GitHub] [submarine] asfgit closed pull request #225: SUBMARINE-421. Support restrict spark configurations

2020-03-12 Thread GitBox
asfgit closed pull request #225: SUBMARINE-421. Support restrict spark configurations URL: https://github.com/apache/submarine/pull/225 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [submarine] yaooqinn opened a new pull request #225: SUBMARINE-421. Support restrict spark configurations

2020-03-12 Thread GitBox
yaooqinn opened a new pull request #225: SUBMARINE-421. Support restrict spark configurations URL: https://github.com/apache/submarine/pull/225 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing

[GitHub] [submarine] asfgit closed pull request #224: SUBMARINE-425. Optimize java style check in github actions

2020-03-11 Thread GitBox
asfgit closed pull request #224: SUBMARINE-425. Optimize java style check in github actions URL: https://github.com/apache/submarine/pull/224 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [submarine] yaooqinn commented on issue #224: SUBMARINE-425. Optimize java style check in github actions

2020-03-11 Thread GitBox
yaooqinn commented on issue #224: SUBMARINE-425. Optimize java style check in github actions URL: https://github.com/apache/submarine/pull/224#issuecomment-597989990 cc @yuanzac @liuxunorg thanks guys This is an automated

[GitHub] [submarine] yaooqinn opened a new pull request #224: SUBMARINE-425. Optimize java style check in github actions

2020-03-11 Thread GitBox
yaooqinn opened a new pull request #224: SUBMARINE-425. Optimize java style check in github actions URL: https://github.com/apache/submarine/pull/224 ### What is this PR for? the current java style check does not show the root cause for us. ### What type of PR is

[GitHub] [submarine] cchung100m commented on issue #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager

2020-03-11 Thread GitBox
cchung100m commented on issue #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager URL: https://github.com/apache/submarine/pull/223#issuecomment-597966700 @liuxunorg Thanks for managing this PR. :)

[GitHub] [submarine] asfgit closed pull request #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager

2020-03-11 Thread GitBox
asfgit closed pull request #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager URL: https://github.com/apache/submarine/pull/223 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [submarine] asfgit closed pull request #222: SUBMARINE-424. Enable scala style check in github actions

2020-03-11 Thread GitBox
asfgit closed pull request #222: SUBMARINE-424. Enable scala style check in github actions URL: https://github.com/apache/submarine/pull/222 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [submarine] yaooqinn commented on issue #222: SUBMARINE-424. Enable scala style check in github actions

2020-03-11 Thread GitBox
yaooqinn commented on issue #222: SUBMARINE-424. Enable scala style check in github actions URL: https://github.com/apache/submarine/pull/222#issuecomment-597706331 cc @liuxunorg @yuanzac This is an automated message from

[GitHub] [submarine] asfgit closed pull request #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
asfgit closed pull request #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [submarine] cchung100m opened a new pull request #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager

2020-03-11 Thread GitBox
cchung100m opened a new pull request #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager URL: https://github.com/apache/submarine/pull/223 ### What is this PR for? Solve potential NPE for MockRemoteDirectoryManager MockRemoteDirectoryManager#getModelDir:

[GitHub] [submarine] yaooqinn opened a new pull request #222: SUBMARINE-424. Enable scala style check in github actions

2020-03-11 Thread GitBox
yaooqinn opened a new pull request #222: SUBMARINE-424. Enable scala style check in github actions URL: https://github.com/apache/submarine/pull/222 ### What is this PR for? add some scala style check rule from http://www.scalastyle.org/rules-1.0.0.html enable it in the GitHub

[GitHub] [submarine] kevin85421 commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
kevin85421 commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221#discussion_r390984116 ## File path: docs/development/IntegrationTest.md ## @@ -12,17 +12,13 @@ limitations under the

[GitHub] [submarine] kevin85421 commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
kevin85421 commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221#discussion_r390981493 ## File path: docs/development/IntegrationTest.md ## @@ -12,17 +12,13 @@ limitations under the

[GitHub] [submarine] pingsutw commented on issue #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
pingsutw commented on issue #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221#issuecomment-597642241 Thanks @kevin85421, GitHub actions failure seems unrelated This is an

[GitHub] [submarine] yuanzac commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
yuanzac commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221#discussion_r390951022 ## File path: docs/development/IntegrationTest.md ## @@ -12,17 +12,13 @@ limitations under the

[GitHub] [submarine] yuanzac commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
yuanzac commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221#discussion_r390954315 ## File path: docs/development/IntegrationTest.md ## @@ -12,17 +12,13 @@ limitations under the

[GitHub] [submarine] kevin85421 opened a new pull request #221: SUBMARINE-423. Update the E2E test document

2020-03-11 Thread GitBox
kevin85421 opened a new pull request #221: SUBMARINE-423. Update the E2E test document URL: https://github.com/apache/submarine/pull/221 ### What is this PR for? Update the E2E test document ### What type of PR is it? [Improvement] ### Todos ### What is

[GitHub] [submarine] asfgit closed pull request #220: SUBMARINE-420. Full TPCDS test coverage for spark security plugin

2020-03-11 Thread GitBox
asfgit closed pull request #220: SUBMARINE-420. Full TPCDS test coverage for spark security plugin URL: https://github.com/apache/submarine/pull/220 This is an automated message from the Apache Git Service. To respond to

[GitHub] [submarine] yaooqinn commented on issue #220: SUBMARINE-420. Full TPCDS test coverage for spark security plugin

2020-03-11 Thread GitBox
yaooqinn commented on issue #220: SUBMARINE-420. Full TPCDS test coverage for spark security plugin URL: https://github.com/apache/submarine/pull/220#issuecomment-597485833 cc @liuxunorg This is an automated message from

[GitHub] [submarine] yaooqinn opened a new pull request #220: SUBMARINE-420. Full TPCDS test coverage for spark security plugin

2020-03-11 Thread GitBox
yaooqinn opened a new pull request #220: SUBMARINE-420. Full TPCDS test coverage for spark security plugin URL: https://github.com/apache/submarine/pull/220 ### What is this PR for? As we rewrite spark SQL plans in the spark-security plugin, we don't want to break anything AS-IS

[GitHub] [submarine] asfgit closed pull request #219: SUBMARINE-418. Support Data Masking for spark-security

2020-03-11 Thread GitBox
asfgit closed pull request #219: SUBMARINE-418. Support Data Masking for spark-security URL: https://github.com/apache/submarine/pull/219 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [submarine] yaooqinn commented on issue #219: SUBMARINE-418. Support Data Masking

2020-03-11 Thread GitBox
yaooqinn commented on issue #219: SUBMARINE-418. Support Data Masking URL: https://github.com/apache/submarine/pull/219#issuecomment-597469609 cc @liuxunorg This is an automated message from the Apache Git Service. To

[GitHub] [submarine] yaooqinn opened a new pull request #219: SUBMARINE-418. Support Data Masking

2020-03-11 Thread GitBox
yaooqinn opened a new pull request #219: SUBMARINE-418. Support Data Masking URL: https://github.com/apache/submarine/pull/219 ### What is this PR for? add data masking for spark-security, which enable administrators to mask sensitive data per column e.g. phone num

[GitHub] [submarine] asfgit closed pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-10 Thread GitBox
asfgit closed pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215 This is an automated message from the Apache Git Service. To

[GitHub] [submarine] liuxunorg commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-10 Thread GitBox
liuxunorg commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-597155649 LGTM Will merge if no more comments.

[GitHub] [submarine] asfgit closed pull request #218: SUBMARINE-417. Support Row Filtering

2020-03-10 Thread GitBox
asfgit closed pull request #218: SUBMARINE-417. Support Row Filtering URL: https://github.com/apache/submarine/pull/218 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [submarine] yaooqinn commented on issue #218: SUBMARINE-417. Support Row Filtering

2020-03-10 Thread GitBox
yaooqinn commented on issue #218: SUBMARINE-417. Support Row Filtering URL: https://github.com/apache/submarine/pull/218#issuecomment-596919165 cc @liuxunorg @yuanzac, thanks for reviewing in advance This is an automated

[GitHub] [submarine] yaooqinn opened a new pull request #218: SUBMARINE-417. Support Row Filtering

2020-03-09 Thread GitBox
yaooqinn opened a new pull request #218: SUBMARINE-417. Support Row Filtering URL: https://github.com/apache/submarine/pull/218 ### What is this PR for? Add row-level filtering feature to spark-security, which provider administrators to set system-level filters to end-users. e.g.

[GitHub] [submarine] asfgit closed pull request #217: SUBMARINE-416. [SDK] GitHub actions support pysubmarine

2020-03-09 Thread GitBox
asfgit closed pull request #217: SUBMARINE-416. [SDK] GitHub actions support pysubmarine URL: https://github.com/apache/submarine/pull/217 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [submarine] liuxunorg commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
liuxunorg commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-596904890 Oh, I didn't notice the `{$lowercase_filename}IT.java` rule. If so, then it won't change.

[GitHub] [submarine] kevin85421 commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
kevin85421 commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-596895049 > It seems that travis of apache/submarine has some problems and is not run. > It is correct to see

[GitHub] [submarine] pingsutw commented on issue #217: SUBMARINE-416. [SDK] GitHub actions support pysubmarine

2020-03-09 Thread GitBox
pingsutw commented on issue #217: SUBMARINE-416. [SDK] GitHub actions support pysubmarine URL: https://github.com/apache/submarine/pull/217#issuecomment-596891574 @liuxunorg Thanks for the review This is an automated message

[GitHub] [submarine] liuxunorg commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
liuxunorg commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-596890637 It seems that travis of apache/submarine has some problems and is not run. It is correct to see the

[GitHub] [submarine] cchung100m commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
cchung100m commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214#issuecomment-596884111 Thanks. @liuxunorg This is an automated

[GitHub] [submarine] asfgit closed pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
asfgit closed pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214 This is an automated message from the Apache Git Service. To respond to

[GitHub] [submarine] pingsutw opened a new pull request #217: SUBMARINE-416. [SDK] GitHub actions support pysubmarine

2020-03-09 Thread GitBox
pingsutw opened a new pull request #217: SUBMARINE-416. [SDK] GitHub actions support pysubmarine URL: https://github.com/apache/submarine/pull/217 ### What is this PR for? Support submarine SDK to use GitHub actions for a fast testing ### What type of PR is it? [Improvement]

[GitHub] [submarine] kevin85421 commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
kevin85421 commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#discussion_r390062217 ## File path:

[GitHub] [submarine] kevin85421 commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
kevin85421 commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#discussion_r390062137 ## File path:

[GitHub] [submarine] cchung100m commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
cchung100m commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-596859270 Hi @kevin85421 Thanks for the awesome work! Please fix the reported errors and

[GitHub] [submarine] cchung100m commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
cchung100m commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214#issuecomment-596856574 Hi @liuxunorg Thanks for the feedback. I re-triggered the CI process.

[GitHub] [submarine] asfgit closed pull request #216: SUBMARINE-415. Show databases command to allow exposing filtered databases

2020-03-09 Thread GitBox
asfgit closed pull request #216: SUBMARINE-415. Show databases command to allow exposing filtered databases URL: https://github.com/apache/submarine/pull/216 This is an automated message from the Apache Git Service. To

[GitHub] [submarine] cchung100m commented on a change in pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
cchung100m commented on a change in pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214#discussion_r390042276 ## File path:

[GitHub] [submarine] jasoonn commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
jasoonn commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#discussion_r390030652 ## File path:

[GitHub] [submarine] jasoonn commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
jasoonn commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#discussion_r390029839 ## File path:

[GitHub] [submarine] jasoonn commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
jasoonn commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#discussion_r390029839 ## File path:

[GitHub] [submarine] yuanzac commented on a change in pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
yuanzac commented on a change in pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214#discussion_r389785192 ## File path:

[GitHub] [submarine] liuxunorg commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
liuxunorg commented on a change in pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#discussion_r389775759 ## File path:

[GitHub] [submarine] kevin85421 edited a comment on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
kevin85421 edited a comment on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-596599015 @jasoonn @liuxunorg Can you help me review the pr? Thanks!

[GitHub] [submarine] kevin85421 commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
kevin85421 commented on issue #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215#issuecomment-596599015 @jasoonn @liuxunorg Can you help me review the pr?

[GitHub] [submarine] kevin85421 opened a new pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular

2020-03-09 Thread GitBox
kevin85421 opened a new pull request #215: SUBMARINE-398. Implement frontend of data-dict page in workbench with Angular URL: https://github.com/apache/submarine/pull/215 ### What is this PR for? Implement frontend of the data-dict page in workbench with Angular ### What type

[GitHub] [submarine] asfgit closed pull request #213: SUBMARINE-414. Refine Github action and travis

2020-03-09 Thread GitBox
asfgit closed pull request #213: SUBMARINE-414. Refine Github action and travis URL: https://github.com/apache/submarine/pull/213 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [submarine] liuxunorg commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
liuxunorg commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214#issuecomment-596576690 @cchung100m This PR travis not passed. This is

[GitHub] [submarine] cchung100m commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
cchung100m commented on issue #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214#issuecomment-596567532 Hi @szilard-nemeth I would appreciate that if you can help to review it, thanks.

[GitHub] [submarine] cchung100m opened a new pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

2020-03-09 Thread GitBox
cchung100m opened a new pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent URL: https://github.com/apache/submarine/pull/214 ### What is this PR for? RemoteDirectoryManager contains many methods that receive a URI. The types are sometimes

[GitHub] [submarine] asfgit closed pull request #212: SUBMARINE-413. Custom show databases command to allow exposing filtered databases

2020-03-09 Thread GitBox
asfgit closed pull request #212: SUBMARINE-413. Custom show databases command to allow exposing filtered databases URL: https://github.com/apache/submarine/pull/212 This is an automated message from the Apache Git Service.

[GitHub] [submarine] yaooqinn opened a new pull request #213: SUBMARINE-414. Refine Github action and travis

2020-03-09 Thread GitBox
yaooqinn opened a new pull request #213: SUBMARINE-414. Refine Github action and travis URL: https://github.com/apache/submarine/pull/213 ### What is this PR for? 1. rm rat from Travis which is duplicated with GitHub actions 2. disable style check temporarily in GitHub action

[GitHub] [submarine] yaooqinn opened a new pull request #212: SUBMARINE-413. Custom show databases command to allow exposing filtered databases

2020-03-09 Thread GitBox
yaooqinn opened a new pull request #212: SUBMARINE-413. Custom show databases command to allow exposing filtered databases URL: https://github.com/apache/submarine/pull/212 ### What is this PR for? add a new Command to replace spark's own ShowDatabasesCommand to filter out

[GitHub] [submarine] asfgit closed pull request #210: SUBMARINE-412. Basic GitHub aciton support for submarine project

2020-03-09 Thread GitBox
asfgit closed pull request #210: SUBMARINE-412. Basic GitHub aciton support for submarine project URL: https://github.com/apache/submarine/pull/210 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [submarine] liuxunorg commented on issue #210: SUBMARINE-412. Basic GitHub aciton support for submarine project

2020-03-09 Thread GitBox
liuxunorg commented on issue #210: SUBMARINE-412. Basic GitHub aciton support for submarine project URL: https://github.com/apache/submarine/pull/210#issuecomment-596426194 @yaooqinn Thank you for contribution this feature. Will merge if no more comments.

[GitHub] [submarine] yaooqinn commented on issue #210: SUBMARINE-412. Basic GitHub aciton support for submarine project

2020-03-09 Thread GitBox
yaooqinn commented on issue #210: SUBMARINE-412. Basic GitHub aciton support for submarine project URL: https://github.com/apache/submarine/pull/210#issuecomment-596420873 thanks @pingsutw This is an automated message from

[GitHub] [submarine] asfgit closed pull request #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark

2020-03-09 Thread GitBox
asfgit closed pull request #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark URL: https://github.com/apache/submarine/pull/211 This is an automated message from the Apache Git Service. To

[GitHub] [submarine] liuxunorg commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark

2020-03-09 Thread GitBox
liuxunorg commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark URL: https://github.com/apache/submarine/pull/211#issuecomment-596415134 Because there are several PRs to submit after this feature, I will merge this PR as soon as possible.

[GitHub] [submarine] yaooqinn commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark

2020-03-09 Thread GitBox
yaooqinn commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark URL: https://github.com/apache/submarine/pull/211#issuecomment-596408599 notice that submarine supports Hadoop 3.1/3.2, which are not supported by spark 2.3/2.4. so I excluded them

[GitHub] [submarine] yaooqinn commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark

2020-03-09 Thread GitBox
yaooqinn commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark URL: https://github.com/apache/submarine/pull/211#issuecomment-596403824 thanks @liuxunorg This is an automated

[GitHub] [submarine] yaooqinn commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark

2020-03-09 Thread GitBox
yaooqinn commented on issue #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark URL: https://github.com/apache/submarine/pull/211#issuecomment-596389285 cc @liuxunorg @yuanzac, thanks for reviewing in advance.

[GitHub] [submarine] yaooqinn opened a new pull request #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark

2020-03-09 Thread GitBox
yaooqinn opened a new pull request #211: SUBMARINE-411. Basic SQL Standard Authorization ACL Management for Spark URL: https://github.com/apache/submarine/pull/211 ### What is this PR for? This pr aims to provide submarine spark jobs with ACL Management abilities. In this pr, we

[GitHub] [submarine] asfgit closed pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml

2020-03-08 Thread GitBox
asfgit closed pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml URL: https://github.com/apache/submarine/pull/209 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [submarine] liuxunorg commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml

2020-03-08 Thread GitBox
liuxunorg commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml URL: https://github.com/apache/submarine/pull/209#discussion_r389456330 ## File path:

[GitHub] [submarine] pingsutw commented on issue #210: [WIP] Basic GitHub aciton support for submarine project

2020-03-08 Thread GitBox
pingsutw commented on issue #210: [WIP] Basic GitHub aciton support for submarine project URL: https://github.com/apache/submarine/pull/210#issuecomment-596319913 @yaooqinn Thanks for working on it. We need to create a JIRA ticket. more info could refer to this

[GitHub] [submarine] yaooqinn commented on issue #210: [WIP] Basic GitHub aciton support for submarine project

2020-03-08 Thread GitBox
yaooqinn commented on issue #210: [WIP] Basic GitHub aciton support for submarine project URL: https://github.com/apache/submarine/pull/210#issuecomment-596316127 oops.. seems only Only repository collaborators can create workflows.

[GitHub] [submarine] yuanzac commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml

2020-03-08 Thread GitBox
yuanzac commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml URL: https://github.com/apache/submarine/pull/209#discussion_r389449630 ## File path:

[GitHub] [submarine] yaooqinn opened a new pull request #210: [WIP] Basic GitHub aciton support for submarine project

2020-03-08 Thread GitBox
yaooqinn opened a new pull request #210: [WIP] Basic GitHub aciton support for submarine project URL: https://github.com/apache/submarine/pull/210 ### What is this PR for? Add build/rat/linter GitHub actions for a fast check to help developers to fix trivial things ###

[GitHub] [submarine] liuxunorg opened a new pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml

2020-03-08 Thread GitBox
liuxunorg opened a new pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml URL: https://github.com/apache/submarine/pull/209 ### What is this PR for? At present, the artifactId of some submarine modules does not contain submarine, resulting in the compiled jar

[GitHub] [submarine] asfgit closed pull request #208: SUBMARINE-401. [SDK] Add Factorization Machines model

2020-03-08 Thread GitBox
asfgit closed pull request #208: SUBMARINE-401. [SDK] Add Factorization Machines model URL: https://github.com/apache/submarine/pull/208 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [submarine] liuxunorg commented on issue #208: SUBMARINE-401. [SDK] Add Factorization Machines model

2020-03-08 Thread GitBox
liuxunorg commented on issue #208: SUBMARINE-401. [SDK] Add Factorization Machines model URL: https://github.com/apache/submarine/pull/208#issuecomment-596203329 Will merge if no more comments. This is an automated message

[GitHub] [submarine] asfgit closed pull request #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2

2020-03-08 Thread GitBox
asfgit closed pull request #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2 URL: https://github.com/apache/submarine/pull/203 This is an automated message from the Apache Git Service. To respond to

[GitHub] [submarine] asfgit closed pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular

2020-03-08 Thread GitBox
asfgit closed pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular URL: https://github.com/apache/submarine/pull/206 This is an automated message from the Apache Git Service. To respond to

[GitHub] [submarine] liuxunorg commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular

2020-03-08 Thread GitBox
liuxunorg commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular URL: https://github.com/apache/submarine/pull/206#issuecomment-596186124 Will merge if no more comments This is an

[GitHub] [submarine] liuxunorg edited a comment on issue #202: Failed to import project Maven dependency

2020-03-08 Thread GitBox
liuxunorg edited a comment on issue #202: Failed to import project Maven dependency URL: https://github.com/apache/submarine/issues/202#issuecomment-596185401 `mvn install ...` will compile submarine locally and install it into your local mvn repository. Not downloaded from Apache's mvn

[GitHub] [submarine] liuxunorg commented on issue #202: Failed to import project Maven dependency

2020-03-08 Thread GitBox
liuxunorg commented on issue #202: Failed to import project Maven dependency URL: https://github.com/apache/submarine/issues/202#issuecomment-596185401 mvn install will compile submarine locally and install it into your local mvn repository. Not downloaded from Apache's mvn repository.

[GitHub] [submarine] Languomao commented on issue #202: Failed to import project Maven dependency

2020-03-08 Thread GitBox
Languomao commented on issue #202: Failed to import project Maven dependency URL: https://github.com/apache/submarine/issues/202#issuecomment-596184185 > hi @Languomao :-) > You are welcome to use submarine, you can compile subamrine according to this document.

[GitHub] [submarine] asfgit closed pull request #207: SUBMARINE-406. optimize travis

2020-03-07 Thread GitBox
asfgit closed pull request #207: SUBMARINE-406. optimize travis URL: https://github.com/apache/submarine/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [submarine] lowc1012 commented on issue #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2

2020-03-07 Thread GitBox
lowc1012 commented on issue #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2 URL: https://github.com/apache/submarine/pull/203#issuecomment-596161235 @pingsutw @liuxunorg Thanks for your review! I will change it later.

[GitHub] [submarine] liuxunorg commented on issue #207: SUBMARINE-406. optimize travis

2020-03-07 Thread GitBox
liuxunorg commented on issue #207: SUBMARINE-406. optimize travis URL: https://github.com/apache/submarine/pull/207#issuecomment-596158488 > One minor question. Do we need to test VUE workbench? Wait for the NG version to be developed before deleting the VUE version.

[GitHub] [submarine] jasoonn commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular

2020-03-07 Thread GitBox
jasoonn commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular URL: https://github.com/apache/submarine/pull/206#issuecomment-596155911 @liuxunorg Thank for your advice. I have updated my pr.

[GitHub] [submarine] liuxunorg commented on issue #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2

2020-03-07 Thread GitBox
liuxunorg commented on issue #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2 URL: https://github.com/apache/submarine/pull/203#issuecomment-596154633 https://github.com/apache/submarine/pull/203#discussion_r388899026 @lowc1012 Can you change job name to

[GitHub] [submarine] liuxunorg commented on a change in pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular

2020-03-07 Thread GitBox
liuxunorg commented on a change in pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular URL: https://github.com/apache/submarine/pull/206#discussion_r389324993 ## File path:

[GitHub] [submarine] pingsutw opened a new pull request #208: SUBMARINE-401. [SDK] Add Factorization Machines model

2020-03-07 Thread GitBox
pingsutw opened a new pull request #208: SUBMARINE-401. [SDK] Add Factorization Machines model URL: https://github.com/apache/submarine/pull/208 ### What is this PR for? Add TensorFlow implementation of Factorization Machines model ### What type of PR is it? [Feature]

[GitHub] [submarine] liuxunorg commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular

2020-03-07 Thread GitBox
liuxunorg commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular URL: https://github.com/apache/submarine/pull/206#issuecomment-596101488 @jasoonn Thank you contribution for this feature. Because `submarine-test/e2e` has been changed to

[GitHub] [submarine] jasoonn opened a new pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular

2020-03-07 Thread GitBox
jasoonn opened a new pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular URL: https://github.com/apache/submarine/pull/206 ### What is this PR for? Implement the job page in workbench with Angular. ### What type of PR is it? [Feature]

[GitHub] [submarine] asfgit closed pull request #205: SUBMARINE-407. Change module name e2e to test-e2e

2020-03-07 Thread GitBox
asfgit closed pull request #205: SUBMARINE-407. Change module name e2e to test-e2e URL: https://github.com/apache/submarine/pull/205 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [submarine] asfgit closed pull request #204: SUBMARINE-404. Fixed fasterxml package conflict

2020-03-07 Thread GitBox
asfgit closed pull request #204: SUBMARINE-404. Fixed fasterxml package conflict URL: https://github.com/apache/submarine/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   3   4   5   6   7   8   9   10   >