Re: Close SVN-1778

2023-10-01 Thread Nathan Hartman
On Sun, Oct 1, 2023 at 9:58 AM Daniel Sahlberg wrote: > > Hi, > > Issue SVN-1778 [1] is about the Python bindings, class FileDiff, where get_pipe() called an external program diff (under Windows: diff.exe). Since diff.exe has to be installed (and added to PATH) manually on Windows the function

Re: svn commit: r1912500 - in /subversion/trunk/subversion/bindings/swig: python/libsvn_swig_py/swigutil_py.c python/libsvn_swig_py/swigutil_py.h python/svn/delta.py python/svn/repos.py svn_delta.i sv

2023-10-01 Thread Daniel Sahlberg
Den sön 24 sep. 2023 kl 12:55 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>: > Hi, > > On 2023/09/24 17:53, Daniel Sahlberg wrote: > > Den sön 24 sep. 2023 kl 07:06 skrev : > > > >> Author: futatuki > >> Date: Sun Sep 24 05:06:08 2023 > >> New Revision: 1912500 > >> > >> URL:

Close SVN-1778

2023-10-01 Thread Daniel Sahlberg
Hi, Issue SVN-1778 [1] is about the Python bindings, class FileDiff, where get_pipe() called an external program diff (under Windows: diff.exe). Since diff.exe has to be installed (and added to PATH) manually on Windows the function would fail. The same is true on other os:es but diff is probably

Re: svn commit: r1912515 - /subversion/trunk/subversion/bindings/swig/python/tests/repository.py

2023-10-01 Thread Daniel Sahlberg
Hi, Some minor nits in this commit: Den sön 24 sep. 2023 kl 11:02 skrev : > Author: futatuki > Date: Sun Sep 24 09:02:05 2023 > New Revision: 1912515 > [...] > @@ -318,6 +388,36 @@ class SubversionRepositoryTestCase(unitt > del subpool > self.assertEqual(None, editor_ref()) > > +