and committed your patch in r1462041.
For the mailing list history:
13:02 @Bert philipm: Did you see the problem described by jcorvel in his
mail? Or is the fix+test to be on the safe
side?
13:02 philipm What problem exactly?
13:03 @Bert philipm: r1462041
13:04 philipm I see, what you
-Original Message-
From: Daniel Shahaf [mailto:danie...@elego.de]
Sent: donderdag 28 maart 2013 13:22
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: svn commit: r1462054 - in /subversion/branches/verify-at-
commit/subversion: include/svn_fs.h libsvn_fs/fs-loader.c
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: donderdag 28 maart 2013 19:32
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Opening the repository hooks environment file
Bert Huijben b...@qqmail.nl writes
-Original Message-
From: Branko Čibej [mailto:br...@wandisco.com]
Sent: donderdag 28 maart 2013 22:06
To: dev@subversion.apache.org
Subject: Re: Opening the repository hooks environment file
On 28.03.2013 21:50, Bert Huijben wrote:
-Original Message-
From: MARTIN
--parents is supported for urls below a repository, but I agree that we should
reduce the number of errors that show this hint.
Bert
Sent from Windows Mail
From: Daniel Shahaf
Sent: Friday, March 29, 2013 12:25 AM
To: dev@subversion.apache.org
Another one I randomly ran
ago you approved
another one)
That will automatically trigger the backport script without anybody else having
to do something.
Bert
there is some SVN_TEST_ macro that tests for a specific error code and
then clears the error for you.
That would be a more stable test than just assuming any error is ok.
Bert
of broken
operations when the network layer times out on a long callback invocation.
Bert
Sent from Windows Mail
From: Julian Foad
Sent: Tuesday, March 26, 2013 9:18 PM
To: Stefan Sperling
Cc: Subversion Development; Bert Huijben; Stefan Küng
Stefan Sperling wrote:
On Tue, Mar
no risk of
getting invalid state committed).
I haven't dived deeper in this problem space as after fixing any small
problem a similar remaining one turned up.
(I reverted my work and continued with the other work)
Bert
Isn't there an apr variant of this macro we can/should use?
Bert From: Joe Swatosh
Sent: 25-3-2013 01:01
To: SVN Dev
Subject: [PATCH] #include limts.h for ULONG_MAX
While I found this issue using my very old compiler, it seems reasonable since
that is where ULONG_MAX has been defined for a long
-Original Message-
From: C. Michael Pilato [mailto:cmpil...@collab.net]
Sent: woensdag 20 maart 2013 12:14
To: Bert Huijben
Cc: Subversion Development
Subject: New svn_auth_cleanup_walk() API.
Bert,
I have some questions about the new svn_auth_cleanup_walk() API you
introduced
and not...
but we decided not to a long time ago.
There is an exception list for functions that we hide somewhere and with some
trickery we could enable different versions for debug and release mode.
Bert
during our tests.
(For some time during 1.7 development the svnversion code only worked correctly
in this scenario and the test suite didn't notice)
Bert
.
We made svn_editor_t private for 1.8. How hard would it be to make these
private as well?
I think we only use them to fetch information for editor v2.
Bert
is in the
parent, but there is no parent or parent_node wouldn't be NULL)
Bert
that comment)
Bert
-Original Message-
From: Julian Foad [mailto:julianf...@btopenworld.com]
Sent: vrijdag 15 maart 2013 22:01
To: Subversion Development
Cc: Philip Martin; Stefan Sperling; Bert Huijben
Subject: Conflict resolver callback design
A long email, for folks interested in conflict
-Original Message-
From: Sergei Antonov [mailto:sap...@gmail.com]
Sent: donderdag 14 maart 2013 13:33
To: dev@subversion.apache.org
Subject: Re: Windows build still requires apr-util?
On 13 March 2013 19:15, Bert Huijben b...@qqmail.nl wrote:
-Original Message
for 1.8.0 as it allows getting your db in an
inconsistent state:
http://subversion.tigris.org/issues/show_bug.cgi?id=4336 - Handle incoming
deletes via the update move editor doesn't add base-deleted
(My guess would be that it isn't hard to fix this for someone familiar with
this code)
Bert
-Original Message-
From: Sergei Antonov [mailto:sap...@gmail.com]
Sent: donderdag 14 maart 2013 14:13
To: Bert Huijben
Subject: Re: Windows build still requires apr-util?
On 14 March 2013 13:44, Bert Huijben b...@qqmail.nl wrote:
-Original Message-
From: Sergei
-Original Message-
From: Sergei Antonov [mailto:sap...@gmail.com]
Sent: donderdag 14 maart 2013 16:02
To: dev@subversion.apache.org
Subject: Re: Windows build still requires apr-util?
On 14 March 2013 15:00, Bert Huijben b...@qqmail.nl wrote:
-Original Message
JavaHL to enable the metadata only move. I would
have to check the commit to see which value he enabled.
Bert
don't have access to that version of Visual C++
to fix it.
Bert
.
If our NMake support still works (I never used it), I would recommend that
users of these old versions of Visual Studio use that, if they want to build
subversion using those tools.
Bert
?
Bert
neither looks like a correct Windows path, nor a Subversion
canonical path.
Bert
that the node was moved
away, if it is replaced. You can get those details from the working copy if you
really have to. We don't have to record everything in the reason.
Bert
.
What do people think? Good idea? Too ugly for the limited benefit?
+1
Would be nice if we can use a buildbot to build in this mode.
Bert
libsvn_ra_svn and svnserve, via a public api.
Nobody else should use it directly)
Bert
still read them during upgrade of course)
Bert From: Branko Čibej
Sent: 12-3-2013 18:34
To: Subversion Development
Subject: Re: Confusion to svn_kind_t!
So I've started the merge of svn_kind_t into svn_node_kind_t and have
run across a more fundamental kind of conflict that I can't resolve
without
I didn’t expect to see this option in ‘svn’. I would have guessed it was
api only??
Bert
Sent from Windows Mail
*From:* Philip Martin phi...@codematters.co.uk
*Sent:* March 12, 2013 7:15 PM
*To:* Branko Čibej
*CC:* dev@subversion.apache.org
*Subject:* Re: svn_client_move7 and mixed
before committing is no
problem. But breaking powerful refactoring tools is.
Bert
with depth empty.
Bert
, since svn_kind_t values are now
backwards compatible with node_kind_t.
]]]
We don't need a format bump as the working copy stores a word, not an int.
Bert
Index: subversion/include/svn_types.h
==
=
--- subversion
lock should fix
it. (That is also a quick fix you might be able to apply)
It is safer this way, then to always keep it.
But of course it would be nicer if we can just fix it ;-)
Bert
Yes, you need apr-util for apr 0.x and 1.x.
In 2.x apr-util might/will be integrated in Apr,so you still need it
but don't have to install it separately.
In the past you also needed apr-iconv, but that is no longer required
(depending on your settings)
Bert From: Sergei Antonov
Sent: 10-3-2013
svn_private_config.hw (-1.7.x) during the svn_config project, but as I
said I don't think it is really tested for that old versions of Visual Studio.
(Patches welcome as some httpd versions still use that old Visual C++)
Bert
client,
you've gotta slap those four characters SVN/ in your User-Agent header
value.
What about proxy servers?
There used to be privacy features in several proxies that suppressed the user
agent. (Not sure if they still use that trick).
Bert
-Original Message-
From: C. Michael Pilato [mailto:cmpil...@collab.net]
Sent: donderdag 7 maart 2013 17:32
To: Bert Huijben
Cc: 'Gavin Baumanis'; 'jinfroster'; dev@subversion.apache.org
Subject: Re: [PATCH] implement keywords substitution in mod_dav_svn
On 03/07/2013 11:27 AM
. */
+ SVN_ERR(svn_io_copy_perms(src, dst, pool));
+
+ return SVN_NO_ERROR;
}
There is a possible race condition here, which might be resolved by copying the
permissions before moving.
(But most likely you just get a different race condition by switching the order)
Bert
with
whole program optimization, but with a shared library build there
certainly will be a performance difference in the delta calculation, which
is already cpu bound in many real world scenarios.
Bert
Sent from Windows Mail
*From:* stef...@apache.org
*Sent:* February 28, 2013 8:46 AM
*To:* comm
(and only supporting the default
compression type).
You can make this work for this file type, but it needs different code than
making gzip use the same trick.
(The deflate is restarted per file, and there are file headers between the
files and at the end)
Bert
'libsvn_repos difference calculation'.
The switch code doesn't use the code that we usually call 'diff', as that is
more related to the diff/merge model.
Bert
to have some api to
make the eols on files consistent... Would this work for you?
Bert
-Original Message-
From: Stefan Küng [mailto:tortoise...@gmail.com]
Sent: zondag 24 februari 2013 17:01
To: Bert Huijben
Cc: 'Subversion Development'
Subject: Re: svn add and inconsistent line endings
On 24.02.2013 16:47, Bert Huijben wrote:
-Original Message
-Original Message-
From: Branko Čibej [mailto:br...@wandisco.com]
Sent: zondag 24 februari 2013 17:31
To: dev@subversion.apache.org
Subject: Re: svn add and inconsistent line endings
On 24.02.2013 17:00, Stefan Küng wrote:
On 24.02.2013 16:47, Bert Huijben wrote
-Original Message-
From: Stefan Küng [mailto:tortoise...@gmail.com]
Sent: zondag 24 februari 2013 19:15
To: Bert Huijben
Cc: 'Subversion Development'
Subject: Re: svn add and inconsistent line endings
On 24.02.2013 18:56, Bert Huijben wrote:
-Original Message
.
Bert
the path and tries again.
We should really get away from this kind of patterns wherever we can.
(Security boundaries might be an exception)
Bert
From: Stefan Fuhrmann [mailto:stefan.fuhrm...@wandisco.com]
Sent: donderdag 21 februari 2013 22:56
To: Julian Foad
Cc: dev@subversion.apache.org
tweak the documentation for this function to handle
this case. This is the most important api to the BASE layer towards
libsvn_client.
What about excluded and server excluded?
Maybe we should add some optional not-present output argument handling all of
them?
Bert
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: dinsdag 19 februari 2013 11:50
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c
Bert Huijben b
are typically used longer than
one command in any client but svn and these clients hand their config
instance.
Bert Huijben (Cell phone)
From: Philip Martin
Sent: 18-2-2013 18:21
To: Neels Hofmeyr
Cc: dev@subversion.apache.org
Subject: Re: [svnbench] Revision: 1447108 compiled Feb 18 2013,
00:21:45
to just detect that they
are the same db.
Let's call 1.8, Subversion 2.0 if we start breaking things this way.
Bert
in real user performance in clients like AnkhSVN
and TortoiseSVN.
Bert
?
(Away from my pc... spending time with my sons)
Bert
automatic after obtaining the
proper working copy lock.
** The same user might just have another update or commit running on that
part of the working copy!! **
Bert
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
-Original Message-
From: Mark Phippard [mailto:markp...@gmail.com]
Sent: vrijdag 15 februari 2013 16:07
To: Bert Huijben
Cc: Philip Martin; dev@subversion.apache.org
Subject: Re: move conflict resolution UI (was: Re: branch 1.8 or at least
start
making alpha releases?)
On Fri
is 32 bit there, while
apr_off_t is 64 bit on these platforms.
(Or is this special cased in apr or svn?)
And I would recommend using 0x%something to make it obvious for readers of
the message that the value is hexadecimal, without having to check the
sourcecode.
Bert
-Original Message-
From: C. Michael Pilato [mailto:cmpil...@collab.net]
Sent: donderdag 14 februari 2013 15:10
To: Johan Corveleyn
Cc: Bert Huijben; Bert Huijben; dev@subversion.apache.org
Subject: Re: svn commit: r1445973 - in /subversion/trunk/subversion:
include/svn_ra.h
the first revision, so it is not slower than the current server side
algorithm). But if it is we can optimize it later.
Bert
Sent from Windows Mail
*From:* Johan Corveleyn jcor...@gmail.com
*Sent:* February 14, 2013 12:50 AM
*To:* rhuij...@apache.org
*CC:* dev@subversion.apache.org
*Subject
be very welcome to allow switching to a more
efficient walk in a future subversion version.
Bert
*From:* Philip Martin philip.mar...@wandisco.com
*Sent:* February 12, 2013 2:32 PM
*To:* Ferenc Kovacs tyr...@gmail.com
*CC:* dev@subversion.apache.org
*Subject:* Re: svn blame not working for files which
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: dinsdag 12 februari 2013 19:30
To: Bert Huijben
Cc: Ferenc Kovacs; dev@subversion.apache.org
Subject: Re: svn blame not working for files which had binary mime-type
size makes sense for the average caller?
Bert
snip
Modified: subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/fs.c
URL: http://svn.apache.org/viewvc/subversion/branches/fsfs-
format7/subversion/libsvn_fs_fs/fs.c?rev=1444956r1=1444955r2=1444956
view=diff
-Original Message-
From: C. Michael Pilato [mailto:cmpil...@collab.net]
Sent: vrijdag 8 februari 2013 15:22
To: dev@subversion.apache.org
Cc: Bert Huijben; comm...@subversion.apache.org
Subject: Re: svn commit: r1443705 -
/subversion/trunk/subversion/libsvn_ra_serf/commit.c
. Or every svn invocation would have crashed since your change.
(See r1443562 for a reproduction recipe)
Bert
and
http://server/some/subdir ?
The Windows buildbot uses the configuration written by win-tests.py; I'm not
sure which httpd configuration the centos buildbot uses.
Bert
Thanks for confirming the problem I expected to see when I wrote r1443705.
Now we just have to find a proper fix.
(I think r1443705 can be reverted as this trick clearly doesn’t work)
Bert
Sent from Windows Mail
*From:* Philip Martin codematt...@ntlworld.com
*Sent:* February 8, 2013 1:06 AM
'... But we can’t break history, or
switching between old or future revisions.
Bert
Sent from Windows Mail
*From:* Greg Stein gst...@gmail.com
*Sent:* February 5, 2013 4:57 AM
*To:* Joe Schaefer joe_schae...@yahoo.com
*CC:* dev@subversion.apache.org
*Subject:* Re: Coniguring 301/302 redirects
.
+ * Should be 0 otherwise. */
+ apr_size_t header_size;
} svn_fs_fs__rep_header_t;
Are you sure you want an architecture dependent size in this struct?
I would expect an explicit 32 or 64 bit int here.
Bert
at this stack, this error originates in the iprops fetch that was added
before the actual update for 1.8.
Bert
subversion/libsvn_ra/ra_loader.c:1323: (apr_err=175011)
subversion/libsvn_ra/compat.c:914: (apr_err=175011)
subversion/libsvn_ra_serf/serf.c:1081: (apr_err=175011)
subversion
setting match the libmagic output for that file?) instead of adding
just a warning when setting the file binary explicitly.
Maybe we should validate our libmagic based decision to make something
binary?
Bert Huijben (Cell phone)
From: Justin Erenkrantz
Sent: 3-2-2013 9:18
To: Bert Huijben
Cc: dev
.
Bert
.
Why not just leave a top level folder with some readme?
I think you should be able to redirect the normal webbrowser GETs though, as
I don't think we use those urls from our ra layers. (Or did we start using
them for HEAD requests in HTTPv2?)
Bert
, if it is no longer needed
there.
I know little about it myself, but on IRC, Bert said [1]:
I would hope we can ignore WC/DAV props. And if somebody suggests
it I
would be +1 on removing them now completely from our client. (The
skelta
update in serf for old style servers makes them unnecessary
of
stability guarantees.
It is probably still better than the entry-like code in 1.7, but it can use
some work.
Bert
-Original Message-
From: Ivan Zhakov [mailto:i...@visualsvn.com]
Sent: donderdag 31 januari 2013 22:50
To: Paul Burba; Bert Huijben
Cc: Julian Foad; Subversion Development
Subject: Re: Reintegrate-like merges and diff_ignore_ancestry
Thanks for demonstrating use-case. That what I
until you go to the next row.
Bert
-Original Message-
From: Bert Huijben [mailto:b...@qqmail.nl]
Sent: dinsdag 29 januari 2013 18:35
To: 'Julian Foad'; 'Subversion Development'
Subject: RE: Unsafe WC DB calls: sqlite_column_text(..., pool=NULL)
-Original Message-
From: Julian Foad [mailto:julianf
. (I don't maintain code connected to this)
Bert
.
Bert
this without your patch if you use
expected_err = svntest.verify.RegexOutput([
# lines here
])
Instead of
expected_err = [
# lines here
]
Just like how we handle separate kinds of output (items, unordered, regex,
unordered regex, any text, or a plain list)
Bert
optimize the diff view, we should also do that.
Bert
will be deleted.
I would welcome feedback.
Bert
[[
* subversion/libsvn_client/merge.c
(drive_merge_report_editor): Request walking deleted directories.
* subversion/tests/cmdline/*
Fix expected results.
]]
merge-deleted-handling.patch
Description: Binary data
: 1436783
URL: http://svn.apache.org/viewvc?rev=1436783view=rev
Log:
ra_serf: Add 'svndiff1' and 'svndiff' to Accept-Encoding header in update
report request.
Should we backport this to 1.7.x?
Or doesn't this trigger the more efficient wire protocol?
Bert
to status. Every node with a BASE node is replaced, even though the
node is not the op-root that replaces the node. There are entry_status,
entry_rev and entry_copied keywords to handle this in the test suite)
Bert
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: dinsdag 22 januari 2013 18:56
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: upgrade_tests 29 XFAIL
Bert Huijben b...@qqmail.nl writes:
W: Couldn't find
think the test verification needs a bit of relaxation.
Bert
to retrieve top much information for every not changed directory,
which we now identify correctly as not relevant.
But this is mostly in the 'diff' part of the merge, not the 'merge' code
itself.
Bert
path it will now
place a similar hidden marker as you would get when you update a path to r0
(or commit a file delete). The next update will now bring in the missing
node.
I will nominate the fix for backporting to a future 1.7 release.
Bert
From: Maxwell Ballenger
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: vrijdag 18 januari 2013 11:20
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: svn commit: r1434913 -
/subversion/trunk/subversion/libsvn_wc/wc_db.c
Bert
-Original Message-
From: Stefan Sperling [mailto:s...@elego.de]
Sent: vrijdag 18 januari 2013 16:53
To: Bert Huijben
Cc: 'Philip Martin'; dev@subversion.apache.org
Subject: Re: svn commit: r1434913 -
/subversion/trunk/subversion/libsvn_wc/wc_db.c
On Fri, Jan 18, 2013 at 03:18
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: vrijdag 18 januari 2013 16:50
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: svn commit: r1434913 -
/subversion/trunk/subversion/libsvn_wc/wc_db.c
Bert
-Original Message-
From: Stefan Sperling [mailto:s...@elego.de]
Sent: vrijdag 18 januari 2013 17:01
To: Bert Huijben; 'Philip Martin'; dev@subversion.apache.org
Subject: Re: svn commit: r1434913 -
/subversion/trunk/subversion/libsvn_wc/wc_db.c
On Fri, Jan 18, 2013 at 04:52:42PM
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: vrijdag 18 januari 2013 20:13
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: svn commit: r1434913 -
/subversion/trunk/subversion/libsvn_wc/wc_db.c
Bert Huijben
implementation, or should we
first go back to the design of the move storage?
Bert
-Original Message-
From: Paul Burba [mailto:ptbu...@gmail.com]
Sent: maandag 14 januari 2013 22:20
To: Subversion Development
Cc: Stefan Sperling; Julian Foad; Bert Huijben
Subject: 1.8 Release Status : Test Review Task Update
Re the roadmap item Test Review - Determine which
-Original Message-
From: Branko Čibej [mailto:br...@wandisco.com]
Sent: vrijdag 11 januari 2013 13:08
To: dev@subversion.apache.org
Subject: Re: svn commit: r1431757 -
/subversion/trunk/subversion/libsvn_repos/repos.c
On 11.01.2013 12:23, Bert Huijben wrote:
-Original
else has a lock (or when there are
wq items)
Your change made it much easier to perform these very dangerous operations,
breaking the lock of the second process, while the normal cleanup probably
already worked.
(Any process is allowed to run the workqueue at any time)
Bert
-Original Message-
From: Bert Huijben [mailto:b...@qqmail.nl]
Sent: vrijdag 11 januari 2013 14:12
To: dev@subversion.apache.org
Subject: RE: svn commit: r1431633 - in /subversion/trunk/subversion:
libsvn_wc/cleanup.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h
tests/cmdline/wc_tests.py
that for 1.x.
Bert Huijben (Cell phone)
From: Paul Burba
Sent: 11-1-2013 21:36
To: Subversion Development
Subject: Do we expect default ignores when no ignores are defined
anywhere?
I was a bit surprised to learn today that if one has no global-ignore
options defined in any of the run-time configs
801 - 900 of 1808 matches
Mail list logo