Re: svn commit: r997203 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_diff/ subversion/libsvn_fs_fs/ subversion/libsvn_ra_svn/ subversion/libsvn_repos/ sub

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 06:52:07AM -, hwri...@apache.org wrote: == --- subversion/trunk/subversion/include/svn_string.h (original) +++ subversion/trunk/subversion/include/svn_string.h Wed Sep 15 06:52:06 2010 @@

Re: svn commit: r995603 - /subversion/branches/performance/subversion/libsvn_subr/svn_string.c

2010-09-15 Thread Stefan Sperling
On Fri, Sep 10, 2010 at 03:32:14PM +0200, Stefan Sperling wrote: On Thu, Sep 09, 2010 at 10:58:06PM -, stef...@apache.org wrote: Author: stefan2 Date: Thu Sep 9 22:58:06 2010 New Revision: 995603 URL: http://svn.apache.org/viewvc?rev=995603view=rev Log: Try really hard to help

Re: svn commit: r997203 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_diff/ subversion/libsvn_fs_fs/ subversion/libsvn_ra_svn/ subversion/libsvn_repos/ sub

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 9:45 AM, Stefan Sperling s...@elego.de wrote: On Wed, Sep 15, 2010 at 06:52:07AM -, hwri...@apache.org wrote: == --- subversion/trunk/subversion/include/svn_string.h (original) +++

Re: svn commit: r995603 - /subversion/branches/performance/subversion/libsvn_subr/svn_string.c

2010-09-15 Thread Branko Čibej
On 15.09.2010 09:46, Stefan Sperling wrote: On Fri, Sep 10, 2010 at 03:32:14PM +0200, Stefan Sperling wrote: On Thu, Sep 09, 2010 at 10:58:06PM -, stef...@apache.org wrote: Author: stefan2 Date: Thu Sep 9 22:58:06 2010 New Revision: 995603 URL:

Public API documentation

2010-09-15 Thread Hyrum K. Wright
I've been thinking about ways that our API documentation could be made a bit cleaner. Currently, we use a lot of prose to describe APIs, their parameters, and other nuances. I find this approach rather unique, and in some ways obfuscating. We have great documentation in that we cover a lot of

RE: svn commit: r997026 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2010-09-15 Thread Bert Huijben
-Original Message- From: cmpil...@apache.org [mailto:cmpil...@apache.org] Sent: dinsdag 14 september 2010 20:09 To: comm...@subversion.apache.org Subject: svn commit: r997026 - /subversion/trunk/subversion/mod_dav_svn/repos.c Author: cmpilato Date: Tue Sep 14 18:08:59 2010 New

RE: svn commit: r997237 - in /subversion/trunk/subversion/bindings/javahl/native: ClientContext.cpp ClientContext.h SVNClient.cpp

2010-09-15 Thread Bert Huijben
-Original Message- From: hwri...@apache.org [mailto:hwri...@apache.org] Sent: woensdag 15 september 2010 11:18 To: comm...@subversion.apache.org Subject: svn commit: r997237 - in /subversion/trunk/subversion/bindings/javahl/native: ClientContext.cpp ClientContext.h SVNClient.cpp

Re: Public API documentation

2010-09-15 Thread Julian Foad
Hyrum K. Wright wrote: I've been thinking about ways that our API documentation could be made a bit cleaner. Currently, we use a lot of prose to describe APIs, their parameters, and other nuances. I find this approach rather unique, and in some ways obfuscating. We have great

Re: Public API documentation

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 11:35 AM, Julian Foad julian.f...@wandisco.com wrote: Hyrum K. Wright wrote: I've been thinking about ways that our API documentation could be made a bit cleaner. Currently, we use a lot of prose to describe APIs, their parameters, and other nuances.  I find this

Re: svn commit: r997237 - in /subversion/trunk/subversion/bindings/javahl/native: ClientContext.cpp ClientContext.h SVNClient.cpp

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 11:34 AM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: hwri...@apache.org [mailto:hwri...@apache.org] Sent: woensdag 15 september 2010 11:18 To: comm...@subversion.apache.org Subject: svn commit: r997237 - in

Re: [Issue 3474] making a new subdir, moving files into it and then renaming the subdir, breaks history of the moved files

2010-09-15 Thread Philip Martin
Julian Foad julian.f...@wandisco.com writes: On Tue, 2010-09-14, Daniel Shahaf wrote: Johan Corveleyn wrote on Sat, Sep 11, 2010 at 00:02:16 +0200: On Fri, Sep 10, 2010 at 11:45 PM, joha...@tigris.org wrote: http://subversion.tigris.org/issues/show_bug.cgi?id=3474 --- Additional

1.6.13 release

2010-09-15 Thread Hyrum K. Wright
It's been 3 months since the last 1.6.x release, and we've got a few items in STATUS or CHANGES which could warrant a release. I'd like to roll in 1 or 2 weeks, so please go through STATUS and do some review. If folks have thoughts on the timeliness of this release, or other changes which ought

RE: [Issue 3474] making a new subdir, moving files into it and then renaming the subdir, breaks history of the moved files

2010-09-15 Thread Bert Huijben
-Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: woensdag 15 september 2010 12:08 To: Julian Foad Cc: Daniel Shahaf; Johan Corveleyn; Subversion Development Subject: Re: [Issue 3474] making a new subdir, moving files into it and then renaming the

Re: [Issue 3474] making a new subdir, moving files into it and then renaming the subdir, breaks history of the moved files

2010-09-15 Thread Philip Martin
Bert Huijben b...@qqmail.nl writes: -Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Perhaps we should simply notify for all nodes? Perhaps each individual client should be deciding which notifications to suppress? +1 on moving the choice to the clients.

Re: sasl mechanisms order

2010-09-15 Thread Stefan Sperling
On Tue, Sep 07, 2010 at 02:33:28PM +0700, Victor Sudakov wrote: This time it has compiled, but does not work. svn list svn://admin/test/ works OK (IMHO because the ANONYMOUS mechanism is sufficient for that) but svn co svn://admin/test/ dumps core immediately. Hi Victor, I hope I have

Re: svn diff optimization to make blame faster?

2010-09-15 Thread Johan Corveleyn
On Sun, Sep 5, 2010 at 1:53 AM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, Aug 24, 2010 at 11:11 AM, Philip Martin philip.mar...@wandisco.com wrote: Johan Corveleyn jcor...@gmail.com writes: On Sun, Aug 22, 2010 at 4:02 PM, Branko Čibej br...@xbc.nu wrote: svn_diff uses basically the

Re: svn diff optimization to make blame faster?

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 02:20:05PM +0200, Johan Corveleyn wrote: Just to know how hard/fast I should pursue this: is there any chance that a change like this could still make it into 1.7 (maybe even backported to 1.6?), provided that the patch is of good quality and all... ? Depending on how

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
On Tue, 2010-09-07, s...@apache.org wrote: Author: stsp Date: Tue Sep 7 00:09:46 2010 New Revision: 993183 URL: http://svn.apache.org/viewvc?rev=993183view=rev Log: Introduce a new family of functions to parse numbers from strings. Looks useful. Thanks. The goal is to replace direct

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
Also printf formatting type mismatches: subversion/libsvn_subr/svn_string.c: In function 'svn_cstring_strtoui64': subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long unsigned int', but argument 5 has type 'apr_uint64_t' subversion/libsvn_subr/svn_string.c:662: format '%lu'

Re: Public API documentation

2010-09-15 Thread Uwe Stuehler
On Mi, 2010-09-15 at 10:35 +0100, Julian Foad wrote: Hyrum K. Wright wrote: I've been thinking about ways that our API documentation could be made a bit cleaner. ... Thoughts? -Hyrum +1. You know what, I've been a bit skeptical of the list-of-params style of documentation, as

Re: svn diff optimization to make blame faster?

2010-09-15 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Sep 15, 2010 at 14:20:05 +0200: The patch is still very crude, with lots of code duplication, and everything stuffed in one big function (and I may have overlooked some edge conditions), so I don't feel it's ready to post yet (don't want to waste people's time

Re: svn commit: r997249 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/cl.h svn/main.c svn/patch-cmd.c tests/cmdline/patch_tests.py tests/libsvn_client/client-test.c

2010-09-15 Thread Daniel Shahaf
s...@apache.org wrote on Wed, Sep 15, 2010 at 10:05:15 -: Author: stsp Date: Wed Sep 15 10:05:14 2010 New Revision: 997249 URL: http://svn.apache.org/viewvc?rev=997249view=rev Log: Add an --old-patch-target-names option to svn patch. This option is useful in two cases: 1) A patch

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 02:14:36PM +0100, Julian Foad wrote: On Tue, 2010-09-07, s...@apache.org wrote: Author: stsp Date: Tue Sep 7 00:09:46 2010 New Revision: 993183 URL: http://svn.apache.org/viewvc?rev=993183view=rev Log: Introduce a new family of functions to parse numbers

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 02:27:21PM +0100, Julian Foad wrote: Also printf formatting type mismatches: subversion/libsvn_subr/svn_string.c: In function 'svn_cstring_strtoui64': subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long unsigned int', but argument 5 has type

Re: Public API documentation

2010-09-15 Thread C. Michael Pilato
On 09/15/2010 05:35 AM, Julian Foad wrote: Hyrum K. Wright wrote: I've been thinking about ways that our API documentation could be made a bit cleaner. [...] It's is really difficult to determine what each parameter does or what possible errors are returned, without reading the entire

Re: Public API documentation

2010-09-15 Thread Daniel Trebbien
Hyrum K. Wright hyrum_wright at mail.utexas.edu writes: Thanks. Though I'll probably wait a day or two, to let any dissenters make themselves known. :) -1/2. There are parts of your idea that I like, such as linking to common documentation, enumerating all of the errors that can be returned,

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Philip Martin
Stefan Sperling s...@elego.de writes: The translation issues is why I didn't use the APR_[U]INT64_T_FMT. It's either using it and make life hard for translators, or have these warnings... neither solution is perfect. Or is there a better solution? Have two format strings and pick the right

Re: Copies via update -- net win or net loss? (Was: svn commit: r996914 ...)

2010-09-15 Thread Daniel Shahaf
C. Michael Pilato wrote on Tue, Sep 14, 2010 at 10:58:20 -0400: On 09/14/2010 10:25 AM, rhuij...@apache.org wrote: Author: rhuijben Date: Tue Sep 14 14:25:52 2010 New Revision: 996914 URL: http://svn.apache.org/viewvc?rev=996914view=rev Log: When mixing the two major hacks of the

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
Stefan Sperling wrote: On Wed, Sep 15, 2010 at 02:14:36PM +0100, Julian Foad wrote: On Tue, 2010-09-07, s...@apache.org wrote: * subversion/include/svn_string.h (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi, svn_cstring_strtoui64, svn_cstring_atoui64,

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-15 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Sep 14, 2010 at 21:18:26 +0200: On Tue, Sep 14, 2010 at 12:49:06PM +0100, Julian Foad wrote: Right. The issue seems to be How do I determine what path I should apply the patch to? If the patch style is --- wc/file +++ wc/file or --- old_wc/file

Re: Copies via update -- net win or net loss? (Was: svn commit: r996914 ...)

2010-09-15 Thread C. Michael Pilato
On 09/15/2010 12:01 PM, Daniel Shahaf wrote: C. Michael Pilato wrote on Tue, Sep 14, 2010 at 10:58:20 -0400: On 09/14/2010 10:25 AM, rhuij...@apache.org wrote: Author: rhuijben Date: Tue Sep 14 14:25:52 2010 New Revision: 996914 URL: http://svn.apache.org/viewvc?rev=996914view=rev Log:

[PATCH] NODES table presence values

2010-09-15 Thread Julian Foad
Bert, Erik, Greg... I think the schema should not disallow the 'excluded' presence in NODES table where op_depth 0 (which corresponds roughly to old WORKING_NODE). There are already 'copy' cases where it is used, and seems useful and right. I also think the schema should not disallow 'absent'.

Re: svn commit: r997249 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/cl.h svn/main.c svn/patch-cmd.c tests/cmdline/patch_tests.py tests/libsvn_client/client-test.c

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 04:51:15PM +0200, Daniel Shahaf wrote: s...@apache.org wrote on Wed, Sep 15, 2010 at 10:05:15 -: Author: stsp Date: Wed Sep 15 10:05:14 2010 New Revision: 997249 URL: http://svn.apache.org/viewvc?rev=997249view=rev Log: Add an --old-patch-target-names

Re: Public API documentation

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 5:07 PM, Daniel Trebbien dtrebb...@gmail.com wrote: Hyrum K. Wright hyrum_wright at mail.utexas.edu writes: Thanks.  Though I'll probably wait a day or two, to let any dissenters make themselves known. :) -1/2. There are parts of your idea that I like, such as linking

Re: svn commit: r997249 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/cl.h svn/main.c svn/patch-cmd.c tests/cmdline/patch_tests.py tests/libsvn_client/client-test.c

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 8:42 PM, Stefan Sperling s...@elego.de wrote: On Wed, Sep 15, 2010 at 04:51:15PM +0200, Daniel Shahaf wrote: s...@apache.org wrote on Wed, Sep 15, 2010 at 10:05:15 -: Author: stsp Date: Wed Sep 15 10:05:14 2010 New Revision: 997249 URL:

Fwd: Regression for issue:2362 ?

2010-09-15 Thread Weirdan
Forwarding to dev@ as this seems to me an obvious regression (unfortunately I got no reply from users@) -- Forwarded message -- From: Weirdan weir...@gmail.com Date: Wed, Sep 8, 2010 at 2:50 PM Subject: Regression for issue:2362 ? To: us...@subversion.apache.org Hello I'm using

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 05:12:43PM +0100, Julian Foad wrote: + * @since New in 1.7. + */ +svn_error_t * +svn_cstring_strtoi64(apr_int64_t *n, const char *str, + apr_int64_t minval, apr_int64_t maxval, + int base); +/** + *

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-15 Thread Stefan Sperling
On Fri, Sep 10, 2010 at 04:02:52PM +0200, Branko Čibej wrote: On 10.09.2010 15:26, Stefan Sperling wrote: I know we're using C89, but maybe it's time to move on and upgrade to C99 where the benefits are desirable? When Subversion was started, C89 was about a decade old, and C99 is just as

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 9:03 PM, Stefan Sperling s...@elego.de wrote: On Fri, Sep 10, 2010 at 04:02:52PM +0200, Branko Čibej wrote:  On 10.09.2010 15:26, Stefan Sperling wrote: I know we're using C89, but maybe it's time to move on and upgrade to C99 where the benefits are desirable? When

Re: svn commit: r997249 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/cl.h svn/main.c svn/patch-cmd.c tests/cmdline/patch_tests.py tests/libsvn_client/client-test.c

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 08:53:17PM +0200, Hyrum K. Wright wrote: How about just adding '--patch-left' and '--patch-right' or something. The either both have to used, or neither, and if they are, use those names as the once in the patch. I don't like these names because it's not clear what

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 06:15:58PM +0200, Daniel Shahaf wrote: Stefan Sperling wrote on Tue, Sep 14, 2010 at 21:18:26 +0200: On Tue, Sep 14, 2010 at 12:49:06PM +0100, Julian Foad wrote: Right. The issue seems to be How do I determine what path I should apply the patch to? If the patch

Pending 1.6.x backport proposals.

2010-09-15 Thread C. Michael Pilato
I've committed a bunch of changes for issue #3709 and related situations (r996884, r997026, r997457, r997466, r997471, and r997474). I *do* plan to propose them for backport to 1.6.x, but that work will have to wait until tomorrow. Just letting folks know. -- C. Michael Pilato

Pending 1.6.x backport proposals.

2010-09-15 Thread C. Michael Pilato
I've committed a bunch of changes for issue #3709 and related situations (r996884, r997026, r997457, r997466, r997471, and r997474). I *do* plan to propose them for backport to 1.6.x, but that work will have to wait until tomorrow. Just letting folks now. -- C. Michael Pilato

Re: svn commit: r997403 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-09-15 Thread Greg Stein
On Wed, Sep 15, 2010 at 13:19, julianf...@apache.org wrote: ... -    - ### A comment on 'repos_id' and 'repos_relpath' says they may be null; -      is this true and wanted? Yes. That meant use the parent's information, and extend it to compute this node's value. +    - The Node-Rev group

Re: svn commit: r997334 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-09-15 Thread Greg Stein
On Wed, Sep 15, 2010 at 09:45, julianf...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_wc/wc-metadata.sql Wed Sep 15 13:45:12 2010 @@ -618,6 +618,21 @@ PRAGMA user_version =    BASE nodes and on top of other WORKING nodes, due to nested tree structure    changes. The layers

Re: svn commit: r996811 - in /subversion/trunk/subversion/libsvn_wc: upgrade.c wc.h

2010-09-15 Thread Greg Stein
On Tue, Sep 14, 2010 at 06:08, rhuij...@apache.org wrote: Author: rhuijben Date: Tue Sep 14 10:08:35 2010 New Revision: 996811 URL: http://svn.apache.org/viewvc?rev=996811view=rev Log: Move some defines that are only used on upgrades from wc.h to upgrade.c. *

Re: svn commit: r997493 - /subversion/object-model/

2010-09-15 Thread Greg Stein
On Wed, Sep 15, 2010 at 16:39, hwri...@apache.org wrote: Author: hwright Date: Wed Sep 15 20:39:44 2010 New Revision: 997493 URL: http://svn.apache.org/viewvc?rev=997493view=rev Log: Create the object-model branch, wherein we will attempt to put into practice some of the ideas defined in

Re: svn commit: r997493 - /subversion/object-model/

2010-09-15 Thread Hyrum K. Wright
On Wed, Sep 15, 2010 at 10:43 PM, Greg Stein gst...@gmail.com wrote: On Wed, Sep 15, 2010 at 16:39,  hwri...@apache.org wrote: Author: hwright Date: Wed Sep 15 20:39:44 2010 New Revision: 997493 URL: http://svn.apache.org/viewvc?rev=997493view=rev Log: Create the object-model branch,

UTF-8 NFC/NFD paths issue

2010-09-15 Thread Erik Huelsmann
Yesterday, I was talking to CMike about our long-standing issue with UTF-8 strings designating a certain path not neccessarily being equal to other strings designating the same path. The issue has to do with NFC (composed) and NFD (decomposed) representation of Unicode characters. CMike nicely

Re: UTF-8 NFC/NFD paths issue

2010-09-15 Thread Daniel Shahaf
Erik Huelsmann wrote on Wed, Sep 15, 2010 at 23:20:06 +0200: Yesterday, I was talking to CMike about our long-standing issue with UTF-8 strings designating a certain path not neccessarily being equal to other strings designating the same path. The issue has to do with NFC (composed) and NFD

Re: UTF-8 NFC/NFD paths issue

2010-09-15 Thread Greg Stein
On Wed, Sep 15, 2010 at 23:35, Daniel Shahaf d...@daniel.shahaf.name wrote: Erik Huelsmann wrote on Wed, Sep 15, 2010 at 23:20:06 +0200: Yesterday, I was talking to CMike about our long-standing issue with UTF-8 strings designating a certain path not neccessarily being equal to other strings