OWP: Introduction for Gabriela Gibson

2012-12-10 Thread Gabriela Gibson
Dear All, My name is Gabriela Gibson and I've applied for the internship with Subversion under the Gnome Outreach for Women Program. I am an ex-wizardess who used to haunt a long-lost MUD. I've not programmed in a while, although I've *intended* to join more than one open-source project

[PATCH] Test for line ending bug in svnrdump (issue 4263)

2012-12-10 Thread Gabriela Gibson
[[[ Test for issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in 'svn:log' property * subversion/tests/cmdline/svnrdump_tests.py copy_bad_line_endings_load: Test for \r line ending bug in svnrdump (issue 4263) ]]] Index: svnrdump_tests.py

OWP: Introduction for Gabriela Gibson

2012-12-10 Thread Gabriela Gibson
Dear All, My name is Gabriela Gibson and I've applied for the internship with Subversion under the Gnome Outreach for Women Program. I am an ex-wizardess who used to haunt a long-lost MUD. I've not programmed in a while, although I've *intended* to join more than one open-source project

[PATCH] Test for line ending bug in svnrdump (issue 4263)

2012-12-10 Thread Gabriela Gibson
[[[ Test for issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in 'svn:log' property * subversion/tests/cmdline/svnrdump_tests.py copy_bad_line_endings_load: Test for \r line ending bug in svnrdump (issue 4263) ]]] Index: svnrdump_tests.py

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

2012-12-11 Thread Gabriela Gibson
On 11/12/12 00:46, Daniel Shahaf wrote: Need parentheses around the symbol name. Lines should be wrapped at 80 characters and subsequent lines indented. The web page instructions[1] need updating because they doesn't mention this and so, I was trying to stay under a 72 character limit for

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

2012-12-11 Thread Gabriela Gibson
On 11/12/12 00:46, Daniel Shahaf wrote: snip subversion/svnrdump/svnrdump.c:554: (apr_err=125005) subversion/libsvn_repos/load.c:583: (apr_err=125005) subversion/libsvn_repos/load.c:260: (apr_err=125005) subversion/svnrdump/load_editor.c:858: (apr_err=125005)

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

2012-12-11 Thread Gabriela Gibson
On 11/12/12 23:01, Daniel Shahaf wrote: Gabriela Gibson wrote on Tue, Dec 11, 2012 at 22:18:54 +: On 11/12/12 00:46, Daniel Shahaf wrote: I will attempt to do just this. Also your tip with the libtool was much appreciated, thank you very much :) Welcome. Index: subversion/tests

[PATCH] Fix for \r in svnrdump load (issue 4263)

2012-12-17 Thread Gabriela Gibson
Hi all, [[ Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in 'svn:log' property Fix to ensure that no \r characters are present in revision or node props. In the case of \r\n character sequences, the \r is removed. In the case of \r characters which are not followed by

Re: [PATCH] Fix for \r in svnrdump load (issue 4263)

2012-12-18 Thread Gabriela Gibson
On 18/12/12 02:09, Ben Reser wrote: On Mon, Dec 17, 2012 at 5:40 PM, Gabriela Gibson gabriela.gib...@gmail.com wrote: [[ Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in 'svn:log' property Fix to ensure that no \r characters are present in revision or node props

Re: [PATCH] Fix for \r in svnrdump load (issue 4263) (reworked)

2012-12-18 Thread Gabriela Gibson
[[[ Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in 'svn:log' property Fix to ensure that no \r characters are present in revision or node props. In the case of \r\n character sequences, the \r is removed. In the case of \r characters which are not followed by \n, the

[PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-19 Thread Gabriela Gibson
on page: http://subversion.apache.org/docs/community-guide/general.html#directory-layout Patch by: Gabriela Gibson gabriela.gib...@gmail.com ]]] regards, Gabriela ps.: The credit note was just for practice : --- general-orig.html 2012-12-19 11:53:49.880600246 + +++ general-new.html 2012-12

Re: [PATCH] code file names linkified in general.html of the Hacking Gttuide

2012-12-20 Thread Gabriela Gibson
On 19/12/12 12:59, Stefan Sperling wrote: Here it looks like we'll end up closing li twice. Was that on purpose? Oops :( -- Firefox saved a mangled original I worked on and when I looked at the messy patch this produced, I decided to get a fresh copy and to 'buff it out' by copying the

Re: [PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-26 Thread Gabriela Gibson
. Patch by: Gabriela Gibson gabriela.gib...@gmail.com ]]] Index: docs/community-guide/general.part.html === --- docs/community-guide/general.part.html (revision 1425918) +++ docs/community-guide/general.part.html (working copy) @@ -174,15

[PATCH] Update to out-of-date code comments

2012-12-27 Thread Gabriela Gibson
* subversion/svnserve/svnserve.c: (Opening comment): File name fixed Patch by Gabriela Gibson gabriela.gibson_at_gmail.com ]]] Index: subversion/tests/svn_test_main.c === --- subversion/tests/svn_test_main.c (revision 1426182

Re: [PATCH] Update to out-of-date code comments

2012-12-28 Thread Gabriela Gibson
rename Patch by: Gabriela Gibson gabriela.gibson_at_gmail.com ]]]

Proposal for OPW project

2012-12-30 Thread Gabriela Gibson
Hi, As you may know, I have been familiarising myself with Subversion with a view to obtaining an internship under the Outreach Program for Women. However, I have yet to decide on a project. For those that aren't aware, this is a 3 month sponsored internship similar to the Google Summer of

[PATCH] Procedure for making web page changes

2012-12-31 Thread Gabriela Gibson
This is a first cut, there is room for improvement, please let me know what you think. Because of the size of the changes, I considered attaching the resulting web page -- would that be appropriate in future? Happy New Year! Gabriela [[[ Addition of section describing procedure for

Re: Proposal for OPW project

2013-01-01 Thread Gabriela Gibson
Hi All, The following is a conversation that should have been held on the list, please excuse the misunderstanding on my part. On 01.01.2013 15:09, Gabriela Gibson wrote: Hi Brane, Daniel mentioned on the dev list that you are working on the C++ bindings and advised me to contact you

[PATCH]: Re: Proposal for OPW project

2013-01-02 Thread Gabriela Gibson
On 02/01/13 00:55, Branko Čibej wrote: On 01.01.2013 22:17, Gabriela Gibson wrote: Hi Brane and everyone here, I've used configure and friends before, albeit in a much smaller setting, so the territory looks familiar. Googletest and virtual hosts also looks also like good tools to know about

Re: Proposal for OPW project

2013-01-02 Thread Gabriela Gibson
On 02/01/13 10:38, Philip Martin wrote: Gabriela Gibson gabriela.gib...@gmail.com writes: But this would leave space for other projects. Does anyone have ideas for good (relatively small) projects to help me learn the code base? A small one: svnadmin freeze multiple repositories http

[PATCH]: Re: Proposal for OPW project

2013-01-03 Thread Gabriela Gibson
is: [[[ Change default behaviour of get_deps.sh from downloading gtest library to making it an optional target. * get-deps.sh (usage): Add gtest to list of possible arguments. (get_deps): Remove gtest from list of default downloads. Patch by: Gabriela Gibson gabriela.gibson{_AT_}gmail.com ]]]

Re: Proposal for OPW project

2013-01-03 Thread Gabriela Gibson
On 02/01/13 21:59, Philip Martin wrote: Or the loop could go in the libsvn_repos library by changing the svn_repos_freeze API to pass an array of paths. The loop in the library may well look much like the above svnadmin loop, but putting it in the library has the advantage of making it readily

[Patch] Re: [PATCH] code file names linkified in general.html of the Hacking Guide

2013-01-06 Thread Gabriela Gibson
to point to current directories in development repository. (directory-layout): Remove apr and neon links. Patch by: Gabriela Gibson gabriela.gibson{_AT_}gmail.com ]]]

sha-256 comment in /trunk/subversion/libsvn_subr/crypto.c

2013-01-08 Thread Gabriela Gibson
In line 555 and 690 in crypto.c, there are the following FIXME's: /* ### FIXME: This should be a SHA-256. */ SVN_ERR(svn_checksum(stuff_sum, svn_checksum_sha1, stuff_vector, stuff_len, scratch_pool)); The problem appears to be that there is no sha-256 implementation

Diff Project compilation problem

2013-01-09 Thread Gabriela Gibson
I added a new option to the command structure and the compile error I get is this: ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined reference to `svn_wc__get_wcroot' ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined reference to `svn_wc_add_from_disk2' What

Re: Diff Project compilation problem

2013-01-09 Thread Gabriela Gibson
On 09/01/13 16:54, Philip Martin wrote: ./configure --prefix=/usr/local/subversionx ... which solves the linking problem. I never install this build so /usr/local/subversionx/lib never exists. When I want to install a build of Subversion I reconfigure and rebuild using the correct

Re: [PATCH] Re: Diff Project compilation problem

2013-01-10 Thread Gabriela Gibson
On 10/01/13 03:55, Daniel Shahaf wrote: Is this section applicable to tarball builds (which don't use autogen.sh) too? I'm worming my way through the list (more to come) but have encountered the following issue: I was testing whether the current tarball (subversion-1.7.8.tar.gz) is

Re: [PATCH] Re: Diff Project compilation problem

2013-01-13 Thread Gabriela Gibson
I propose we add the FAQ entry similar to the following: pOne typical error message class involve the following pattern:/p pre ../../subversion/../*.so: undefined reference to `function_not_worked_on' collect2: ld returned 1 exit status make: *** [subversion/something/something] Error 1 /pre

Re: Wiki access request

2013-01-15 Thread Gabriela Gibson
GabrielaGibson On Tue, Jan 15, 2013 at 12:29 PM, Daniel Shahaf d...@daniel.shahaf.namewrote: What's your username? Gabriela Gibson wrote on Tue, Jan 15, 2013 at 11:39:15 +: Could I have Wiki editing access please?

Entry level projects Ads

2013-01-16 Thread Gabriela Gibson
Directory Idea' led to that idea: Stefan wrote: On Tue, Jan 15, 2013 at 12:41:33PM +, Gabriela Gibson wrote: As an idea, do you think we could attract more contributers if we had an 'apprentice positions offered' page with (say) 3 projects earmarked for beginners of various skill sets

Walk-through Directory Idea

2013-01-16 Thread Gabriela Gibson
Please take a look at the sketch here: http://wiki.apache.org/subversion/Walkthrough%20directory%20Concept%20page

Re: [PATCH] Procedure for making web page changes

2013-01-20 Thread Gabriela Gibson
On 20/01/13 05:17, Daniel Shahaf wrote: Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: On 03/01/13 04:34, Daniel Shahaf wrote: + liEnable Server Side Includes for the relevant DocumentRoot. The + relevant Apache directive is: + pre Options +Include What

Re: Running gdb in the build tree Re: OWP: Introduction for Gabriela Gibson

2013-01-21 Thread Gabriela Gibson
On 21/01/13 11:05, Daniel Shahaf wrote: On Mon, Dec 10, 2012 at 11:02:22PM -0500, C. Michael Pilato wrote: On 12/10/2012 07:32 PM, Daniel Shahaf wrote: Gabriela Gibson wrote on Tue, Dec 11, 2012 at 00:21:19 +: For my initial submission I have written a test for issue 4263 which I'll mail

Re: Running gdb in the build tree Re: OWP: Introduction for Gabriela Gibson

2013-01-21 Thread Gabriela Gibson
On 21/01/13 16:11, Daniel Shahaf wrote: Hyrum K Wright wrote on Mon, Jan 21, 2013 at 11:05:23 -0500: On Mon, Jan 21, 2013 at 6:41 AM, Gabriela Gibson gabriela.gib...@gmail.comwrote: We might want to think about putting them on the site or on the wiki, as it might be hard for newcomers

Re: Running gdb in the build tree Re: OWP: Introduction for Gabriela Gibson

2013-01-23 Thread Gabriela Gibson
On 21/01/13 16:05, Hyrum K Wright wrote: We might want to think about putting them on the site or on the wiki, as it might be hard for newcomers to find them buried in an email thread. But I agree that a location collecting debugging tips would be useful. I've parked the current collection

Community-guide: outdated svn-breakage web page advice on building.html

2013-01-25 Thread Gabriela Gibson
The following section http://subversion.apache.org/docs/community-guide/building.html#automated-tests is still pointing to the removed svntest directory: /trunk/tools/test-scripts/svntest/ here: If you'd like to send svn-breakage messages too, use the svntest framework (start at the README).

[PATCH] Re: Community-guide: outdated svn-breakage web page advice on building.html

2013-01-25 Thread Gabriela Gibson
about SVN automated tests and repoint links * svn/site/publish/docs/community-guide/building.part.html (automated-tests): Update information and links. (build-farm): Updated link to trac.buildbot.net site. Patch by: Gabriela Gibson gabriela.gibson{_AT_}gmail.com Suggested by: Stefan

[OPW] Introducing the 2013 Apache Subversion Intern

2013-01-31 Thread Gabriela Gibson
Hi everyone, I am the current Gnome Outreach Program for Women intern for the Apache Subversion project, sponsored by Elego, Berlin, Germany. OPW is a GNOME Woman initiative that aims to inspire women to contribute to Free Software projects. A short introduction to my official goals for the

Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-01 Thread Gabriela Gibson
On 22/01/13 12:03, Stefan Sperling wrote: On Tue, Jan 22, 2013 at 11:15:30AM +, Gabriela Gibson wrote: Part of my 2013 OPW Project for Subversion is to add the Googletest First of all thanks to Ben for rescuing my messy post =) Also thanks to everyone who gave me hints

[PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-05 Thread Gabriela Gibson
rules Patch by: Gabriela Gibson gabriela.gibson{_AT_}gmail.com ]]]

Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

2013-02-06 Thread Gabriela Gibson
On 05/02/13 17:00, Branko Čibej wrote: On 05.02.2013 14:28, Gabriela Gibson wrote: I'm almost sure you meant, path = gtestlib. -- Brane Nope, meant libgtest, ended up with both and the mistake compiled %-) I think it's working now, see attached patch. Index: configure.ac

Re: [OPW] Introducing the 2013 Apache Subversion Intern

2013-02-14 Thread Gabriela Gibson
On 31/01/13 12:54, Nico Kadel-Garcia wrote: On Thu, Jan 31, 2013 at 7:24 AM, Gabriela Gibson gabriela.gib...@gmail.com wrote: Hi everyone, I am the current Gnome Outreach Program for Women intern for the Apache Subversion project, sponsored by Elego, Berlin, Germany. OPW is a GNOME Woman

[RFC] Build System Documentation

2013-02-18 Thread Gabriela Gibson
I've written up some documentation about the build system, could I please have some feedback as to usefulness, style, shape etc? thanks, Gabriela --- The Subversion Build System, an overview

mailing list issues and the silly error in the build system doc thread

2013-02-18 Thread Gabriela Gibson
Hi, it seems that the mailing list is not mailing me a copy of threads I start, so it's not easy to add a correction if I have made a mistake, unless someone posts first so I can answer. Would it be possible to change this? Alas, it looks like there is always at least one error hiding -- in

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Gabriela Gibson
On 20/01/13 05:17, Daniel Shahaf wrote: Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: On 03/01/13 04:34, Daniel Shahaf wrote: + liEnable Server Side Includes for the relevant DocumentRoot. The + relevant Apache directive is: + pre Options +Include What

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Gabriela Gibson
(this is a test, I hope this does not make it's own, new thread!) On 1/20/13, Gabriela Gibson gabriela.gib...@gmail.com wrote: On 20/01/13 05:17, Daniel Shahaf wrote: Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: On 03/01/13 04:34, Daniel Shahaf wrote: + liEnable Server Side

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Gabriela Gibson
On 19/02/13 13:06, Daniel Shahaf wrote: I see. The interesting part is that I asked about AddOutputFilter INCLUDES .html because httpd.conf has it enabled for us specifically. I Also tested by hand and confirmed that /www/subversion.apache.org/index2.html has SSI directives parsed even if

Re: [PATCH] Procedure for making web page changes

2013-02-20 Thread Gabriela Gibson
to web.html. * publish/docs/community-guide/debugging.html (site-content): Add SSI variable pointing to web.html. * publish/docs/community-guide/building.html (site-content): Add SSI variable pointing to web.html. Patch by: Gabriela Gibson gabriela.gibson{_AT_}gmail.com ]]] Index: publish/.htaccess

Re: [PATCH] Procedure for making web page changes

2013-02-20 Thread Gabriela Gibson
On 20/02/13 15:28, Gabriela Gibson wrote: On 20/02/13 07:24, Daniel Shahaf wrote: Directory /x1/www/subversion.apache.org Thank you :) The patch and log are attached. Sorry, I'm just hooked on phonics at the moment (and the virus I'm still wrestling is probably innocent), a correction

Re: [PATCH] Procedure for making web page changes

2013-02-20 Thread Gabriela Gibson
On 20/02/13 18:54, Daniel Shahaf wrote: Gabriela Gibson wrote on Wed, Feb 20, 2013 at 16:22:36 +: On 20/02/13 15:28, Gabriela Gibson wrote: +++ publish/.htaccess (working copy) @@ -1,7 +1,6 @@ # duplicated in httpd.conf in r795618 Options +Includes -XBitHack On RedirectMatch

Build System: autogen.sh header warnings when compiling with gtest

2013-02-21 Thread Gabriela Gibson
Ben Reser asked me in the [RFC] Build System Documentation thread about the gtest example: -mv $GTEST gtest +mv $GTEST libgtest +echo Gtest has been installed, please note: +echo autogen.sh will issue spurious header warnings. +echo ./configure --enable-gtest will

Re: [RFC] Build System Documentation

2013-02-22 Thread Gabriela Gibson
On 22/02/13 00:45, Daniel Shahaf wrote: % svn log -qv -l1 -r 1:HEAD subversion/tests/cmdline/atomic-ra-revprop-change.c r965054 | danielsh | 2010-07-17 14:23:38 +0300 (Sat, 17 Jul 2010) Changed paths: M

Re: [RFC] Build System Documentation

2013-02-22 Thread Gabriela Gibson
On 20/02/13 21:06, Ben Reser wrote: On Mon, Feb 18, 2013 at 4:10 AM, Gabriela Gibson gabriela.gib...@gmail.com wrote: Thank you for the corrections and ideas, they have been worked into the document. Also typo of recognized/recognised (depending on preference US vs UK spelling). What

Re: [RFC] Build System Documentation

2013-02-22 Thread Gabriela Gibson
On 22/02/13 20:09, Daniel Shahaf wrote: Gabriela Gibson wrote on Fri, Feb 22, 2013 at 17:13:08 +: On 20/02/13 21:06, Ben Reser wrote: You skipped the primary function of gen-make.py which is caused by this call generator.write(). There are two gen-make.py files -- I was describing /trunk

Re: [RFC] Build System Documentation

2013-02-24 Thread Gabriela Gibson
On 22/02/13 00:45, Daniel Shahaf wrote: How about just linking to a revnum wherein a standalone application was added? That's less likely to get out of date. For example % svn log -qv -l1 -r 1:HEAD subversion/tests/cmdline/atomic-ra-revprop-change.c

Re: [RFC] Build System Documentation

2013-02-24 Thread Gabriela Gibson
On 24/02/13 17:57, Branko Čibej wrote: On 24.02.2013 18:21, Gabriela Gibson wrote: svn diff on which target? :) Well, svn diff -c 858288 works great, so I assumed that it's legit : (now I have to wonder _why_ this works, heh) If I run your command on the root of a trunk checkout

[PATCH] htaccess file and permissions

2013-02-28 Thread Gabriela Gibson
[[[ Update web server configuration file and change file permissions to remove the executable bit. * site/publish/.htaccess(): remove XBitHack On. * site/* remove svn:executable property from all files, with the exception of 'download/download.cgi'. Patch by: Gabriela Gibson

Re: [PATCH] htaccess file and permissions

2013-02-28 Thread Gabriela Gibson
: http://svn.haxx.se/dev/archive-2013-02/0274.shtml for the discussion. * site/publish/.htaccess(): remove XBitHack On. * site/* remove svn:executable property from all files. Patch by: Gabriela Gibson gabriela.gibson{_AT_}gmail.com Suggested by: danielsh ]]]

svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-01 Thread Gabriela Gibson
I have an old 1.6 Ubuntu installed svn, and it's blocking me from debugging because the client format is to old. Since I need a working svn to do anything, I cannot just get rid of it. This is what happens when I try to debug anything: in emacs24: M-x libtool --mode=execute gdb -i=mi --epoch

[RFC] gtest branch posted

2013-03-03 Thread Gabriela Gibson
Here is the patch for the branch I added earlier on: https://svn.apache.org/repos/asf/subversion/branches/gtest_addition/ Please let me know if there is anything I can do to improve upon this. Thanks :) Gabriela Index: INSTALL

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 01/03/13 22:53, Daniel Shahaf wrote: BTW, I do 'alias -g \$svn=\$SVN' so that the envvar is called SVN (scripts look for that) but interactively I can type '$svn' in lowercase. _create_aliases() { thank you for that :) The instructions on building serf were a little outdated, but I got

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 18:09, Daniel Shahaf wrote: Gabriela Gibson wrote on Mon, Mar 04, 2013 at 17:51:15 +: +However, to compile serf with Subversion, the following configure +flags are also required: + + --with-apr=/path/to/apr/install + --with-apr-util=/path/to/apr-util/install + First of all

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 19:02, Daniel Shahaf wrote: ./serfmake --prefix=/usr/local/serf build check install Sorry, I should have mentioned that properly -- serf is installed at this point. But I double checked, and for me, it is still broken. Btw, those instructions no longer work for the new serf,

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 19:44, Daniel Shahaf wrote: Do you use the system's apr (e.g., /usr/lib/libapr-1.so) or compile your own? If the former you should install the apr-dev (or similar) package, if the latter it appears you need to pass --with-apr to serf/serfmake (or serf/configure if you use that).

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 22:48, Ben Reser wrote: Can you provide the output of the serf sections in config.log? ./configure --enable-maintainer-mode --with-serf=/usr/local/serf configure:5459: result: yes configure:5491: serf library configuration via prefix configure:5501: checking serf.h usability

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 22:57, Daniel Shahaf wrote: Gabriela Gibson wrote on Mon, Mar 04, 2013 at 22:33:23 +: What I've also found during my experiments at the weekend is that apr-related entries in LD_FLAGS are edited while configure runs. So: LD_FLAGS=-L/usr/local/serf/lib -L/usr/local/apr/lib

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 22:57, Daniel Shahaf wrote: Gabriela Gibson wrote on Mon, Mar 04, 2013 at 22:33:23 +: What I've also found during my experiments at the weekend is that apr-related entries in LD_FLAGS are edited while configure runs. So: LD_FLAGS=-L/usr/local/serf/lib -L/usr/local/apr/lib

Re: OT: $SVN envvars Re: svn 1.8 debugging-compilation-serf-configure problem because of 1.6 Ubuntu install

2013-03-04 Thread Gabriela Gibson
On 04/03/13 23:17, Daniel Shahaf wrote: Gabriela Gibson wrote on Mon, Mar 04, 2013 at 23:16:21 +: On 04/03/13 22:57, Daniel Shahaf wrote: Gabriela Gibson wrote on Mon, Mar 04, 2013 at 22:33:23 +: What I've also found during my experiments at the weekend is that apr-related entries

[RFC] get-deps.sh make-over

2013-03-08 Thread Gabriela Gibson
I would like to make get-deps.sh a little more informative. 1) every time it downloads something, it should tell you what it got, where it is and what it's needed for and what you're expected to do with it, if anything. For example: - downloading apt (required library) from ... - done --

svn diff fix for bug 2044

2013-03-19 Thread Gabriela Gibson
Hi, I've made some changes to meet some feature requests regarding svn diff. Could you please take a look and let me know if I'm on the right track? thanks, Gabriela [[[ Change svn diff to allow removal of -u and use of arbitrary strings in place of current hard-coded -L switch. This

Re: svn diff fix for bug 2044

2013-03-19 Thread Gabriela Gibson
On 19/03/13 13:09, Julian Foad wrote: Julian Foad wrote: For the record, the summary line of issue #2044 is 'Fully customizable external diff invocations'. (I like to mention the summary alongside the number as I am not good at memorizing issue numbers.) I'm curious about your patch because

Re: svn diff fix for bug 2044

2013-03-20 Thread Gabriela Gibson
Thanks for all the feedback, advice and ideas so far :) IIRC Subversion needs to communicate the following file names to the user's diff program: mine, yours, base and output It then takes the user input (--diff-cmd) from either the command line or a script, and produces a command to run the

Re: Issue #2044 - Fully customizable external diff invocations

2013-03-21 Thread Gabriela Gibson
On 21/03/13 15:05, Julian Foad wrote: - Does Subversion provide good labels? I have been using 'diff3-cmd' configured to run kdiff3, and the labels Subversion passes to it are like '.mine', '.r1459015' and '.r1459080' -- they don't include the file name at all, which makes it very hard to see

Re: [PATCH] Code tidying for subversion/include/config.h

2013-03-24 Thread Gabriela Gibson
On 23/03/13 15:58, Daniel Shahaf wrote: Gabriela Gibson wrote on Sat, Mar 23, 2013 at 15:27:31 +: [[[ Align variables for easier reading. *subversion/include/config.h(): Align variables. ]]] -0. The indentation is intention and reflects the nesting (e.g., --config-option

Re: [PATCH] Code tidying for subversion/include/config.h

2013-03-26 Thread Gabriela Gibson
On 25/03/13 13:40, C. Michael Pilato wrote: Note that if there's a way to make the additional comment *not* show up in our doxygen docs, that's preferred -- I don't suspect the indentation-dependent layout of that header will survive the transformation to that output format. After trying out

[PATCH] Change label strings in svn up to match svn diff

2013-03-30 Thread Gabriela Gibson
[[[ Change the label strings for svn merge and svn update when diff3-cmd is used to match the label strings for svn diff when diff-cmd is used. * subversion/libsvn_wc/update_editor.c (svn_wc__perform_file_merge): Alter label to include filename. ]]] Index:

[PATCH] run_test.py appearance changes

2013-03-31 Thread Gabriela Gibson
[[[ Disable ANSI color for dumb terminals, format terminal test output. * build/run_tests.py (TestHarness): Add test condition, format terminal output. ]]] I disabled color conditionally for dumb terminals because the control characters are displayed in the raw in those. Index:

Re: [PATCH] Change label strings in svn up to match svn diff

2013-03-31 Thread Gabriela Gibson
On 31/03/13 00:39, Daniel Shahaf wrote: Gabriela Gibson wrote on Sat, Mar 30, 2013 at 21:31:31 +: Code inspection tells me that oldrev_str can become the @a suffix parameter to the svn_io_open_uniquely_named() call in preserve_pre_merge_files(), in which case [\t ()] are all inappropriate

Re: [PATCH] run_test.py appearance changes

2013-04-01 Thread Gabriela Gibson
On 01/04/13 01:31, Daniel Shahaf wrote: I reworked hunk 2 because I found a bug. The actual problem I saw was caused because the script didn't handle the case where the terminal dimension returns as (0,0). I've fixed this in the new patch, and cleaned up inefficient code. I did note,

Re: [PATCH] run_test.py appearance changes

2013-04-06 Thread Gabriela Gibson
On 4/2/13, Daniel Shahaf danie...@elego.de wrote: I'm not sure how to interpret a return value of (0,0) that's not accompanied by an error flag (C errno!=0, or a Python exception). Is that normal behaviour, a bug we should be working around in our code, or an indication of a bug in our logic in

Diff Project --invoke-diff-cmd part

2013-04-11 Thread Gabriela Gibson
This patch plugs in a new option --invoke-diff-cmd into the existing diff command structure, but does leave the existing diff-cmd option untouched. This addition allows the user to define a complex diff command, to be applied in place of the internal diff, for example: svn diff

Subversion InstantPlayground patch

2013-04-16 Thread Gabriela Gibson
Here is a little dev toy for casual submitters and people who just want to have a quick play with the svn source, or perhaps use svn as a framework to explore one of the API's that svn uses. The patch sets up a new option for the svn diff command called 'InstantPlayground' and puts a function

Re: Diff Project --invoke-diff-cmd part

2013-04-23 Thread Gabriela Gibson
Many thanks for the inspiring feedback! Gabriela Julian Foad wrote: * This patch breaks the override --internal-diff for now, because this part has to be revised anyway when the invoke-diff3-cmd part gets added. OK, we'll have to decide

[PATCH] Fix for --internal-diff cmd coredump problem

2013-04-24 Thread Gabriela Gibson
[[[ Fix --internal-diff coredump due to NULL pointer in string routine. * subversion/libsvn_subr/config.c (make_string_from_option): Add test to ensure that the string passed to strcmp is not a NULL value. ]]] Index: subversion/libsvn_subr/config.c

[PATCH] Doxygen documentation change for svn_cstring_split() in svn_string.h

2013-04-27 Thread Gabriela Gibson
Danielsh suggested on IRC that I clarify the API documentation for the function svn_cstring_split(). [[[ Clarify the doxygen documentation for the semantics of the @a sep_chars parameter. * subversion/include/svn_string.h (svn_cstring_split): Update doxygen comment. Suggested by: Danielsh

Re: Diff Project --invoke-diff-cmd part

2013-04-28 Thread Gabriela Gibson
On 28/04/13 10:24, Daniel Shahaf wrote: Alan Barrett wrote on Wed, Apr 24, 2013 at 09:44:11 +0200: On Tue, 23 Apr 2013, Gabriela Gibson wrote: Also, a minor design nit (sorry, no code review): The ---f1 construct is something I've never seen before. That's why I picked it --- I checked

Re: Diff Project --invoke-diff-cmd part

2013-04-29 Thread Gabriela Gibson
Take two. Thanks for looking! Gabriela [[[ Add new diff option --invoke-diff-cmd which allows the user to define a custom command line or config file entry for an external diff program. * subversion/include/svn_client.h (svn_client_diff6): Deprecate. Add new Doxygen comment.

Re: Diff Project --invoke-diff-cmd part

2013-04-29 Thread Gabriela Gibson
Sorry I forgot to explain the changed syntax. Here is the help section: --invoke-diff-cmd ARG: use ARG as format string for external diff command invocation. Substitutions: %f1 %f2 files to compare %l1 %l2 user defined labels Examples: --invoke-diff-cmd=diff -y %f1 %f2

[PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Gabriela Gibson
[[[ Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz * subversion/build/get-deps.sh: (): Update zlib version number. (get_zlib): Modify tar command and file extension. ]]] Index: get-deps.sh === ---

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-05-01 Thread Gabriela Gibson
On 30/04/13 18:27, Ben Reser wrote: 1) Need to avoid using GNU tar options on this. Just like we don't use the j option to tar to deal with bzip2 we can't use the z option to deal with gzip. Should this note be a comment in get-deps.sh?

[PATCH] HACKING GUIDE entry for SVN_DBG usage in the Debugging Subversion section

2013-05-06 Thread Gabriela Gibson
Hi, I created a short SVN_DBG overview for the debugging page in the HACKING GUIDE. Please let me know if this can be improved. Gabriela [[[ Add section describing usage of the SVN_DBG macro to the Community Guide page 'Debugging Subversion'. *

--invoke-diff-cmd test suite woes

2013-05-08 Thread Gabriela Gibson
Hi, All my manual tests for the current --invoke-diff-cmd work fine, but I cannot get the test suite to work. I added the following new test (nr 49) to diff_tests.py: [[[ # Check the order of the arguments for an external diff tool def diff_invoke_external_diffcmd(sbox): svn diff

Re: Diff Project --invoke-diff-cmd part

2013-05-13 Thread Gabriela Gibson
Hi, thanks for all the comments and help, here is the next attempt. Gabriela [[[ Add new diff option --invoke-diff-cmd which allows the user to define a custom command line or config file entry for an external diff program. * subversion/include/svn_client.h (svn_client_diff7,

Re: Diff Project --invoke-diff-cmd part

2013-05-13 Thread Gabriela Gibson
On 13/05/13 22:53, Gabriela Gibson wrote: Hi, thanks for all the comments and help, here is the next attempt. Gabriela Sorry I had one mistake in the patch that has now been fixed. Please ignore the patch in the previous post, the attached patch is the working one. Gabriela Index

Re: Diff Project --invoke-diff-cmd part

2013-05-17 Thread Gabriela Gibson
Hi, I made a feature branch for the project here: https://svn.apache.org/repos/asf/subversion/branches/invoke-diff-cmd-feature/ Gabriela

Re: svn commit: r1484260 - /subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_client/diff.c

2013-05-20 Thread Gabriela Gibson
On 19/05/13 17:48, Daniel Shahaf wrote: On Sun, May 19, 2013 at 10:15:55AM -, g...@apache.org wrote: Author: gbg Date: Sun May 19 10:15:55 2013 New Revision: 1484260 URL: http://svn.apache.org/r1484260 Log: Seperate variable declaration from assigment. * subversion/libsvn_client/diff.c

Re: Review of invoke-diff-cmd-feature branch

2013-05-21 Thread Gabriela Gibson
Because there is no option object that we can query from within io.c, diff.c and other places, we have to add extra courier parameters for every command line option we wish to add, in a number of places. We have 4 (potential) diff commands -- diff-cmd, diff3-cmd, invoke-diff-cmd and

Re: Review of invoke-diff-cmd-feature branch

2013-06-04 Thread Gabriela Gibson
Hi, I hope I've resolved most issues, here are ones I need to ask about: Index: subversion/include/svn_client.h === --- subversion/include/svn_client.h (revision 1484305) +++ subversion/include/svn_client.h (working copy) @@

Re: Review of invoke-diff-cmd-feature branch

2013-06-12 Thread Gabriela Gibson
On 6/11/13, Daniel Shahaf danie...@elego.de wrote: Gabriela Gibson wrote on Mon, Jun 10, 2013 at 23:39:45 +0100: On 6/10/13, Daniel Shahaf danie...@elego.de wrote: * @a invoke_diff_cmd takes an argument which is used to call an * external diff program. When invoked, the argument may

[PATCH] HACKING GUIDE: update and relocate advice on how to write log message for branches.

2013-06-13 Thread Gabriela Gibson
[[[ Rework branch and log message documentation. Tidy HTML. * community-guide/conventions.part.html (log-messages): Rework relocated branch log message documentation moved from community-guide/general.part.html#lightweight-branches. Remove mention of 'CIA' and substitute with ASFBot

  1   2   >