[dev] [st] [PATCH 2/2] Make -e behave as -- for compatibility.

--- st.c | 5 + 1 file changed, 5 insertions(+) diff --git a/st.c b/st.c index 6c9ba5c..5469a2c 100644 --- a/st.c +++ b/st.c @@ -4034,6 +4034,11 @@ main(int argc, char *argv[]) { case 'c': opt_class = EARGF(usage()); break; + case 'e': +

[dev] [st] [PATCH 1/2] Remove -e option. Use -- instead.

--- FAQ | 4 ++-- st.1 | 13 + st.c | 19 ++- 3 files changed, 13 insertions(+), 23 deletions(-) diff --git a/FAQ b/FAQ index 3502c60..275fc4e 100644 --- a/FAQ +++ b/FAQ @@ -26,8 +26,8 @@ st or st-256color. The default value for TERM can be changed in config.h

[dev] [vis] [PATCH] Highlight null directive.

--- config.def.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.def.h b/config.def.h index ff1a63c..bcacc8d 100644 --- a/config.def.h +++ b/config.def.h @@ -883,7 +883,7 @@ static Color colors[] = { } #define SYNTAX_C_PREPROCESSOR { \ - (^#[\\t

Re: [dev] [st] [PATCH 2/3] Do not use tmoveto in tputtab.

Applied, thanks!

Re: [dev] [st] ICCCM compatible selection handling

Applied, thanks.

Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

Hi Ben, Quoth tauto...@gmail.com: What is the build error? ‎I submitted the disk cache support, and can fix it. I am looking to see if I have an environment to reproduce.  Attached. surf build options: CFLAGS = -std=c99 -pedantic -Wall -Os -I. -I/usr/include -I/usr/X11R6/include -pthread

Re: [dev] [st] [PATCH 2/2] Make -e behave as -- for compatibility.

On Mon, Apr 13, 2015 at 09:58:16PM +0200, Roberto E. Vargas Caballero wrote: + case 'e': + /* xterm/rxvt compatibility */ + *argv[0] = '-'; + argc++, argv--; + break; case 'f': opt_font = EARGF(usage()); break;

[dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

Hi folks, Surf won't compile on Debian Wheezy anymore because of the disk cache stuff. This adds an #ifdef to make it disable-able. Probably not for mainline, but might be useful for people. Nick From 7dc9959f5b5bb12911bffc5fb91e80fd0b9bc4cf Mon Sep 17 00:00:00 2001 From: Nick White

Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

Hi Nick, What is the build error? ‎I submitted the disk cache support, and can fix it. I am looking to see if I have an environment to reproduce.  Thanks, Ben   Original Message   From: Nick Sent: Monday, April 13, 2015 3:06 PM To: dev@suckless.org Reply To: dev mail list Subject: [dev] [surf]

Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

Thank you, Nick.  ‎It looks like you can use SOUP_CHECK_VERSION(2, 34, 0) to test for the version that supports disk cache. ‎May you please try your patch with that code, and send me an updated patch? I will then test on my own system with support, and verify that the positive case also works. 

Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

Hi, ‎It looks like you can use SOUP_CHECK_VERSION(2, 34, 0) to test for the version that supports disk cache. ‎May you please try your patch with that code, and send me an updated patch? I will then test on my own system with support, and verify that the positive case also works.  I

[dev] [st][PATCH] Add tty line support

Not always is desirable to create a pseudo terminal, and some times we want to open a terminal emulator over a tty line. With this new patch is possible to do someting like: $ stty raw /dev/ttyS0 $ stty -iexten /dev/ttyS0 $ stty 115200 /dev/ttyS0 $ st -l /dev/ttyS0

Re: [dev] [st] [PATCH 2/3] Move tresize comments around.

Applied, thanks.

Re: [dev] [st] [PATCH 3/3] Remove 'slide' variable in tresize.

Applied, thanks. ---BeginMessage--- --- st.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/st.c b/st.c index 51bd40c..ce2646e 100644 --- a/st.c +++ b/st.c @@ -2770,7 +2770,6 @@ tresize(int col, int row) { int i; int minrow = MIN(row, term.row);

Re: [dev] [st] [PATCH 1/2] Do not use switch for fork() call.

I don't understand this patch. The switch-fork is a common idiom and I don't know why you think it should be changed. Regards,

Re: [dev] [st] [PATCH 1/2] Use do..while in window mapping loop.

Applied, thanks.

Re: [dev] [st] [PATCH 2/2] Remove unnecessary XFilterEvent call.

Applied, thanks.

Re: [dev] [st] [PATCH 2/2] Simplify loop condition.

Applied, thanks.

Re: [dev] [st] [PATCH 1/3] tresize: move for loop outside if

Applied, thanks.

Re: [dev] [st] [PATCH 4/3] tresize: remove unnecessary if

The assembly is rather irrelevant in this case. Let's write the code the way it is most understandable and clear. Yeah, I totally agree with you here. I'd remove the if, memmove is equivalent to a non-op when the offset is 0. But the problem now is to decide what is more understable. I

Re: [dev] [st] [PATCH 2/3] Move tresize comments around.

Applied, thanks.

Re: [dev] [st] [PATCH 1/2] Do not use switch for fork() call.

On Mon, Apr 13, 2015 at 09:20:34AM +0200, Roberto E. Vargas Caballero wrote: I don't understand this patch. The switch-fork is a common idiom and I don't know why you think it should be changed. It separates the case when fork fails and when fork succeeds. You can even move error-processing

[dev] [st] [PATCH 1/3] Fix typo.

It seems that LICENSE files are more common than LICENCE files. At least this patch makes spelling consistent. --- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st.c b/st.c index f183803..db35e71 100644 --- a/st.c +++ b/st.c @@ -1,4 +1,4 @@ -/* See LICENSE for licence

[dev] [st] [PATCH 3/3] Simplify tmoveto.

LIMIT returns value. This fact is already used in x2col and y2row. --- st.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/st.c b/st.c index e01df66..33fd4de 100644 --- a/st.c +++ b/st.c @@ -1572,11 +1572,9 @@ tmoveto(int x, int y) { miny = 0;

[dev] [st] [PATCH 2/3] Do not use tmoveto in tputtab.

tmoveto resets CURSOR_WRAPNEXT. Simple testcase: for i in $(seq 1 200); do printf '\t.'; usleep 10; printf '\t@'; usleep 10; done In st executing this script causes @ and . to overwrite each other in the last column. --- st.c | 2 +- 1 file changed, 1

[dev] [st] [PATCH 2/3] Remove -e option. Use -- instead.

--- FAQ | 4 ++-- st.1 | 13 + st.c | 16 ++-- 3 files changed, 13 insertions(+), 20 deletions(-) diff --git a/FAQ b/FAQ index 3502c60..275fc4e 100644 --- a/FAQ +++ b/FAQ @@ -26,8 +26,8 @@ st or st-256color. The default value for TERM can be changed in config.h

[dev] [st] [PATCH 1/3] Remove 'titles' variable.

We do not free it until exit anyway. --- st.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/st.c b/st.c index b2bcfe9..867744a 100644 --- a/st.c +++ b/st.c @@ -4021,7 +4021,6 @@ usage(void) { int main(int argc, char *argv[]) { - char *titles; uint

Re: [dev] [st] [PATCH 2/3] Remove -e option. Use -- instead.

Please report if there are known compatibility problems that require -e option to be present. Maybe something related to Debian alternatives mechanism etc. Otherwise this patch removes ugly goto and makes 'st mutt' work just like 'xterm mutt' instead of simply ignoring remaining arguments.

Re: [dev] [st] [PATCH 1/3] Fix typo.

Applied, thanks,

[dev] [st] [PATCH] Remove useless if in tstrsequence.

--- st.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/st.c b/st.c index b2bcfe9..154dd52 100644 --- a/st.c +++ b/st.c @@ -2446,21 +2446,19 @@ tdectest(char c) { void tstrsequence(uchar c) { - if (c 0x80) { - switch (c)

Re: [dev] [st] [PATCH 3/3] Simplify tmoveto.

Applied, thanks.

Re: [dev] [st] [PATCH] Remove useless if in tstrsequence.

Applied, thanks.

Re: [dev] [st] [PATCH] Remove useless if in tstrsequence.

Applied, thanks.

[dev] [st] [PATCH 3/3] Remove old TODO entry.

It probably refers to http://lists.suckless.org/dev/1211/13427.html and does not seem like a bug in st. --- TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/TODO b/TODO index 90e3d56..5f74cd5 100644 --- a/TODO +++ b/TODO @@ -19,7 +19,6 @@ bugs * fix shift up/down (shift selection

Re: [dev] [st] [PATCH 1/2] Do not use switch for fork() call.

After asking in the IRC channel, all the people thought like me. Both are correct, and the fork-switch is a very common idiom, which makes easier to see what is the objective of the code, so I will not apply this patch. Regards,

Re: [dev] [st] [PATCH 1/3] Remove 'titles' variable.

Applied, thanks.

Re: [dev] [st] [PATCH 2/3] Remove -e option. Use -- instead.

I think we should keep the -e option, because xterm has this option and it is used in a lot of places. I like the idea of executing all the remaining parameters, but I think we should admit both forms. Regards,

Re: [dev] [st] [PATCH 4/3] tresize: remove unnecessary if

Applied, thanks.

Re: [dev] [st] [PATCH 3/3] Remove old TODO entry.

Applied, thanks.