[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

mistercrunch commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-378768974 @fabianmenges do you all use extraction functions much? Do you think you can review/test this?

[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

mistercrunch commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-378768974 @fabianmenges do you all use extraction functions much? Do you think you can review this?

[GitHub] mistercrunch closed pull request #4754: [deck_multi] fixing issues with deck_multi

mistercrunch closed pull request #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mistercrunch commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

mistercrunch commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378780210 100px is very small, I do agree that we need to collapse wide columns, but we can't assume an hover

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4741: Set longer CSRF token duration (one week)

mistercrunch commented on issue #4741: Set longer CSRF token duration (one week) URL: https://github.com/apache/incubator-superset/pull/4741#issuecomment-378770453 I think SQL Lab surfaces the error properly and the explore view does give `Unexpected error`. Let me open an issue. Here:

[GitHub] mistercrunch closed issue #4739: The CSRF token has expired

mistercrunch closed issue #4739: The CSRF token has expired URL: https://github.com/apache/incubator-superset/issues/4739 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] mistercrunch closed pull request #4741: Set longer CSRF token duration (one week)

mistercrunch closed pull request #4741: Set longer CSRF token duration (one week) URL: https://github.com/apache/incubator-superset/pull/4741 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mistercrunch opened a new issue #4762: CSRF token expiration leads to "Unexpected Error"

mistercrunch opened a new issue #4762: CSRF token expiration leads to "Unexpected Error" URL: https://github.com/apache/incubator-superset/issues/4762 ### Superset version 0.24.0 ### Expected results Proper error message "CSRF token has expired please refresh the page".

[GitHub] mistercrunch commented on issue #4759: Ability to add multiple sources (namely time series) to a chart

mistercrunch commented on issue #4759: Ability to add multiple sources (namely time series) to a chart URL: https://github.com/apache/incubator-superset/issues/4759#issuecomment-378769581 Line chart only ok? That would make this feature a lot easier to build, and insure that most line

[GitHub] mistercrunch commented on issue #4759: Ability to add multiple sources (namely time series) to a chart

mistercrunch commented on issue #4759: Ability to add multiple sources (namely time series) to a chart URL: https://github.com/apache/incubator-superset/issues/4759#issuecomment-378769581 Line chart only ok? That would make this feature a lot easier to build, and insure that most line

[GitHub] williaster opened a new pull request #4763: [dashboard builder] static layout + toasts

williaster opened a new pull request #4763: [dashboard builder] static layout + toasts URL: https://github.com/apache/incubator-superset/pull/4763 This PR adds several improvements to the dashboard builder **redux state** - changed layout key from `dashboard` =>

[GitHub] john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746#discussion_r179325932 ## File path: superset/connectors/sqla/views.py ## @@ -213,8 +216,10 @@

[GitHub] john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746#discussion_r179326188 ## File path: superset/migrations/versions/130915240929_is_sqllab_viz_flow.py

[GitHub] vylc opened a new issue #4764: [Dashboard Feature] Copy charts based on a dimension value

vylc opened a new issue #4764: [Dashboard Feature] Copy charts based on a dimension value URL: https://github.com/apache/incubator-superset/issues/4764 A flavor of templating, it would be a killer feature to: (1) Programmatically create charts. The use case here is if I'm monitoring a

[GitHub] mistercrunch commented on issue #844: Update to d3 v4 ?

mistercrunch commented on issue #844: Update to d3 v4 ? URL: https://github.com/apache/incubator-superset/issues/844#issuecomment-378768453 There have been conversations and work in the direction or using data-ui which is build on top of vx, for composable, stylable, React-first

[GitHub] mistercrunch commented on issue #844: Update to d3 v4 ?

mistercrunch commented on issue #844: Update to d3 v4 ? URL: https://github.com/apache/incubator-superset/issues/844#issuecomment-378768453 There have been conversations and work in the direction or using data-ui which is build on top of vx, for composable, stylable, React-first

[GitHub] mistercrunch commented on issue #4761: [druid] Excluding refreshing verbose name

mistercrunch commented on issue #4761: [druid] Excluding refreshing verbose name URL: https://github.com/apache/incubator-superset/pull/4761#issuecomment-378768694 Good catch LGTM This is an automated message from the Apache

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin

williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378795429 great addition. my only suggestion at this point is setting `flat` as the default because `staggered` isn't as polished / adds

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378777839 @graceguo-supercat @michellethomas would love for someone at Airbnb to sign off on this as it will affects a million line

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4763: [dashboard builder] static layout + toasts

williaster commented on issue #4763: [dashboard builder] static layout + toasts URL: https://github.com/apache/incubator-superset/pull/4763#issuecomment-378786701 gonna merge this (build doesn't matter for us now) This is an

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378790730 @mistercrunch sorry I was wondering what your thoughts were on this? Additionally having a `requirements.txt` with

[GitHub] john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746#discussion_r179326091 ## File path: superset/migrations/versions/130915240929_is_sqllab_viz_flow.py

[GitHub] john-bodley commented on issue #4551: [sql lab] option to disable cross schema search

john-bodley commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-378767310 @mistercrunch this migration didn't cause a lock on our end. I wonder whether there's also merit in caching when

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr=h1) Report > Merging

[GitHub] john-bodley closed pull request #4761: [druid] Excluding refreshing verbose name

john-bodley closed pull request #4761: [druid] Excluding refreshing verbose name URL: https://github.com/apache/incubator-superset/pull/4761 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards

codecov-io commented on issue #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards

codecov-io commented on issue #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on a dimension value

mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on a dimension value URL: https://github.com/apache/incubator-superset/issues/4764#issuecomment-378814432 Another idea would be to "export your dashboard as code", then check it into source control. Engineers

[GitHub] pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-378546276 doesn't work for me, dashboard.b21ed8e6fe6a55e3a492.entry.js:326 Uncaught TypeError: Cannot read property

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-378553076 On the `Edit Dashboard` page This is an automated

[GitHub] pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-378552760 sorry to sound dumb, but where do i set this value for 'Position JSON'? for now, i upgraded superset and now

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-378547578 Oh, I'm sorry, suggested fix for the another issue of uploading csv. For this one, I've added '[]' as a

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378815265 I'd also prefer `flat` to staggered as a default, but with the current default time formatter the labels overlap in some

[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing

mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378826189 So if I want to add a python dep where do I do it? In setup.py AND in requirements.txt? I was thinking

[GitHub] mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746#discussion_r179346093 ## File path: superset/connectors/sqla/views.py ## @@ -213,8 +216,10

[GitHub] mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746#discussion_r179346252 ## File path: superset/migrations/versions/130915240929_is_sqllab_viz_flow.py

[GitHub] williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin

williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378825466 is there a rush to merge this? would it be worthwhile to add the shorter date formatting in this PR and set the default to

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378828200 But yeah, while this doesn't fix everything, it addresses many visualizations defects and bugs with the xAxis and makes

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179325525 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -153,6 +157,27 @@

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179326670 ## File path: superset/assets/javascripts/components/URLShortLinkButton.jsx ## @@ -25,20 +27,20 @@

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179344205 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -153,6 +157,27 @@

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179325754 ## File path: superset/assets/javascripts/dashboard/dashboardUtils.js ## @@ -0,0 +1,17 @@ +/* eslint

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179326998 ## File path: superset/assets/javascripts/components/URLShortLinkButton.jsx ## @@ -25,20 +27,20 @@

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179328605 ## File path: superset/assets/javascripts/dashboard/dashboardUtils.js ## @@ -0,0 +1,17 @@ +/* eslint

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179328605 ## File path: superset/assets/javascripts/dashboard/dashboardUtils.js ## @@ -0,0 +1,17 @@ +/* eslint

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179344602 ## File path: superset/assets/javascripts/components/URLShortLinkButton.jsx ## @@ -25,20 +27,20 @@

[GitHub] mistercrunch opened a new pull request #4765: [line] fix verbose names in time shift

mistercrunch opened a new pull request #4765: [line] fix verbose names in time shift URL: https://github.com/apache/incubator-superset/pull/4765 https://user-images.githubusercontent.com/487433/38348683-1a0bff60-3858-11e8-85dc-76ee81e391e0.png;> closes

[GitHub] lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378822990 @mistercrunch, You are right. I think I should add resizable property to it and max width should be

[GitHub] codecov-io commented on issue #4765: [line] fix verbose names in time shift

codecov-io commented on issue #4765: [line] fix verbose names in time shift URL: https://github.com/apache/incubator-superset/pull/4765#issuecomment-378827057 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4765: [line] fix verbose names in time shift

codecov-io commented on issue #4765: [line] fix verbose names in time shift URL: https://github.com/apache/incubator-superset/pull/4765#issuecomment-378827057 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on a dimension value

mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on a dimension value URL: https://github.com/apache/incubator-superset/issues/4764#issuecomment-378814124 I had conversations about arrays or matrix of charts before. Idea being to write a for loop around a

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378826578 Actually the default setting is `auto`, which turns into staggered for time series. We can change what `auto` means in the

[GitHub] jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB

jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB URL: https://github.com/apache/incubator-superset/issues/4501#issuecomment-378609733 Thanks @sebastianwindeck! This is an automated message

[GitHub] feng-tao closed pull request #4745: [bugfix] Fix the arguement order for security function

feng-tao closed pull request #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch closed issue #3829: Cannot create table with same name from a different datasource

mistercrunch closed issue #3829: Cannot create table with same name from a different datasource URL: https://github.com/apache/incubator-superset/issues/3829 This is an automated message from the Apache Git Service. To

[GitHub] mistercrunch closed issue #4757: delete sum and avg field but not deleted.

mistercrunch closed issue #4757: delete sum and avg field but not deleted. URL: https://github.com/apache/incubator-superset/issues/4757 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mistercrunch commented on issue #4757: delete sum and avg field but not deleted.

mistercrunch commented on issue #4757: delete sum and avg field but not deleted. URL: https://github.com/apache/incubator-superset/issues/4757#issuecomment-378664577 That's the intended behavior, for now you have to manually delete the metrics as well. If we'd just delete metrics there's

[GitHub] GabeLoins commented on issue #4729: [explore] don't prompt to 'Run Query' on viewport change

GabeLoins commented on issue #4729: [explore] don't prompt to 'Run Query' on viewport change URL: https://github.com/apache/incubator-superset/pull/4729#issuecomment-378688131 Nice! Glad you found a way out. Closing my old PR.

[GitHub] codecov-io commented on issue #4740: Add extraction function support for Druid queries

codecov-io commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-378676086 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=h1) Report > Merging

[GitHub] GabeLoins closed pull request #4610: [Explore] removing refresh chart overlay on deck_gl charts

GabeLoins closed pull request #4610: [Explore] removing refresh chart overlay on deck_gl charts URL: https://github.com/apache/incubator-superset/pull/4610 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts URL: https://github.com/apache/incubator-superset/pull/4610#issuecomment-378688089 closing in favor of: https://github.com/apache/incubator-superset/pull/4729

[GitHub] mistercrunch commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

mistercrunch commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-378663082 If you've seen this > `0.24.0` let me know and I'll reopen

[GitHub] codecov-io commented on issue #4755: Pass granularity from backend to frontend as ISO duration

codecov-io commented on issue #4755: Pass granularity from backend to frontend as ISO duration URL: https://github.com/apache/incubator-superset/pull/4755#issuecomment-378680060 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr=h1) Report > Merging

[GitHub] lprashant-94 opened a new pull request #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

lprashant-94 opened a new pull request #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758 Fix: #2900 Setting 100 column length limit in sql_lab resultset.

[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging

[GitHub] betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#discussion_r179226751 ## File path: superset/assets/visualizations/nvd3_vis.js ## @@ -160,31 +145,57 @@

[GitHub] betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#discussion_r179228737 ## File path: superset/assets/visualizations/nvd3_vis.js ## @@ -160,31 +145,57 @@

[GitHub] vylc opened a new issue #4759: Ability to add multiple sources (namely time series) to a chart

vylc opened a new issue #4759: Ability to add multiple sources (namely time series) to a chart URL: https://github.com/apache/incubator-superset/issues/4759 Currently, the best way to add multiple datasets to the same chart is to use annotations. However, annotation layers don't respond

[GitHub] betodealmeida commented on a change in pull request #4754: [deck_multi] fixing issues with deck_multi

betodealmeida commented on a change in pull request #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754#discussion_r179254609 ## File path: superset/assets/visualizations/deckgl/multi.jsx ## @@ -49,9 +47,8 @@

[GitHub] betodealmeida commented on a change in pull request #4754: [deck_multi] fixing issues with deck_multi

betodealmeida commented on a change in pull request #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754#discussion_r179254409 ## File path: superset/assets/visualizations/deckgl/multi.jsx ## @@ -8,17 +8,15 @@

[GitHub] ttannis opened a new pull request #4760: Dptools 414 dashboard url

ttannis opened a new pull request #4760: Dptools 414 dashboard url URL: https://github.com/apache/incubator-superset/pull/4760 This PR addresses issue #4309 filed by @vylc. A URLShortLinkButton has been added to the dashboard, and the component has been refactored to be able to be shared

[GitHub] codecov-io commented on issue #4760: Dptools 414 dashboard url

codecov-io commented on issue #4760: Dptools 414 dashboard url URL: https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration

mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration URL: https://github.com/apache/incubator-superset/pull/4755#discussion_r179266163 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ##

[GitHub] hughhhh commented on a change in pull request #4760: Dptools 414 dashboard url

hug commented on a change in pull request #4760: Dptools 414 dashboard url URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179269372 ## File path: superset/assets/javascripts/components/URLShortLinkButton.jsx ## @@ -25,20 +27,20 @@ export

[GitHub] john-bodley opened a new pull request #4761: [druid] Excluding refreshing verbose name

john-bodley opened a new pull request #4761: [druid] Excluding refreshing verbose name URL: https://github.com/apache/incubator-superset/pull/4761 The verbose name is often user defined however when refreshing Druid metrics this would be overwritten. This PR removes setting of the

[GitHub] hughhhh commented on a change in pull request #4760: Dptools 414 dashboard url

hug commented on a change in pull request #4760: Dptools 414 dashboard url URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179269531 ## File path: superset/assets/javascripts/dashboard/dashboardUtils.js ## @@ -0,0 +1,17 @@ +/* eslint camelcase:

[GitHub] codecov-io commented on issue #4761: [druid] Excluding refreshing verbose name

codecov-io commented on issue #4761: [druid] Excluding refreshing verbose name URL: https://github.com/apache/incubator-superset/pull/4761#issuecomment-378736710 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr=h1) Report > Merging

[GitHub] mistercrunch closed pull request #4742: [sql lab] preserve schema through visualize flow

mistercrunch closed pull request #4742: [sql lab] preserve schema through visualize flow URL: https://github.com/apache/incubator-superset/pull/4742 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378739069 I agree on the [un] manageability of this file. The challenge is that the different visualizations both from a controls and

[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards

ttannis commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179280068 ## File path: superset/assets/javascripts/dashboard/dashboardUtils.js ## @@ -0,0 +1,17 @@ +/* eslint

[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards

ttannis commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179279931 ## File path: superset/assets/javascripts/components/URLShortLinkButton.jsx ## @@ -25,20 +27,20 @@ export

[GitHub] codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi

codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754#issuecomment-378447046 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr=h1) Report > Merging

[GitHub] mattmoehr commented on issue #844: Update to d3 v4 ?

mattmoehr commented on issue #844: Update to d3 v4 ? URL: https://github.com/apache/incubator-superset/issues/844#issuecomment-378746562 I was just doing some research about version breaks in regards to D3, and basically what I found is that Superset is using NVD3 which is a project that

[GitHub] mattmoehr commented on issue #844: Update to d3 v4 ?

mattmoehr commented on issue #844: Update to d3 v4 ? URL: https://github.com/apache/incubator-superset/issues/844#issuecomment-378746562 I was just doing some research about version breaks in regards to D3. What I found is that Superset is using NVD3, which is a project that wraps and

[GitHub] asyd commented on issue #3829: Cannot create table with same name from a different datasource

asyd commented on issue #3829: Cannot create table with same name from a different datasource URL: https://github.com/apache/incubator-superset/issues/3829#issuecomment-378516174 Any news by chance ? This is an automated

[GitHub] pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-378540859 same issue, please suggest solution. @wangqi19940304 @xrmx

[GitHub] CasperLiu commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

CasperLiu commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-378520815 mistercrunch， Thanks for your explanation! Regards, Jiaxu 刘佳旭

[GitHub] asyd commented on issue #3829: Cannot create table with same name from a different datasource

asyd commented on issue #3829: Cannot create table with same name from a different datasource URL: https://github.com/apache/incubator-superset/issues/3829#issuecomment-378534554 Oh, just tested 0.24.0 and seem it's working, so maybe someone should close this issue?

[GitHub] mistercrunch opened a new pull request #4756: Improve xAxis ticks, thinner bottom margin

mistercrunch opened a new pull request #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756 Introducing a new control `X Tick Layout` with options `['auto', 'flat', '45°', 'staggered']` for nvd3 visualizations. nvd3

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr=h1) Report > Merging

[GitHub] songying2013 opened a new issue #4757: delete sum and avg field but not deleted.

songying2013 opened a new issue #4757: delete sum and avg field but not deleted. URL: https://github.com/apache/incubator-superset/issues/4757 When I am in Sources > Tables > Edit Record > List Columns , I delete some field, but after I save the edit, it still there.

[GitHub] mistercrunch closed pull request #4005: [BUGFIX]: JavaScripts max int is 2^53 - 1, longs are bigger

mistercrunch closed pull request #4005: [BUGFIX]: JavaScripts max int is 2^53 - 1, longs are bigger URL: https://github.com/apache/incubator-superset/pull/4005 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

  1   2   >