mistercrunch commented on a change in pull request #4760: URL shortner for
dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r179344205
##########
File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx
##########
@@ -153,6 +157,27 @@ class Dashboard extends React.PureComponent {
return this.props.filters[sliceId];
}
+ addHistory({ isReplace = false, title }) {
Review comment:
I'm confused about this method:
* why using destructuring in the function parameters?
* why do we need to alter the browser history?
* `title` is never passed to it, won't that lead to clearing the title?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
