mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179328605
 
 

 ##########
 File path: superset/assets/javascripts/dashboard/dashboardUtils.js
 ##########
 @@ -0,0 +1,17 @@
+/* eslint camelcase: 0 */
+import URI from 'urijs';
+
+export function getURIDirectory(dashboard) {
 
 Review comment:
   that logic already exists in the backend, you could add a line `'url': 
self.url,` here:
   
https://github.com/apache/incubator-superset/blob/master/superset/models/core.py#L378

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to