[GitHub] timifasubaa commented on issue #3339: [explore] Fix and test slice id logging issue

2017-08-18 Thread git
timifasubaa commented on issue #3339: [explore] Fix and test slice id logging issue URL: https://github.com/apache/incubator-superset/pull/3339#issuecomment-323492169 I took inspiration from test_user_profile and test_fetch_datasource_metadata and what I have as far as I can see is

[GitHub] mistercrunch commented on issue #3339: [explore] Fix and test slice id logging issue

2017-08-18 Thread git
mistercrunch commented on issue #3339: [explore] Fix and test slice id logging issue URL: https://github.com/apache/incubator-superset/pull/3339#issuecomment-323489331 Also looking at Travis build logs it looks like json.loads doesn't like `None`

[GitHub] mistercrunch commented on issue #3339: [explore] Fix and test slice id logging issue

2017-08-18 Thread git
mistercrunch commented on issue #3339: [explore] Fix and test slice id logging issue URL: https://github.com/apache/incubator-superset/pull/3339#issuecomment-323488989 see how the other tests include a `self.login` call.

[GitHub] mistercrunch closed pull request #3338: [hotfix] self-immune filter_box fix

2017-08-18 Thread git
mistercrunch closed pull request #3338: [hotfix] self-immune filter_box fix URL: https://github.com/apache/incubator-superset/pull/3338 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] coveralls commented on issue #3338: [hotfix] self-immune filter_box fix

2017-08-18 Thread git
coveralls commented on issue #3338: [hotfix] self-immune filter_box fix URL: https://github.com/apache/incubator-superset/pull/3338#issuecomment-323487531 [![Coverage Status](https://coveralls.io/builds/12903118/badge)](https://coveralls.io/builds/12903118) Coverage remained

[GitHub] coveralls commented on issue #3338: [hotfix] self-immune filter_box fix

2017-08-18 Thread git
coveralls commented on issue #3338: [hotfix] self-immune filter_box fix URL: https://github.com/apache/incubator-superset/pull/3338#issuecomment-323487535 [![Coverage Status](https://coveralls.io/builds/12903118/badge)](https://coveralls.io/builds/12903118) Coverage remained

[GitHub] mistercrunch commented on issue #3242: [sql lab] Make sql editor resizable

2017-08-18 Thread git
mistercrunch commented on issue #3242: [sql lab] Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323486649 ![img](https://media.giphy.com/media/d86kftzaeizO8/giphy.gif)

[GitHub] mistercrunch closed pull request #3242: [sql lab] Make sql editor resizable

2017-08-18 Thread git
mistercrunch closed pull request #3242: [sql lab] Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] timifasubaa opened a new pull request #3339: [explore] Fix and test slice id logging issue

2017-08-18 Thread git
timifasubaa opened a new pull request #3339: [explore] Fix and test slice id logging issue URL: https://github.com/apache/incubator-superset/pull/3339 This PR fixes and tests the slice_id logging issue (https://github.com/apache/incubator-superset/issues/3311) @mistercrunch

[GitHub] mistercrunch commented on issue #3242: [sql lab] Make sql editor resizable

2017-08-18 Thread git
mistercrunch commented on issue #3242: [sql lab] Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323485796 Not need to squash, we use the Github "Squash and merge" button. Let me try it out!

[GitHub] mistercrunch opened a new pull request #3338: [hotfix] self-immune filter_box fix

2017-08-18 Thread git
mistercrunch opened a new pull request #3338: [hotfix] self-immune filter_box fix URL: https://github.com/apache/incubator-superset/pull/3338 This is an automated message from the Apache Git Service. To respond to the

[GitHub] laranzu closed issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder

2017-08-18 Thread git
laranzu closed issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder URL: https://github.com/apache/incubator-superset/issues/3312 This is an automated message from the Apache

[GitHub] mistercrunch closed pull request #3308: [sql lab] improve error messages

2017-08-18 Thread git
mistercrunch closed pull request #3308: [sql lab] improve error messages URL: https://github.com/apache/incubator-superset/pull/3308 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mistercrunch closed issue #3030: flawed logic in the new visualization timeout

2017-08-18 Thread git
mistercrunch closed issue #3030: flawed logic in the new visualization timeout URL: https://github.com/apache/incubator-superset/issues/3030 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mistercrunch closed pull request #3335: [dashboard] re-enabling cascading filters

2017-08-18 Thread git
mistercrunch closed pull request #3335: [dashboard] re-enabling cascading filters URL: https://github.com/apache/incubator-superset/pull/3335 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mistercrunch closed pull request #3329: Syncing the timeout param from backend

2017-08-18 Thread git
mistercrunch closed pull request #3329: Syncing the timeout param from backend URL: https://github.com/apache/incubator-superset/pull/3329 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] izetex commented on issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
izetex commented on issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337#issuecomment-323466877 The backend is MySQL. The description of spatial extension is https://dev.mysql.com/doc/refman/5.7/en/spatial-extensions.html

[GitHub] RoganW commented on a change in pull request #3335: [dashboard] re-enabling cascading filters

2017-08-18 Thread git
RoganW commented on a change in pull request #3335: [dashboard] re-enabling cascading filters URL: https://github.com/apache/incubator-superset/pull/3335#discussion_r133891648 ## File path: superset/assets/javascripts/dashboard/Dashboard.jsx ## @@ -190,6 +186,10 @@

[GitHub] coveralls commented on issue #3242: [sql lab] Make sql editor resizable

2017-08-18 Thread git
coveralls commented on issue #3242: [sql lab] Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323453247 [![Coverage Status](https://coveralls.io/builds/12900518/badge)](https://coveralls.io/builds/12900518) Coverage remained

[GitHub] coveralls commented on issue #3242: [sql lab] Make sql editor resizable

2017-08-18 Thread git
coveralls commented on issue #3242: [sql lab] Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323453248 [![Coverage Status](https://coveralls.io/builds/12900518/badge)](https://coveralls.io/builds/12900518) Coverage remained

[GitHub] dmigo commented on issue #3242: WIP: Make sql editor resizable

2017-08-18 Thread git
dmigo commented on issue #3242: WIP: Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323449238 @mistercrunch it is ready in terms of code. Should I squash all the changes into one commit?

[GitHub] coveralls commented on issue #3335: [dashboard] re-enabling cascading filters

2017-08-18 Thread git
coveralls commented on issue #3335: [dashboard] re-enabling cascading filters URL: https://github.com/apache/incubator-superset/pull/3335#issuecomment-323445706 [![Coverage Status](https://coveralls.io/builds/1282/badge)](https://coveralls.io/builds/1282) Coverage

[GitHub] coveralls commented on issue #3335: [dashboard] re-enabling cascading filters

2017-08-18 Thread git
coveralls commented on issue #3335: [dashboard] re-enabling cascading filters URL: https://github.com/apache/incubator-superset/pull/3335#issuecomment-323445704 [![Coverage Status](https://coveralls.io/builds/1282/badge)](https://coveralls.io/builds/1282) Coverage

[GitHub] coveralls commented on issue #3329: Syncing the timeout param from backend

2017-08-18 Thread git
coveralls commented on issue #3329: Syncing the timeout param from backend URL: https://github.com/apache/incubator-superset/pull/3329#issuecomment-323438258 [![Coverage Status](https://coveralls.io/builds/12899549/badge)](https://coveralls.io/builds/12899549) Coverage remained

[GitHub] mistercrunch commented on issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
mistercrunch commented on issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337#issuecomment-323438290 What is the database backend? Postgres? Druid? One path towards a solution is to improve the json serializer

[GitHub] coveralls commented on issue #3329: Syncing the timeout param from backend

2017-08-18 Thread git
coveralls commented on issue #3329: Syncing the timeout param from backend URL: https://github.com/apache/incubator-superset/pull/3329#issuecomment-323438258 [![Coverage Status](https://coveralls.io/builds/12899549/badge)](https://coveralls.io/builds/12899549) Coverage

[GitHub] coveralls commented on issue #3242: WIP: Make sql editor resizable

2017-08-18 Thread git
coveralls commented on issue #3242: WIP: Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323419067 [![Coverage Status](https://coveralls.io/builds/12898277/badge)](https://coveralls.io/builds/12898277) Coverage remained the

[GitHub] coveralls commented on issue #3242: WIP: Make sql editor resizable

2017-08-18 Thread git
coveralls commented on issue #3242: WIP: Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-323419065 [![Coverage Status](https://coveralls.io/builds/12898277/badge)](https://coveralls.io/builds/12898277) Coverage remained the

[GitHub] xrmx commented on issue #3013: New chart type : Chord Diagrams

2017-08-18 Thread git
xrmx commented on issue #3013: New chart type : Chord Diagrams URL: https://github.com/apache/incubator-superset/pull/3013#issuecomment-323351482 @ouyangal the actual error would be helpful but please try to reproduce with a modern version of node (6+) and if you cannot upgrade to a node

[GitHub] ouyangal commented on issue #3013: New chart type : Chord Diagrams

2017-08-18 Thread git
ouyangal commented on issue #3013: New chart type : Chord Diagrams URL: https://github.com/apache/incubator-superset/pull/3013#issuecomment-323350004 I get an error when trying to make a custom build so I can use the chord visualization: `Error Message: Failed at superset@0.18.5 build

[GitHub] izetex commented on issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
izetex commented on issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337#issuecomment-323331456 I suspect that the following causes the error: ``` 'location': '\xe6\x10\x00\x00\x01\x01\x00\x00\x00\x00\x00

[GitHub] elkan1788 commented on issue #2771: UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-3: ordinal not in range(128)

2017-08-18 Thread git
elkan1788 commented on issue #2771: UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-3: ordinal not in range(128) URL: https://github.com/apache/incubator-superset/issues/2771#issuecomment-323299387 @RichardKyire I don't known the deep reason. May you can check the

[GitHub] izetex commented on issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
izetex commented on issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337#issuecomment-323295834 ``` 2017-08-18 11:38:52,062:INFO:root:Fetching data: {u'changedOn': datetime.datetime(2017, 8, 18, 8, 38, 52),

[GitHub] xrmx commented on issue #3066: Add support for column specific fillna to viz

2017-08-18 Thread git
xrmx commented on issue #3066: Add support for column specific fillna to viz URL: https://github.com/apache/incubator-superset/pull/3066#issuecomment-323279483 Maybe i wasn't clear but right now my visualization are not working with superset because NULL is not coerced to '0' (string)

[GitHub] xrmx commented on issue #3336: Unable to directly create table from query ( feature request)

2017-08-18 Thread git
xrmx commented on issue #3336: Unable to directly create table from query ( feature request) URL: https://github.com/apache/incubator-superset/issues/3336#issuecomment-323290712 PR welcome of course! This is an automated

[GitHub] xrmx commented on issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
xrmx commented on issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337#issuecomment-323290429 Also providing a (subset) of the value of data from views/core.py:2071 would be helpful.

[GitHub] xrmx commented on issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
xrmx commented on issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337#issuecomment-323290027 Please quote the stacktrace and add the superset version per

[GitHub] izetex opened a new issue #3337: Error in SQL Query results on Spatial columns

2017-08-18 Thread git
izetex opened a new issue #3337: Error in SQL Query results on Spatial columns URL: https://github.com/apache/incubator-superset/issues/3337 ### Superset version ### Expected results Results are rendered with spatial data. ### Actual results Error: 'utf8'

[GitHub] coveralls commented on issue #3066: Add support for column specific fillna to viz

2017-08-18 Thread git
coveralls commented on issue #3066: Add support for column specific fillna to viz URL: https://github.com/apache/incubator-superset/pull/3066#issuecomment-323287549 [![Coverage Status](https://coveralls.io/builds/12890299/badge)](https://coveralls.io/builds/12890299) Coverage

[GitHub] izetex opened a new issue #3336: Unable to directly create table from query ( feature request)

2017-08-18 Thread git
izetex opened a new issue #3336: Unable to directly create table from query ( feature request) URL: https://github.com/apache/incubator-superset/issues/3336 This is a feature request I really like the idea of SQL editor embedded in Superset and like the idea of table.slices However

[GitHub] xrmx commented on issue #3066: Add support for column specific fillna to viz

2017-08-18 Thread git
xrmx commented on issue #3066: Add support for column specific fillna to viz URL: https://github.com/apache/incubator-superset/pull/3066#issuecomment-323279483 Maybe i wasn't clear but right now my visualization are not working with superset because NULL is not coerced to '0' (string)

[GitHub] xrmx commented on issue #3066: Add support for column specific fillna to viz

2017-08-18 Thread git
xrmx commented on issue #3066: Add support for column specific fillna to viz URL: https://github.com/apache/incubator-superset/pull/3066#issuecomment-323279483 Maybe i wasn't clear but right now my visualization are not working with superset because NULL is not coerced to '0' (string)

[GitHub] xrmx commented on issue #3066: Add support for column specific fillna to viz

2017-08-18 Thread git
xrmx commented on issue #3066: Add support for column specific fillna to viz URL: https://github.com/apache/incubator-superset/pull/3066#issuecomment-323279483 Maybe i wasn't clear but right now my visualization are not working with superset because NULL is not coerced to '0' (string)

[GitHub] xrmx commented on issue #3066: Add support for column specific fillna to viz

2017-08-18 Thread git
xrmx commented on issue #3066: Add support for column specific fillna to viz URL: https://github.com/apache/incubator-superset/pull/3066#issuecomment-323279483 Maybe i wasn't clear but right now my visualization are not working with superset because NULL is not coerced to '0' (string)

[GitHub] NaukhaizAhmad commented on issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed.

2017-08-18 Thread git
NaukhaizAhmad commented on issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed. URL: https://github.com/apache/incubator-superset/issues/3334#issuecomment-323277916 No No! That was more of a look n feel issue ( #3321). It's related to

[GitHub] NaukhaizAhmad commented on issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed.

2017-08-18 Thread git
NaukhaizAhmad commented on issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed. URL: https://github.com/apache/incubator-superset/issues/3334#issuecomment-323277916 No No! It's related to functionality of the select all feature. Select all

[GitHub] xrmx commented on issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed.

2017-08-18 Thread git
xrmx commented on issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed. URL: https://github.com/apache/incubator-superset/issues/3334#issuecomment-323277381 Isn't this the very same issue you reported earlier in #3321?

[GitHub] mistercrunch opened a new pull request #3335: [dashboard] re-enabling cascading filters

2017-08-18 Thread git
mistercrunch opened a new pull request #3335: [dashboard] re-enabling cascading filters URL: https://github.com/apache/incubator-superset/pull/3335 https://github.com/apache/incubator-superset/pull/3183 disabled the ability of a filterbox to get filtered by another filterbox

[GitHub] mistercrunch closed pull request #3333: [hotfix] hotfixing the hotfix

2017-08-18 Thread git
mistercrunch closed pull request #: [hotfix] hotfixing the hotfix URL: https://github.com/apache/incubator-superset/pull/ This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] coveralls commented on issue #3333: [hotfix] hotfixing the hotfix

2017-08-18 Thread git
coveralls commented on issue #: [hotfix] hotfixing the hotfix URL: https://github.com/apache/incubator-superset/pull/#issuecomment-323268942 [![Coverage Status](https://coveralls.io/builds/12889542/badge)](https://coveralls.io/builds/12889542) Coverage remained the same

[GitHub] coveralls commented on issue #3333: [hotfix] hotfixing the hotfix

2017-08-18 Thread git
coveralls commented on issue #: [hotfix] hotfixing the hotfix URL: https://github.com/apache/incubator-superset/pull/#issuecomment-323268941 [![Coverage Status](https://coveralls.io/builds/12889542/badge)](https://coveralls.io/builds/12889542) Coverage remained the same

[GitHub] mistercrunch commented on issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder

2017-08-18 Thread git
mistercrunch commented on issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder URL: https://github.com/apache/incubator-superset/issues/3312#issuecomment-323268769 Authentication is totally in scope for FAB:

[GitHub] NaukhaizAhmad opened a new issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed.

2017-08-18 Thread git
NaukhaizAhmad opened a new issue #3334: Select all checkbox won't work correctly, if browser's 'go back' button is pressed. URL: https://github.com/apache/incubator-superset/issues/3334 ### Superset version 0.19.0 ### Browser Chrome 60 & 61 ### Expected results