[
https://issues.apache.org/jira/browse/SYNCOPE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misagh Moayyed resolved SYNCOPE-1699.
-
Resolution: Fixed
> Extract key from path for UserUpdate ops if undefined in request
[
https://issues.apache.org/jira/browse/SYNCOPE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616667#comment-17616667
]
ASF subversion and git services commented on SYNCOPE-1699:
--
Commit
mmoayyed merged PR #381:
URL: https://github.com/apache/syncope/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on PR #381:
URL: https://github.com/apache/syncope/pull/381#issuecomment-1276123377
> I think my original implementation of this was correct. Please take
another look.
I agree, all began with my tendence to try to optimize around decoding path
parameters if not
mmoayyed commented on PR #381:
URL: https://github.com/apache/syncope/pull/381#issuecomment-1276119538
I think my original implementation of this was correct. Please take another
look. I included your test as well as one extra one to show how this would
work. (Thanks for the test By the
mmoayyed commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993389942
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on PR #381:
URL: https://github.com/apache/syncope/pull/381#issuecomment-1276033757
I think you can also add a test case to `UserIssuesITCase` like the
following, which would fail with NPE in the current `master`
```java
@Test
public void
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993347291
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993347291
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993344004
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993342196
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993342196
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993326009
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993326009
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993324192
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed merged PR #380:
URL: https://github.com/apache/syncope/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993307335
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993304181
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed opened a new pull request, #381:
URL: https://github.com/apache/syncope/pull/381
Please see https://issues.apache.org/jira/browse/SYNCOPE-1699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SYNCOPE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misagh Moayyed updated SYNCOPE-1699:
Summary: Extract key from path for UserUpdate ops if undefined in request
body (was:
Misagh Moayyed created SYNCOPE-1699:
---
Summary: Extract key from path for UserUpdate Ops if undefined in
request body
Key: SYNCOPE-1699
URL: https://issues.apache.org/jira/browse/SYNCOPE-1699
21 matches
Mail list logo
