[GitHub] [syncope] ilgrosso commented on pull request #333: [SYNCOPE-1666] linked account must have AES as encryption algorithm

2022-03-31 Thread GitBox
ilgrosso commented on pull request #333: URL: https://github.com/apache/syncope/pull/333#issuecomment-1084427879 @andrea-patricelli Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project syncope-core-provisioning-java:

[GitHub] [syncope] ilgrosso merged pull request #332: [SYNCOPE-1670] Enable for graceful shutdown

2022-03-30 Thread GitBox
ilgrosso merged pull request #332: URL: https://github.com/apache/syncope/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #331: [SYNCOPE-1670] Enable for graceful shutdown

2022-03-29 Thread GitBox
ilgrosso merged pull request #331: URL: https://github.com/apache/syncope/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso closed pull request #330: Better GH actions step definition

2022-03-22 Thread GitBox
ilgrosso closed pull request #330: URL: https://github.com/apache/syncope/pull/330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli merged pull request #329: Fix for classpath scan

2022-03-22 Thread GitBox
andrea-patricelli merged pull request #329: URL: https://github.com/apache/syncope/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a change in pull request #329: Fix for classpath scan

2022-03-21 Thread GitBox
ilgrosso commented on a change in pull request #329: URL: https://github.com/apache/syncope/pull/329#discussion_r831268671 ## File path: client/idrepo/console/src/main/java/org/apache/syncope/client/console/init/ClassPathScanImplementationLookup.java ## @@ -263,9 +263,10 @@

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #329: Fix for classpath scan

2022-03-21 Thread GitBox
andrea-patricelli commented on a change in pull request #329: URL: https://github.com/apache/syncope/pull/329#discussion_r831263975 ## File path: client/idrepo/console/src/main/java/org/apache/syncope/client/console/init/ClassPathScanImplementationLookup.java ## @@ -263,9

[GitHub] [syncope] ilgrosso commented on a change in pull request #329: Fix for classpath scan

2022-03-21 Thread GitBox
ilgrosso commented on a change in pull request #329: URL: https://github.com/apache/syncope/pull/329#discussion_r831257206 ## File path: client/idrepo/console/src/main/java/org/apache/syncope/client/console/init/ClassPathScanImplementationLookup.java ## @@ -263,9 +263,10 @@

[GitHub] [syncope] ilgrosso merged pull request #328: [SYNCOPE-1669] Ensuring to create pull results for remediations

2022-03-21 Thread GitBox
ilgrosso merged pull request #328: URL: https://github.com/apache/syncope/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #327: [SYNCOPE-1656] Cleanup and refactor

2022-03-18 Thread GitBox
ilgrosso merged pull request #327: URL: https://github.com/apache/syncope/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #327: [SYNCOPE-1656] Cleanup and refactor

2022-03-17 Thread GitBox
ilgrosso merged pull request #327: URL: https://github.com/apache/syncope/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #326: [SYNCOPE-1667] Adding PropagationPolicy

2022-03-15 Thread GitBox
ilgrosso merged pull request #326: URL: https://github.com/apache/syncope/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #325: [SYNCOPE-1667] Adding PropagationPolicy

2022-03-15 Thread GitBox
ilgrosso merged pull request #325: URL: https://github.com/apache/syncope/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #324: [SYNCOPE-1332] Moving to Java 8 DateTime APIs

2022-03-10 Thread GitBox
ilgrosso merged pull request #324: URL: https://github.com/apache/syncope/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #323: Some AnySearchDAO cleanup

2022-03-08 Thread GitBox
ilgrosso merged pull request #323: URL: https://github.com/apache/syncope/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-03-07 Thread GitBox
ilgrosso merged pull request #315: URL: https://github.com/apache/syncope/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli merged pull request #321: [SYNCOPE-1666] added security answer hashing (#319)

2022-03-04 Thread GitBox
andrea-patricelli merged pull request #321: URL: https://github.com/apache/syncope/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #322: [SYNCOPE-1653] Add missing conf items

2022-03-04 Thread GitBox
ilgrosso merged pull request #322: URL: https://github.com/apache/syncope/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a change in pull request #321: [SYNCOPE-1666] added security answer hashing (#319)

2022-03-04 Thread GitBox
ilgrosso commented on a change in pull request #321: URL: https://github.com/apache/syncope/pull/321#discussion_r819591668 ## File path: core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/UserLogic.java ## @@ -124,15 +125,14 @@ public UserLogic( return

[GitHub] [syncope] andrea-patricelli opened a new pull request #321: [SYNCOPE-1666] added security answer hashing (#319)

2022-03-04 Thread GitBox
andrea-patricelli opened a new pull request #321: URL: https://github.com/apache/syncope/pull/321 [SYNCOPE-1666] added security answer hashing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [syncope] ilgrosso merged pull request #320: [SYNCOPE-1652] Add missing conf items

2022-03-04 Thread GitBox
ilgrosso merged pull request #320: URL: https://github.com/apache/syncope/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli merged pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli merged pull request #319: URL: https://github.com/apache/syncope/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on pull request #319: URL: https://github.com/apache/syncope/pull/319#issuecomment-1058192783 LGTM @andrea-patricelli please go ahead squash and merge if tests are succeeding -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818767117 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/user/JPALinkedAccount.java ## @@ -157,10 +166,9 @@ public

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818764359 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/user/JPALinkedAccount.java ## @@ -157,10 +166,9

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818759453 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java ## @@ -144,17 +135,42

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818702717 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/user/JPALinkedAccount.java ## @@ -157,10 +166,9 @@ public

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818481948 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818485371 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818481948 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818461666 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818461666 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818461666 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818416257 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818415455 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818370864 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818412829 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818412425 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java ## @@ -681,32 +711,21 @@

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r81842 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java ## @@ -681,32 +711,21

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818410505 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java ## @@ -681,32 +711,21

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818410185 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java ## @@ -681,32 +711,21

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-03 Thread GitBox
andrea-patricelli commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818410023 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] ilgrosso commented on a change in pull request #319: [SYNCOPE-1666] added security answer hashing

2022-03-02 Thread GitBox
ilgrosso commented on a change in pull request #319: URL: https://github.com/apache/syncope/pull/319#discussion_r818370864 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java ## @@ -54,8 +55,14 @@ void

[GitHub] [syncope] mmoayyed commented on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-28 Thread GitBox
mmoayyed commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1054004942 The reason this is failing is because: - Your service is registered as `http://localhost:8080/.*` - The service parameter sent to CAS is

[GitHub] [syncope] ilgrosso edited a comment on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-26 Thread GitBox
ilgrosso edited a comment on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1052319920 `CASSRAITCase#web` is failing. The reason seems to be that accessing

[GitHub] [syncope] ilgrosso commented on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-26 Thread GitBox
ilgrosso commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1052319920 `CASSRAITCase#web` is failing. The reason seems to be that accessing http://localhost:8080/protected/get?key1=value1=value2=value3=an%20url%20encoded%20value%3A%20this%21

[GitHub] [syncope] ilgrosso merged pull request #318: [SYNCOPE-1664] JSONB: Inconsistent search query when is used a pull correlation rule

2022-02-25 Thread GitBox
ilgrosso merged pull request #318: URL: https://github.com/apache/syncope/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #317: [SYNCOPE-1664] JSONB: Inconsistent search query when is used a pull correlation rule

2022-02-24 Thread GitBox
ilgrosso commented on pull request #317: URL: https://github.com/apache/syncope/pull/317#issuecomment-1050067924 LGTM thanks @SamuelGaro - please open a similar PR for `2_1_X` thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [syncope] ilgrosso merged pull request #317: [SYNCOPE-1664] JSONB: Inconsistent search query when is used a pull correlation rule

2022-02-24 Thread GitBox
ilgrosso merged pull request #317: URL: https://github.com/apache/syncope/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] SamuelGaro commented on pull request #317: [SYNCOPE-1664] JSONB: Inconsistent search query when is used a pull correlation rule

2022-02-24 Thread GitBox
SamuelGaro commented on pull request #317: URL: https://github.com/apache/syncope/pull/317#issuecomment-1049705595 > @SamuelGaro there are a few test cases failing: https://github.com/apache/syncope/runs/5317086137?check_suite_focus=true#step:6:3403 @ilgrosso I'm going to check --

[GitHub] [syncope] ilgrosso commented on pull request #317: [SYNCOPE-1664] JSONB: Inconsistent search query when is used a pull correlation rule

2022-02-24 Thread GitBox
ilgrosso commented on pull request #317: URL: https://github.com/apache/syncope/pull/317#issuecomment-1049703894 @SamuelGaro there are a few test cases failing: https://github.com/apache/syncope/runs/5317086137?check_suite_focus=true#step:6:3403 -- This is an automated message from the

[GitHub] [syncope] ilgrosso commented on a change in pull request #317: [SYNCOPE-1664] JSONB: Inconsistent search query when is used a pull correlation rule

2022-02-24 Thread GitBox
ilgrosso commented on a change in pull request #317: URL: https://github.com/apache/syncope/pull/317#discussion_r813711581 ## File path: core/persistence-jpa-json/src/main/java/org/apache/syncope/core/persistence/jpa/dao/PGJPAJSONAnySearchDAO.java ## @@ -200,8 +200,11 @@

[GitHub] [syncope] ilgrosso merged pull request #316: [SYNCOPE-1658] Tabular Topology

2022-02-17 Thread GitBox
ilgrosso merged pull request #316: URL: https://github.com/apache/syncope/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #316: [SYNCOPE-1658] Tabular Topology

2022-02-17 Thread GitBox
ilgrosso commented on pull request #316: URL: https://github.com/apache/syncope/pull/316#issuecomment-1042996292 Thanks @SamuelGaro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [syncope] ilgrosso commented on a change in pull request #316: [SYNCOPE-1658] Tabular Topology

2022-02-16 Thread GitBox
ilgrosso commented on a change in pull request #316: URL: https://github.com/apache/syncope/pull/316#discussion_r808295939 ## File path: client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/SchedTaskDirectoryPanel.java ## @@ -156,15 +213,15 @@ protected

[GitHub] [syncope] ilgrosso commented on a change in pull request #316: [SYNCOPE-1658] Tabular Topology

2022-02-16 Thread GitBox
ilgrosso commented on a change in pull request #316: URL: https://github.com/apache/syncope/pull/316#discussion_r808295106 ## File path: client/idrepo/console/src/main/java/org/apache/syncope/client/console/init/ClassPathScanImplementationLookup.java ## @@ -180,7 +185,13 @@

[GitHub] [syncope] SamuelGaro commented on pull request #316: [SYNCOPE-1658] Tabular Topology

2022-02-16 Thread GitBox
SamuelGaro commented on pull request #316: URL: https://github.com/apache/syncope/pull/316#issuecomment-1041476152 > @SamuelGaro I see the following test failures: > > ``` > Error: Failures: > Error:AjaxBrowseITCase.browsingBookmarkablePageLink:64 path:

[GitHub] [syncope] ilgrosso commented on pull request #316: [SYNCOPE-1658] Tabular Topology

2022-02-16 Thread GitBox
ilgrosso commented on pull request #316: URL: https://github.com/apache/syncope/pull/316#issuecomment-1041461207 @SamuelGaro I see the following test failures: ``` Error: Failures: Error:AjaxBrowseITCase.browsingBookmarkablePageLink:64 path:

[GitHub] [syncope] SamuelGaro commented on pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
SamuelGaro commented on pull request #312: URL: https://github.com/apache/syncope/pull/312#issuecomment-1040417640 > Thanks for your contribution @SamuelGaro > > Since this appears to be your very first one, please go ahead and [submit your

[GitHub] [syncope] ilgrosso merged pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso merged pull request #312: URL: https://github.com/apache/syncope/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso commented on pull request #312: URL: https://github.com/apache/syncope/pull/312#issuecomment-1040360176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] ilgrosso commented on a change in pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso commented on a change in pull request #312: URL: https://github.com/apache/syncope/pull/312#discussion_r806826486 ## File path: client/console/src/main/java/org/apache/syncope/client/console/commons/ConnectorDataProvider.java ## @@ -0,0 +1,151 @@ +/* + * Licensed to

[GitHub] [syncope] mmoayyed closed pull request #313: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed closed pull request #313: URL: https://github.com/apache/syncope/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] mmoayyed commented on a change in pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on a change in pull request #315: URL: https://github.com/apache/syncope/pull/315#discussion_r806557330 ## File path: pom.xml ## @@ -446,9 +446,9 @@ under the License. 2.3.0 -5.2.1 +5.3.1 -6.5.0-RC4 +6.5.1-SNAPSHOT Review comment:

[GitHub] [syncope] andrea-patricelli merged pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-15 Thread GitBox
andrea-patricelli merged pull request #314: URL: https://github.com/apache/syncope/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-15 Thread GitBox
andrea-patricelli commented on a change in pull request #314: URL: https://github.com/apache/syncope/pull/314#discussion_r806010350 ## File path: client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfPasswordReset.java ## @@ -91,10 +91,7 @@ public

[GitHub] [syncope] ilgrosso commented on a change in pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-15 Thread GitBox
ilgrosso commented on a change in pull request #314: URL: https://github.com/apache/syncope/pull/314#discussion_r80548 ## File path: client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfPasswordReset.java ## @@ -91,10 +91,7 @@ public

[GitHub] [syncope] ilgrosso commented on pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-15 Thread GitBox
ilgrosso commented on pull request #314: URL: https://github.com/apache/syncope/pull/314#issuecomment-1039323576 @andrea-patricelli a test is failing: AuthenticatedITCase.selfUpdate:99 » NullPointer -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [syncope] mmoayyed commented on pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1039978373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] mmoayyed edited a comment on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed edited a comment on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040075316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] mmoayyed commented on pull request #313: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #313: URL: https://github.com/apache/syncope/pull/313#issuecomment-1039976215 Closing this for no; starting off with a new branch here in apache/syncope to make collab easier. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [syncope] ilgrosso commented on pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
ilgrosso commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-103620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] ilgrosso commented on pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso commented on pull request #312: URL: https://github.com/apache/syncope/pull/312#issuecomment-1040419156 Thank you again @SamuelGaro ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [syncope] ilgrosso merged pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso merged pull request #312: URL: https://github.com/apache/syncope/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] SamuelGaro commented on pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
SamuelGaro commented on pull request #312: URL: https://github.com/apache/syncope/pull/312#issuecomment-1040417640 > Thanks for your contribution @SamuelGaro > > Since this appears to be your very first one, please go ahead and [submit your

[GitHub] [syncope] ilgrosso commented on pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso commented on pull request #312: URL: https://github.com/apache/syncope/pull/312#issuecomment-1040360176 Thanks for your contribution @SamuelGaro Since this appears to be your very first one, please go ahead and [submit your

[GitHub] [syncope] mmoayyed commented on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040273540 Yes I agree. That's good thing to do at least for the time being while this stuff gets worked out, with a small note to revisit this later in the future upgrades. -- This is

[GitHub] [syncope] ilgrosso commented on a change in pull request #312: [SYNCOPE-1658] Tabular Topology

2022-02-15 Thread GitBox
ilgrosso commented on a change in pull request #312: URL: https://github.com/apache/syncope/pull/312#discussion_r806826486 ## File path: client/console/src/main/java/org/apache/syncope/client/console/commons/ConnectorDataProvider.java ## @@ -0,0 +1,151 @@ +/* + * Licensed to

[GitHub] [syncope] ilgrosso commented on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
ilgrosso commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040113493 Ok, your explanation makes definitely sense to me. So, we should consider (and maybe document) as manageable by `WAConfigService` not all the available CAS properties,

[GitHub] [syncope] mmoayyed edited a comment on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed edited a comment on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040075316 I see; thanks for the details. This seems simple-enough to fix; unfortunately like most other seemingly-simple problems, it's quite complicated to work it out.

[GitHub] [syncope] mmoayyed edited a comment on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed edited a comment on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040075316 I see; thanks for the details. This is seems simple-enough to fix; unfortunately like most other seemingly-simple problems, it's quite complicated to work it out.

[GitHub] [syncope] mmoayyed commented on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040075316 I see; thanks for the details. This seems simple-enough to fix; unfortunately like most other seemingly-simple problems, it's quite complicated to work it out. Mainly

[GitHub] [syncope] ilgrosso commented on pull request #315: Upgrading CAS to 6.5.x; moving wa-reference as https

2022-02-15 Thread GitBox
ilgrosso commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040058676 > Do you happen to know which properties are not loaded? All or only a select few? It starts empty, but when I add something like ```

[GitHub] [syncope] mmoayyed commented on pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1040023555 A few updates: - There are no references to `SpringBeanAutowiringSupport` in CAS 6.5; This should be removed and should not show up; however, the warning is entirely

[GitHub] [syncope] ilgrosso commented on pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
ilgrosso commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-103620 If possible, we should address the following items as well: * continuous statements appearing in the logs as ``` WARN

[GitHub] [syncope] mmoayyed commented on a change in pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on a change in pull request #315: URL: https://github.com/apache/syncope/pull/315#discussion_r806557330 ## File path: pom.xml ## @@ -446,9 +446,9 @@ under the License. 2.3.0 -5.2.1 +5.3.1 -6.5.0-RC4 +6.5.1-SNAPSHOT Review comment:

[GitHub] [syncope] mmoayyed commented on pull request #315: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #315: URL: https://github.com/apache/syncope/pull/315#issuecomment-1039978373 Now seeing a lot of: ``` 12:03:11.754 ERROR org.apache.syncope.common.keymaster.client.api.ServiceOps - Could not unregister NetworkService{type=SRA,

[GitHub] [syncope] mmoayyed commented on pull request #313: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed commented on pull request #313: URL: https://github.com/apache/syncope/pull/313#issuecomment-1039976215 Closing this for no; starting off with a new branch here in apache/syncope to make collab easier. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [syncope] mmoayyed closed pull request #313: Upgrading CAS to 6.5.0, moving wa-reference as https

2022-02-15 Thread GitBox
mmoayyed closed pull request #313: URL: https://github.com/apache/syncope/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli merged pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-15 Thread GitBox
andrea-patricelli merged pull request #314: URL: https://github.com/apache/syncope/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-14 Thread GitBox
ilgrosso commented on pull request #314: URL: https://github.com/apache/syncope/pull/314#issuecomment-1039323576 @andrea-patricelli a test is failing: AuthenticatedITCase.selfUpdate:99 » NullPointer -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [syncope] andrea-patricelli commented on a change in pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-14 Thread GitBox
andrea-patricelli commented on a change in pull request #314: URL: https://github.com/apache/syncope/pull/314#discussion_r806010350 ## File path: client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfPasswordReset.java ## @@ -91,10 +91,7 @@ public

[GitHub] [syncope] ilgrosso commented on a change in pull request #314: SYNCOPE-1661 added sidebar layout JSON configuration

2022-02-14 Thread GitBox
ilgrosso commented on a change in pull request #314: URL: https://github.com/apache/syncope/pull/314#discussion_r80548 ## File path: client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfPasswordReset.java ## @@ -91,10 +91,7 @@ public

[GitHub] [syncope] ilgrosso commented on pull request #314: added sidebar layout JSON configuration

2022-02-14 Thread GitBox
ilgrosso commented on pull request #314: URL: https://github.com/apache/syncope/pull/314#issuecomment-1039191241 @andrea-patricelli please add the issue number to this PR title, e.g. rename it as `[SYNCOPE-XXX] ,` -- This is an automated message from the Apache Git Service. To respond

[GitHub] [syncope] ilgrosso merged pull request #311: Enabling GH actions for Oracle DB

2022-02-09 Thread GitBox
ilgrosso merged pull request #311: URL: https://github.com/apache/syncope/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #310: Improving GH actions and ITs

2022-02-05 Thread GitBox
ilgrosso merged pull request #310: URL: https://github.com/apache/syncope/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso closed pull request #309: GH actions improvements

2022-02-05 Thread GitBox
ilgrosso closed pull request #309: URL: https://github.com/apache/syncope/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #308: [SYNCOPE-1612] fix connector/resource connection check

2022-02-04 Thread GitBox
ilgrosso merged pull request #308: URL: https://github.com/apache/syncope/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a change in pull request #308: fix connector/resource connection check

2022-02-04 Thread GitBox
ilgrosso commented on a change in pull request #308: URL: https://github.com/apache/syncope/pull/308#discussion_r799410934 ## File path: client/console/src/main/java/org/apache/syncope/client/console/topology/TopologyWebSocketBehavior.java ## @@ -59,12 +59,12 @@ private

[GitHub] [syncope] ilgrosso commented on pull request #307: [SYNCOPE-1657] Changes to Topology for allowing to specify a resource name during clone

2022-02-04 Thread GitBox
ilgrosso commented on pull request #307: URL: https://github.com/apache/syncope/pull/307#issuecomment-1029826289 Thanks for your contribution @eeleren ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

<    1   2   3   4   5   6   7   8   9   >