[GitHub] atsticks commented on issue #10: TAMAYA-352 Unpredictable behavior when a resolver can't resolve the …

2019-01-16 Thread GitBox
atsticks commented on issue #10: TAMAYA-352 Unpredictable behavior when a resolver can't resolve the … URL: https://github.com/apache/incubator-tamaya-extensions/pull/10#issuecomment-454941873 Sinve everything in Apache is happening on the mailing list ;-) can you open a discussion

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744455#comment-16744455 ] ASF subversion and git services commented on TAMAYA-217: Commit

[GitHub] atsticks commented on issue #7: TAMAYA-350 - Do not provide null as "null" string

2019-01-16 Thread GitBox
atsticks commented on issue #7: TAMAYA-350 - Do not provide null as "null" string URL: https://github.com/apache/incubator-tamaya-extensions/pull/7#issuecomment-454937665 The corresponding change has been done in the code, see the current snippet, so I will close this request: ```

[GitHub] atsticks closed pull request #7: TAMAYA-350 - Do not provide null as "null" string

2019-01-16 Thread GitBox
atsticks closed pull request #7: TAMAYA-350 - Do not provide null as "null" string URL: https://github.com/apache/incubator-tamaya-extensions/pull/7 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744453#comment-16744453 ] ASF subversion and git services commented on TAMAYA-217: Commit

[GitHub] atsticks commented on issue #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver

2019-01-16 Thread GitBox
atsticks commented on issue #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver URL: https://github.com/apache/incubator-tamaya-extensions/pull/9#issuecomment-454936368 I close this request, it has been fixed in the code already. Thanks.

[GitHub] atsticks closed pull request #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver

2019-01-16 Thread GitBox
atsticks closed pull request #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver URL: https://github.com/apache/incubator-tamaya-extensions/pull/9 This is an automated message

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744454#comment-16744454 ] ASF subversion and git services commented on TAMAYA-217: Commit

[jira] [Commented] (TAMAYA-216) Migrate all tests in module extensions

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1679#comment-1679 ] ASF subversion and git services commented on TAMAYA-216: Commit

[jira] [Commented] (TAMAYA-216) Migrate all tests in module extensions

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1678#comment-1678 ] ASF subversion and git services commented on TAMAYA-216: Commit

[jira] [Commented] (TAMAYA-216) Migrate all tests in module extensions

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744450#comment-16744450 ] ASF subversion and git services commented on TAMAYA-216: Commit

[jira] [Commented] (TAMAYA-216) Migrate all tests in module extensions

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1677#comment-1677 ] ASF subversion and git services commented on TAMAYA-216: Commit

[GitHub] atsticks merged pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-16 Thread GitBox
atsticks merged pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25 This is an automated message from the Apache Git Service. To respond to the

[GitHub] atsticks commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-16 Thread GitBox
atsticks commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25#discussion_r248442001 ## File path:

Re: AssertJ and Tamaya test code

2019-01-16 Thread P. Ottlinger
Dear Aaron, Am 16.01.19 um 15:40 schrieb Aaron Coburn: > https://github.com/apache/incubator-tamaya/pull/32 > https://github.com/apache/incubator-tamaya-extensions/pull/25 > https://github.com/apache/incubator-tamaya-sandbox/pull/17 Thanks for all your work - I remember (because I started to do

[GitHub] ottlinger commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-16 Thread GitBox
ottlinger commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25#discussion_r248426649 ## File path:

[jira] [Closed] (TAMAYA-218) Migrate all tests in module sandbox

2019-01-16 Thread Philipp Ottlinger (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger closed TAMAYA-218. Resolution: Fixed [https://github.com/apache/incubator-tamaya-sandbox/pull/17] Thanks. >

[jira] [Commented] (TAMAYA-318) Move the SPI Support from Extensions to API

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744407#comment-16744407 ] ASF subversion and git services commented on TAMAYA-318: Commit

[jira] [Commented] (TAMAYA-218) Migrate all tests in module sandbox

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744406#comment-16744406 ] ASF subversion and git services commented on TAMAYA-218: Commit

[jira] [Commented] (TAMAYA-218) Migrate all tests in module sandbox

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744397#comment-16744397 ] ASF subversion and git services commented on TAMAYA-218: Commit

[jira] [Commented] (TAMAYA-218) Migrate all tests in module sandbox

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744398#comment-16744398 ] ASF subversion and git services commented on TAMAYA-218: Commit

[jira] [Commented] (TAMAYA-218) Migrate all tests in module sandbox

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744395#comment-16744395 ] ASF subversion and git services commented on TAMAYA-218: Commit

[jira] [Commented] (TAMAYA-218) Migrate all tests in module sandbox

2019-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744396#comment-16744396 ] ASF subversion and git services commented on TAMAYA-218: Commit

[GitHub] ottlinger merged pull request #17: TAMAYA-218: Migrate test assertions to AssertJ

2019-01-16 Thread GitBox
ottlinger merged pull request #17: TAMAYA-218: Migrate test assertions to AssertJ URL: https://github.com/apache/incubator-tamaya-sandbox/pull/17 This is an automated message from the Apache Git Service. To respond to the

Re: AssertJ and Tamaya test code

2019-01-16 Thread P. Ottlinger
Am 16.01.19 um 15:40 schrieb Aaron Coburn: > And in terms of process, should I be waiting for someone to merge these PRs? > Or should I push these commits directly to master? I'll have a look at the PRs - I like reviewing ;-) Thanks for your contribution - I'm just not sure whether we can drop

AssertJ and Tamaya test code

2019-01-16 Thread Aaron Coburn
Hi All, There is a quartet of Jira issues related to consolidating the test assertion code so that AssertJ is used (TAMAYA-216, TAMAYA-217, TAMAYA-218 and TAMAYA-219). At present, there is a combination of AssertJ, JUnit and Hamcrest in use throughout the tests. I have three open pull requests