[GitHub] acoburn opened a new pull request #20: Add timeout value to events.ObservedConfigTest

2018-12-17 Thread GitBox
acoburn opened a new pull request #20: Add timeout value to events.ObservedConfigTest URL: https://github.com/apache/incubator-tamaya-extensions/pull/20 The Apache Jenkins server seems to occasionally get "stuck" on this test. This just adds a 60 second timeout, since a failed test is much

[GitHub] atsticks closed pull request #20: Add timeout value to events.ObservedConfigTest

2018-12-17 Thread GitBox
atsticks closed pull request #20: Add timeout value to events.ObservedConfigTest URL: https://github.com/apache/incubator-tamaya-extensions/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] peculater opened a new pull request #12: Exclude the docs project from the OSGi scan.

2018-12-30 Thread GitBox
peculater opened a new pull request #12: Exclude the docs project from the OSGi scan. URL: https://github.com/apache/incubator-tamaya-sandbox/pull/12 Tamaya-validator_alpha's dependency on tamaya-doc_alpha causes the Karaf plugin to try to read doc's target/classes directory as a jar file.

[GitHub] peculater closed pull request #12: Get the tests passing before 2018 ends.

2018-12-30 Thread GitBox
peculater closed pull request #12: Get the tests passing before 2018 ends. URL: https://github.com/apache/incubator-tamaya-sandbox/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] acoburn opened a new pull request #21: Clean up OSGi/Manifest metadata

2019-01-03 Thread GitBox
acoburn opened a new pull request #21: Clean up OSGi/Manifest metadata URL: https://github.com/apache/incubator-tamaya-extensions/pull/21 Related to TAMAYA-331 As with https://github.com/apache/incubator-tamaya/pull/30, this adds the `buildnumber-maven-plugin` in order to correctly p

[GitHub] acoburn opened a new pull request #13: Clean up OSGi/Manifest metadata

2019-01-03 Thread GitBox
acoburn opened a new pull request #13: Clean up OSGi/Manifest metadata URL: https://github.com/apache/incubator-tamaya-sandbox/pull/13 Related to TAMAYA-331 Similar to https://github.com/apache/incubator-tamaya/pull/30, this cleans up the OSGi metadata, adding the `buildnumber-maven-

[GitHub] acoburn opened a new pull request #22: Update dependencies to non-beta versions

2019-01-03 Thread GitBox
acoburn opened a new pull request #22: Update dependencies to non-beta versions URL: https://github.com/apache/incubator-tamaya-extensions/pull/22 Some dependencies are tied to beta releases. This updates those dependencies to the latest non-beta version. --

[GitHub] acoburn opened a new pull request #14: Update to non-alpha depedencies

2019-01-03 Thread GitBox
acoburn opened a new pull request #14: Update to non-alpha depedencies URL: https://github.com/apache/incubator-tamaya-sandbox/pull/14 This updates some dependencies from `alpha` versions to stable 1.x versions. Note: the `javax.json` dependency is updated to the 1.1 artifact, since t

[GitHub] ottlinger closed pull request #14: Update to non-alpha depedencies

2019-01-03 Thread GitBox
ottlinger closed pull request #14: Update to non-alpha depedencies URL: https://github.com/apache/incubator-tamaya-sandbox/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] ottlinger closed pull request #13: Clean up OSGi/Manifest metadata

2019-01-03 Thread GitBox
ottlinger closed pull request #13: Clean up OSGi/Manifest metadata URL: https://github.com/apache/incubator-tamaya-sandbox/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] ottlinger commented on issue #9: TAMAYA-345 Associative array default separator to ':'

2019-01-03 Thread GitBox
ottlinger commented on issue #9: TAMAYA-345 Associative array default separator to ':' URL: https://github.com/apache/incubator-tamaya-sandbox/pull/9#issuecomment-451294300 @peculater can you have a look at the merge request and update it accordingly - thanks :-)

[GitHub] ottlinger closed pull request #22: Update dependencies to non-beta versions

2019-01-03 Thread GitBox
ottlinger closed pull request #22: Update dependencies to non-beta versions URL: https://github.com/apache/incubator-tamaya-extensions/pull/22 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] ottlinger closed pull request #21: Clean up OSGi/Manifest metadata

2019-01-03 Thread GitBox
ottlinger closed pull request #21: Clean up OSGi/Manifest metadata URL: https://github.com/apache/incubator-tamaya-extensions/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] acoburn opened a new pull request #23: Remove duplicate import

2019-01-03 Thread GitBox
acoburn opened a new pull request #23: Remove duplicate import URL: https://github.com/apache/incubator-tamaya-extensions/pull/23 The `tamaya-spisupport` module is imported twice. This removes the duplicate entry. This is a

[GitHub] acoburn opened a new pull request #24: TAMAYA-154 Fix javadoc issues

2019-01-03 Thread GitBox
acoburn opened a new pull request #24: TAMAYA-154 Fix javadoc issues URL: https://github.com/apache/incubator-tamaya-extensions/pull/24 This addresses a few minor javadoc issues. This is an automated message from the Apache Gi

[GitHub] acoburn opened a new pull request #15: Remove duplicate import of tamaya-formats

2019-01-03 Thread GitBox
acoburn opened a new pull request #15: Remove duplicate import of tamaya-formats URL: https://github.com/apache/incubator-tamaya-sandbox/pull/15 The `tamaya-formats` module is listed twice in the dependencies. This removes the extraneous one. ---

[GitHub] acoburn opened a new pull request #16: TAMAYA-154 fix javadoc errors

2019-01-03 Thread GitBox
acoburn opened a new pull request #16: TAMAYA-154 fix javadoc errors URL: https://github.com/apache/incubator-tamaya-sandbox/pull/16 This fixes some minor javadoc errors. This is an automated message from the Apache Git Servic

[GitHub] peculater commented on issue #9: TAMAYA-345 Associative array default separator to ':'

2019-01-03 Thread GitBox
peculater commented on issue #9: TAMAYA-345 Associative array default separator to ':' URL: https://github.com/apache/incubator-tamaya-sandbox/pull/9#issuecomment-451343310 This got incorporated into https://github.com/apache/incubator-tamaya-extensions/commit/9f38f77020a057145aa246f2ff6f

[GitHub] peculater closed pull request #9: TAMAYA-345 Associative array default separator to ':'

2019-01-03 Thread GitBox
peculater closed pull request #9: TAMAYA-345 Associative array default separator to ':' URL: https://github.com/apache/incubator-tamaya-sandbox/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] peculater commented on issue #6: Proposal: Change default key-value separator from :: to =

2019-01-03 Thread GitBox
peculater commented on issue #6: Proposal: Change default key-value separator from :: to = URL: https://github.com/apache/incubator-tamaya-sandbox/pull/6#issuecomment-451343439 This got changed from '::' to ':' based on the conversation linked at the top, and implemented in https://githu

[GitHub] peculater closed pull request #6: Proposal: Change default key-value separator from :: to =

2019-01-03 Thread GitBox
peculater closed pull request #6: Proposal: Change default key-value separator from :: to = URL: https://github.com/apache/incubator-tamaya-sandbox/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] ottlinger commented on a change in pull request #16: TAMAYA-154 fix javadoc errors

2019-01-07 Thread GitBox
ottlinger commented on a change in pull request #16: TAMAYA-154 fix javadoc errors URL: https://github.com/apache/incubator-tamaya-sandbox/pull/16#discussion_r245775341 ## File path: validation/src/main/java/org/apache/tamaya/validation/spi/AbstractValidator.java ## @@ -

[GitHub] ottlinger closed pull request #15: Remove duplicate import of tamaya-formats

2019-01-07 Thread GitBox
ottlinger closed pull request #15: Remove duplicate import of tamaya-formats URL: https://github.com/apache/incubator-tamaya-sandbox/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] ottlinger closed pull request #16: TAMAYA-154 fix javadoc errors

2019-01-07 Thread GitBox
ottlinger closed pull request #16: TAMAYA-154 fix javadoc errors URL: https://github.com/apache/incubator-tamaya-sandbox/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] ottlinger commented on issue #16: TAMAYA-154 fix javadoc errors

2019-01-07 Thread GitBox
ottlinger commented on issue #16: TAMAYA-154 fix javadoc errors URL: https://github.com/apache/incubator-tamaya-sandbox/pull/16#issuecomment-452058715 Thanks :-) This is an automated message from the Apache Git Service. To re

[GitHub] ottlinger closed pull request #24: TAMAYA-154 Fix javadoc issues

2019-01-07 Thread GitBox
ottlinger closed pull request #24: TAMAYA-154 Fix javadoc issues URL: https://github.com/apache/incubator-tamaya-extensions/pull/24 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] ottlinger commented on issue #24: TAMAYA-154 Fix javadoc issues

2019-01-07 Thread GitBox
ottlinger commented on issue #24: TAMAYA-154 Fix javadoc issues URL: https://github.com/apache/incubator-tamaya-extensions/pull/24#issuecomment-452059412 Thanks. This is an automated message from the Apache Git Service. To re

[GitHub] ottlinger closed pull request #23: Remove duplicate import

2019-01-07 Thread GitBox
ottlinger closed pull request #23: Remove duplicate import URL: https://github.com/apache/incubator-tamaya-extensions/pull/23 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] acoburn opened a new pull request #3: TAMAYA-376 Add committers to developer list

2019-01-07 Thread GitBox
acoburn opened a new pull request #3: TAMAYA-376 Add committers to developer list URL: https://github.com/apache/incubator-tamaya-site/pull/3 This adds @peculater and myself to the Tamaya developer list. This is an automated

[GitHub] acoburn opened a new pull request #17: TAMAYA-218: Migrate test assertions to AssertJ

2019-01-09 Thread GitBox
acoburn opened a new pull request #17: TAMAYA-218: Migrate test assertions to AssertJ URL: https://github.com/apache/incubator-tamaya-sandbox/pull/17 Resolves TAMAYA-218 This is an automated message from the Apache Git Servic

[GitHub] peculater commented on a change in pull request #17: TAMAYA-218: Migrate test assertions to AssertJ

2019-01-09 Thread GitBox
peculater commented on a change in pull request #17: TAMAYA-218: Migrate test assertions to AssertJ URL: https://github.com/apache/incubator-tamaya-sandbox/pull/17#discussion_r246586669 ## File path: camel/pom.xml ## @@ -61,6 +61,10 @@ under the License. java

[GitHub] acoburn opened a new pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-10 Thread GitBox
acoburn opened a new pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25 This migrates all of the test assertions from a combination of junit/hamcrest/assertj to only use the AssertJ library. It also removes th

[GitHub] acoburn commented on a change in pull request #17: TAMAYA-218: Migrate test assertions to AssertJ

2019-01-10 Thread GitBox
acoburn commented on a change in pull request #17: TAMAYA-218: Migrate test assertions to AssertJ URL: https://github.com/apache/incubator-tamaya-sandbox/pull/17#discussion_r246791992 ## File path: camel/pom.xml ## @@ -61,6 +61,10 @@ under the License. java-h

[GitHub] acoburn commented on issue #3: TAMAYA-376 Add committers to developer list

2019-01-10 Thread GitBox
acoburn commented on issue #3: TAMAYA-376 Add committers to developer list URL: https://github.com/apache/incubator-tamaya-site/pull/3#issuecomment-453135866 Resolved via https://github.com/apache/incubator-tamaya-site/commit/982c8a35697e0019e4162f473192a1d662f7e28e --

[GitHub] acoburn closed pull request #3: TAMAYA-376 Add committers to developer list

2019-01-10 Thread GitBox
acoburn closed pull request #3: TAMAYA-376 Add committers to developer list URL: https://github.com/apache/incubator-tamaya-site/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ottlinger merged pull request #17: TAMAYA-218: Migrate test assertions to AssertJ

2019-01-16 Thread GitBox
ottlinger merged pull request #17: TAMAYA-218: Migrate test assertions to AssertJ URL: https://github.com/apache/incubator-tamaya-sandbox/pull/17 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] ottlinger commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-16 Thread GitBox
ottlinger commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25#discussion_r248426649 ## File path: modules/collections/src/test/java/org/apache/tamaya/collections/CollectionAdva

[GitHub] atsticks commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-16 Thread GitBox
atsticks commented on a change in pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25#discussion_r248442001 ## File path: modules/collections/src/test/java/org/apache/tamaya/collections/CollectionAdvan

[GitHub] atsticks merged pull request #25: TAMAYA-216: Migrate test assertions to assertj

2019-01-16 Thread GitBox
atsticks merged pull request #25: TAMAYA-216: Migrate test assertions to assertj URL: https://github.com/apache/incubator-tamaya-extensions/pull/25 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] atsticks closed pull request #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver

2019-01-16 Thread GitBox
atsticks closed pull request #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver URL: https://github.com/apache/incubator-tamaya-extensions/pull/9 This is an automated message from

[GitHub] atsticks commented on issue #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver

2019-01-16 Thread GitBox
atsticks commented on issue #9: TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver URL: https://github.com/apache/incubator-tamaya-extensions/pull/9#issuecomment-454936368 I close this request, it has been fixed in the code already. Thanks. ---

[GitHub] atsticks closed pull request #7: TAMAYA-350 - Do not provide null as "null" string

2019-01-16 Thread GitBox
atsticks closed pull request #7: TAMAYA-350 - Do not provide null as "null" string URL: https://github.com/apache/incubator-tamaya-extensions/pull/7 This is an automated message from the Apache Git Service. To respond to the

[GitHub] atsticks commented on issue #7: TAMAYA-350 - Do not provide null as "null" string

2019-01-16 Thread GitBox
atsticks commented on issue #7: TAMAYA-350 - Do not provide null as "null" string URL: https://github.com/apache/incubator-tamaya-extensions/pull/7#issuecomment-454937665 The corresponding change has been done in the code, see the current snippet, so I will close this request: ``` i

[GitHub] atsticks commented on issue #10: TAMAYA-352 Unpredictable behavior when a resolver can't resolve the …

2019-01-16 Thread GitBox
atsticks commented on issue #10: TAMAYA-352 Unpredictable behavior when a resolver can't resolve the … URL: https://github.com/apache/incubator-tamaya-extensions/pull/10#issuecomment-454941873 Sinve everything in Apache is happening on the mailing list ;-) can you open a discussion thread

[GitHub] acoburn opened a new pull request #26: TAMAYA-219: Enable checkstyle analysis

2019-01-17 Thread GitBox
acoburn opened a new pull request #26: TAMAYA-219: Enable checkstyle analysis URL: https://github.com/apache/incubator-tamaya-extensions/pull/26 This enables checkstyle analysis on the extension modules. Errors will be reported to the console but will not (at present) fail a build. ---

[GitHub] acoburn opened a new pull request #18: TAMAYA-219: Enable checkstyle analysis

2019-01-17 Thread GitBox
acoburn opened a new pull request #18: TAMAYA-219: Enable checkstyle analysis URL: https://github.com/apache/incubator-tamaya-sandbox/pull/18 This enables checkstyle analysis of the sandbox modules but will not (at present) fail builds on style violations. ---

[GitHub] acoburn commented on issue #26: TAMAYA-219: Enable checkstyle analysis

2019-01-17 Thread GitBox
acoburn commented on issue #26: TAMAYA-219: Enable checkstyle analysis URL: https://github.com/apache/incubator-tamaya-extensions/pull/26#issuecomment-455324004 I now realize that this PR is going to fail because the `buildconfigurations` artifact from the main codebase is pushed neither t

[GitHub] ottlinger commented on issue #26: TAMAYA-219: Enable checkstyle analysis

2019-01-19 Thread GitBox
ottlinger commented on issue #26: TAMAYA-219: Enable checkstyle analysis URL: https://github.com/apache/incubator-tamaya-extensions/pull/26#issuecomment-455813818 @acoburn this thing looks ready 2 merge. Correct? This is an a

[GitHub] ottlinger merged pull request #18: TAMAYA-219: Enable checkstyle analysis

2019-01-19 Thread GitBox
ottlinger merged pull request #18: TAMAYA-219: Enable checkstyle analysis URL: https://github.com/apache/incubator-tamaya-sandbox/pull/18 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] ottlinger merged pull request #26: TAMAYA-219: Enable checkstyle analysis

2019-01-19 Thread GitBox
ottlinger merged pull request #26: TAMAYA-219: Enable checkstyle analysis URL: https://github.com/apache/incubator-tamaya-extensions/pull/26 This is an automated message from the Apache Git Service. To respond to the message,