+1
and as soon as 0.9.3 is released we can focus on using more recent
compilers towards C++11
-roger
Quoting Jake Farrell jfarr...@apache.org:
Based on a previous positive discussion regarding switching our build
system over from autoconf to cmake [1] and the recent progress that has
been
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541728#comment-14541728
]
julien greard commented on THRIFT-2642:
---
Hi,
Thanks for the indication about the
+1
Oryginalna wiadomość
Od: Jake Farrell jfarr...@apache.org
Data:13.05.2015 6:21 (GMT+01:00)
Do: dev@thrift.apache.org
Temat: [VOTE] Switch Apache Thrift from autoconf to cmake
Based on a previous positive discussion regarding switching our build
system over from
[
https://issues.apache.org/jira/browse/THRIFT-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
julien greard resolved THRIFT-3147.
---
Resolution: Not A Problem
Fix Version/s: 0.9.2
not a bug after all - it was a
[
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541839#comment-14541839
]
Roger Meier commented on THRIFT-3143:
-
Is copying really necessary? I would like to
[
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541832#comment-14541832
]
Roger Meier commented on THRIFT-3112:
-
yes, please provide a patrch
[Java]
[
https://issues.apache.org/jira/browse/THRIFT-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-2326.
-
Resolution: Duplicate
Enums generated for Java doesn't work for types in maps
+0
I don't have strong opinions on autoconf vs. cmake. +1 for getting rid of
one of the build systems though. Many thanks for those that took the
effort to develop and try out the new build system.
Jake Farrell jfarr...@apache.org wrote on 05/12/2015 11:21:41 PM:
From: Jake Farrell
Github user itkach commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-101651241
e.g. lib/js/test/deep-constructor.test.js ?
So more duplication, except it also needs to be rewritten for the different
test runner js uses
An
[
https://issues.apache.org/jira/browse/THRIFT-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541841#comment-14541841
]
Roger Meier commented on THRIFT-1833:
-
This patch is very old and needs to be
[
https://issues.apache.org/jira/browse/THRIFT-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541835#comment-14541835
]
Roger Meier commented on THRIFT-3127:
-
I think we should go for this standard
[
https://issues.apache.org/jira/browse/THRIFT-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541945#comment-14541945
]
Xiaoshuang LU commented on THRIFT-3127:
---
This ticket is blocked by THRIFT-3013.
[
https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541842#comment-14541842
]
ASF GitHub Bot commented on THRIFT-3122:
Github user itkach commented on the pull
[
https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2941:
---
Assignee: (was: Jens Geyer)
Convert processor to use switch instead of map
[
https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2941:
---
Patch Info: (was: Patch Available)
Convert processor to use switch instead of map
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-101781028
e.g. lib/js/test/deep-constructor.test.js ?
So more duplication, except it also needs to be rewritten for the
different test runner js uses
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-101799446
What about Jasmine, Karma and PhantomJS as unit test suite?
and Protractor if we do e2e, what's best for nodejs? or node.js io.js and
javascript all in one?
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/480#issuecomment-101795809
Thanks for the PR but this causes a syntax error:
```
./thrift/lib/nodejs/test/gen-nodejs/ThriftTest.js:14
var ThriftTest.ThriftTest_testVoid_args =
[
https://issues.apache.org/jira/browse/THRIFT-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542538#comment-14542538
]
ASF GitHub Bot commented on THRIFT-3148:
Github user asfgit closed the pull
[
https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-2941.
--
Resolution: Incomplete
Please feel free to reopen with an improved patch.
Convert processor to use
[
https://issues.apache.org/jira/browse/THRIFT-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542720#comment-14542720
]
Jens Geyer commented on THRIFT-2954:
[~AnnaDymek], great to hear!
If you like, you
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542749#comment-14542749
]
Jens Geyer commented on THRIFT-2642:
You will be, just fire away :-)
Just remember,
[
https://issues.apache.org/jira/browse/THRIFT-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542769#comment-14542769
]
Hudson commented on THRIFT-3148:
SUCCESS: Integrated in Thrift #1545 (See
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542602#comment-14542602
]
ASF GitHub Bot commented on THRIFT-3122:
Github user bufferoverflow commented on
[
https://issues.apache.org/jira/browse/THRIFT-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542720#comment-14542720
]
Jens Geyer edited comment on THRIFT-2954 at 5/13/15 9:07 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542753#comment-14542753
]
Jens Geyer commented on THRIFT-3131:
Agree.
Make suggested import path for go
[
https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542492#comment-14542492
]
ASF GitHub Bot commented on THRIFT-3122:
Github user henrique commented on the
Hi,
I installed boost in a non-standard location and call
./configure --with-boost=/usr/local
With todays trunk I get this below, but the issue may be some days old. I have
not yet found the exact commit who caused this. Note the wrong path:
g++: error:
Ok, seems to be sth. else ... please ignore.
-Ursprüngliche Nachricht-
From: Jens Geyer
Sent: Thursday, May 14, 2015 12:15 AM
To: dev@thrift.apache.org
Subject: Boost vs. Build
Hi,
I installed boost in a non-standard location and call
./configure --with-boost=/usr/local
With
[
https://issues.apache.org/jira/browse/THRIFT-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542878#comment-14542878
]
Anna Dymek commented on THRIFT-2954:
Hey,
I'm already on the mailing list and I've
[
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542753#comment-14542753
]
Jens Geyer edited comment on THRIFT-3131 at 5/13/15 9:47 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543122#comment-14543122
]
Jake Farrell commented on THRIFT-3131:
--
git-wip should not be used for this git.a.o
[
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543072#comment-14543072
]
Konstantin Shaposhnikov commented on THRIFT-3131:
-
The question of
Konstantin Shaposhnikov created THRIFT-3149:
---
Summary: Make ReadFieldN methods in generated Go code private
Key: THRIFT-3149
URL: https://issues.apache.org/jira/browse/THRIFT-3149
Project:
[
https://issues.apache.org/jira/browse/THRIFT-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543209#comment-14543209
]
Konstantin Shaposhnikov commented on THRIFT-3149:
-
Pull request to follow
[
https://issues.apache.org/jira/browse/THRIFT-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543223#comment-14543223
]
Konstantin Shaposhnikov commented on THRIFT-3150:
-
Pull request to follow
Konstantin Shaposhnikov created THRIFT-3150:
---
Summary: Add an option to thrift go generator to make Read and
Write methods private
Key: THRIFT-3150
URL: https://issues.apache.org/jira/browse/THRIFT-3150
Nobuaki Sukegawa created THRIFT-3148:
Summary: Markdown links to coding_standards are dead
Key: THRIFT-3148
URL: https://issues.apache.org/jira/browse/THRIFT-3148
Project: Thrift
Issue
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/491
THRIFT-3148 Markdown links to coding_standards are dead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3148
Alternatively
+1
I really liked the flexibility and the degree of Windows support when
dealing with both tools for patches.
Only downside for me has been having two systems.
On Wed, May 13, 2015 at 10:29 PM, Ben Craig bencr...@apache.org wrote:
+0
I don't have strong opinions on autoconf vs. cmake. +1
[
https://issues.apache.org/jira/browse/THRIFT-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542277#comment-14542277
]
ASF GitHub Bot commented on THRIFT-3148:
GitHub user nsuke opened a pull request:
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-101528449
1. e.g. lib/js/test/deep-constructor.test.js ? If you have the time it will
be perfect.
2. Yes, we have this duplication but at least it would be only loaded once,
[
https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541435#comment-14541435
]
ASF GitHub Bot commented on THRIFT-3122:
Github user henrique commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539620#comment-14539620
]
julien greard edited comment on THRIFT-2642 at 5/13/15 7:42 AM:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539620#comment-14539620
]
julien greard edited comment on THRIFT-2642 at 5/13/15 7:42 AM:
+1
Absolutely. One build system, and one build system only. When cmake is ready,
we should do that. I especially agree with the proposal re 093 release. Let's
bring that one on the road, then move forward to cmake as the only build system.
A big Thank You to all the people who worked on this!
[
https://issues.apache.org/jira/browse/THRIFT-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3148.
-
Resolution: Pending Closed
Assignee: Nobuaki Sukegawa
thanks!
Markdown links to
48 matches
Mail list logo
