[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-10-11 Thread Patrick Bennett (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567209#comment-15567209 ] Patrick Bennett commented on THRIFT-3855: - Looks like this was fixed already in the latest code.

Re: 0.10.0 release candidate

2016-10-11 Thread BCG
On 10/11/2016 11:13 AM, Jake Farrell wrote: Hey Ben THRIFT-2527 is in the 0.10.0 release candidate branch, 3rd commit in the log from HEAD with commit hash 548403eeab40ca8c8217fce2dade26876b41b152 -Jake My apologies, thanks Jake!

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565717#comment-15565717 ] ASF GitHub Bot commented on THRIFT-3546: Github user jfarrell commented on the issue:

[GitHub] thrift issue #1111: THRIFT-3546: Remove global namespace objects from nodejs...

2016-10-11 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/ at quick run through patch looks ok to me, @Jens-G @RandyAbernethy can either of you please review also --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-10-11 Thread Patrick Bennett (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565712#comment-15565712 ] Patrick Bennett commented on THRIFT-3855: - I just modified the generated .go code and got it

Re: 0.10.0 release candidate

2016-10-11 Thread Jake Farrell
Hey Ben THRIFT-2527 is in the 0.10.0 release candidate branch, 3rd commit in the log from HEAD with commit hash 548403eeab40ca8c8217fce2dade26876b41b152 -Jake On Tue, Oct 11, 2016 at 10:55 AM, BCG wrote: > On 10/11/2016 09:45 AM, BCG wrote: > >> On 10/11/2016 09:23 AM,

Re: 0.10.0 release candidate

2016-10-11 Thread BCG
On 10/11/2016 09:45 AM, BCG wrote: On 10/11/2016 09:23 AM, Jake Farrell wrote: Morning everyone I have a working 0.10.0 release candidate [1] which is now passing all tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been closed as well. Are there any final patches we want to see

Re: 0.10.0 release candidate

2016-10-11 Thread BCG
On 10/11/2016 09:23 AM, Jake Farrell wrote: Morning everyone I have a working 0.10.0 release candidate [1] which is now passing all tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been closed as well. Are there any final patches we want to see make it in, if not then I plan on

[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate

2016-10-11 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565413#comment-15565413 ] Jake Farrell commented on THRIFT-3775: -- My latest pull request update [1] against trunk at d6bcb26

0.10.0 release candidate

2016-10-11 Thread Jake Farrell
Morning everyone I have a working 0.10.0 release candidate [1] which is now passing all tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been closed as well. Are there any final patches we want to see make it in, if not then I plan on branching, package and start the release

[jira] [Assigned] (THRIFT-3835) Thrift generates javascript code for node js with error

2016-10-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould reassigned THRIFT-3835: -- Assignee: Benjamin Gould > Thrift generates javascript code for node js with error >

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565392#comment-15565392 ] Benjamin Gould commented on THRIFT-3546: Added to my PR to emit a "use strict" directive at the