[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1484 ---

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164729770 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164729591 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use Thrift\StringFunc\Mbstring;

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633942 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633860 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633628 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633402 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632749 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize =

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632507 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632710 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632409 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use Thrift\StringFunc\Mbstring;

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1484 TBufferedTransport must have underlying transport ref: https://issues.apache.org/jira/browse/THRIFT-4477 You can merge this pull request into a Git repository by running: $ git pull