[GitHub] thrift issue #1328: THRIFT-2221: detect C++11 and use std namespace for memo...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1328 I added a TPipe test because I changed one line of code in TPipe to work around a build issue, and I didn't see a TTransportTest test for TPipe. --- If your project is set up for it, you can reply

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121665#comment-16121665 ] ASF GitHub Bot commented on THRIFT-2221: Github user jeking3 commented on the issue:

[jira] [Updated] (THRIFT-4283) TNamedPipeServer race condition in interrupt

[ https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Noël Goor updated THRIFT-4283: --- Attachment: thrift-4283-TNamedPipeServer-race-condition.patch > TNamedPipeServer race

[jira] [Created] (THRIFT-4283) TNamedPipeServer race condition in interrupt

Jean-Noël Goor created THRIFT-4283: -- Summary: TNamedPipeServer race condition in interrupt Key: THRIFT-4283 URL: https://issues.apache.org/jira/browse/THRIFT-4283 Project: Thrift Issue

[jira] [Updated] (THRIFT-4283) TNamedPipeServer race condition in interrupt

[ https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Noël Goor updated THRIFT-4283: --- Labels: c++ (was: ) > TNamedPipeServer race condition in interrupt >

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121937#comment-16121937 ] ASF GitHub Bot commented on THRIFT-2221: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121953#comment-16121953 ] James E. King, III commented on THRIFT-2221: Okay that one was fun... :) > Generate c++ code

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121952#comment-16121952 ] ASF GitHub Bot commented on THRIFT-2221: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds

[ https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121982#comment-16121982 ] James E. King, III commented on THRIFT-3978: The following still need to be cleaned up before

[GitHub] thrift issue #1328: THRIFT-2221: detect C++11 and use std namespace for memo...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1328 The lone build failure is a "D" language/test issue that appears sporadically. All other builds passed. As such, I am going to merge this in given it was already reviewed, and the follow-on

[jira] [Updated] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2221: --- Description: Most modern compilers now have full support for std::shared_ptr when

[jira] [Commented] (THRIFT-4246) Sequence number mismatch on multiplexed clients

[ https://issues.apache.org/jira/browse/THRIFT-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122274#comment-16122274 ] ASF GitHub Bot commented on THRIFT-4246: Github user boivie commented on the issue:

[GitHub] thrift issue #1322: THRIFT-4246 Multiplexed clients sequence id fix

Github user boivie commented on the issue: https://github.com/apache/thrift/pull/1322 Thanks James. I just rebased it, but travis and AppVeyor fails from unrelated reasons. Can they be retriggered? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122386#comment-16122386 ] ASF GitHub Bot commented on THRIFT-3821: Github user asuhan commented on the issue:

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122089#comment-16122089 ] Mario Emmenlauer commented on THRIFT-2221: -- Thanks again [~jking] , super great work and its

[jira] [Resolved] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2221. Resolution: Fixed > Generate c++ code with std::shared_ptr instead of

[jira] [Updated] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2221: --- Fix Version/s: 0.11.0 Component/s: C++ - Library > Generate c++ code with

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122756#comment-16122756 ] ASF GitHub Bot commented on THRIFT-3821: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122757#comment-16122757 ] ASF GitHub Bot commented on THRIFT-3821: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1326: THRIFT-3821

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1326#discussion_r132611000 --- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp --- @@ -361,9 +361,13 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) { }

[GitHub] thrift pull request #1326: THRIFT-3821

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1326#discussion_r132611133 --- Diff: lib/cpp/test/TMemoryBufferTest.cpp --- @@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) { BOOST_CHECK_NO_THROW(buf2.write((const

[jira] [Commented] (THRIFT-4248) Compile fails - strncpy, memcmp, memset not declared in src/thrift/transport/TSSLSocket.cpp

[ https://issues.apache.org/jira/browse/THRIFT-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122758#comment-16122758 ] James E. King, III commented on THRIFT-4248: Compile fails - on what platform / environment?

[jira] [Commented] (THRIFT-4248) Compile fails - strncpy, memcmp, memset not declared in src/thrift/transport/TSSLSocket.cpp

[ https://issues.apache.org/jira/browse/THRIFT-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122765#comment-16122765 ] ASF GitHub Bot commented on THRIFT-4248: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1307: THRIFT-4248: Import cstring in TSSLSocket

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (THRIFT-4248) Compile fails - strncpy, memcmp, memset not declared in src/thrift/transport/TSSLSocket.cpp

[ https://issues.apache.org/jira/browse/THRIFT-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4248: -- Assignee: James E. King, III > Compile fails - strncpy, memcmp, memset not

[jira] [Assigned] (THRIFT-3963) Thrift.cabal filename does not match module name

[ https://issues.apache.org/jira/browse/THRIFT-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3963: -- Assignee: James E. King, III > Thrift.cabal filename does not match module

[jira] [Updated] (THRIFT-3963) Thrift.cabal filename does not match module name

[ https://issues.apache.org/jira/browse/THRIFT-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3963: --- Affects Version/s: (was: 1.0) 0.10.0 > Thrift.cabal

[GitHub] thrift pull request #1265: THRIFT-3963 Thrift.cabal filename does not match ...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3963) Thrift.cabal filename does not match module name

[ https://issues.apache.org/jira/browse/THRIFT-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122771#comment-16122771 ] ASF GitHub Bot commented on THRIFT-3963: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-3963) Thrift.cabal filename does not match module name

[ https://issues.apache.org/jira/browse/THRIFT-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3963. Resolution: Fixed Fix Version/s: 0.11.0 > Thrift.cabal filename does not

[GitHub] thrift issue #1278: THRIFT-4211: Fix logging in thrift library

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1278 Would you be able to rebase against master and push so there is one commit (just like there is now), but more importantly it will kick off a new CI build for us. Thanks. --- If your project is

[GitHub] thrift issue #1279: THRIFT-4212: Fix flush on ssl socket thrift

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1279 When THRIFT-4211 is clean in CI and merged, you will need to rebase this since it includes THRIFT-4211, and then we can get it into CI for a build then merge. Thanks. --- If your project is set

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

[ https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122773#comment-16122773 ] ASF GitHub Bot commented on THRIFT-4211: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1326: THRIFT-3821

Github user asuhan commented on a diff in the pull request: https://github.com/apache/thrift/pull/1326#discussion_r132612265 --- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp --- @@ -361,9 +361,13 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) { }

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122776#comment-16122776 ] ASF GitHub Bot commented on THRIFT-3821: Github user asuhan commented on a diff in the pull

[jira] [Commented] (THRIFT-4212) c_glib flush tries to close SSL even if socket is invalid

[ https://issues.apache.org/jira/browse/THRIFT-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122775#comment-16122775 ] ASF GitHub Bot commented on THRIFT-4212: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1326: THRIFT-3821

Github user asuhan commented on a diff in the pull request: https://github.com/apache/thrift/pull/1326#discussion_r132612556 --- Diff: lib/cpp/test/TMemoryBufferTest.cpp --- @@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) { BOOST_CHECK_NO_THROW(buf2.write((const

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122799#comment-16122799 ] ASF GitHub Bot commented on THRIFT-3821: Github user asuhan commented on a diff in the pull

[GitHub] thrift pull request #1326: THRIFT-3821

Github user asuhan commented on a diff in the pull request: https://github.com/apache/thrift/pull/1326#discussion_r132613779 --- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp --- @@ -361,9 +361,13 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) { }

[jira] [Commented] (THRIFT-4274) Python feature tests for SSL/TLS failing

[ https://issues.apache.org/jira/browse/THRIFT-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122187#comment-16122187 ] ASF GitHub Bot commented on THRIFT-4274: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1326: THRIFT-3821

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1326#discussion_r132545680 --- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp --- @@ -361,9 +361,12 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) { }

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122168#comment-16122168 ] ASF GitHub Bot commented on THRIFT-3821: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122696#comment-16122696 ] ASF GitHub Bot commented on THRIFT-3821: Github user asuhan commented on the issue:

[GitHub] thrift pull request #1321: THRIFT-4274: Catch OSError in TSSLServerSocket.ac...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #1327: make thrift error:class ‘apache::thrift::transport::TH...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1327 @jfarrell this pull request is bogus and this topic should be closed. I reproduced your issue with THeaderTransport under CentOS 6.9 and the same installation instructions. The

[GitHub] thrift issue #1323: THRIFT-3775: 0.10.0 release

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1323 @jfarrell this needs to be closed. It is invalid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate

[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122171#comment-16122171 ] ASF GitHub Bot commented on THRIFT-3775: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122170#comment-16122170 ] ASF GitHub Bot commented on THRIFT-3821: Github user jeking3 commented on the issue: