[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

2018-01-16 Thread uint
Github user uint commented on the issue: https://github.com/apache/thrift/pull/1412 @dkochmanski I confirmed I get the issue locally on SBCL 1.3.1, but 1.3.14 works fine. @jeking3 I don't think we can fix the issue with SBCL 1.3.1 (easily), as it seems like either Quicklisp

[jira] [Commented] (THRIFT-82) Common Lisp support

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326970#comment-16326970 ] ASF GitHub Bot commented on THRIFT-82: -- Github user uint commented on the issue:

[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327189#comment-16327189 ] ASF GitHub Bot commented on THRIFT-4438: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327186#comment-16327186 ] ASF GitHub Bot commented on THRIFT-4438: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56

2018-01-16 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1451#discussion_r161777001 --- Diff: build/docker/ubuntu-trusty/Dockerfile --- @@ -1,223 +0,0 @@ -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may

[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56

2018-01-16 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1451#discussion_r161777313 --- Diff: composer.json --- @@ -16,12 +16,12 @@ "issues": "https://issues.apache.org/jira/browse/THRIFT; }, "require": {

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327314#comment-16327314 ] ASF GitHub Bot commented on THRIFT-4460: Github user RobberPhex commented on the issue:

[GitHub] thrift issue #1472: THRIFT-4460: PHP Library use PSR-2

2018-01-16 Thread RobberPhex
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1472 rebased and squashed ---

[GitHub] thrift issue #1472: THRIFT-4460: PHP Library use PSR-2

2018-01-16 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1472 Rebase on master as I merged THRIFT-4459. ---

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327159#comment-16327159 ] ASF GitHub Bot commented on THRIFT-4460: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1471: THRIFT-4459: reduce php library directory depth

2018-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1471 ---

[jira] [Resolved] (THRIFT-4459) reduce php library directory depth

2018-01-16 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4459. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > reduce php

[jira] [Commented] (THRIFT-4459) reduce php library directory depth

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327158#comment-16327158 ] ASF GitHub Bot commented on THRIFT-4459: Github user asfgit closed the pull request at: