[GitHub] thrift issue #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1507 Failures seem unrelated. Should I merge or do you need to something on docker.io? ---

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400633#comment-16400633 ] ASF GitHub Bot commented on THRIFT-4516: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400644#comment-16400644 ] ASF GitHub Bot commented on THRIFT-4516: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1507 ---

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400598#comment-16400598 ] ASF GitHub Bot commented on THRIFT-4516: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1507 Go ahead and merge. After you merge, I update my fork and kick a build on my account to refresh the images. It's an optimization that saves ~10 minutes per build job. ---

[jira] [Comment Edited] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400437#comment-16400437 ] James E. King, III edited comment on THRIFT-4515 at 3/15/18 7:30 PM: -

[jira] [Comment Edited] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400437#comment-16400437 ] James E. King, III edited comment on THRIFT-4515 at 3/15/18 8:22 PM: -

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

Maybe a dumb question, but... are there some duplicate files in the way? Did you try using a fresh working copy? -Ursprüngliche Nachricht- From: Allen George Sent: Wednesday, March 14, 2018 11:05 PM To: dev@thrift.apache.org Subject: Re: Problems compiling master dotnet and csharp

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

I tried “make clean” and the problem persisted. I then went into the tutorial directory and deleted the “obj” and “bin” folders - problem solved. There must be some missing rule somewhere; either that, or I’d garbage left over from an older build. Thank you for pointing me in the right direction

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400158#comment-16400158 ] ASF GitHub Bot commented on THRIFT-4474: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1479: THRIFT-4474: generate PHP code use PSR-4 style de...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1479 ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399971#comment-16399971 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on a diff in the pull

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user ozymaxx commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174686397 --- Diff: test/DoubleConstantsTest.thrift --- @@ -0,0 +1,17 @@ +namespace java thrift.test +namespace cpp thrift.test + +// more tests on

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399974#comment-16399974 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on a diff in the pull

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user ozymaxx commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174686538 --- Diff: lib/java/gradle/unitTests.gradle --- @@ -68,6 +68,20 @@ test { include '**/Test*.class' exclude '**/Test*\$*.class' +

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399977#comment-16399977 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on a diff in the pull

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user ozymaxx commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174687128 --- Diff: test/py/RunClientServer.py --- @@ -298,7 +300,11 @@ def main(): print('') for genpydir in generated_dirs:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399976#comment-16399976 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on a diff in the pull

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user ozymaxx commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174687088 --- Diff: test/py/CMakeLists.txt --- @@ -27,7 +27,7 @@ add_test(NAME python_test_generate ) add_test(NAME python_test -COMMAND

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1634#comment-1634 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 Btw, what's the full name of the test which you want to succeed? I squashed to another commit and will take a look if this test has passed or not (I hope there is not something wrong related to my

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

I have not seen these issues; however the only docker image we currently run precross on is the ubuntu-artful image. - Jim On Wed, Mar 14, 2018 at 6:05 PM, Allen George wrote: > Hi JensG and Jim, > > You’re absolutely right - my initial message wasn't useful; I typed

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174771623 --- Diff: test/DoubleConstantsTest.thrift --- @@ -0,0 +1,17 @@ +namespace java thrift.test +namespace cpp thrift.test + +// more tests on

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400357#comment-16400357 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400334#comment-16400334 ] James E. King, III commented on THRIFT-3877: Hi, no, I set it back "to-do" because it's a

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 Need to squash to one commit, ideally, to make a merge easier, and fix the issue causing older MSVC compilers (which people still use...) to generate different floating constants than other

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400361#comment-16400361 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1480 @jeking3 This looks reasonable. Should have tests, though. ---

[jira] [Resolved] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-4474. - Resolution: Fixed Fix Version/s: 0.12.0 > PHP generator use PSR-4 default >

[jira] [Commented] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400437#comment-16400437 ] James E. King, III commented on THRIFT-4515: So far I have: * Teach C++ TestServer to ignore

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400457#comment-16400457 ] ASF GitHub Bot commented on THRIFT-4516: GitHub user dcelasun opened a pull request:

[GitHub] thrift pull request #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

GitHub user dcelasun opened a pull request: https://github.com/apache/thrift/pull/1507 THRIFT-4516: Fix "go vet" warnings for Go 1.10 Opening this here because my free Travis account has its builds killed after 50 minutes. You can merge this pull request into a Git repository by

[jira] [Updated] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4515: --- Description: The cross test suite kills the server process after the client is done,

[GitHub] thrift pull request #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1507#discussion_r174810986 --- Diff: lib/go/test/dontexportrwtest/compile_test.go --- @@ -29,10 +28,10 @@ import ( func TestReadWriteMethodsArePrivate(t *testing.T) { //

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400517#comment-16400517 ] ASF GitHub Bot commented on THRIFT-4516: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

Github user dcelasun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1507#discussion_r174812332 --- Diff: lib/go/test/dontexportrwtest/compile_test.go --- @@ -29,10 +28,10 @@ import ( func TestReadWriteMethodsArePrivate(t *testing.T) { //

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400520#comment-16400520 ] ASF GitHub Bot commented on THRIFT-4516: Github user dcelasun commented on a diff in the pull

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 Okay, I will add a condition on the tests. The values to do the assertions with will depend on the compiler. ---

[jira] [Commented] (THRIFT-4516) Add support for go 1.10

[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400513#comment-16400513 ] ASF GitHub Bot commented on THRIFT-4516: Github user jeking3 commented on a diff in the pull

[GitHub] thrift issue #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1507 I'll keep an eye on this. Right now the docker images on docker.io have to be generated manually every time they are updated, otherwise the build jobs take more time than they should. ---

[jira] [Created] (THRIFT-4519) The appveyor cygwin job is failing due to a javadoc issue

James E. King, III created THRIFT-4519: -- Summary: The appveyor cygwin job is failing due to a javadoc issue Key: THRIFT-4519 URL: https://issues.apache.org/jira/browse/THRIFT-4519 Project: Thrift

[jira] [Commented] (THRIFT-4519) The appveyor cygwin job is failing due to a javadoc issue

[ https://issues.apache.org/jira/browse/THRIFT-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400533#comment-16400533 ] James E. King, III commented on THRIFT-4519: [~Alex-Vol] if you have any time could you look

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400542#comment-16400542 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 You may be missing my point here. Regardless of the compiler used to build the thrift compiler, whether it is gcc-4.6, clang-6.0, MSVC 2010, MSVC 2013, MSVC 2017, the floating constants emitted

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400566#comment-16400566 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue: