[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098990#comment-14098990
]
Chris Thompson commented on THRIFT-1840:
This issue still exists in the latest
GitHub user cdwijayarathna opened a pull request:
https://github.com/apache/thrift/pull/191
THRIFT-2578 Moving 'make cross' from test.sh to test.py
--server attribute and --client attribute added.
Uses comma separated server and client inputs (eg: --server=cpp,py ,
[
https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099011#comment-14099011
]
ASF GitHub Bot commented on THRIFT-2578:
GitHub user cdwijayarathna opened a pull
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52356290
@bufferoverflow Added changes suggested by @zilberstein in
https://github.com/cdwijayarathna/thrift/commit/33fe8f6da989181060d4c502a27426b7d57ff046
, should I
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099119#comment-14099119
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user cdwijayarathna commented on the
Github user zilberstein commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52356546
@cdwijayarathna, you can squash your commits and then force push to the
branch
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099122#comment-14099122
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user zilberstein commented on the
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52357551
The changes within .travis.yml and contrib/installDependencies.sh are not
required.
you can do this:
{noformat}
diff --git a/lib/hs/Thrift.cabal
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099138#comment-14099138
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user bufferoverflow commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-2667.
-
Resolution: Fixed
committed
create Windows Installer via CPack
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52358462
@bufferoverflow Added suggested changes and committed. Is there anything
else I need to do for this?
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099148#comment-14099148
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user cdwijayarathna commented on the
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52358999
please fix all the white space issues
e.g contrib/installDependencies.sh and many other areas had no changes
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099154#comment-14099154
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user bufferoverflow commented on the
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52359230
You also might start using --port=${THRIFT_TEST_PORT}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52359274
I removed trailing white spaces in files I edited, do I need to undo them?
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099157#comment-14099157
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user bufferoverflow commented on the
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099159#comment-14099159
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user cdwijayarathna commented on the
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16316474
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099170#comment-14099170
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user zilberstein commented on a diff
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52360323
sorry, I did not recognized that. Perfect!
committed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099178#comment-14099178
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user bufferoverflow commented on the
Github user cdwijayarathna commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16316696
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099184#comment-14099184
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user cdwijayarathna commented on a
[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Thompson updated THRIFT-1840:
---
Attachment: fix_globals.js
For anyone else that runs into this issue, this is a quick node
[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099203#comment-14099203
]
Chris Thompson edited comment on THRIFT-1840 at 8/15/14 9:43 PM:
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16317049
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16317067
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099209#comment-14099209
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user zilberstein commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099208#comment-14099208
]
ASF GitHub Bot commented on THRIFT-847:
---
Github user zilberstein commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099227#comment-14099227
]
Roger Meier commented on THRIFT-1840:
-
Do you use namespace?
Thrift Generated Code
Roger Meier created THRIFT-2668:
---
Summary: TestSuite: detailed result on passed tests by feature
Key: THRIFT-2668
URL: https://issues.apache.org/jira/browse/THRIFT-2668
Project: Thrift
Issue
[
https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099348#comment-14099348
]
Hudson commented on THRIFT-2578:
FAILURE: Integrated in Thrift #1259 (See
See https://builds.apache.org/job/Thrift/1259/changes
Changes:
[roger] THRIFT-2578 Moving 'make cross' from test.sh to test.py
[roger] THRIFT-847 Test Framework harmonization across all languages
[roger] THRIFT-2667 create Windows Installer via CPack
[roger] THRIFT-847 Test Framework
[
https://issues.apache.org/jira/browse/THRIFT-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099350#comment-14099350
]
Hudson commented on THRIFT-2667:
FAILURE: Integrated in Thrift #1259 (See
[
https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099349#comment-14099349
]
Hudson commented on THRIFT-847:
---
FAILURE: Integrated in Thrift #1259 (See
See https://builds.apache.org/job/Thrift-Compiler-Windows/1328/changes
Changes:
[roger] THRIFT-2578 Moving 'make cross' from test.sh to test.py
[roger] THRIFT-847 Test Framework harmonization across all languages
[roger] THRIFT-2667 create Windows Installer via CPack
[roger] THRIFT-847 Test
[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099481#comment-14099481
]
Chris Thompson commented on THRIFT-1840:
The generated JavaScript code doesn't
38 matches
Mail list logo
