[
https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321706#comment-16321706
]
ASF GitHub Bot commented on THRIFT-4423:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1445
I'll watch for a passing build, and then merge tomorrow if it's good.
---
Tomorrow I plan on adding a comment to each of these pull requests and
closing them by submitting an empty commit with github directives into the
trunk. We're going to start getting more aggressive with maintaining the
pull request backlog. Things cannot sit for 3 or 4 years.
For items submitted
[
https://issues.apache.org/jira/browse/THRIFT-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4399.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> plugin.thrift
[
https://issues.apache.org/jira/browse/THRIFT-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321698#comment-16321698
]
ASF GitHub Bot commented on THRIFT-4399:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1435
---
[
https://issues.apache.org/jira/browse/THRIFT-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4399:
--
Assignee: James E. King, III
> plugin.thrift t_const_value is not used as a un
[
https://issues.apache.org/jira/browse/THRIFT-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4393.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> repeated runs
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1419
---
[
https://issues.apache.org/jira/browse/THRIFT-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4393:
--
Assignee: James E. King, III
> repeated runs of compiler produce different bin
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1418
---
Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
This patch only flxes cpp-cpp (http) failures. B/c the deeper issue is that
the Thrift cpp stack (both client & server) is nonstandard.
I think I mentioned that I could improve this a bit
[
https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321585#comment-16321585
]
ASF GitHub Bot commented on THRIFT-3877:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1418
I'm not certain this resolves THRIFT-3877 entirely - your take?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1418
Pulling this into a sandbox to see if it fixes any of the `cpp*http` known
test failures.
---
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321581#comment-16321581
]
ASF GitHub Bot commented on THRIFT-4448:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1459
Ugh, so it turns out Ubuntu Xenial comes with go 1.6 which is pretty much
the version we use on all of our CI builds for testing (like cross test).
For further details on the issue see:
[
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4443.
Resolution: Fixed
Committed - thanks!
> node.js json_protocol throws error in skip
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1460
---
[
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321578#comment-16321578
]
ASF GitHub Bot commented on THRIFT-4443:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4443:
--
Assignee: James E. King, III
> node.js json_protocol throws error in skip func
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321571#comment-16321571
]
ASF GitHub Bot commented on THRIFT-4447:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1461
---
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4447.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> Golang: Panic
[
https://issues.apache.org/jira/browse/THRIFT-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321565#comment-16321565
]
ASF GitHub Bot commented on THRIFT-4446:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4447:
--
Assignee: James E. King, III
> Golang: Panic on p.c.Call when using deprecated
[
https://issues.apache.org/jira/browse/THRIFT-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4446.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> JSONProtocol
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1463
---
[
https://issues.apache.org/jira/browse/THRIFT-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4446:
--
Assignee: James E. King, III
> JSONProtocol Base64 Encoding Trims Padding
> --
[
https://issues.apache.org/jira/browse/THRIFT-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4450.
Resolution: Fixed
Committed - thanks!
> Add seek support to TCompactInputProtocol
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1462
---
[
https://issues.apache.org/jira/browse/THRIFT-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321550#comment-16321550
]
ASF GitHub Bot commented on THRIFT-4450:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1462
I opened THRIFT-4450 in Apache Jira for this issue.
In the future please begin by opening a Jira ticket and then prepend the
ticket name to the title of your pull request so that they are co
James E. King, III created THRIFT-4450:
--
Summary: Add seek support to TCompactInputProtocol in Rust
Key: THRIFT-4450
URL: https://issues.apache.org/jira/browse/THRIFT-4450
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321531#comment-16321531
]
ASF GitHub Bot commented on THRIFT-4448:
Github user johnboiles commented on the
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1459
Sounds good want me to take a stab at dropping 1.6 support?
---
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321509#comment-16321509
]
Buğra Gedik commented on THRIFT-4413:
-
Thanks for keeping this alive. [~jfarrell]: Co
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
[
https://issues.apache.org/jira/browse/THRIFT-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
boxcppguy updated THRIFT-4449:
--
Description:
What we observed is, when using the C# implementation TNamedPipeServerTransport
along wit
boxcppguy created THRIFT-4449:
-
Summary: C# - TNamedPipeServerTransport.AcceptImpl can block
indefinitely if TNamedPipeServerTransport.Close is called too quickly
Key: THRIFT-4449
URL: https://issues.apache.org/jira/b
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321459#comment-16321459
]
ASF GitHub Bot commented on THRIFT-4447:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1461
The reasoning for this is that Apache maintains its own master repository;
so pull requests here have to be pulled into the master by a committer, and
then the github mirror updates. If the commit
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321449#comment-16321449
]
James E. King, III edited comment on THRIFT-4413 at 1/11/18 12:30 AM:
-
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321449#comment-16321449
]
James E. King, III commented on THRIFT-4413:
I have a slack communication fro
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321447#comment-16321447
]
ASF GitHub Bot commented on THRIFT-4448:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1459
At this point we should consider dropping go 1.6. Other go projects have
moved on and we can too. I had a discussion with someone about whether it
makes sense to support older go versions, and the
[
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321444#comment-16321444
]
ASF GitHub Bot commented on THRIFT-4390:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1458
Sure - I like progress. :)
---
[
https://issues.apache.org/jira/browse/THRIFT-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321438#comment-16321438
]
ASF GitHub Bot commented on THRIFT-4295:
Github user jeking3 commented on a diff
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1340#discussion_r160835825
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -242,8 +242,10 @@ public function open()
throw new TException($error);
}
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321166#comment-16321166
]
ASF GitHub Bot commented on THRIFT-4447:
Github user johnboiles commented on the
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
> For Thrift, PRs are not merged, just closed. You'll see a commit with you
as the author but someone else as the committer, like these.
Ah got it, good to know thanks!
---
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321096#comment-16321096
]
ASF GitHub Bot commented on THRIFT-4447:
Github user dcelasun commented on the is
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
> GitHub can now automatically squash commits in PRs at merge time
For Thrift, PRs are not merged, just closed. You'll see a commit with you
as the author but someone else as the committer,
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321089#comment-16321089
]
ASF GitHub Bot commented on THRIFT-4447:
Github user johnboiles commented on the
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
Travis was green so i've squashed it!
FYI for the future: GitHub can now automatically squash commits in PRs at
merge time. If that feature is enabled for the repo it shouldn't be necessa
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320807#comment-16320807
]
ASF GitHub Bot commented on THRIFT-4447:
Github user dcelasun commented on the is
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
Happy to help. Once Travis is all green, please squash your commits so
it'll be easier to merge.
---
[
https://issues.apache.org/jira/browse/THRIFT-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320722#comment-16320722
]
ASF GitHub Bot commented on THRIFT-4447:
Github user johnboiles commented on the
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
Done ^. Thanks again for all your direction Dcelasun
---
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320434#comment-16320434
]
Volodymyr Gotra commented on THRIFT-4434:
-
Hey
It seem it works well now (checke
66 matches
Mail list logo
