[
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338468#comment-16338468
]
Robert Lu commented on THRIFT-4474:
---
Maybe this is a break change.
The code generated by old thrift
[
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338457#comment-16338457
]
ASF GitHub Bot commented on THRIFT-4474:
GitHub user RobberPhex opened a pull request:
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1479
THRIFT-4474: generate PHP code use PSR-4 style default
ref: https://issues.apache.org/jira/browse/THRIFT-4474
You can merge this pull request into a Git repository by running:
$ git pull
Robert Lu created THRIFT-4474:
-
Summary: PHP generator use PSR-4 default
Key: THRIFT-4474
URL: https://issues.apache.org/jira/browse/THRIFT-4474
Project: Thrift
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338247#comment-16338247
]
ASF GitHub Bot commented on THRIFT-4308:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/723
See https://issues.apache.org/jira/browse/THRIFT-4308
Essentially the upstream deimos modules for openssl and libevent no longer
work, and we need to move to something else for secure and
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163681677
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163679874
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
close();
}
+bool
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163673632
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
close();
}
+bool
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
Ok, reverted back.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163663375
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
close();
}
+bool
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163664502
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163663584
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
close();
}
+bool
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1476
I see now, I may have led you down the wrong path with my comments. So
peek() blocks waiting for data the be available to read and the end result of
peek is that there is data to read OR the
[
https://issues.apache.org/jira/browse/THRIFT-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4471.
Resolution: Fixed
Fix Version/s: 0.12.0
I fixed the build script and
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163651048
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163640014
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
[
https://issues.apache.org/jira/browse/THRIFT-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338018#comment-16338018
]
ASF GitHub Bot commented on THRIFT-4473:
GitHub user Jens-G opened a pull request:
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1478
THRIFT-4473 Move Thrift.Console.pas out of the Library
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/THRIFT-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4473:
---
Component/s: Delphi - Library
> Move Thrift.Console.pas out of the Library
>
[
https://issues.apache.org/jira/browse/THRIFT-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4468:
---
Issue Type: Sub-task (was: Improvement)
Parent: THRIFT-4473
> Make the class TGUIConsole
[
https://issues.apache.org/jira/browse/THRIFT-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4467:
---
Issue Type: Sub-task (was: Improvement)
Parent: THRIFT-4473
> Add methods
[
https://issues.apache.org/jira/browse/THRIFT-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-4473:
--
Assignee: Jens Geyer
> Move Thrift.Console.pas out of the Library
>
Jens Geyer created THRIFT-4473:
--
Summary: Move Thrift.Console.pas out of the Library
Key: THRIFT-4473
URL: https://issues.apache.org/jira/browse/THRIFT-4473
Project: Thrift
Issue Type:
[
https://issues.apache.org/jira/browse/THRIFT-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337967#comment-16337967
]
James E. King, III commented on THRIFT-4471:
How can I test a package that I build locally
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
@Jens-G what do you think about the notion of moving the definition of
error message enumerations into a single common .thrift file that gets compiled
and then comsumed by the libraries? It would
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163623295
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163622772
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
[
https://issues.apache.org/jira/browse/THRIFT-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4294.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
[
https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4259.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
[
https://issues.apache.org/jira/browse/THRIFT-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4178.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
[
https://issues.apache.org/jira/browse/THRIFT-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4120.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
[
https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3983.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
[
https://issues.apache.org/jira/browse/THRIFT-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-1507.
Resolution: Fixed
Assignee: James E. King, III (was: Jake Farrell)
[
https://issues.apache.org/jira/browse/THRIFT-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-1418.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
Github user nrTQgc commented on the issue:
https://github.com/apache/thrift/pull/723
I replaced dub.sdl with dub.json and fixed deprecation warnings. Can you
explain issues with current versions of openssl and libevent? What options we
have?
---
Github user Typz commented on the issue:
https://github.com/apache/thrift/pull/1448
Indeed, it is complete now: the lib can be built without Boost, both
through autoconf or cmake.
Tests (based on boost test) and tutorial still require boost, though.
---
37 matches
Mail list logo
