[GitHub] thrift pull request #1497: Do not call workSocket() in TNonblockigServer wit...

2018-03-06 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1497#discussion_r172754060 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -472,6 +472,18 @@ void TNonblockingServer::TConnection::workSocket() { }

[GitHub] thrift pull request #1497: Do not call workSocket() in TNonblockigServer wit...

2018-03-06 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1497#discussion_r172752961 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -472,6 +472,18 @@ void TNonblockingServer::TConnection::workSocket() { }

[jira] [Commented] (THRIFT-4510) Regression in 0.11: Arrays with default values in python

2018-03-06 Thread Jason Gauci (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388791#comment-16388791 ] Jason Gauci commented on THRIFT-4510: - Cool, here's a stack trace if you need one: 

[jira] [Commented] (THRIFT-4510) Regression in 0.11: Arrays with default values in python

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388771#comment-16388771 ] James E. King, III commented on THRIFT-4510: Thanks, we need to root cause the regression. >

[jira] [Created] (THRIFT-4510) Regression in 0.11: Arrays with default values in python

2018-03-06 Thread Jason Gauci (JIRA)
Jason Gauci created THRIFT-4510: --- Summary: Regression in 0.11: Arrays with default values in python Key: THRIFT-4510 URL: https://issues.apache.org/jira/browse/THRIFT-4510 Project: Thrift

[jira] [Commented] (THRIFT-4480) NodeJS warning on binary_protocol writeMessageEnd when seqid = 0

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388706#comment-16388706 ] ASF GitHub Bot commented on THRIFT-4480: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1487: THRIFT-4480 - Handle seqid = 0

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1487 ---

[jira] [Assigned] (THRIFT-4480) NodeJS warning on binary_protocol writeMessageEnd when seqid = 0

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4480: -- Assignee: James E. King, III > NodeJS warning on binary_protocol

[GitHub] thrift pull request #1497: Do not call workSocket() in TNonblockigServer wit...

2018-03-06 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1497#discussion_r172695014 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -472,6 +472,18 @@ void TNonblockingServer::TConnection::workSocket() { }

[GitHub] thrift pull request #1497: Do not call workSocket() in TNonblockigServer wit...

2018-03-06 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1497#discussion_r172694884 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -472,6 +472,18 @@ void TNonblockingServer::TConnection::workSocket() { }

[GitHub] thrift issue #1495: THRIFT-4497: Use map() field type for Erlang type for ma...

2018-03-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1495 Hi, please rebase this on the current master and force push to kick a new build - I think the CI build environment is stable again. ---

[jira] [Commented] (THRIFT-4497) Erlang records should use map() for map type

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388697#comment-16388697 ] ASF GitHub Bot commented on THRIFT-4497: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388696#comment-16388696 ] ASF GitHub Bot commented on THRIFT-4495: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1494: THRIFT-4495: Allow `undefined` for non-required Erlang r...

2018-03-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1494 Hi, please rebase this on the current master and force push to kick a new build - I think the CI build environment is stable again. ---

[jira] [Resolved] (THRIFT-4508) Define CI operating system coverage rules for the project and (hopefully) simplify CI a little more

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4508. Resolution: Fixed Fix Version/s: 0.12.0 > Define CI operating system

[jira] [Commented] (THRIFT-4482) error making c++ library on windows 8.1 using cygwin

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388576#comment-16388576 ] James E. King, III commented on THRIFT-4482: Once THRIFT-4508 is cleared out I can run a

[jira] [Assigned] (THRIFT-4482) error making c++ library on windows 8.1 using cygwin

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4482: -- Assignee: James E. King, III > error making c++ library on windows 8.1 using

[jira] [Closed] (THRIFT-748) C++ TSocket default linger setting breaks forked parent process

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-748. - Resolution: Won't Fix Assignee: James E. King, III In light of the resolution of

[jira] [Updated] (THRIFT-4508) Define CI operating system coverage rules for the project and (hopefully) simplify CI a little more

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4508: --- Description: Currently we build on three linux operating system levels in CI in

[jira] [Closed] (THRIFT-4479) Enhance Windows CI build with 32/64 cygwin/mingw builds like in Boost.Format

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4479. -- Resolution: Duplicate > Enhance Windows CI build with 32/64 cygwin/mingw builds like

[jira] [Closed] (THRIFT-4369) Upgrade Thrift for Node.js with ws new version

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4369. -- Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0

[jira] [Closed] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-3485. -- Resolution: Fixed Assignee: Jake Farrell Fix Version/s: 0.11.0 I

[jira] [Closed] (THRIFT-4427) Thrift 0.11 is not available on npm

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4427. -- > Thrift 0.11 is not available on npm > --- > >

[jira] [Resolved] (THRIFT-4427) Thrift 0.11 is not available on npm

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4427. Resolution: Fixed Fix Version/s: 0.11.0 0.11.0 is available on npm when I

[jira] [Updated] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4509: --- Description: The npm libraries that our js and nodejs depend on are starting to go

[jira] [Created] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

2018-03-06 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4509: -- Summary: js and nodejs libraries need to be refreshed with current libraries Key: THRIFT-4509 URL: https://issues.apache.org/jira/browse/THRIFT-4509

[jira] [Commented] (THRIFT-4507) TWaitableNamedPipeImpl::read race condition can cause hang in ~TWaitableNamedPipeImpl

2018-03-06 Thread Jeremy Spiegel (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388018#comment-16388018 ] Jeremy Spiegel commented on THRIFT-4507: I haven't determined what the right fix is yet. I was

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387992#comment-16387992 ] ASF GitHub Bot commented on THRIFT-4489: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1491 If you haven't seen it I recommend reading `build/docker/README.md` and use the `ubuntu-artful` image to run a cross test with `build/docker/scripts/cross-test.sh` inside the docker container.

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387984#comment-16387984 ] ASF GitHub Bot commented on THRIFT-4489: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1491 The presence of "--domain-socket" to the client or server implies uds. This needs to be fixed, and domain needs to be moved from haskell to nodejs, and the cross tests that are failing (many) in

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387972#comment-16387972 ] ASF GitHub Bot commented on THRIFT-4489: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1491: THRIFT-4489: Add UDS support for nodejs thrift cl...

2018-03-06 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1491#discussion_r172557523 --- Diff: test/tests.json --- @@ -221,7 +221,8 @@ "framed" ], "sockets": [ - "ip" + "ip", + "domain"

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387961#comment-16387961 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387962#comment-16387962 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx closed the pull request at:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-06 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 Okay, I will open it back once I am done. ---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-06 Thread ozymaxx
Github user ozymaxx closed the pull request at: https://github.com/apache/thrift/pull/1496 ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387956#comment-16387956 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 Sourceforge was down for a while. I am working on getting the builds back to green (passing). I recommend that you keep your pull request squashed to one commit. In fact since you are doing

[jira] [Assigned] (THRIFT-4504) Use dlang native build and package manager (dub) for builds

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4504: -- Assignee: (was: James E. King, III) > Use dlang native build and package

[jira] [Commented] (THRIFT-4354) TSocket block on read

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387895#comment-16387895 ] ASF GitHub Bot commented on THRIFT-4354: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4354) TSocket block on read

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4354. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > TSocket

[GitHub] thrift pull request #1384: THRIFT-4354 TSocket block on read

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1384 ---

[jira] [Commented] (THRIFT-4488) Performance impact of Nagle disabled

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387838#comment-16387838 ] James E. King, III commented on THRIFT-4488: I am not aware of an issue in this area; it's

[jira] [Commented] (THRIFT-4507) TWaitableNamedPipeImpl::read race condition can cause hang in ~TWaitableNamedPipeImpl

2018-03-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387817#comment-16387817 ] James E. King, III commented on THRIFT-4507: Thanks for reporting this with a working

[jira] [Created] (THRIFT-4508) Define CI operating system coverage rules for the project and (hopefully) simplify CI a little more

2018-03-06 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4508: -- Summary: Define CI operating system coverage rules for the project and (hopefully) simplify CI a little more Key: THRIFT-4508 URL: