[jira] [Commented] (THRIFT-4546) Thrift No Longer on ASF Git

2018-12-27 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729696#comment-16729696 ] Robert Lu commented on THRIFT-4546: --- There are many "git-wip-us.apache.org" in the repositor

[jira] [Commented] (THRIFT-4576) PHP: untracked dependency: composer

2018-06-06 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504215#comment-16504215 ] Robert Lu commented on THRIFT-4576: --- [composer|https://getcomposer.org/] in php likes npm in node

Re: CI Build Status for Thrift

2018-03-02 Thread Robert Lu
Hi, Could we switch to https://github.com/Microsoft/vcpkg? -- Robert Lu On 3/1/18 11:38, James E. King, III wrote: Appveyor builds are not working. The build scripts use chocolatey to install some tools like winflexbison for MSVC builds, and that chocolatey package is currently broken

[jira] [Created] (THRIFT-4498) add phpcs back

2018-02-22 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4498: - Summary: add phpcs back Key: THRIFT-4498 URL: https://issues.apache.org/jira/browse/THRIFT-4498 Project: Thrift Issue Type: Improvement Components: PHP

[jira] [Created] (THRIFT-4477) TBufferedTransport must have underlying transport

2018-01-29 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4477: - Summary: TBufferedTransport must have underlying transport Key: THRIFT-4477 URL: https://issues.apache.org/jira/browse/THRIFT-4477 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-4475) lib/php/test should be checked for PSR-2

2018-01-25 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4475: - Summary: lib/php/test should be checked for PSR-2 Key: THRIFT-4475 URL: https://issues.apache.org/jira/browse/THRIFT-4475 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

2018-01-24 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338468#comment-16338468 ] Robert Lu commented on THRIFT-4474: --- Maybe this is a break change. The code generated by old thrift

[jira] [Created] (THRIFT-4474) PHP generator use PSR-4 default

2018-01-24 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4474: - Summary: PHP generator use PSR-4 default Key: THRIFT-4474 URL: https://issues.apache.org/jira/browse/THRIFT-4474 Project: Thrift Issue Type: Improvement

[jira] [Closed] (THRIFT-4438) require php ^5.6 || ^7.0

2018-01-23 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu closed THRIFT-4438. - Resolution: Not A Problem > require php ^5.6 || ^7.0 > > >

[jira] [Updated] (THRIFT-4463) PHP generated code match PSR-2

2018-01-17 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4463: -- Description: When use thrift compiler to generate PHP code, there are many issues doesn't match [PSR

[jira] [Created] (THRIFT-4463) PHP generated code match PSR-2

2018-01-17 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4463: - Summary: PHP generated code match PSR-2 Key: THRIFT-4463 URL: https://issues.apache.org/jira/browse/THRIFT-4463 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-4460) php library use PSR-2

2018-01-15 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4460: - Summary: php library use PSR-2 Key: THRIFT-4460 URL: https://issues.apache.org/jira/browse/THRIFT-4460 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-11 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4452: - Summary: optimize Dockerfile (only onetime apt-get update) Key: THRIFT-4452 URL: https://issues.apache.org/jira/browse/THRIFT-4452 Project: Thrift Issue Type

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

2017-12-24 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303096#comment-16303096 ] Robert Lu commented on THRIFT-4423: --- [~jking3] Is the `Thrift` folder necessary? If you have any

[jira] [Commented] (THRIFT-4119) bootstrap.sh is missing from the source tarball

2017-12-14 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291982#comment-16291982 ] Robert Lu commented on THRIFT-4119: --- [~ctubbsii] I haven't permission to plan this change, and I

[jira] [Updated] (THRIFT-4119) bootstrap.sh is missing from the source tarball

2017-12-14 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4119: -- Affects Version/s: 0.11.0 > bootstrap.sh is missing from the source tarb

[jira] [Created] (THRIFT-4425) Publish Thrift v0.11 to packagist.org

2017-12-13 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4425: - Summary: Publish Thrift v0.11 to packagist.org Key: THRIFT-4425 URL: https://issues.apache.org/jira/browse/THRIFT-4425 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

2017-12-13 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290248#comment-16290248 ] Robert Lu commented on THRIFT-4423: --- [~jking3] The directory is too deep to navigate. Before

[jira] [Updated] (THRIFT-4423) migrate php library to psr-4

2017-12-13 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4423: -- External issue URL: https://github.com/apache/thrift/pull/1445 > migrate php library to ps

[jira] [Created] (THRIFT-4423) migrate php library to psr-4

2017-12-13 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4423: - Summary: migrate php library to psr-4 Key: THRIFT-4423 URL: https://issues.apache.org/jira/browse/THRIFT-4423 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-4374) cannot load thrift_protocol due to undefined symbol: _ZTVN10__cxxabiv120__si_class_type_infoE

2017-10-26 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4374: - Summary: cannot load thrift_protocol due to undefined symbol: _ZTVN10__cxxabiv120__si_class_type_infoE Key: THRIFT-4374 URL: https://issues.apache.org/jira/browse/THRIFT-4374

[jira] [Commented] (THRIFT-577) Factor BinaryProtocolAccelerated into separate components

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220009#comment-16220009 ] Robert Lu commented on THRIFT-577: -- The fastbinary.c is already move to lib/py/src/ext/ by THRIFT-3612

[jira] [Commented] (THRIFT-515) Having the same namespace in separate thrift files generates non-working code

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219997#comment-16219997 ] Robert Lu commented on THRIFT-515: -- As discussed above, This is not a bug. Please close this. > Hav

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219284#comment-16219284 ] Robert Lu commented on THRIFT-4356: --- [~danielsmithsd] Thanks for your feedback, I submit a PR: https

[jira] [Commented] (THRIFT-4271) warning: 'register' storage class is deprecated

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219228#comment-16219228 ] Robert Lu commented on THRIFT-4271: --- When you build thrift_prototcol php extension, after run phpize

[jira] [Commented] (THRIFT-496) Pure python reader/writer

2017-10-24 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216704#comment-16216704 ] Robert Lu commented on THRIFT-496: -- accelerated python compact protocol is implemented by THRIFT-3612

[jira] [Commented] (THRIFT-4168) Travis CI builds are being triggered by apache master pushes

2017-10-24 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216680#comment-16216680 ] Robert Lu commented on THRIFT-4168: --- [~jking3] I think CI at master is a indicator of health of branch

Re: PR to remove PHP5 support

2017-10-23 Thread Robert Lu
Hi, PHP library is still support PHP5 and PHP7 (>=5.3.0). but, PHP extension (thrift_protocol) will just support PHP7, doesn't support PHP5. -- Robert Lu On 10/24/17 11:16, James E. King, III wrote: Hi folks, There is a PR on the table that will remove PHP5 support in favor of P

[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2017-10-23 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216225#comment-16216225 ] Robert Lu commented on THRIFT-4037: --- Personally, I'd like to migrate to cmake. But, I haven't

Re: ant -Drelease=true publish failed

2017-10-20 Thread Robert Lu
ific version of maven 'org.apache.maven.plugins:maven-gpg-plugin': > Plugin requires Maven version 2.2.1 where you are currently running 3.5.0. > Have you tried building with Maven 2.2.1? > > -Jake > > On Mon, Oct 16, 2017 at 2:41 AM, Robert Lu <robberp...@gmail.com> wrote: &g

[jira] [Comment Edited] (THRIFT-3983) libthrift is deployed on central with pom packaging instead of jar

2017-10-16 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205480#comment-16205480 ] Robert Lu edited comment on THRIFT-3983 at 10/16/17 7:03 AM: - Hi, [~jking3

[jira] [Commented] (THRIFT-3983) libthrift is deployed on central with pom packaging instead of jar

2017-10-16 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205480#comment-16205480 ] Robert Lu commented on THRIFT-3983: --- Hi, [~jking3] Defiantly it's not right at [lib/java/build.xml

ant -Drelease=true publish failed

2017-10-16 Thread Robert Lu
e: "mac os x", version: "10.13.1", arch: "x86_64", family: "mac" Does anyone know why it's failed? Thank you in advance! -- Robert Lu <robberp...@gmail.com> About me: http://about.me/RobberPhex

[jira] [Commented] (THRIFT-4119) bootstrap.sh is missing from the source tarball

2017-10-10 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198462#comment-16198462 ] Robert Lu commented on THRIFT-4119: --- [~ctubbsii] Well, I agree with you. [~jfarrell] Talk about

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-09 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198033#comment-16198033 ] Robert Lu commented on THRIFT-4356: --- [~jfarrell] The root cause is extension call user function

[jira] [Commented] (THRIFT-4354) TSocket block on read

2017-10-09 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198031#comment-16198031 ] Robert Lu commented on THRIFT-4354: --- [~jfarrell] I think it's a simple fix. Is there any problem

[jira] [Created] (THRIFT-4361) cannot serialize set<map<i32, i64> > via extension

2017-10-09 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4361: - Summary: cannot serialize set<map<i32, i64> > via extension Key: THRIFT-4361 URL: https://issues.apache.org/jira/browse/THRIFT-4361 Project: Thrift

[jira] [Commented] (THRIFT-4271) warning: 'register' storage class is deprecated

2017-10-08 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196461#comment-16196461 ] Robert Lu commented on THRIFT-4271: --- Firstly, I don't think this is a Major bug. And, the "'reg

[jira] [Updated] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-04 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4356: -- Environment: PHP 7.0.23 (cli) (built: Sep 25 2017 08:07:30) ( NTS ) macOS 10.13.1 Beta (17B25c

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-04 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191493#comment-16191493 ] Robert Lu commented on THRIFT-4356: --- How to reproduce: {code} git clone https://github.com/RobberPhex

[jira] [Created] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-04 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4356: - Summary: thrift_protocol call Transport cause Segmentation fault Key: THRIFT-4356 URL: https://issues.apache.org/jira/browse/THRIFT-4356 Project: Thrift Issue

[jira] [Closed] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

2017-10-04 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu closed THRIFT-3845. - Resolution: Won't Fix > TBinaryProtocolAccelerated cannot use thrift_protocol

[jira] [Created] (THRIFT-4354) TSocket block on read

2017-10-03 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4354: - Summary: TSocket block on read Key: THRIFT-4354 URL: https://issues.apache.org/jira/browse/THRIFT-4354 Project: Thrift Issue Type: Bug Components: PHP

[jira] [Updated] (THRIFT-4354) TSocket block on read

2017-10-03 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4354: -- Description: When \Thrift\Transport\TSocket::read is called, it will block until receive $len byte

[jira] [Created] (THRIFT-4353) cannot read via thrift_protocol at server side

2017-10-03 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4353: - Summary: cannot read via thrift_protocol at server side Key: THRIFT-4353 URL: https://issues.apache.org/jira/browse/THRIFT-4353 Project: Thrift Issue Type

[jira] [Commented] (THRIFT-4119) bootstrap.sh is missing from the source tarball

2017-09-29 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186879#comment-16186879 ] Robert Lu commented on THRIFT-4119: --- *Can you give the download link which you used?* I tried download

[jira] [Updated] (THRIFT-4034) CMake doesn't work to build compiler

2017-01-19 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4034: -- External issue URL: https://github.com/apache/thrift/pull/1161 > CMake doesn't work to build compi

[jira] [Created] (THRIFT-4034) CMake doesn't work to build compiler

2017-01-19 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4034: - Summary: CMake doesn't work to build compiler Key: THRIFT-4034 URL: https://issues.apache.org/jira/browse/THRIFT-4034 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-08-01 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401584#comment-15401584 ] Robert Lu commented on THRIFT-3844: --- [~jfarrell] If there is something bad in this issue, please commit

[jira] [Commented] (THRIFT-3846) thriftClient connect some thriftServers cause IOException.

2016-06-02 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312740#comment-15312740 ] Robert Lu commented on THRIFT-3846: --- You'd better debug in server, First, you can debug in process

[jira] [Created] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

2016-05-31 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-3845: - Summary: TBinaryProtocolAccelerated cannot use thrift_protocol ext Key: THRIFT-3845 URL: https://issues.apache.org/jira/browse/THRIFT-3845 Project: Thrift Issue

[jira] [Commented] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-05-31 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307914#comment-15307914 ] Robert Lu commented on THRIFT-3844: --- There is my pr [https://github.com/apache/thrift/pull/1021

[jira] [Created] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-05-31 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-3844: - Summary: thrift_protocol cannot compile in 7.0.7 Key: THRIFT-3844 URL: https://issues.apache.org/jira/browse/THRIFT-3844 Project: Thrift Issue Type: Bug