[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833017#comment-15833017
]
James E. King, III commented on THRIFT-3013:
I understand where folks are coming from, so
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832918#comment-15832918
]
Jens Geyer commented on THRIFT-3013:
[~jking3], when cmake is able to create an VCSPROJ for the
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832913#comment-15832913
]
Jens Geyer commented on THRIFT-3013:
{quote}
Also FWIW I actually appreciate how simple it is to
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832772#comment-15832772
]
Benjamin Gould commented on THRIFT-3013:
FWIW I use the technique of creating a single file that
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738185#comment-14738185
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi [~jfarrell], I prefer to a whole option parser because
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599438#comment-14599438
]
Jake Farrell commented on THRIFT-3013:
--
+1 to reducing dependencies and keeping dev
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528407#comment-14528407
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi [~roger.meier], new ticket
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526139#comment-14526139
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi [~roger.meier], thanks for your
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521786#comment-14521786
]
Roger Meier commented on THRIFT-3013:
-
Patch looks good, thanks!
Personally I would
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504945#comment-14504945
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi [~roger.meier], would you mind trying
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14496874#comment-14496874
]
Roger Meier commented on THRIFT-3013:
-
Do you have all languages enabled? It still
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497522#comment-14497522
]
Xiaoshuang LU commented on THRIFT-3013:
---
No, I do not enable all the languages.
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497523#comment-14497523
]
Xiaoshuang LU commented on THRIFT-3013:
---
No, I do not enable all the languages.
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495966#comment-14495966
]
Xiaoshuang LU commented on THRIFT-3013:
---
[~roger.meier], thank you very much. I
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493918#comment-14493918
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi [~roger.meier], any comments on my
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495704#comment-14495704
]
Roger Meier commented on THRIFT-3013:
-
Thanks [~in-chief]
patch v2 looks good nice,
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487595#comment-14487595
]
James E. King, III commented on THRIFT-3013:
I see no reason to shy away from
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486752#comment-14486752
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi James, thanks for your comments.
I
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485984#comment-14485984
]
James E. King, III commented on THRIFT-3013:
How about switching to
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486500#comment-14486500
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi guys, thrift compiler does not rely on
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486506#comment-14486506
]
Xiaoshuang LU commented on THRIFT-3013:
---
I think the reason why Roger leverages
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486316#comment-14486316
]
Roger Meier commented on THRIFT-3013:
-
Good point Jim!
I introduced
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486702#comment-14486702
]
James E. King, III commented on THRIFT-3013:
Interesting - I thought that the
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486751#comment-14486751
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi James, thanks for your comments.
I
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484537#comment-14484537
]
Xiaoshuang LU commented on THRIFT-3013:
---
Hi Roger, I share your opinion. But I am
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394359#comment-14394359
]
Xiaoshuang LU commented on THRIFT-3013:
---
This patch is based on the assumption that
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352432#comment-14352432
]
John Wang commented on THRIFT-3013:
---
Jens, thanks for yours recommendation. What about
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345559#comment-14345559
]
Jens Geyer commented on THRIFT-3013:
Hi,
say, you have 2 Thrift IDL files, like with
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341792#comment-14341792
]
Jens Geyer commented on THRIFT-3013:
Pro Tip: If the files are included into each
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341929#comment-14341929
]
John Wang commented on THRIFT-3013:
---
Hi Jens, thanks for your comments. But I am not
30 matches
Mail list logo
