[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399624#comment-16399624 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...

2018-03-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/802 I haven't looked at this in detail yet, but is your intent to see this merged before we release 3.2.8/3.3.2? Personally, I'd like to see it wait until a following release so that we don't need

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399588#comment-16399588 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...

2018-03-14 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/802 Thanks @spmallette, that actually looks like a good solution. I just pushed a commit that uses this solution. This not only allows skipping of `docker push` for SNAPSHOT versions,

[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399217#comment-16399217 ] ASF GitHub Bot commented on TINKERPOP-1854: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net

2018-03-14 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/792 I just rebased on `tp32` and hopefully also addressed your suggestions. `Lambda` now implements a bunch of interfaces that mirror the Java functional interfaces from the traversal API:

Re: [DISCUSS] JIRA Issues in Commits

2018-03-14 Thread Stephen Mallette
We put it on the pull request headers, but those don't make it into the commit logs. I'd like it in the commit message itself in addition to the PR title. I don't think we have any such policy in the dev docs at this point beyond the requirement for the PR. On Wed, Mar 14, 2018 at 11:59 AM,

Re: [DISCUSS] JIRA Issues in Commits

2018-03-14 Thread Robert Dale
I thought we already did that except for merges and CTRs. Did you want to include it in all commit messages? Or is it to formalize it in the Developer Docs? Robert Dale On Wed, Mar 14, 2018 at 11:54 AM, Stephen Mallette wrote: > I tend to tie my commits to JIRA by

[DISCUSS] JIRA Issues in Commits

2018-03-14 Thread Stephen Mallette
I tend to tie my commits to JIRA by prefixing the first line of my commit with the JIRA ticket to which it applies. How does everyone feel about following that pattern? I hate to institute extra stuff on folks, but for various reasons I spend time in commit logs and there are times when I have the

Re: [DISCUSS] Drop support for Giraph in 3.4.0

2018-03-14 Thread Ted Wilmes
I agree, I think it's a good idea to remove it. I haven't ever run into anyone using the GiraphGraphComputer. --Ted On Wed, Mar 14, 2018 at 3:03 AM, Jorge Bay Gondra wrote: > I'm +1 on removing support for Giraph. > > We should try to simplify the build as much as

[jira] [Commented] (TINKERPOP-1896) gremlin-python lambdas error

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398485#comment-16398485 ] ASF GitHub Bot commented on TINKERPOP-1896: --- Github user asfgit closed the pull request at:

[jira] [Closed] (TINKERPOP-1896) gremlin-python lambdas error

2018-03-14 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1896. --- Resolution: Fixed > gremlin-python lambdas error > >

[GitHub] tinkerpop pull request #814: TINKERPOP-1896 Fixed bug in lambda processing f...

2018-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/814 ---

[jira] [Commented] (TINKERPOP-1914) Support construct a GremlinServer instance from gremlin executor service

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398444#comment-16398444 ] ASF GitHub Bot commented on TINKERPOP-1914: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #813: TINKERPOP-1914 Support construct a GremlinServer insta...

2018-03-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/813 i think this is ok to add back. i obviously never factored out the underlying ability to pass that service to the `ServerGremlinExecutor` so I think it might be ok to allow it to be passed in

[GitHub] tinkerpop pull request #:

2018-03-14 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/tinkerpop/commit/bccff988dc713b9acdee9e9a3858e2c10b7de163#commitcomment-28084039 In gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java:

[GitHub] tinkerpop pull request #:

2018-03-14 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/tinkerpop/commit/bccff988dc713b9acdee9e9a3858e2c10b7de163#commitcomment-28083988 In gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Traversal.java: In

[jira] [Commented] (TINKERPOP-1923) Intermittent NegativeArraySizeException on drop

2018-03-14 Thread James Baker (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398297#comment-16398297 ] James Baker commented on TINKERPOP-1923: I take that back, I've just observed it happening in

[jira] [Commented] (TINKERPOP-1923) Intermittent NegativeArraySizeException on drop

2018-03-14 Thread James Baker (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398272#comment-16398272 ] James Baker commented on TINKERPOP-1923: This could be a OpenJDK bug. It happens in OpenJDK

Re: [DISCUSS] Drop support for Giraph in 3.4.0

2018-03-14 Thread Jorge Bay Gondra
I'm +1 on removing support for Giraph. We should try to simplify the build as much as possible and this integration doesn't seem to be very useful or in demand, specially with gremlin OLAP. On Tue, Mar 13, 2018 at 7:34 PM, Stephen Mallette wrote: > A week or so ago I