GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/847
JavaScript GLV: Document lack of GraphSON3 support
Document that GraphSON3 is not supported and how to add GraphSON2
serializers to the Gremlin Server 3.3+.
No need to vote, we can
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/846
Fix JavaScript Gremlin documentation
Several fixes to the JavaScript GLV documentation:
- Use 'gremlin' package name
- Include information regarding Promises
- Reference
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/840#discussion_r182710477
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/TimeSpanConverter.cs ---
@@ -0,0 +1,45 @@
+#region License
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/841
lgtm, VOTE +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/840#discussion_r182680326
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/TimeSpanConverter.cs ---
@@ -0,0 +1,45 @@
+#region License
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/834
Great!
VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/822
I've merged it into `tp32`, `tp32` into `tp33` and `tp33` into `master`.
This pull request shown master being the base branch when it was `tp32`.
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176684867
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/EnumWrapper.cs
---
@@ -48,5 +50,32 @@ protected EnumWrapper(string enumName, string enumValue
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/822
Nice catch @spmallette, I've fixed it.
---
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/822
TINKERPOP-1880 Sign assembly on Linux and macOS
With the latest .NET Core SDK (2.1.101), its now possible to sign
assemblies from Linux and macOS.
We should update our own local
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/820
I agree, we should fix
`g_V_storeXaX_byXoutEXcreatedX_countX_out_out_storeXaX_byXinEXcreatedX_weight_sumX`
outside of this pr.
Having the gherkin based tests running on GraphSON3
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/820
I've rebased this branch to get the fixes for `P.within()` from #817.
Also, I've switched to use a lambda (now that we support it :) ) to obtain
all the edges for the scenario data
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/817#discussion_r175434403
--- Diff: gremlin-dotnet/glv/P.template ---
@@ -94,8 +94,8 @@ namespace Gremlin.Net.Process.Traversal
<% } %><% pmethods.findAll{ it in
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/817
VOTE +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/817#discussion_r175035051
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/P.cs ---
@@ -148,12 +154,29 @@ public static P Test(params object[] args
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/817#discussion_r175033888
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/P.cs ---
@@ -148,12 +154,29 @@ public static P Test(params object[] args
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r175032311
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Lambda.cs ---
@@ -0,0 +1,59 @@
+#region License
+
+/*
+ * Licensed
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/792
I would prefer a generic `ILambda` for string based lambdas (groovy and
python) but I don't have an strong opinion about it.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/792
The implementation looks great and the final `GraphTraversal` and
`GraphTraversalSource` APIs make a lot of sense, like:
```csharp
public GraphTraversal<S, E2> Branch (IFu
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/814
Makes sense, VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/812
lgtm, VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/807
VOTE: +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r170027393
--- Diff: gremlin-dotnet/glv/generate.groovy ---
@@ -48,7 +48,7 @@ def toCSharpTypeMap = ["Long": "long",
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/800
VOTE +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169076841
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java
---
@@ -147,7 +149,12 @@ public void init(final
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169017035
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java
---
@@ -147,7 +149,12 @@ public void init(final
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/798
The increased coverage is great!
I'm still puzzled by ticket 1891 (`P.not()` serialization) but that's a
different issue.
VOTE +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r167847541
--- Diff: gremlin-dotnet/glv/generate.groovy ---
@@ -48,7 +48,7 @@ def toCSharpTypeMap = ["Long": "long",
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r167791719
--- Diff: docs/src/reference/gremlin-variants.asciidoc ---
@@ -436,6 +438,22 @@ NOTE: Many of the TraversalStrategy classes in
Gremlin.Net are proxies
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r167790135
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs ---
@@ -40,9 +40,6 @@ private static string GetMessage(IgnoreReason
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r167789173
--- Diff: gremlin-dotnet/glv/generate.groovy ---
@@ -48,7 +48,7 @@ def toCSharpTypeMap = ["Long": "long",
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r167789705
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/LambdaSerializer.cs ---
@@ -0,0 +1,45 @@
+#region License
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/792#discussion_r167789593
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/LambdaSerializer.cs ---
@@ -0,0 +1,45 @@
+#region License
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/790
lgtm, VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/792
I didn't have time to review this one, I hope I will be able to look into
it by the end this week.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/780
lgtm! VOTE: +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Rebased.
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/776#discussion_r162555342
--- Diff: gremlin-dotnet/glv/GraphTraversal.template ---
@@ -68,7 +68,7 @@ namespace Gremlin.Net.Process.Traversal
public GraphTraversal
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/776#discussion_r162377440
--- Diff: gremlin-dotnet/glv/GraphTraversal.template ---
@@ -68,7 +68,7 @@ namespace Gremlin.Net.Process.Traversal
public GraphTraversal
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
> About `utils.toPromise` - if I understand you well, you want a dual
callback/promise API for most async functions?
Just promise-based API, no callback-based API. `utils.toProm
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Thanks @dkuppitz for looking into the maven issue!
I'll rebase it and add a `g:T` deserializer.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I've addressed the comments made by @spmallette:
- I've included sections on the `development-environment.asciidoc` file for
js environment and info for the release managers.
- Moved
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/695#discussion_r160120074
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/package.json ---
@@ -0,0 +1,39 @@
+{
+ "name": "gre
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
What a great time of the year to review this pr! ð
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/766#discussion_r158473167
--- Diff: docs/preprocessor/preprocess-file.sh ---
@@ -139,7 +140,7 @@ if [ ! ${SKIP} ] && [ $(grep -c '^\[gremlin' ${input})
-gt 0 ]; then
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/763
VOTE +1
---
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/764
GLV Test Suite: Restore Local feature scenarios to master branch
As part of fixing conflicts and understanding GLV test failures on the last
`tp32->master` merge, I've removed most scenar
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/763
I think this should be targeted to `tp32` branch.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/754
I've addressed the issues brought up in @FlorianHockmann's review.
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/754#discussion_r154619459
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs ---
@@ -0,0 +1,381 @@
+#region License
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/762
TINKERPOP-1745 Gremlin.Net: Use DateTimeOffset for g:Date and g:Timestamp
https://issues.apache.org/jira/browse/TINKERPOP-1745
VOTE +1
You can merge this pull request into a Git
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/761
TINKERPOP-1825 Gremlin.Net: fix generation of Constant() and Fold() steps
https://issues.apache.org/jira/browse/TINKERPOP-1825
Addressed the issue where generic parameter types
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/760
lgtm! VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I've implemented the support files for the gherkin test suite.
Thanks to the test suite, I've found and fixed some bugs that were part of
the original implementation.
`mvn clean
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/758
VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/754
I've rebased after #757 was merged. Included all previously skipped
scenarios related to `IDictionary<K, V>` coercion.
I included two type-related fixes to the Match and Group fe
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/753
Besides the suggestion from @dkuppitz , lgtm!
VOTE +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/753#discussion_r154010923
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/JavaTranslator.java
---
@@ -173,6 +173,12 @@ private Object invokeMethod(final
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153151298
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153128066
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/754#discussion_r153125632
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs
---
@@ -0,0 +1,472 @@
+#region License
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153125359
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/754
I rebased it against `tp32`, all tests pass.
VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Nice! lgtm
VOTE +1
---
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/757
TINKERPOP-1837 Gremlin .NET: Provide type coercion between IDictionary<K,
V> instances
https://issues.apache.org/jira/browse/TINKERPOP-1837
(The new Travis job comes in
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/752
Landed in `tp32` and merged into `master`.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/752
@spmallette Yes, the separate jobs run in parallel, so in a few minutes you
can check if the module from the job is affected.
VOTE +1
---
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/754
TINKERPOP-1827 Gremlin .NET: Test Suite Runner
https://issues.apache.org/jira/browse/TINKERPOP-1827
Adds support for Gherkin features for Gremlin.NET.
Changes are made on top
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r152230125
--- Diff: gremlin-test/features/sideEffect/Sack.feature ---
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r152009040
--- Diff: gremlin-test/features/map/Fold.feature ---
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/752
TINKERPOP-1820 TravisCI: Add Gremlin.Net as job
https://issues.apache.org/jira/browse/TINKERPOP-1820
Adds `gremlin-dotnet` integration tests to travis build as a separate job.
You can
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/738
I'm closing this one. I'll open a new one to only add Gremlin.Net tests
support.
---
Github user jorgebay closed the pull request at:
https://github.com/apache/tinkerpop/pull/738
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@robertdale thanks for looking into it.
I'm running `mvn clean install -DskipTests` followed by a `mvn clean
install -pl :gremlin-dotnet-tests -P gremlin-dotnet
-DskipIntegrationTests
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r151703665
--- Diff: gremlin-test/features/map/Min.feature ---
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r151456526
--- Diff: gremlin-test/features/branch/Choose.feature ---
@@ -0,0 +1,124 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
I'm getting a path related issue on Gremlin.Net - Test module, while
executing:
```
mvn clean install -pl :gremlin-dotnet-tests -P gremlin-dotnet
-DskipIntegrationTests=false
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Ah, I see its possible to run integration test using:
```
mvn clean install -pl :gremlin-dotnet-source,:gremlin-dotnet-tests -P
gremlin-dotnet -DskipIntegrationTests=false
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
hm... with the new server start scripts, when running from within a
directory like:
```
cd gremlin-dotnet
mvn clean install -P gremlin-dotnet
```
I get the following
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
`docker/build.sh -t -n -i` succeeds and tests pass.
VOTE: +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Fixes look good to me!
I'm running integration tests locally on docker and I'll come back to give
my plus one.
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150542775
--- Diff:
gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150542730
--- Diff: gremlin-python/src/main/jython/radish/feature_steps.py ---
@@ -0,0 +1,231 @@
+'''
+Licensed to the Apache Software Foundation (ASF
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150497558
--- Diff: gremlin-python/src/main/jython/radish/feature_steps.py ---
@@ -0,0 +1,231 @@
+'''
+Licensed to the Apache Software Foundation (ASF
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150476717
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs ---
@@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150517147
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs ---
@@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150477310
--- Diff: gremlin-python/pom.xml ---
@@ -440,6 +440,17 @@ limitations under the License
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150502204
--- Diff:
gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/712
@FlorianHockmann Can we merge this?
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/738
> I see that you used the -q option. What happens if there is a failure in
native python tests? currently i don't see any output for those, i'm wondering
how that will fail when it d
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/712
Yes it builds, this PR is good to go on my end!
Sorry I forgot to confirm on Friday :/
---
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/738
TINKERPOP-1820 Include Python and .NET GLVs on TravisCI
https://issues.apache.org/jira/browse/TINKERPOP-1820
Run Python and .NET GLV tests on travis CI.
You can merge this pull request
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/712
All .NET tests passes with:
```
mvn clean install -DskipTests
cd gremlin-dotnet && mvn clean install -P gremlin-dotnet
```
I'm running a `docker/build.sh -t -n -i`
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/712
VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/732
VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/728
VOTE +1
---
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r141109744
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs ---
@@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r140812056
--- Diff: gremlin-dotnet/glv/GraphTraversal.template ---
@@ -65,9 +65,17 @@ namespace Gremlin.Net.Process.Traversal
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r140818845
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bindings.cs ---
@@ -29,14 +32,42 @@ namespace Gremlin.Net.Process.Traversal
public
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r140818483
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs ---
@@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object
101 - 200 of 251 matches
Mail list logo
