Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/759
VOTE +1
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/755
The bug is in GremlinServer's `TraversalOpProcessor`. I have it fixed.
Running integration tests now.
---
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/755
TINKERPOP-1834: Consider iterate() as a first class step
https://issues.apache.org/jira/browse/TINKERPOP-1834
This is a re-issuing of a previously closed commit. In this model
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/748
Closing. Going to provide a simpler solution.
---
Github user okram closed the pull request at:
https://github.com/apache/tinkerpop/pull/748
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/748
A `cap()` step is a `SupplyBarrierStep` and thus, requires an emission -- a
single emission, but an emission nonetheless. The ultimate solution step has to
a `FilterStep` by nature so it can truly
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/748
There is nothing for "the server" to know. Thus, gutting the introspection.
By appending `filter(false)` to the bytecode, you have a traversal that returns
nothing. Which is exactly wha
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/748
I think we over engineered this ticket. I believe @dkuppitz has the best
idea.
```
public Traversal<S,E> iterate() {
this.filter(false);
while(hasNext()) {
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/748
Makes sense.
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/748
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/748
TINKERPOP-1834: Consider iterate() as a first class step
https://issues.apache.org/jira/browse/TINKERPOP-1834
When a user triggers a "terminal method" (e.g. `toList(
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/746
VOTE +1
---
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/744
TINKERPOP-1802: hasId() fails for empty collections
https://issues.apache.org/jira/browse/TINKERPOP-1802
If `hasId([])` is specified, then an `ArrayOutOfBoundsException` occurs.
This has
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/743
TINKERPOP-1813: Subgraph step requires the graph API
https://issues.apache.org/jira/browse/TINKERPOP-1813
This ticket wanted `SubgraphStep` to not use the structure API
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/740
TINKERPOP-1814: Some process tests require the graph API
https://issues.apache.org/jira/browse/TINKERPOP-1814
Fixed assertions in the test cases outlined by @BrynCooke that use
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/739
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/739
TINKERPOP-1821: Consistent behavior of self-referencing edges
https://issues.apache.org/jira/browse/TINKERPOP-1821
Added test for self-edges and fixed a semantic issue in `Neo4jGraph
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/734
VOTE +1
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/735
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/735
TINKERPOP-1803: inject() doesn't re-attach with remote traversals
https://issues.apache.org/jira/browse/TINKERPOP-1803
Fixed an "attachement"-bug in `InjectStep` with
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/734
This is a nice update @artem-aliev because it doesn't change API and it is
general for all `GraphComputer` implementations. Great! A couple things please
for a solid VOTE.
1. Please update
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/721
VOTE +1
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/731
VOTE +1
---
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/730
TINKERPOP-1797: LambdaRestrictionStrategy and LambdaMapStep in
by()-modulation.
https://issues.apache.org/jira/browse/TINKERPOP-1797
We have had too many problems
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/729
I just unzipped the jar and the META-INF/ does not contain it. Just a
pom.xml in there.
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/729
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/729
TINKERPOP-1632: Create a set of default functions
https://issues.apache.org/jira/browse/TINKERPOP-1632
This is an implementation of lambda-less math capabilities in Gremlin
leveraging
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/721#discussion_r142426106
--- Diff: hadoop-gremlin/conf/hadoop-gryo.properties ---
@@ -29,8 +29,8 @@ gremlin.hadoop.outputLocation=output
spark.master=local[4
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/726
TINKERPOP-1795: Getting Lambda comparator message for .profile() step
https://issues.apache.org/jira/browse/TINKERPOP-1795
Some objects are hard to check for "lambdaness" a
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/721#discussion_r142035586
--- Diff: hadoop-gremlin/conf/hadoop-gryo.properties ---
@@ -29,8 +29,8 @@ gremlin.hadoop.outputLocation=output
spark.master=local[4
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/723
VOTE +1
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/724
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/724
TINKERPOP-1793: addE() should allow dynamic edge labels
https://issues.apache.org/jira/browse/TINKERPOP-1793
There are a few changes here:
1. `addV(traversal)` and `addE(traversal
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/714
VOTE +1
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/721
This is good stuff. Is it possible to write a test case for the work? Also,
can you fix your documentation so its `TinkerPop` not `Tinkerpop` (camel case).
---
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/720#discussion_r140513636
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class
that has
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/720
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/720
TINKERPOP-1789: Reference elements should be represented by id and label
https://issues.apache.org/jira/browse/TINKERPOP-1789
Fixed a bug where `ReferenceVertex` was always returning
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139994557
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgramTest.java
---
@@ -38,7 +38,7
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139992366
--- Diff: docs/src/upgrade/release-3.3.x.asciidoc ---
@@ -32,6 +32,43 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.1/CHANGELOG.asc
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/717
Pushed `maxIterations` concept.
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/717
You know what we should do. It should be `maxIterations`. This way, if it
converges before hand, great. Done. If it doesn't, well, it will go for
`maxIterations` and then stop. This way `epsilon
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/717
@spmallette -- I'm putting this into `TP 3.3.x` because it is a breaking
change. I believe it is too late into `3.2.x` to introduce such changes.
---
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139985206
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgramTest.java
---
@@ -38,7 +38,7
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139984956
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgram.java
---
@@ -155,61 +161,61
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139984575
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/PageRankVertexProgramStep.java
---
@@ -47,7 +47,7
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/713
VOTE +1
---
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/717
TINKERPOP-1783: PageRank gives incorrect results for graphs with sinks
https://issues.apache.org/jira/browse/TINKERPOP-1783
There were a couple of problems with `PageRankVertexProgram
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/714#discussion_r138748892
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/RangeByIsCountStrategyTest.java
---
@@ -99,6
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/708
VOTE +1
---
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/711
TINKERPOP-1746: Better error message on wrong ordering of
emit()/until()/has()
Simply added a proper error message when `repeatTraversal` is null. This
provides a better user experience than
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/705
Yes. Exactly.
Here is the thing is -- I don't really care for TinkerPop3 anymore so it
can go as people want it too, I won't fight. But if you want to start aligning
concepts so TinkerPop4
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/705
`TinkerGraph.clear()` is bad too. It is `g.V().drop()`.
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/705
I don't think it is a good idea to implement `TinkerGraph.clone()`. I
think, instead, that there could be a "clone utility" that works for all
graphs, not just Tinker
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/699
I'm scared -- VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/701#discussion_r136094137
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
---
@@ -513,8 +513,15 @@ public int hashCode
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/702
TINKERPOP-1764: Generalize MatchStep to localize all barriers, not just
reducing barriers.
https://issues.apache.org/jira/browse/TINKERPOP-1764
Prior to this moment, only reducing barrier
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/701
TINKERPOP-1762: Make MatchStep analyze mid-clause variables for executing
ordering purposes.
https://issues.apache.org/jira/browse/TINKERPOP-1762
There was a bug in `MatchStep` where
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/698
@xytxytxyt -- please close this ticket if everything looks good to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/698
Merged. I had to tweak both tests a bit. `limit(1)` still in the groovy
test. The test used `values('name')` instead of just `name`. Groovy test was
not in sugar syntax.
---
If your project
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/700
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/698#discussion_r135646159
--- Diff:
gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/branch/GroovyRepeatTest.groovy
---
@@ -97,5 +97,10
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r135642938
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_S_SE_SL_Traverser.java
---
@@ -110,17 +112,22 @@ public
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r135642562
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/O_Traverser.java
---
@@ -23,6 +23,7 @@
import
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r135642343
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/LP_O_OB_P_S_SE_SL_Traverser.java
---
@@ -106,17 +106,18
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r135642190
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_Traverser.java
---
@@ -62,10 +62,12 @@ public void
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/700
No. I just spaced on selecting `tp32/` and left it defaulted at `master/`.
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/700
TINKERPOP-1760: OLAP compilation failing around ConnectiveStrategy
https://issues.apache.org/jira/browse/TINKERPOP-1760
The more general problem was in `ComputerVerificationStrategy
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r135576162
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/process/traversal/TinkerGraphPerformanceTest.java
---
@@ -0,0 +1,53
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/698
VOTE +1. (I can do the final merge when all the votes are tallied)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/698
The result is the same. However, I would prefer to have "the simplest query
that fails" and thus, no `limit(1)`, but if the DSEGraph traversal strategies
are failing cause of `limit(1)
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/698
Is the `limit(1)` necessary for the DSEGraph testing because against MODERN
its the same result?There is only 1 outgoing path between marko and ripple.
```
gremlin> g.V().has('n
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/698
What is the intention of the test? What are you trying to prove?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/697
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/697
Cleaner `if/else` clause.
```
return first instanceof Number && second instanceof Number ?
NumberHelper.compare((Number) second, (Number) first) :
Co
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/697
Eek. Yea. That `try/catch` sorta sucks. Can you do some performance testing
with and without they `try/catch`? Would you mind?
---
If your project is set up for it, you can reply to this email
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/691
I am not too hip to the Python code anymore, but I do know that adding the
GraphSON3 support was a little "sketchy". Thus, if this is a Python-esque
improvement upon my non-Pyt
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/687
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/688
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/687#discussion_r132184141
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategyTest.java
---
@@ -95,6 +95,7
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/687#discussion_r132183920
--- Diff: CHANGELOG.asciidoc ---
@@ -143,6 +143,7 @@ TinkerPop 3.2.6 (Release Date: NOT OFFICIALLY RELEASED
YET)
This release also includes
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/689
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/689
```
gremlin> g = TinkerFactory.createModern().traversal()
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g = g.withS
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/689
TINKERPOP-1743: LambdaRestrictionStrategy does not catch lambdas passed to
sack()
https://issues.apache.org/jira/browse/TINKERPOP-1743
Fixed a lambda-leak in `SackValueStep` where
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/685
Very good. VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/686
VOTE +1.
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/686
TINKERPOP-1740: Add vertex parameter overload to to() and from()
https://issues.apache.org/jira/browse/TINKERPOP-1740
Is it me or is it hot out? Oo...
```
a = g.V(1
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/684
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/683
VOTE +1 (got rid of BigDecimal typing -- good).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/682
Ah. I didn't realize that either. BigDecimal is not something we
want to support.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/681
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/682
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/681
TINKERPOP-1535: Bump to support Giraph 1.2.0.
https://issues.apache.org/jira/browse/TINKERPOP-1535
I bumped Giraph from 1.1.0 to 1.20. It was a pretty straight forward
upgrade
Github user okram closed the pull request at:
https://github.com/apache/tinkerpop/pull/677
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/677
@dkuppitz Can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/679
TINKERPOP-1679: Detached side-effects aren't attached when remoted
https://issues.apache.org/jira/browse/TINKERPOP-1679
This was occurring because Gremlin-Python did not have serializers
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/677
Yes -- tested again to be safe.
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/675
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/678
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/677
TINKERPOP-1729: Remove deprecated select steps.
https://issues.apache.org/jira/browse/TINKERPOP-1729
There is no point is crying over spilled milk. The deed is done. It had to
be done
1 - 100 of 450 matches
Mail list logo
