[GitHub] tinkerpop issue #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/548 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-01 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/548#discussion_r98931140 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GraphStep.java --- @@ -164,13 +164,13 @@ public int hashCode

[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-01 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/548#discussion_r98930854 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/FlatMapStep.java --- @@ -44,6 +45,7 @@ public FlatMapStep

[GitHub] tinkerpop issue #551: Fix the serializers lookup to handle the type first, t...

2017-01-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/551 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #553: remove tests from setup.py

2017-01-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/553 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/546 I just tested the `PathRetractionStrategy` code in the GraphActors branch and the `akka-gremlin/` test suite passes. *** Sidenote: can you finalize your variables if possible? VOTE

[GitHub] tinkerpop issue #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-01-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/548 Yes. That makes sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop pull request #549: TINKERPOP-1617: Create a SingleIterationStrateg...

2017-01-26 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/549 TINKERPOP-1617: Create a SingleIterationStrategy which will do its best to rewrite OLAP traversals to not message pass. https://issues.apache.org/jira/browse/TINKERPOP-1617

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-25 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/546 So the problem I was having was related to the interplay between `PathRetractionStrategy` and `MatchPredicateStrategy`. You can't have `PathRetractionStrategy` without `MatchPredicateStrategy

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

2017-01-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/537 Actually, can you add a test case for this so we know it doesn't break again in the future? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/539 Just realized that the `GroupStep` work fixed: https://issues.apache.org/jira/browse/TINKERPOP-1261 ``` gremlin> m = ["marko":['blah']] ==>marko=[b

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/538 So `MultiComparator` is internal to a `Traversal`. The way in which GraphSON serializes traversals is via their Bytecode. Thus, when the bytecode gets recompiled on the deserializing end

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/539 ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/538 ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/539 Whoa. Because I branched from `master/` the rebase looked insane nevermind. I will twiddle to `tp32/` upon merge. --- If your project is set up for it, you can reply to this email and have

[GitHub] tinkerpop pull request #539: TINKERPOP-1606: Refactor GroupStep to not have ...

2017-01-18 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/539 TINKERPOP-1606: Refactor GroupStep to not have the reduction traversal included in its BiOperator. https://issues.apache.org/jira/browse/TINKERPOP-1606 This is huge. With this PR

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/538 Decided to not touch `GroupStep` till the next release as it is more complicated to handle than `OrderGlobalStep` and `SampleGlobalStep`. Thus, for this PR: VOTE +1. --- If your project

[GitHub] tinkerpop pull request #538: TINKERPOP-1248: OrderGlobalStep should use loca...

2017-01-18 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/538 TINKERPOP-1248: OrderGlobalStep should use local star graph to compute sorts, prior to reduction. https://issues.apache.org/jira/browse/TINKERPOP-1248 We now support having the projected

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/535 This is not the way that this should be done. We shouldn't remove any strategies. What we should do is generalize the `ProfileTests` so they are not so specific about step indexes and the like

[GitHub] tinkerpop issue #531: Added more recipes

2017-01-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/531 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/535 I was thinking more about this specific problem. The real problem is `ProfileTest`, not `LazyBarrierStrategy`. We need to generalize all the `ProfileTest` test cases such that they not be concerned

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/535 There are numerous areas where `is.testing` is used for strategies. We shouldn't just do this for one of them and push a PR. We should overhaul the entire system so we don't have some parts

[GitHub] tinkerpop pull request #531: Added more recipes

2017-01-11 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/531#discussion_r95562174 --- Diff: docs/src/recipes/appendix.asciidoc --- @@ -0,0 +1,226 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] tinkerpop pull request #531: Added more recipes

2017-01-11 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/531#discussion_r95563597 --- Diff: docs/src/recipes/appendix.asciidoc --- @@ -0,0 +1,226 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] tinkerpop pull request #531: Added more recipes

2017-01-11 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/531#discussion_r95565322 --- Diff: docs/src/recipes/duplicate-edge.asciidoc --- @@ -0,0 +1,142 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] tinkerpop issue #529: TINKERPOP-1549 Implement skip()

2017-01-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/529 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #530: TINKERPOP-1531: DedupTest.g_V_asXaX_repeatXboth...

2017-01-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/530 TINKERPOP-1531: DedupTest.g_V_asXaX_repeatXbothX_timesX3X_emit_asXbX_group_byXselectXaXX_byXselectXbX_dedup_order_byXidX_foldX_selectXvaluesX_unfold_dedup assumes id implements Comparable https

[GitHub] tinkerpop pull request #529: TINKERPOP-1549 Implement skip()

2017-01-10 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/529#discussion_r95350852 --- Diff: gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/filter/GroovyRangeTest.groovy --- @@ -108,5 +108,15

[GitHub] tinkerpop pull request #529: TINKERPOP-1549 Implement skip()

2017-01-10 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/529#discussion_r95351351 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.java --- @@ -810,6 +810,20 @@ protected

[GitHub] tinkerpop pull request #529: TINKERPOP-1549 Implement skip()

2017-01-10 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/529#discussion_r95351178 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -1916,6 +1916,35 @@ g.V(1).both().both().simplePath() g.V(1).both().both().simplePath().path

[GitHub] tinkerpop pull request #528: TINKERPOP-1116: Some anonymous traversal steps ...

2017-01-09 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/528 TINKERPOP-1116: Some anonymous traversal steps can be hard typed. https://issues.apache.org/jira/browse/TINKERPOP-1116 Tweaked the typing of various `__` anonymous traversal steps

[GitHub] tinkerpop pull request #527: TINKERPOP-1521: Mutating steps don't recognize ...

2017-01-09 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/527 TINKERPOP-1521: Mutating steps don't recognize side-effects https://issues.apache.org/jira/browse/TINKERPOP-1521 `AddVertexStartStep` was using an `EmptyTraverser` to compute

[GitHub] tinkerpop issue #526: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2017-01-09 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/526 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #525: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2017-01-09 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/525 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #524: TINKERPOP-1585 & TINKERPOP-1590: DedupGlobalSte...

2017-01-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/524#discussion_r95010996 --- Diff: spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/SparkInterceptorStrategyTest.java

[GitHub] tinkerpop pull request #524: TINKERPOP-1585 & TINKERPOP-1590: DedupGlobalSte...

2017-01-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/524#discussion_r95001231 --- Diff: spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/SparkInterceptorStrategyTest.java

[GitHub] tinkerpop pull request #524: TINKERPOP-1585 & TINKERPOP-1590: DedupGlobalSte...

2017-01-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/524#discussion_r95000938 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupGlobalStep.java --- @@ -89,6 +92,17 @@ public

[GitHub] tinkerpop pull request #524: TINKERPOP-1585 & TINKERPOP-1590: DedupGlobalSte...

2017-01-05 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/524 TINKERPOP-1585 & TINKERPOP-1590: DedupGlobalStep and Distributed TinkerMemory https://issues.apache.org/jira/browse/TINKERPOP-1585 https://issues.apache.org/jira/browse/TINKERPOP-

[GitHub] tinkerpop pull request #522: TINKERPOP-1588: Added Terminal Steps section to...

2017-01-05 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/522 TINKERPOP-1588: Added Terminal Steps section to the docs https://issues.apache.org/jira/browse/TINKERPOP-1588 Added a "Terminal Steps" section to the documentation that include

[GitHub] tinkerpop issue #521: TINKERPOP-1589 Re-introduced CloseableIterator

2017-01-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/521 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #515: TINKERPOP-1581 Gremlin-Python driver connection is not...

2017-01-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/515 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #521: TINKERPOP-1589 Re-introduced CloseableIterator

2017-01-05 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/521#discussion_r94776952 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Traversal.java --- @@ -254,9 +254,14 @@ public default void

[GitHub] tinkerpop issue #520: TINKERPOP-1130 IO Testing

2017-01-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/520 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #521: TINKERPOP-1589 Re-introduced CloseableIterator

2017-01-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/521 Nice. Clean backwards compatible `GraphStep.close()` method which uses `instanceof`. Are you looking for a VOTE now or are you still building on this PR? -- e.g. integrating

[GitHub] tinkerpop issue #520: TINKERPOP-1130 IO Testing

2017-01-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/520 First off, thank you for doing this -- what an undertaking. Getting I/O solid for 3.3.0 is crucial given the versioning push and the desired serialization changes for GLVs. Before officially voting

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2017-01-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/486 This is a good find. However, the implementation is a bit gimpy. `Step.getRequirements()` is already a recursive process as `TraversalParents` will check their children for requirements. I

[GitHub] tinkerpop pull request #506: TINKERPOP-1389: Support Spark 2.0.0

2017-01-03 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/506#discussion_r94413881 --- Diff: CHANGELOG.asciidoc --- @@ -46,6 +46,10 @@ TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET) * Removed all performance tests

[GitHub] tinkerpop issue #518: Honor the equals() contract on Property impls by allow...

2016-12-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/518 Yea, I would put the null check into `ElementHelper.areEqual()` so all providers have the same semantics. Then I would add a structure test to verifies that null is okay for `equals()` for every

[GitHub] tinkerpop issue #516: TINKERPOP-1584 Made Gryo support a number of classes G...

2016-12-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/516 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #478: TINKERPOP-1490 Implemented promise API for Traversal

2016-12-16 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/478 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #510: TINKERPOP-1562 Migrate ScriptEngine-related code to gr...

2016-12-11 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/510 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #510: TINKERPOP-1562 Migrate ScriptEngine-related cod...

2016-12-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/510#discussion_r91200131 --- Diff: hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/jsr223/HadoopGremlinPlugin.java --- @@ -0,0 +1,153 @@ +/* + * Licensed

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 Sorry. I thought we had 3 VOTEs and I merged. I just asked @dkuppitz to VOTE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop issue #511: TINKERPOP-1539 Create a ComplexTraversalTest with craz...

2016-12-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/511 This is great. We should really be diligent to keep growing the tests here. As our strategies get more complex (and are working in recursive fashions) we really need to have complex, nasty nested

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 I would actually remove `start()` from static imports. Its never used as its more of a "helper method" and then less chance for naming collisions. --- If your project is set up for i

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 Perfect. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #507: TINKERPOP-1573: Bindings don't work in coalesce

2016-12-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/507 I know it sucks. I don't like this any more than you do. Here is the saving grace -- if someone comes up with a better solution, there are only two classes we need to tweak (`Bytecode

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-11-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 In Gremlin-Java, those methods do the following: ``` public static GraphTraversal<A, A> start() { return new DefaultGraphTraversal<>(); }

[GitHub] tinkerpop pull request #506: TINKERPOP-1389: Support Spark 2.0.0

2016-11-29 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/506 TINKERPOP-1389: Support Spark 2.0.0 https://issues.apache.org/jira/browse/TINKERPOP-1389 This was a crazy rollercoaster ride, but we now have three good things: 1. A more

[GitHub] tinkerpop issue #494: TINKERPOP-1443 - Introduce API check into the build

2016-11-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/494 I would ignore sub-packages right now. Again, lets start off small, get things passing, and over time, add more packages to check. --- If your project is set up for it, you can reply to this email

[GitHub] tinkerpop pull request #446: TINKERPOP-1483: valueMap should always return s...

2016-11-28 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/446#discussion_r89875249 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ValueMapTest.java --- @@ -125,6 +131,30 @@ public void

[GitHub] tinkerpop pull request #446: TINKERPOP-1483: valueMap should always return s...

2016-11-28 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/446#discussion_r89875173 --- Diff: gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyValueMapTest.groovy --- @@ -42,5 +42,10

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

2016-11-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/446 I just realized that `valueMap()` is `Map<String,Object>`, but `valueMap(boolean)` is `Map<Object,Object>`. We should maintain that level of explicitness as I suspect in the futu

[GitHub] tinkerpop pull request #446: TINKERPOP-1483: valueMap should always return s...

2016-11-28 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/446#discussion_r89863961 --- Diff: CHANGELOG.asciidoc --- @@ -46,6 +46,7 @@ TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET) * Removed `tryRandomCommit()` from

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

2016-11-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/446 @dkuppitz -- will you handle merge and thus, do the CHANGELOG and update the upgrade docs on merge? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop issue #505: TINKERPOP-1561 gremiln-python GraphSONWriter doesn't p...

2016-11-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/505 I have no way of checking Python 3.x, but note that everything is good for Python 2.x. ``` [INFO] [INFO

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

2016-11-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/446 Yea, `Map<Object,Object>` is the thing. :| ... I really don't like `valueMap()`. For this reason and for the `boolean` argument overload ... fuggly. VOTE +1. --- If your project

[GitHub] tinkerpop issue #494: TINKERPOP-1443 - Introduce API check into the build

2016-11-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/494 I think we should start this merge off by having only the following packages be analyzed: ``` org.apache.tinkerpop.gremlin.structure org.apache.tinkerpop.gremlin.structure.io

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 You are a bad person @dkuppitz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 Integration tests ran against `master/` (the new target branch). ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 No GraphSON will change in this branch but we will solve TINKERPOP-1562 in the same release as this branch. Thus, this branch is like a "half-ticket" with TINKERPOP-1562's comple

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 This ticket doesn't address a "bug" as much as a consistency issue. The primary issue is that Bytecode and GraphTraversal are not in one-to-one correspondence. You get the sa

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 Another thing we can do that I think would be best is target this to `master/`. Why? 1. There are changes to Gryo we will need to make so ensure "attach-ability." 2. This giv

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 @spmallette --- we simply can't abandon the GraphSON 2.0 changes I made cause we need to be able to "attach properties" (vertex properties and element properties). However, there are

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 https://issues.apache.org/jira/browse/TINKERPOP-1565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 Talking with @spmallette. There are lots of issues with GraphSON 2.0 that both you and I notice. Lets do this. Lets get this ticket merged as there are lots of other work in here and start up a new

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 Please put it in a form like: https://github.com/apache/tinkerpop/blob/e09309c1210ad5d7d5f33440d4d8d1470bd3f0e2/docs/src/dev/io/graphson.asciidoc .. What you mean by "data" doesn't make s

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-21 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r89010633 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java --- @@ -153,13 +152,16 @@ public void

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-21 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r89010296 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java --- @@ -459,9 +486,33 @@ public

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-21 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r88915459 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java --- @@ -175,8 +177,30 @@ public

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-21 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r88914949 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java --- @@ -175,8 +177,30 @@ public

[GitHub] tinkerpop issue #501: Added TP2-to-TP3 GraphML XSLT to resources

2016-11-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/501 Can you please make corresponding JIRA tickets and use the PR naming convention for your PRs? Also, this PR will need documentation as well as an update to the CHANGELOG. Finally, I don't know why

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 Yea. I will do the upgrade and io docs. Integration testing Giraph is running right now :| ... once that completes, I will push doc updates. --- If your project is set up for it, you can reply

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-18 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r88708851 --- Diff: gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GroovyTranslator.java --- @@ -47,8 +49,6 @@ */ public final

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-18 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r88708033 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalTest.java --- @@ -71,4 +80,89 @@ public void

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-18 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/499#discussion_r88707852 --- Diff: CHANGELOG.asciidoc --- @@ -26,6 +26,12 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima TinkerPop 3.2.4

[GitHub] tinkerpop issue #499: TINKERPOP-1520: Difference between 'has' step generate...

2016-11-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/499 Oh -- and I forgot. Gremlin-Python now has serializers for Vertex, Edge, Property, VertexProperty... Thus, you can `g.V(v[1])` from Gremlin-Python to Gremlin-Java. --- If your project is set up

[GitHub] tinkerpop pull request #499: TINKERPOP-1520: Difference between 'has' step g...

2016-11-18 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/499 TINKERPOP-1520: Difference between 'has' step generated graphson2.0 in java and python glv implementation https://issues.apache.org/jira/browse/TINKERPOP-1520 This branch has done alot

[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

2016-11-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/498 Question -- I don't use docker. Does this "just work" with standard `mvn clean install`? If not, can we make it default? --- If your project is set up for it, you can reply to this emai

[GitHub] tinkerpop issue #490: TINKERPOP-1474 GraphSON decode of Vertex and Edge prop...

2016-11-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/490 Dah. I didn't see this ticket. I'm doing this (along with other things) in TINKERPOP-1520. Hmm... perhaps you can provide a PR to that branch ... In particular your test cases. --- If your

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/485 I do like `Traversal.metadata()`. However, I think that metadata should be stored at the root traversal only. Thus, its a global blackboard. Next, given that its an `Admin` method, it should just

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/485 ``` gremlin> g.V().barrier().store('a').sideEffect(select('a')).explain() ==>Traversal Expla

[GitHub] tinkerpop issue #494: TINKERPOP-1443 - Introduce API check into the build

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/494 I think we will need to decide what is considered NOT subject to change and what is subject to change. For example, the `ImmutablePath` method changes are internal changes that are "okay.&quo

[GitHub] tinkerpop issue #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-container...

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/495 We could. However, its such a rare situation too much optimization? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop pull request #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-co...

2016-11-15 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/495 TINKERPOP-1502 & TINKERPOP-1482: Chained has-containers and AndP stringency https://issues.apache.org/jira/browse/TINKERPOP-1502 https://issues.apache.org/jira/browse/TINKERPOP-

[GitHub] tinkerpop issue #493: TINKERPOP-1538 [master]

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/493 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #491: TINKERPOP-1538 Use non-default port for gremlin server...

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/491 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #482: TINKERPOP-1541: Select should default to Pop.la...

2016-11-15 Thread okram
Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tinkerpop issue #492: TINKERPOP-1538 [tp32]

2016-11-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/492 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-14 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/485 Thats fine, just assume that `sideEffect(access a)` is never "the final." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

<    1   2   3   4   5   >