Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
Github user jbmusso commented on the issue:
https://github.com/apache/tinkerpop/pull/695
All good to me!
VOTE +1
---
Github user jbmusso commented on the issue:
https://github.com/apache/tinkerpop/pull/695
According to https://github.com/petkaantonov/bluebird/issues/1026, users
should be able to just patch the global `Promise` object in their application
with:
```javascript
global.Promise =
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Rebased.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
> About `utils.toPromise` - if I understand you well, you want a dual
callback/promise API for most async functions?
Just promise-based API, no callback-based API. `utils.toPromise()`
Github user jbmusso commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Finally found some time. Wew.
Well, this PR is very well crafted - well done! My comments are only minor:
* About `utils.toPromise` - if I understand you well, you want a dual
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Thanks @dkuppitz for looking into the maven issue!
I'll rebase it and add a `g:T` deserializer.
---
Github user jbmusso commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Quick update - I plan to check this PR this weekend.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
gremlin-javascript seems to build ok for me locally, but not on docker.
claims it needs a maven upgrade to 3.1.0 for the npm plugin to work. do you see
the same thing @jorgebay ?
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I've addressed the comments made by @spmallette:
- I've included sections on the `development-environment.asciidoc` file for
js environment and info for the release managers.
- Moved
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
What a great time of the year to review this pr! ð
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
this is excellent. i agree that we should look to merge this for
3.2.8/3.3.2. as we hopefully release 3.2.7/3.3.1 we should see gremlin-js come
into an official state in the first few months
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I've implemented the support files for the gherkin test suite.
Thanks to the test suite, I've found and fixed some bugs that were part of
the original implementation.
`mvn clean
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Just a note for those following this ticket's progress. I'm in the process
of doing TINKERPOP-1784 which will add a language agnostic test suite using
gherkin defined feature files. That
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I mostly cared about nashorn to achieve testing as we did in python. I
sense that most folks won't want to run on nashorn itself, so perhaps direct
support of nashorn doesn't really matter
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I've removed support for Nashorn as part of #626 (see first comment).
JavaScript engines don't provide a standard way to deal with and import
modules, so supporting with multiple runtimes is
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I think the need to figure out the language agnostic way to test GLVs is
becoming more important. I was pretty close to getting nashorn to execute
gremlin-javascript natively, but there's
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Great! It would be really nice to have a working
`GremlinJavaScriptScriptEngine`!
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I rebased this today and added the nashorn scriptengine implementation for
`GremlinScriptEngine`. I'd like to get us running tests with js the way we do
with python since it's jsr223
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Hi @jorgebay - sorry - i just haven't had time to focus on this yet. I'll
try to dig into it next week. Thanks for jamming on this and getting it ready
for merging.
---
If your project is
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
VOTE +1
`mvn clean install -DskipIntegrationTests=false` passes.
API summary:
- All methods are generated using groovy template files.
- Naming conventions for js are
21 matches
Mail list logo
