This vote is now closed with a total of 5 +1s, no +0s and no -1s. The
results are:
BINDING VOTES:
+1 (4 -- Stephen Mallette, Robert Dale, Daniel Kuppitz, Florian Hockmann)
0 (0)
-1 (0)
NON-BINDING VOTES:
+1 (1 -- Pieter Martin)
0 (0)
-1 (0)
Thank you very much,
Stephen
On Fri, Jan 4,
validate-distro passes
VOTE +1
Robert Dale
On Fri, Jan 4, 2019 at 10:38 AM Florian Hockmann
wrote:
> I skimmed over the docs and they look good. I only noticed that we
> apparently forgot to add a link to the new .NET API docs to the docs
> page. It only contains links to the Javadoc and the
I skimmed over the docs and they look good. I only noticed that we
apparently forgot to add a link to the new .NET API docs to the docs
page. It only contains links to the Javadoc and the JSDoc. The .NET docs
are available here:
http://tinkerpop.apache.org/dotnetdocs/3.3.5/index.html
However,
Much better.
*Validating binary distributions*
* downloading Apache TinkerPop Gremlin
(apache-tinkerpop-gremlin-console-3.3.5-bin.zip)... OK
* validating signatures and checksums ...
* PGP signature ... OK
* SHA512 checksum ... OK
* unzipping Apache TinkerPop Gremlin ... OK
* validating
Ok - re-deployed the zips and everything. validate-distribution.sh passes.
I'm still +1 on this as it never failed for me in the past. Please feel
free to review/vote - thanks
On Thu, Jan 3, 2019 at 4:34 PM Robert Dale wrote:
> Looks good to me.
>
> Robert Dale
>
>
> On Thu, Jan 3, 2019 at 4:06
Looks good to me.
Robert Dale
On Thu, Jan 3, 2019 at 4:06 PM Daniel Kuppitz wrote:
> Yea, I already had them locally, I just didn't feel like changing that part
> of the validation script. Since we don't touch the zip files after they
> were generated, I assume that signing still works as
Yea, I already had them locally, I just didn't feel like changing that part
of the validation script. Since we don't touch the zip files after they
were generated, I assume that signing still works as expected.
Cheers,
Daniel
On Thu, Jan 3, 2019 at 2:03 PM Stephen Mallette
wrote:
> btw, in
btw, in case you want to test you need to do:
$ mvn install -Papache-release -DcreateChecksum=true -DskipTests
and you will see the zip with signatures in /target. if you don't have gpg
stuff setup you can at least check the zip by changng "install" to
"package".
On Thu, Jan 3, 2019 at 3:14 PM
I modified my validation script so that it copies the files from my m2
directory instead of downloading them. I also commented out the checksum
check (it can only fail as it would compare my local zip files against
remote checksum files) and the docs check (I haven't built them locally).
With that
I think I figured out how to ignore those directories. Had to override the
default apache parent pom source distribution process - it didn't take into
account non-JVM file stuffs. I didn't see where it was easily accessible to
extend so I just overrode the whole thing. Just pushed a fix on tp33
Hi,
Sqlg passes all its own tests and TinkerPop's structure and process
tests.
Vote +1
Cheers
Pieter
On Wed, 2019-01-02 at 16:49 -0500, Stephen Mallette wrote:
> Hello,
>
> We are happy to announce that TinkerPop 3.3.5 is ready for release.
>
> The release artifacts can be found at this
rm -rf gremlin-dotnet/src/{obj,_site}
rm -rf
gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules
This helps to get a clean build, git clean seems to be the better choice
though.
However, I have no clue how we can control the contents of the src zip
file, I don't even know which
Maybe anything generated should be excluded:
src/docfx
src/gremlin-dotnet-source.iml
src/Gremlin.Net/Driver/obj
src/Gremlin.Net.Template.3.3.4.nupkg
src/nuget-4.4.1.exe
src/obj
src/_site
.vscode
or better yet, 'git clean -fdx' before building the src zip. I haven't
looked at the src zip build
it's too bad validate-distribution.sh passed on my environment. should
docker be rigged to run it instead so it's run on a clean environment from
now on? like:
docker/validate-distribution.sh
??
On Thu, Jan 3, 2019 at 10:34 AM Daniel Kuppitz wrote:
> I just found this entry in my log:
>
>
I just found this entry in my log:
[exec] [19-01-03 03:20:16.409]Error:System.AggregateException: One or
more errors occurred.
(/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/hlxtywvr.c9b
does not exist)
Confirmed, building the tag just worked for me, too.
On Thu, Jan 3, 2019 at 7:59 AM Robert Dale wrote:
> Building the tag from github works fine. Looks like some local build
> artifacts snuck into the src.zip.
>
> Excluding gremlin-dotnet, validate-distribution passes.
>
> Robert Dale
>
>
>
Building the tag from github works fine. Looks like some local build
artifacts snuck into the src.zip.
Excluding gremlin-dotnet, validate-distribution passes.
Robert Dale
On Thu, Jan 3, 2019 at 9:49 AM Robert Dale wrote:
> Daniel, I had to install 'msbuild' in addition to the mono packages.
Daniel, I had to install 'msbuild' in addition to the mono packages. I
also installed mono-addins-devel. I don't know if that actually did
anything.
But now I get some errors with :
System.IO.FileNotFoundException:
Do you guys have Mono installed and the nuget-4.4.1.exe in
gremlin-dotnet/src?
The step that seems to fail for you is where mono executes nuget to
install docfx and a library used by docfx into the directory
gremlin-dotnet/src/docfx. Is that directory maybe already present on
your machines? If
I skimmed over the docs, they look good to me, but the
validate-distribution.sh script fails the same way as for Robert.
Investigating
Cheers,
Daniel
On Wed, Jan 2, 2019 at 2:58 PM Stephen Mallette
wrote:
> Hello,
>
> We are happy to announce that TinkerPop 3.3.5 is ready for release.
>
1. bin/validate-distribution.sh 3.3.5 error:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-antrun-plugin:1.8:run (docfx) on project
gremlin-dotnet-source: An Ant BuildException has occured: exec returned: 1
[ERROR] around Ant part .. @
31:50 in
on #1, I did a system upgrade recently and looks like I lost nuget.
Installed nuget, progresses further but ran into other issues. Will keep
you posted.
Robert Dale
On Thu, Jan 3, 2019 at 8:54 AM Robert Dale wrote:
> 1. bin/validate-distribution.sh 3.3.5 error:
>
> [ERROR] Failed to execute
Hello,
We are happy to announce that TinkerPop 3.3.5 is ready for release.
The release artifacts can be found at this location:
https://dist.apache.org/repos/dist/dev/tinkerpop/3.3.5/
The source distribution is provided by:
apache-tinkerpop-3.3.5-src.zip
Two binary
23 matches
Mail list logo
