Re: Code Freeze 3.2.8/3.3.2

[Robert Dale]

Looks good. Doesn't even show up as a forced update.

Robert Dale

On Fri, Apr 6, 2018 at 9:36 PM, Stephen Mallette 
wrote:

> i think i fixed it. i accidentally pushed a really bad version of tp33 that
> made it even with master!!!
>
> i ended up fixing by doing:
>
> git branch -D tp33
> git checkout tags/3.3.2
> git checkout -b tp33
> ... // all the stuff to bump to 3.3.3-SNAPSHOT again
> git push origin tp33 --force
>
> Thanks to Robert Dale for being available to help me with a git sanity
> check on that. It would be great if others could take a look at the git
> history at some point soon (ideally before we go committing on it again)
> and give me a +1 if everything looks ok.
>
> sorry for the foul upmissed a stupid forward slash in one of my git
> commands and it sent tp33 into a tailspin from there and of course I didn't
> realize it until i'd pushed. bah. git provides more ways for you to screw
> your repo than it does to keep it straight. have a good weekend everyone.
> no more git for me until next week. jeez.
>
> On Fri, Apr 6, 2018 at 8:54 PM, Stephen Mallette 
> wrote:
>
> > I think I just did something bad to git.
> >
> > Please don't push anything until I can try to sort out what happened.
> Damn
> >
> > On Fri, Apr 6, 2018 at 7:51 PM, Stephen Mallette 
> > wrote:
> >
> >> The vote threads are now closed up but we will wait until monday to
> >> finalize up the actual release. Have a good weekend everyone!
> >>
> >> On Tue, Mar 27, 2018 at 2:04 PM, Stephen Mallette  >
> >> wrote:
> >>
> >>> I think the second issue is resolve now with:
> >>>
> >>> https://github.com/apache/tinkerpop/commit/2a9e7e24f4e255cad
> >>> 3eb300423634cbac110d74d
> >>>
> >>> we can thank kevin gallardo for the answer on that one.
> >>>
> >>> On Tue, Mar 27, 2018 at 7:39 AM, Stephen Mallette <
> spmalle...@gmail.com>
> >>> wrote:
> >>>
>  Re-running tests now:
> 
>  https://github.com/apache/tinkerpop/commit/2e74c31c39b959263
>  605436555ba9cbc05eab2c5
> 
>  also, altered the original JIRA a bit:
> 
>  https://issues.apache.org/jira/browse/TINKERPOP-1884
> 
> 
> 
>  On Tue, Mar 27, 2018 at 7:08 AM, Robert Dale 
> wrote:
> 
> > Reverting back to netty 4.0 until there is a critical bug may be the
> > best
> > course.  Spark 2.3 upgrades to netty 4.1 so perhaps that can be done
> in
> > tp34/master.
> >
> > Robert Dale
> >
> > On Tue, Mar 27, 2018 at 6:55 AM, Stephen Mallette <
> > spmalle...@gmail.com>
> > wrote:
> >
> > > hmm - i don't like how shifty this is all getting. I think I might
> > bump
> > > tp33 back to 4.0.x then everything will just work cleanly.
> > >
> > > btw, i'm also now aware of a second issue. the jackson version bump
> > has
> > > created an issue where byte[] is not serializing properly. it used
> > to "just
> > > work" but something must have changed in jackson to now require
> that
> > it be
> > > a registered type. i think i need to get that resolved prior to
> > release -
> > > this could mean a delay.
> > >
> > > On Tue, Mar 27, 2018 at 6:37 AM, Stephen Mallette <
> > spmalle...@gmail.com>
> > > wrote:
> > >
> > > > they would have a problem.  :/
> > > >
> > > > i'm thinking this is an unlikely case? Spark based traversals are
> > > > analytical and thus typically executed through the console rather
> > than
> > > via
> > > > Gremlin Server. So perhaps not a big deal breaker? What do people
> > think?
> > > >
> > > > That said, luckily the workaround is the same as the one for the
> > console.
> > > > Simply need to remove the netty 4.1.x jar from gremlin server's
> > /lib and
> > > > replace it with 4.0.x. I just ran the Gremlin Server integration
> > tests
> > > and
> > > > they pass with that configuration. I could document that process
> > in:
> > > >
> > > > https://github.com/apache/tinkerpop/blob/master/gremlin-
> > > > server/conf/gremlin-server-spark.yaml
> > > >
> > > >
> > > >
> > > > On Mon, Mar 26, 2018 at 8:57 PM, Robert Dale 
> > wrote:
> > > >
> > > >> What happens if someone wants to install Spark in Gremlin
> Server?
> > > >>
> > > >> Robert Dale
> > > >>
> > > >> On Mon, Mar 26, 2018 at 4:07 PM, Stephen Mallette <
> > spmalle...@gmail.com
> > > >
> > > >> wrote:
> > > >>
> > > >> > Kuppitz pointed out that we were having trouble building docs
> > on tp33
> > > >> and
> > > >> > of course, it was spark related. I managed to sort out the
> > problem and
> > > >> we
> > > >> > have our bump to netty 4.1.x to thank along with spark 2.2
> being
> > > pinned
> > > >> on
> > > >> > 

Re: Code Freeze 3.2.8/3.3.2

[Stephen Mallette]

i think i fixed it. i accidentally pushed a really bad version of tp33 that
made it even with master!!!

i ended up fixing by doing:

git branch -D tp33
git checkout tags/3.3.2
git checkout -b tp33
... // all the stuff to bump to 3.3.3-SNAPSHOT again
git push origin tp33 --force

Thanks to Robert Dale for being available to help me with a git sanity
check on that. It would be great if others could take a look at the git
history at some point soon (ideally before we go committing on it again)
and give me a +1 if everything looks ok.

sorry for the foul upmissed a stupid forward slash in one of my git
commands and it sent tp33 into a tailspin from there and of course I didn't
realize it until i'd pushed. bah. git provides more ways for you to screw
your repo than it does to keep it straight. have a good weekend everyone.
no more git for me until next week. jeez.

On Fri, Apr 6, 2018 at 8:54 PM, Stephen Mallette 
wrote:

> I think I just did something bad to git.
>
> Please don't push anything until I can try to sort out what happened. Damn
>
> On Fri, Apr 6, 2018 at 7:51 PM, Stephen Mallette 
> wrote:
>
>> The vote threads are now closed up but we will wait until monday to
>> finalize up the actual release. Have a good weekend everyone!
>>
>> On Tue, Mar 27, 2018 at 2:04 PM, Stephen Mallette 
>> wrote:
>>
>>> I think the second issue is resolve now with:
>>>
>>> https://github.com/apache/tinkerpop/commit/2a9e7e24f4e255cad
>>> 3eb300423634cbac110d74d
>>>
>>> we can thank kevin gallardo for the answer on that one.
>>>
>>> On Tue, Mar 27, 2018 at 7:39 AM, Stephen Mallette 
>>> wrote:
>>>
 Re-running tests now:

 https://github.com/apache/tinkerpop/commit/2e74c31c39b959263
 605436555ba9cbc05eab2c5

 also, altered the original JIRA a bit:

 https://issues.apache.org/jira/browse/TINKERPOP-1884



 On Tue, Mar 27, 2018 at 7:08 AM, Robert Dale  wrote:

> Reverting back to netty 4.0 until there is a critical bug may be the
> best
> course.  Spark 2.3 upgrades to netty 4.1 so perhaps that can be done in
> tp34/master.
>
> Robert Dale
>
> On Tue, Mar 27, 2018 at 6:55 AM, Stephen Mallette <
> spmalle...@gmail.com>
> wrote:
>
> > hmm - i don't like how shifty this is all getting. I think I might
> bump
> > tp33 back to 4.0.x then everything will just work cleanly.
> >
> > btw, i'm also now aware of a second issue. the jackson version bump
> has
> > created an issue where byte[] is not serializing properly. it used
> to "just
> > work" but something must have changed in jackson to now require that
> it be
> > a registered type. i think i need to get that resolved prior to
> release -
> > this could mean a delay.
> >
> > On Tue, Mar 27, 2018 at 6:37 AM, Stephen Mallette <
> spmalle...@gmail.com>
> > wrote:
> >
> > > they would have a problem.  :/
> > >
> > > i'm thinking this is an unlikely case? Spark based traversals are
> > > analytical and thus typically executed through the console rather
> than
> > via
> > > Gremlin Server. So perhaps not a big deal breaker? What do people
> think?
> > >
> > > That said, luckily the workaround is the same as the one for the
> console.
> > > Simply need to remove the netty 4.1.x jar from gremlin server's
> /lib and
> > > replace it with 4.0.x. I just ran the Gremlin Server integration
> tests
> > and
> > > they pass with that configuration. I could document that process
> in:
> > >
> > > https://github.com/apache/tinkerpop/blob/master/gremlin-
> > > server/conf/gremlin-server-spark.yaml
> > >
> > >
> > >
> > > On Mon, Mar 26, 2018 at 8:57 PM, Robert Dale 
> wrote:
> > >
> > >> What happens if someone wants to install Spark in Gremlin Server?
> > >>
> > >> Robert Dale
> > >>
> > >> On Mon, Mar 26, 2018 at 4:07 PM, Stephen Mallette <
> spmalle...@gmail.com
> > >
> > >> wrote:
> > >>
> > >> > Kuppitz pointed out that we were having trouble building docs
> on tp33
> > >> and
> > >> > of course, it was spark related. I managed to sort out the
> problem and
> > >> we
> > >> > have our bump to netty 4.1.x to thank along with spark 2.2 being
> > pinned
> > >> on
> > >> > the 4.0.x line of netty. Basically spark is completely
> incompatible
> > >> there
> > >> > and we get errors as a result. I've tried all manner of things
> to
> > >> resolve
> > >> > it, but only one thing has actually worked. I had to pin the
> Gremlin
> > >> > Console to netty 4.0.x. Luckily, netty 4.0.x on gremlin-driver
> seems
> > >> > compatible with 4.1.x on the gremlin server so 

Re: Code Freeze 3.2.8/3.3.2

[Stephen Mallette]

I think I just did something bad to git.

Please don't push anything until I can try to sort out what happened. Damn

On Fri, Apr 6, 2018 at 7:51 PM, Stephen Mallette 
wrote:

> The vote threads are now closed up but we will wait until monday to
> finalize up the actual release. Have a good weekend everyone!
>
> On Tue, Mar 27, 2018 at 2:04 PM, Stephen Mallette 
> wrote:
>
>> I think the second issue is resolve now with:
>>
>> https://github.com/apache/tinkerpop/commit/2a9e7e24f4e255cad
>> 3eb300423634cbac110d74d
>>
>> we can thank kevin gallardo for the answer on that one.
>>
>> On Tue, Mar 27, 2018 at 7:39 AM, Stephen Mallette 
>> wrote:
>>
>>> Re-running tests now:
>>>
>>> https://github.com/apache/tinkerpop/commit/2e74c31c39b959263
>>> 605436555ba9cbc05eab2c5
>>>
>>> also, altered the original JIRA a bit:
>>>
>>> https://issues.apache.org/jira/browse/TINKERPOP-1884
>>>
>>>
>>>
>>> On Tue, Mar 27, 2018 at 7:08 AM, Robert Dale  wrote:
>>>
 Reverting back to netty 4.0 until there is a critical bug may be the
 best
 course.  Spark 2.3 upgrades to netty 4.1 so perhaps that can be done in
 tp34/master.

 Robert Dale

 On Tue, Mar 27, 2018 at 6:55 AM, Stephen Mallette 
 wrote:

 > hmm - i don't like how shifty this is all getting. I think I might
 bump
 > tp33 back to 4.0.x then everything will just work cleanly.
 >
 > btw, i'm also now aware of a second issue. the jackson version bump
 has
 > created an issue where byte[] is not serializing properly. it used to
 "just
 > work" but something must have changed in jackson to now require that
 it be
 > a registered type. i think i need to get that resolved prior to
 release -
 > this could mean a delay.
 >
 > On Tue, Mar 27, 2018 at 6:37 AM, Stephen Mallette <
 spmalle...@gmail.com>
 > wrote:
 >
 > > they would have a problem.  :/
 > >
 > > i'm thinking this is an unlikely case? Spark based traversals are
 > > analytical and thus typically executed through the console rather
 than
 > via
 > > Gremlin Server. So perhaps not a big deal breaker? What do people
 think?
 > >
 > > That said, luckily the workaround is the same as the one for the
 console.
 > > Simply need to remove the netty 4.1.x jar from gremlin server's
 /lib and
 > > replace it with 4.0.x. I just ran the Gremlin Server integration
 tests
 > and
 > > they pass with that configuration. I could document that process in:
 > >
 > > https://github.com/apache/tinkerpop/blob/master/gremlin-
 > > server/conf/gremlin-server-spark.yaml
 > >
 > >
 > >
 > > On Mon, Mar 26, 2018 at 8:57 PM, Robert Dale 
 wrote:
 > >
 > >> What happens if someone wants to install Spark in Gremlin Server?
 > >>
 > >> Robert Dale
 > >>
 > >> On Mon, Mar 26, 2018 at 4:07 PM, Stephen Mallette <
 spmalle...@gmail.com
 > >
 > >> wrote:
 > >>
 > >> > Kuppitz pointed out that we were having trouble building docs on
 tp33
 > >> and
 > >> > of course, it was spark related. I managed to sort out the
 problem and
 > >> we
 > >> > have our bump to netty 4.1.x to thank along with spark 2.2 being
 > pinned
 > >> on
 > >> > the 4.0.x line of netty. Basically spark is completely
 incompatible
 > >> there
 > >> > and we get errors as a result. I've tried all manner of things to
 > >> resolve
 > >> > it, but only one thing has actually worked. I had to pin the
 Gremlin
 > >> > Console to netty 4.0.x. Luckily, netty 4.0.x on gremlin-driver
 seems
 > >> > compatible with 4.1.x on the gremlin server so the console can
 still
 > >> talk
 > >> > to the server as needed. Here's the PR for consideration:
 > >> >
 > >> > https://github.com/apache/tinkerpop/pull/826
 > >> >
 > >> > if anyone has a better way to resolve this, i'm open to going
 with it
 > -
 > >> in
 > >> > the mean time, if committers could review/vote, that would be
 good.
 > >> >
 > >> >
 > >> >
 > >> > On Sat, Mar 24, 2018 at 4:09 PM, Stephen Mallette <
 > spmalle...@gmail.com
 > >> >
 > >> > wrote:
 > >> >
 > >> > > Just a reminder that code freeze is in effect for the next
 week.
 > >> Please
 > >> > > post issues related to release of 3.2.8/3.3.2 on this thread as
 > >> needed.
 > >> > >
 > >> >
 > >>
 > >
 > >
 >

>>>
>>>
>>
>

[GitHub] tinkerpop pull request #833: TINKERPOP-1903 Migrated Credential DSL to annot...

[spmallette]

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/833

TINKERPOP-1903 Migrated Credential DSL to annotation processor

https://issues.apache.org/jira/browse/TINKERPOP-1903

The old CredentialGraph approach to the Credential DSL has been deprecated 
in favor of the preferred method for DSL development which was published long 
after the original DSL was developed.

All tests pass with `docker/build.sh -t -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1903

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #833


commit 972a9cd48c765bc16b72f5917899b0855711c609
Author: Stephen Mallette 
Date:   2018-04-05T15:51:49Z

TINKERPOP-1903 Migrated Credential DSL to annotation processor

The old CredentialGraph approach to the Credential DSL has been deprecated 
in favor of the preferred method for DSL development which was published long 
after the original DSL was developed.




---

[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429177#comment-16429177
 ] 

ASF GitHub Bot commented on TINKERPOP-1903:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/833

TINKERPOP-1903 Migrated Credential DSL to annotation processor

https://issues.apache.org/jira/browse/TINKERPOP-1903

The old CredentialGraph approach to the Credential DSL has been deprecated 
in favor of the preferred method for DSL development which was published long 
after the original DSL was developed.

All tests pass with `docker/build.sh -t -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1903

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #833


commit 972a9cd48c765bc16b72f5917899b0855711c609
Author: Stephen Mallette 
Date:   2018-04-05T15:51:49Z

TINKERPOP-1903 Migrated Credential DSL to annotation processor

The old CredentialGraph approach to the Credential DSL has been deprecated 
in favor of the preferred method for DSL development which was published long 
after the original DSL was developed.




> Credentials DSL should use the Java annotation processor
> 
>
> Key: TINKERPOP-1903
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1903
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>  Labels: deprecation
> Fix For: 3.3.3
>
>
> This content is a bit outdated - 
> http://tinkerpop.apache.org/docs/current/reference/#credentials-dsl
> uses the old method of DSL development prior to when we established the 
> annotation processor - need to fix both the code itself and the documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1934) Bump to latest version of httpclient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429176#comment-16429176
 ] 

ASF GitHub Bot commented on TINKERPOP-1934:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/832

TINKERPOP-1934 Bumped httpclient to 4.5.5

https://issues.apache.org/jira/browse/TINKERPOP-1934

Removed httpcore NOTICE entry as this more recent version does not contain 
that designation in its NOTICE.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1934

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #832


commit d0901649389da33324e6833b0c84884cf6ec801a
Author: Stephen Mallette 
Date:   2018-04-05T12:11:59Z

TINKERPOP-1934 Bumped httpclient to 4.5.5

Removed httpcore NOTICE entry as this more recent version does not contain 
that designation in its NOTICE.




> Bump to latest version of httpclient
> 
>
> Key: TINKERPOP-1934
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1934
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0, 3.2.9, 3.3.3
>
>
> Should probably go to 4.5.5 which will cleanly get us away from:
> https://nvd.nist.gov/vuln/detail/CVE-2013-4366
> We seem to reference httpclient in a bunch of places - should probably unify 
> the version if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] tinkerpop pull request #832: TINKERPOP-1934 Bumped httpclient to 4.5.5

[spmallette]

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/832

TINKERPOP-1934 Bumped httpclient to 4.5.5

https://issues.apache.org/jira/browse/TINKERPOP-1934

Removed httpcore NOTICE entry as this more recent version does not contain 
that designation in its NOTICE.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1934

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #832


commit d0901649389da33324e6833b0c84884cf6ec801a
Author: Stephen Mallette 
Date:   2018-04-05T12:11:59Z

TINKERPOP-1934 Bumped httpclient to 4.5.5

Removed httpcore NOTICE entry as this more recent version does not contain 
that designation in its NOTICE.




---

Re: Code Freeze 3.2.8/3.3.2

[Stephen Mallette]

The vote threads are now closed up but we will wait until monday to
finalize up the actual release. Have a good weekend everyone!

On Tue, Mar 27, 2018 at 2:04 PM, Stephen Mallette 
wrote:

> I think the second issue is resolve now with:
>
> https://github.com/apache/tinkerpop/commit/2a9e7e24f4e255cad3eb300423634c
> bac110d74d
>
> we can thank kevin gallardo for the answer on that one.
>
> On Tue, Mar 27, 2018 at 7:39 AM, Stephen Mallette 
> wrote:
>
>> Re-running tests now:
>>
>> https://github.com/apache/tinkerpop/commit/2e74c31c39b959263
>> 605436555ba9cbc05eab2c5
>>
>> also, altered the original JIRA a bit:
>>
>> https://issues.apache.org/jira/browse/TINKERPOP-1884
>>
>>
>>
>> On Tue, Mar 27, 2018 at 7:08 AM, Robert Dale  wrote:
>>
>>> Reverting back to netty 4.0 until there is a critical bug may be the best
>>> course.  Spark 2.3 upgrades to netty 4.1 so perhaps that can be done in
>>> tp34/master.
>>>
>>> Robert Dale
>>>
>>> On Tue, Mar 27, 2018 at 6:55 AM, Stephen Mallette 
>>> wrote:
>>>
>>> > hmm - i don't like how shifty this is all getting. I think I might bump
>>> > tp33 back to 4.0.x then everything will just work cleanly.
>>> >
>>> > btw, i'm also now aware of a second issue. the jackson version bump has
>>> > created an issue where byte[] is not serializing properly. it used to
>>> "just
>>> > work" but something must have changed in jackson to now require that
>>> it be
>>> > a registered type. i think i need to get that resolved prior to
>>> release -
>>> > this could mean a delay.
>>> >
>>> > On Tue, Mar 27, 2018 at 6:37 AM, Stephen Mallette <
>>> spmalle...@gmail.com>
>>> > wrote:
>>> >
>>> > > they would have a problem.  :/
>>> > >
>>> > > i'm thinking this is an unlikely case? Spark based traversals are
>>> > > analytical and thus typically executed through the console rather
>>> than
>>> > via
>>> > > Gremlin Server. So perhaps not a big deal breaker? What do people
>>> think?
>>> > >
>>> > > That said, luckily the workaround is the same as the one for the
>>> console.
>>> > > Simply need to remove the netty 4.1.x jar from gremlin server's /lib
>>> and
>>> > > replace it with 4.0.x. I just ran the Gremlin Server integration
>>> tests
>>> > and
>>> > > they pass with that configuration. I could document that process in:
>>> > >
>>> > > https://github.com/apache/tinkerpop/blob/master/gremlin-
>>> > > server/conf/gremlin-server-spark.yaml
>>> > >
>>> > >
>>> > >
>>> > > On Mon, Mar 26, 2018 at 8:57 PM, Robert Dale 
>>> wrote:
>>> > >
>>> > >> What happens if someone wants to install Spark in Gremlin Server?
>>> > >>
>>> > >> Robert Dale
>>> > >>
>>> > >> On Mon, Mar 26, 2018 at 4:07 PM, Stephen Mallette <
>>> spmalle...@gmail.com
>>> > >
>>> > >> wrote:
>>> > >>
>>> > >> > Kuppitz pointed out that we were having trouble building docs on
>>> tp33
>>> > >> and
>>> > >> > of course, it was spark related. I managed to sort out the
>>> problem and
>>> > >> we
>>> > >> > have our bump to netty 4.1.x to thank along with spark 2.2 being
>>> > pinned
>>> > >> on
>>> > >> > the 4.0.x line of netty. Basically spark is completely
>>> incompatible
>>> > >> there
>>> > >> > and we get errors as a result. I've tried all manner of things to
>>> > >> resolve
>>> > >> > it, but only one thing has actually worked. I had to pin the
>>> Gremlin
>>> > >> > Console to netty 4.0.x. Luckily, netty 4.0.x on gremlin-driver
>>> seems
>>> > >> > compatible with 4.1.x on the gremlin server so the console can
>>> still
>>> > >> talk
>>> > >> > to the server as needed. Here's the PR for consideration:
>>> > >> >
>>> > >> > https://github.com/apache/tinkerpop/pull/826
>>> > >> >
>>> > >> > if anyone has a better way to resolve this, i'm open to going
>>> with it
>>> > -
>>> > >> in
>>> > >> > the mean time, if committers could review/vote, that would be
>>> good.
>>> > >> >
>>> > >> >
>>> > >> >
>>> > >> > On Sat, Mar 24, 2018 at 4:09 PM, Stephen Mallette <
>>> > spmalle...@gmail.com
>>> > >> >
>>> > >> > wrote:
>>> > >> >
>>> > >> > > Just a reminder that code freeze is in effect for the next week.
>>> > >> Please
>>> > >> > > post issues related to release of 3.2.8/3.3.2 on this thread as
>>> > >> needed.
>>> > >> > >
>>> > >> >
>>> > >>
>>> > >
>>> > >
>>> >
>>>
>>
>>
>

[RESULT][VOTE] TinkerPop 3.3.2 Release

[Stephen Mallette]

This vote is now closed with a total of 4 +1s, no +0s and no -1s. The results
are:

BINDING VOTES:

+1  (4 -- Dylan Millikin, Daniel Kuppitz, Stephen Mallette, Jason Plurad)
0   (0)
-1  (0)

NON-BINDING VOTES:

+1 (0)
0  (0)
-1 (0)

Thanks,

Stephen

On Fri, Apr 6, 2018 at 2:43 PM, Dylan Millikin 
wrote:

> Ran all tests from the php end. Everything passes. Actually added a couple
> more and those also pass.
>
> VOTE: +1
>
> On Fri, Apr 6, 2018 at 9:29 AM, Jason Plurad  wrote:
>
> > Validated the binaries, did several manual tests with the Gremlin Server
> +
> > Gremlin Console, looked over the documentation.
> >
> > The instructions on the download page to verify with gpg manually are
> fine
> > since the output does say "Good signature" even with the [unknown]
> suffix.
> >
> > VOTE: +1
> >
> > On Wed, Apr 4, 2018 at 2:08 PM, Daniel Kuppitz  wrote:
> >
> > > With the suffix ignored it all looks good.
> > >
> > > Validating binary distributions
> > >
> > > * downloading Apache TinkerPop Gremlin
> > > (apache-tinkerpop-gremlin-console-3.3.2-bin.zip)... OK
> > > * validating signatures and checksums ...
> > >   * PGP signature ... OK
> > >   * MD5 checksum ... OK
> > >   * SHA1 checksum ... OK
> > > * unzipping Apache TinkerPop Gremlin ... OK
> > > * validating Apache TinkerPop Gremlin's docs ... OK
> > > * validating Apache TinkerPop Gremlin's binaries ... OK
> > > * validating Apache TinkerPop Gremlin's legal files ...
> > >   * LICENSE ... OK
> > >   * NOTICE ... OK
> > > * validating Apache TinkerPop Gremlin's plugin directory ... OK
> > > * validating Apache TinkerPop Gremlin's lib directory ... OK
> > > * testing script evaluation ... OK
> > >
> > > * downloading Apache TinkerPop Gremlin
> > > (apache-tinkerpop-gremlin-server-3.3.2-bin.zip)... OK
> > > * validating signatures and checksums ...
> > >   * PGP signature ... OK
> > >   * MD5 checksum ... OK
> > >   * SHA1 checksum ... OK
> > > * unzipping Apache TinkerPop Gremlin ... OK
> > > * validating Apache TinkerPop Gremlin's docs ... OK
> > > * validating Apache TinkerPop Gremlin's binaries ... OK
> > > * validating Apache TinkerPop Gremlin's legal files ...
> > >   * LICENSE ... OK
> > >   * NOTICE ... OK
> > > * validating Apache TinkerPop Gremlin's plugin directory ... OK
> > > * validating Apache TinkerPop Gremlin's lib directory ... OK
> > >
> > > Validating source distribution
> > >
> > > * downloading Apache TinkerPop 3.3.2 (apache-tinkerpop-3.3.2-src.
> zip)...
> > > OK
> > > * validating signatures and checksums ...
> > >   * PGP signature ... OK
> > >   * MD5 checksum ... OK
> > >   * SHA1 checksum ... OK
> > > * unzipping Apache TinkerPop 3.3.2 ... OK
> > > * building project ... OK
> > >
> > >
> > > VOTE: +1 (if nobody has any objections regarding the suffix)
> > >
> > > Furthermore, here's the output of the verification step shown on the
> > > download page:
> > >
> > > $ gpg --verify apache-tinkerpop-3.3.2-src.zip.asc
> > > apache-tinkerpop-3.3.2-src.zip
> > > gpg: Signature made Tue 03 Apr 2018 12:45:53 PM MST
> > > gpg:using RSA key EA53A99854EAB0E6
> > > gpg: Good signature from "Stephen Mallette "
> > > [unknown]
> > > gpg: WARNING: This key is not certified with a trusted signature!
> > > gpg:  There is no indication that the signature belongs to the
> > > owner.
> > > Primary key fingerprint: 0871 A360 AAB5 FD42 2516  E2FB EA53 A998 54EA
> > B0E6
> > >
> > >
> > > Cheers,
> > > Daniel
> > >
> > >
> > > On Wed, Apr 4, 2018 at 1:59 PM, Daniel Kuppitz 
> wrote:
> > >
> > > > Much newer.
> > > >
> > > > $ gpg --version
> > > > gpg (GnuPG) 2.1.15
> > > > libgcrypt 1.7.8
> > > > Copyright (C) 2016 Free Software Foundation, Inc.
> > > > License GPLv3+: GNU GPL version 3 or later <
> > https://gnu.org/licenses/gpl
> > > .
> > > > html>
> > > > This is free software: you are free to change and redistribute it.
> > > > There is NO WARRANTY, to the extent permitted by law.
> > > >
> > > > Home: /home/daniel/.gnupg
> > > > Supported algorithms:
> > > > Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
> > > > Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
> > > > CAMELLIA128, CAMELLIA192, CAMELLIA256
> > > > Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
> > > > Compression: Uncompressed, ZIP, ZLIB, BZIP2
> > > >
> > > >
> > > >
> > > > On Wed, Apr 4, 2018 at 1:57 PM, Stephen Mallette <
> spmalle...@gmail.com
> > >
> > > > wrote:
> > > >
> > > >> out of curiosity - what gpg version do you have? i'm on:
> > > >>
> > > >> $ gpg --version
> > > >> gpg (GnuPG) 1.4.16
> > > >>
> > > >> is that ancient or something? i'd be curious if anyone else has this
> > > >> problem. it's also semi-concerning that this doesn't work because
> we'd
> > > >> want
> > > >> to the verification to behave right with the instructions we have
> > here:
> > > >>
> > > >> http://tinkerpop.apache.org/downloads.html

[GitHub] tinkerpop issue #831: TINKERPOP-1410 Removed test artifact of hadoop-gremlin

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/831
  
VOTE: +1


---

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428962#comment-16428962
 ] 

ASF GitHub Bot commented on TINKERPOP-1410:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/831
  
VOTE: +1


> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] tinkerpop issue #830: TINKERPOP-1143 Moved TraversalEngine to gremlin-test

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/830
  
VOTE: +1


---

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428807#comment-16428807
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/830
  
VOTE: +1


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428800#comment-16428800
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179849183
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

that makes sense - fixed and pushed


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

[spmallette]

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179849183
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

that makes sense - fixed and pushed


---

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428797#comment-16428797
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179848121
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

It's not bad. I don't fully understand the code in `CountMatchAlgorithm` 
(the only place where the boolean flag makes a difference), but it seems like 
it only reorders the match traversals, possibly to optimize memory consumption 
and/or processing time.


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

[dkuppitz]

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179848121
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

It's not bad. I don't fully understand the code in `CountMatchAlgorithm` 
(the only place where the boolean flag makes a difference), but it seems like 
it only reorders the match traversals, possibly to optimize memory consumption 
and/or processing time.


---

Re: [VOTE] TinkerPop 3.3.2 Release

[Dylan Millikin]

Ran all tests from the php end. Everything passes. Actually added a couple
more and those also pass.

VOTE: +1

On Fri, Apr 6, 2018 at 9:29 AM, Jason Plurad  wrote:

> Validated the binaries, did several manual tests with the Gremlin Server +
> Gremlin Console, looked over the documentation.
>
> The instructions on the download page to verify with gpg manually are fine
> since the output does say "Good signature" even with the [unknown] suffix.
>
> VOTE: +1
>
> On Wed, Apr 4, 2018 at 2:08 PM, Daniel Kuppitz  wrote:
>
> > With the suffix ignored it all looks good.
> >
> > Validating binary distributions
> >
> > * downloading Apache TinkerPop Gremlin
> > (apache-tinkerpop-gremlin-console-3.3.2-bin.zip)... OK
> > * validating signatures and checksums ...
> >   * PGP signature ... OK
> >   * MD5 checksum ... OK
> >   * SHA1 checksum ... OK
> > * unzipping Apache TinkerPop Gremlin ... OK
> > * validating Apache TinkerPop Gremlin's docs ... OK
> > * validating Apache TinkerPop Gremlin's binaries ... OK
> > * validating Apache TinkerPop Gremlin's legal files ...
> >   * LICENSE ... OK
> >   * NOTICE ... OK
> > * validating Apache TinkerPop Gremlin's plugin directory ... OK
> > * validating Apache TinkerPop Gremlin's lib directory ... OK
> > * testing script evaluation ... OK
> >
> > * downloading Apache TinkerPop Gremlin
> > (apache-tinkerpop-gremlin-server-3.3.2-bin.zip)... OK
> > * validating signatures and checksums ...
> >   * PGP signature ... OK
> >   * MD5 checksum ... OK
> >   * SHA1 checksum ... OK
> > * unzipping Apache TinkerPop Gremlin ... OK
> > * validating Apache TinkerPop Gremlin's docs ... OK
> > * validating Apache TinkerPop Gremlin's binaries ... OK
> > * validating Apache TinkerPop Gremlin's legal files ...
> >   * LICENSE ... OK
> >   * NOTICE ... OK
> > * validating Apache TinkerPop Gremlin's plugin directory ... OK
> > * validating Apache TinkerPop Gremlin's lib directory ... OK
> >
> > Validating source distribution
> >
> > * downloading Apache TinkerPop 3.3.2 (apache-tinkerpop-3.3.2-src.zip)...
> > OK
> > * validating signatures and checksums ...
> >   * PGP signature ... OK
> >   * MD5 checksum ... OK
> >   * SHA1 checksum ... OK
> > * unzipping Apache TinkerPop 3.3.2 ... OK
> > * building project ... OK
> >
> >
> > VOTE: +1 (if nobody has any objections regarding the suffix)
> >
> > Furthermore, here's the output of the verification step shown on the
> > download page:
> >
> > $ gpg --verify apache-tinkerpop-3.3.2-src.zip.asc
> > apache-tinkerpop-3.3.2-src.zip
> > gpg: Signature made Tue 03 Apr 2018 12:45:53 PM MST
> > gpg:using RSA key EA53A99854EAB0E6
> > gpg: Good signature from "Stephen Mallette "
> > [unknown]
> > gpg: WARNING: This key is not certified with a trusted signature!
> > gpg:  There is no indication that the signature belongs to the
> > owner.
> > Primary key fingerprint: 0871 A360 AAB5 FD42 2516  E2FB EA53 A998 54EA
> B0E6
> >
> >
> > Cheers,
> > Daniel
> >
> >
> > On Wed, Apr 4, 2018 at 1:59 PM, Daniel Kuppitz  wrote:
> >
> > > Much newer.
> > >
> > > $ gpg --version
> > > gpg (GnuPG) 2.1.15
> > > libgcrypt 1.7.8
> > > Copyright (C) 2016 Free Software Foundation, Inc.
> > > License GPLv3+: GNU GPL version 3 or later <
> https://gnu.org/licenses/gpl
> > .
> > > html>
> > > This is free software: you are free to change and redistribute it.
> > > There is NO WARRANTY, to the extent permitted by law.
> > >
> > > Home: /home/daniel/.gnupg
> > > Supported algorithms:
> > > Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
> > > Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
> > > CAMELLIA128, CAMELLIA192, CAMELLIA256
> > > Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
> > > Compression: Uncompressed, ZIP, ZLIB, BZIP2
> > >
> > >
> > >
> > > On Wed, Apr 4, 2018 at 1:57 PM, Stephen Mallette  >
> > > wrote:
> > >
> > >> out of curiosity - what gpg version do you have? i'm on:
> > >>
> > >> $ gpg --version
> > >> gpg (GnuPG) 1.4.16
> > >>
> > >> is that ancient or something? i'd be curious if anyone else has this
> > >> problem. it's also semi-concerning that this doesn't work because we'd
> > >> want
> > >> to the verification to behave right with the instructions we have
> here:
> > >>
> > >> http://tinkerpop.apache.org/downloads.html
> > >>
> > >> wonder if that's a problem too?
> > >>
> > >>
> > >>
> > >> On Wed, Apr 4, 2018 at 4:54 PM, Daniel Kuppitz 
> wrote:
> > >>
> > >> > Either this or I might have a newer gpg version which changed the
> > output
> > >> > slightly. We already ignore the suffix for Ted and Jason, so I guess
> > we
> > >> > should just use the same pattern for everyone. I can CTR this change
> > >> into
> > >> > all main branches; it's just that:
> > >> >
> > >> > -[ `gpg ${ZIP_FILENAME}.asc 2>&1 | grep -c '^gpg: Good signature
> from
> > >> > "Stephen Mallette 

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428767#comment-16428767
 ] 

ASF GitHub Bot commented on TINKERPOP-1410:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/831

TINKERPOP-1410 Removed test artifact of hadoop-gremlin

https://issues.apache.org/jira/browse/TINKERPOP-1410

The hadoop-gremlin test artifact allowed us to re-use some classes in spark 
and giraph testing, but (1) we probably shouldn't have done that in the first 
place as it's not a great practice and (2) we no longer have giraph and there 
really aren't any providers that rely on these classes that I'm aware of. I 
moved around a few classes to get this to all work which is described in more 
detail in upgrade docs. All the test still execute as they did before.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1410

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #831


commit 7eec250a45a4a65bec87364d2c6ca8d895c7cb10
Author: Stephen Mallette 
Date:   2018-04-06T17:10:22Z

TINKERPOP-1410 Removed test artifact of hadoop-gremlin

The hadoop-gremlin test artifact allowed us to re-use some classes in spark 
and giraph testing, but (1) we probably shouldn't have done that in the first 
place as it's not a great practice and (2) we no longer have giraph and there 
really aren't any providers that rely on these classes that I'm aware of. I 
moved around a few classes to get this to all work which is described in more 
detail in upgrade docs. All the test still execute as they did before.




> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] tinkerpop pull request #831: TINKERPOP-1410 Removed test artifact of hadoop-...

[spmallette]

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/831

TINKERPOP-1410 Removed test artifact of hadoop-gremlin

https://issues.apache.org/jira/browse/TINKERPOP-1410

The hadoop-gremlin test artifact allowed us to re-use some classes in spark 
and giraph testing, but (1) we probably shouldn't have done that in the first 
place as it's not a great practice and (2) we no longer have giraph and there 
really aren't any providers that rely on these classes that I'm aware of. I 
moved around a few classes to get this to all work which is described in more 
detail in upgrade docs. All the test still execute as they did before.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1410

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #831


commit 7eec250a45a4a65bec87364d2c6ca8d895c7cb10
Author: Stephen Mallette 
Date:   2018-04-06T17:10:22Z

TINKERPOP-1410 Removed test artifact of hadoop-gremlin

The hadoop-gremlin test artifact allowed us to re-use some classes in spark 
and giraph testing, but (1) we probably shouldn't have done that in the first 
place as it's not a great practice and (2) we no longer have giraph and there 
really aren't any providers that rely on these classes that I'm aware of. I 
moved around a few classes to get this to all work which is described in more 
detail in upgrade docs. All the test still execute as they did before.




---

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

[spmallette]

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179843523
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

oh wow - good catch. i guess the tests pass either way though...don't know 
if that's bad.???


---

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428762#comment-16428762
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179843523
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

oh wow - good catch. i guess the tests pass either way though...don't know 
if that's bad.???


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT][VOTE] TinkerPop 3.2.8 Release

[Ted Wilmes]

 This vote is now closed with a total of 4 +1s, no +0s and no -1s. The
results are:

BINDING VOTES:

+1  (4 -- Ted Wilmes, Daniel Kuppitz, Stephen Mallette, Jason Plurad)
0   (0)
-1  (0)

NON-BINDING VOTES:

+1 (0)
0  (0)
-1 (0)

Thank you very much,
Ted Wilmes

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428669#comment-16428669
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179829888
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

Shouldn't this be `false`?


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

[dkuppitz]

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179829888
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

Shouldn't this be `false`?


---

[jira] [Assigned] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette reassigned TINKERPOP-1410:
---

 Assignee: stephen mallette
   Labels: breaking  (was: )
 Priority: Minor  (was: Major)
Fix Version/s: 3.4.0
   Issue Type: Improvement  (was: Bug)

> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] TinkerPop 3.3.2 Release

[Jason Plurad]

Validated the binaries, did several manual tests with the Gremlin Server +
Gremlin Console, looked over the documentation.

The instructions on the download page to verify with gpg manually are fine
since the output does say "Good signature" even with the [unknown] suffix.

VOTE: +1

On Wed, Apr 4, 2018 at 2:08 PM, Daniel Kuppitz  wrote:

> With the suffix ignored it all looks good.
>
> Validating binary distributions
>
> * downloading Apache TinkerPop Gremlin
> (apache-tinkerpop-gremlin-console-3.3.2-bin.zip)... OK
> * validating signatures and checksums ...
>   * PGP signature ... OK
>   * MD5 checksum ... OK
>   * SHA1 checksum ... OK
> * unzipping Apache TinkerPop Gremlin ... OK
> * validating Apache TinkerPop Gremlin's docs ... OK
> * validating Apache TinkerPop Gremlin's binaries ... OK
> * validating Apache TinkerPop Gremlin's legal files ...
>   * LICENSE ... OK
>   * NOTICE ... OK
> * validating Apache TinkerPop Gremlin's plugin directory ... OK
> * validating Apache TinkerPop Gremlin's lib directory ... OK
> * testing script evaluation ... OK
>
> * downloading Apache TinkerPop Gremlin
> (apache-tinkerpop-gremlin-server-3.3.2-bin.zip)... OK
> * validating signatures and checksums ...
>   * PGP signature ... OK
>   * MD5 checksum ... OK
>   * SHA1 checksum ... OK
> * unzipping Apache TinkerPop Gremlin ... OK
> * validating Apache TinkerPop Gremlin's docs ... OK
> * validating Apache TinkerPop Gremlin's binaries ... OK
> * validating Apache TinkerPop Gremlin's legal files ...
>   * LICENSE ... OK
>   * NOTICE ... OK
> * validating Apache TinkerPop Gremlin's plugin directory ... OK
> * validating Apache TinkerPop Gremlin's lib directory ... OK
>
> Validating source distribution
>
> * downloading Apache TinkerPop 3.3.2 (apache-tinkerpop-3.3.2-src.zip)...
> OK
> * validating signatures and checksums ...
>   * PGP signature ... OK
>   * MD5 checksum ... OK
>   * SHA1 checksum ... OK
> * unzipping Apache TinkerPop 3.3.2 ... OK
> * building project ... OK
>
>
> VOTE: +1 (if nobody has any objections regarding the suffix)
>
> Furthermore, here's the output of the verification step shown on the
> download page:
>
> $ gpg --verify apache-tinkerpop-3.3.2-src.zip.asc
> apache-tinkerpop-3.3.2-src.zip
> gpg: Signature made Tue 03 Apr 2018 12:45:53 PM MST
> gpg:using RSA key EA53A99854EAB0E6
> gpg: Good signature from "Stephen Mallette "
> [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg:  There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: 0871 A360 AAB5 FD42 2516  E2FB EA53 A998 54EA B0E6
>
>
> Cheers,
> Daniel
>
>
> On Wed, Apr 4, 2018 at 1:59 PM, Daniel Kuppitz  wrote:
>
> > Much newer.
> >
> > $ gpg --version
> > gpg (GnuPG) 2.1.15
> > libgcrypt 1.7.8
> > Copyright (C) 2016 Free Software Foundation, Inc.
> > License GPLv3+: GNU GPL version 3 or later  .
> > html>
> > This is free software: you are free to change and redistribute it.
> > There is NO WARRANTY, to the extent permitted by law.
> >
> > Home: /home/daniel/.gnupg
> > Supported algorithms:
> > Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
> > Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
> > CAMELLIA128, CAMELLIA192, CAMELLIA256
> > Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
> > Compression: Uncompressed, ZIP, ZLIB, BZIP2
> >
> >
> >
> > On Wed, Apr 4, 2018 at 1:57 PM, Stephen Mallette 
> > wrote:
> >
> >> out of curiosity - what gpg version do you have? i'm on:
> >>
> >> $ gpg --version
> >> gpg (GnuPG) 1.4.16
> >>
> >> is that ancient or something? i'd be curious if anyone else has this
> >> problem. it's also semi-concerning that this doesn't work because we'd
> >> want
> >> to the verification to behave right with the instructions we have here:
> >>
> >> http://tinkerpop.apache.org/downloads.html
> >>
> >> wonder if that's a problem too?
> >>
> >>
> >>
> >> On Wed, Apr 4, 2018 at 4:54 PM, Daniel Kuppitz  wrote:
> >>
> >> > Either this or I might have a newer gpg version which changed the
> output
> >> > slightly. We already ignore the suffix for Ted and Jason, so I guess
> we
> >> > should just use the same pattern for everyone. I can CTR this change
> >> into
> >> > all main branches; it's just that:
> >> >
> >> > -[ `gpg ${ZIP_FILENAME}.asc 2>&1 | grep -c '^gpg: Good signature from
> >> > "Stephen Mallette "$'` -eq 1 ] || \
> >> > -[ `gpg ${ZIP_FILENAME}.asc 2>&1 | grep -c '^gpg: Good signature from
> >> > "Marko Rodriguez "$'` -eq 1 ] || \
> >> > +[ `gpg ${ZIP_FILENAME}.asc 2>&1 | grep -c '^gpg: Good signature from
> >> > "Stephen Mallette "'` -eq 1 ] || \
> >> > +[ `gpg ${ZIP_FILENAME}.asc 2>&1 | grep -c '^gpg: Good signature from
> >> > "Marko Rodriguez "'` -eq 1 ] || \
> >> >
> >> > Cheers,
>