[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950100#comment-15950100 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user dpitera commented on the issue:

[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...

2017-03-30 Thread dpitera
Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/569 IT tests passed! ``` [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop .. SUCCESS [1:31.220s] [INFO] Apache TinkerPop :: Gremlin Shaded

[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...

2017-03-30 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @spmallette I'm also surprised, but not a docker expert. I'm happy to try out other stuff to get to the bottom of that problem, just let me know if you have some idea. @robertdale Re

[jira] [Closed] (TINKERPOP-1642) Improve performance of mutating traversals

2017-03-30 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1642. - Resolution: Fixed Fix Version/s: 3.2.5 > Improve performance of

[jira] [Commented] (TINKERPOP-1642) Improve performance of mutating traversals

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949703#comment-15949703 ] ASF GitHub Bot commented on TINKERPOP-1642: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #587: TINKERPOP-1642 Performance Enhancement on Mutat...

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (TINKERPOP-1642) Improve performance of mutating traversals

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949673#comment-15949673 ] ASF GitHub Bot commented on TINKERPOP-1642: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #587: TINKERPOP-1642 Performance Enhancement on Mutating Tra...

2017-03-30 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/587 My app tests pass. Also noticed a slight reduction in test time. :grinning: VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949650#comment-15949650 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user krlohnes commented on a diff in the

[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949649#comment-15949649 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user krlohnes commented on a diff in the

[GitHub] tinkerpop pull request #583: TINKERPOP-1657 Provide abstraction to easily al...

2017-03-30 Thread krlohnes
Github user krlohnes commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/583#discussion_r109015202 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java --- @@ -387,6 +387,18 @@ public SerializerSettings() {}

[GitHub] tinkerpop pull request #583: TINKERPOP-1657 Provide abstraction to easily al...

2017-03-30 Thread krlohnes
Github user krlohnes commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/583#discussion_r109015184 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java --- @@ -387,6 +387,18 @@ public SerializerSettings() {}

[GitHub] tinkerpop pull request #583: TINKERPOP-1657 Provide abstraction to easily al...

2017-03-30 Thread krlohnes
Github user krlohnes commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/583#discussion_r109015220 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/AuthenticationHandler.java --- @@ -0,0 +1,52 @@ +/* + *

[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949648#comment-15949648 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user krlohnes commented on a diff in the

[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949621#comment-15949621 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #583: TINKERPOP-1657 Provide abstraction to easily allow dif...

2017-03-30 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/583 One thing I haven't had much time to think about here is how to propagate ssl client authentication up (into an authentication handler). Right now it's at the channel level only. That means

[jira] [Closed] (TINKERPOP-1659) Docker build should use maven settings.xml

2017-03-30 Thread Robert Dale (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale closed TINKERPOP-1659. -- Resolution: Fixed > Docker build should use maven settings.xml >

[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949211#comment-15949211 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user dpitera commented on the issue:

[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...

2017-03-30 Thread dpitera
Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/569 > I think we want the behavior to generally be a "replace" and thus "putTraversalSource()" and "putGraph()" seem like better names. +1 > This has developed into a really nice

[jira] [Commented] (TINKERPOP-1659) Docker build should use maven settings.xml

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949187#comment-15949187 ] ASF GitHub Bot commented on TINKERPOP-1659: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #588: TINKERPOP-1659 Docker uses custom maven setting...

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (TINKERPOP-1659) Docker build should use maven settings.xml

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949019#comment-15949019 ] ASF GitHub Bot commented on TINKERPOP-1659: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #588: TINKERPOP-1659 Docker uses custom maven settings.xml

2017-03-30 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/588 They've started laying fiber in the county. Hopefully they'll bring it all the way down my road. But I don't know if that's 1 year or 5 years from now. Until then, I'm at the outer limits of

[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...

2017-03-30 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/589 I like how the previous example shows the vertices before applying sack(). I think it would be useful to see that before 1 and before 3. Why was the example withBulk(false) removed? I

[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948990#comment-15948990 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...

2017-03-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/569 I've finished playing around with my dummy implementation. Just one weird thing that wasn't easy to see without actually working with the API - `addTraversalSource()` and `addGraph()` aren't

[jira] [Commented] (TINKERPOP-1659) Docker build should use maven settings.xml

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948976#comment-15948976 ] ASF GitHub Bot commented on TINKERPOP-1659: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop issue #588: TINKERPOP-1659 Docker uses custom maven settings.xml

2017-03-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/588 I recently got faster internet, so -1 on this. Just kidding :). Looks good to me and actually doesn't change anything in the "normal" workflow. VOTE: +1 --- If your project is

[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948824#comment-15948824 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #569: TINKERPOP-1438: GraphManager becomes a customiz...

2017-03-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/569#discussion_r108893957 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GraphManager.java --- @@ -21,139 +21,101 @@ import

[GitHub] tinkerpop issue #587: TINKERPOP-1642 Performance Enhancement on Mutating Tra...

2017-03-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/587 `docker/build.sh -t -n -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not