[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312251#comment-16312251 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commente

[GitHub] tinkerpop issue #766: TINKERPOP-1447 Add some JavaScript intelligence to the...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 i deleted both when i did it, but i didn't rebuild from master - i built from this branch i guess ---

[jira] [Commented] (TINKERPOP-1844) Python GLV test should run for GraphSON 3.0

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312234#comment-16312234 ] ASF GitHub Bot commented on TINKERPOP-1844: --- Github user davebshow commented

[GitHub] tinkerpop issue #769: TINKERPOP-1844 Default GraphSON 3.0 for GLV tests in g...

2018-01-04 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/769 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312230#comment-16312230 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commente

[GitHub] tinkerpop issue #766: TINKERPOP-1447 Add some JavaScript intelligence to the...

2018-01-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 Hmm.. there doesn't seem to be much difference. Are you deleting both the hadoop and base images? ---

[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1631#comment-1631 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commente

[GitHub] tinkerpop issue #766: TINKERPOP-1447 Add some JavaScript intelligence to the...

2018-01-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 Try rebuilding the docker images using master. ---

[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312209#comment-16312209 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commente

[GitHub] tinkerpop issue #766: TINKERPOP-1447 Add some JavaScript intelligence to the...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 I saw some problems using docker above to generate docsis that still an issue? I'm getting this: ```text * source: /usr/src/tinkerpop/docs/src/reference/gremlin-variants.asci

[jira] [Commented] (TINKERPOP-1844) Python GLV test should run for GraphSON 3.0

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311872#comment-16311872 ] ASF GitHub Bot commented on TINKERPOP-1844: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #769: TINKERPOP-1844 Default GraphSON 3.0 for GLV tests in g...

2018-01-04 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/769 VOTE: +1 ---

[GitHub] tinkerpop pull request #770: TINKERPOP-1862 TinkerMessenger proper handling ...

2018-01-04 Thread PBGraff
GitHub user PBGraff opened a pull request: https://github.com/apache/tinkerpop/pull/770 TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH This PR presents a fix for `TinkerMessenger` that handled `Direction.BOTH` by identifying the `Vertex` that is not the one receivi

[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311831#comment-16311831 ] ASF GitHub Bot commented on TINKERPOP-1862: --- GitHub user PBGraff opened a pu

[DISCUSS] Use List instead of Set in gremlin-python

2018-01-04 Thread Stephen Mallette
I've been trying to figure out why the GLV test suite won't pass for gremlin-python in GraphSON 3.0 on this issue: https://issues.apache.org/jira/browse/TINKERPOP-1844 The answer turns out to be related to the g:Set. Numbers of mixed types returned from a Set in java aren't recognized as distinct

[jira] [Commented] (TINKERPOP-1844) Python GLV test should run for GraphSON 3.0

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311591#comment-16311591 ] ASF GitHub Bot commented on TINKERPOP-1844: --- GitHub user spmallette opened a

[GitHub] tinkerpop pull request #769: TINKERPOP-1844 Default GraphSON 3.0 for GLV tes...

2018-01-04 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/769 TINKERPOP-1844 Default GraphSON 3.0 for GLV tests in gremlin-python https://issues.apache.org/jira/browse/TINKERPOP-1844 This is a breaking change because `g:Set` no longer returns a `

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311544#comment-16311544 ] ASF GitHub Bot commented on TINKERPOP-1858: --- Github user spmallette commente

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 Ok - thanks for your thoughts. I can't say we have a release date for 3.3.2 in mind yet. I'd say it was a couple of months away at least based on how we typically do releases. ---

[jira] [Commented] (TINKERPOP-1861) VertexProgram create with varargs for Graphs

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311541#comment-16311541 ] ASF GitHub Bot commented on TINKERPOP-1861: --- Github user PBGraff commented o

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311540#comment-16311540 ] ASF GitHub Bot commented on TINKERPOP-1858: --- Github user robertdale commente

[GitHub] tinkerpop issue #768: TINKERPOP-1861 Modify VertexProgram.Builder.create() t...

2018-01-04 Thread PBGraff
Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/768 @spmallette We can apply this to the TP 3.2.x line as well. Should I modify the PR to apply to the tp32 branch instead? ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/767 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311536#comment-16311536 ] ASF GitHub Bot commented on TINKERPOP-1858: --- Github user krlohnes commented

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 @spmallette As far as criticality, that's fairly dependent on the usage of custom authentication handlers in the wild. It's not impacting my current work or any of the work I did at IBM Compose r

[GitHub] tinkerpop pull request #695: TINKERPOP-1489 JavaScript GLV

2018-01-04 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/695#discussion_r159677279 --- Diff: gremlin-javascript/pom.xml --- @@ -0,0 +1,366 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/200

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311484#comment-16311484 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311469#comment-16311469 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[GitHub] tinkerpop pull request #695: TINKERPOP-1489 JavaScript GLV

2018-01-04 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/695#discussion_r159676150 --- Diff: gremlin-javascript/pom.xml --- @@ -0,0 +1,366 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/200

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311465#comment-16311465 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[GitHub] tinkerpop pull request #695: TINKERPOP-1489 JavaScript GLV

2018-01-04 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/695#discussion_r159675592 --- Diff: gremlin-javascript/pom.xml --- @@ -0,0 +1,366 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/200

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311459#comment-16311459 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[GitHub] tinkerpop pull request #695: TINKERPOP-1489 JavaScript GLV

2018-01-04 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/695#discussion_r159674939 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/package.json --- @@ -0,0 +1,39 @@ +{ + "name": "gremlin-javascript", +

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311446#comment-16311446 ] ASF GitHub Bot commented on TINKERPOP-1858: --- Github user spmallette commente

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 a bad merge - thanks. how bad/critical do you rate this problem? ---

[jira] [Closed] (TINKERPOP-781) Local aggregation should not destroy path

2018-01-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-781. -- Resolution: Won't Do I think that this issue is well past scope at this point given i

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311433#comment-16311433 ] ASF GitHub Bot commented on TINKERPOP-1858: --- Github user krlohnes commented

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 @spmallette Yeah, it looks like it happened with the `Merge branch TP32` commit. If you look [here](https://github.com/apache/tinkerpop/commit/960fdc11399590280522189b08727e90cd9b629a#diff-822877

[jira] [Updated] (TINKERPOP-1844) Python GLV test should run for GraphSON 3.0

2018-01-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1844: Labels: breaking (was: ) > Python GLV test should run for GraphSON 3.0 > --

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311310#comment-16311310 ] ASF GitHub Bot commented on TINKERPOP-1858: --- Github user spmallette commente

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 Hi @krlohnes - thanks for this. Did you happen to research the point where this regression occurred? ---

[jira] [Commented] (TINKERPOP-1844) Python GLV test should run for GraphSON 3.0

2018-01-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311307#comment-16311307 ] stephen mallette commented on TINKERPOP-1844: - Yes - I opted to begin atte

[jira] [Commented] (TINKERPOP-1861) VertexProgram create with varargs for Graphs

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311285#comment-16311285 ] ASF GitHub Bot commented on TINKERPOP-1861: --- Github user spmallette commente

[GitHub] tinkerpop issue #768: WIP: Modify VertexProgram.Builder.create() to take Gra...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/768 Please rename the pull request to be prefixed by the JIRA number: TINKERPOP-1861 (that way it will tie into the JIRA integration) Also, is there any reason to not deprecate this back al

[GitHub] tinkerpop issue #768: WIP: Modify VertexProgram.Builder.create() to take Gra...

2018-01-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/768 I don't think we should break the interface. I think these should be new methods and `@deprecate` the old ones. The old methods can call the new methods. ---

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311187#comment-16311187 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user jorgebay commented

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2018-01-04 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/695 What a great time of the year to review this pr! 😄 ---