Re: Code Freeze 3.2.8/3.3.2

2018-04-06 Thread Robert Dale
Looks good. Doesn't even show up as a forced update. Robert Dale On Fri, Apr 6, 2018 at 9:36 PM, Stephen Mallette wrote: > i think i fixed it. i accidentally pushed a really bad version of tp33 that > made it even with master!!! > > i ended up fixing by doing: > > git

Re: Code Freeze 3.2.8/3.3.2

2018-04-06 Thread Stephen Mallette
i think i fixed it. i accidentally pushed a really bad version of tp33 that made it even with master!!! i ended up fixing by doing: git branch -D tp33 git checkout tags/3.3.2 git checkout -b tp33 ... // all the stuff to bump to 3.3.3-SNAPSHOT again git push origin tp33 --force Thanks to Robert

Re: Code Freeze 3.2.8/3.3.2

2018-04-06 Thread Stephen Mallette
I think I just did something bad to git. Please don't push anything until I can try to sort out what happened. Damn On Fri, Apr 6, 2018 at 7:51 PM, Stephen Mallette wrote: > The vote threads are now closed up but we will wait until monday to > finalize

[GitHub] tinkerpop pull request #833: TINKERPOP-1903 Migrated Credential DSL to annot...

2018-04-06 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/833 TINKERPOP-1903 Migrated Credential DSL to annotation processor https://issues.apache.org/jira/browse/TINKERPOP-1903 The old CredentialGraph approach to the Credential DSL has been

[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429177#comment-16429177 ] ASF GitHub Bot commented on TINKERPOP-1903: --- GitHub user spmallette opened a pull request:

[jira] [Commented] (TINKERPOP-1934) Bump to latest version of httpclient

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429176#comment-16429176 ] ASF GitHub Bot commented on TINKERPOP-1934: --- GitHub user spmallette opened a pull request:

[GitHub] tinkerpop pull request #832: TINKERPOP-1934 Bumped httpclient to 4.5.5

2018-04-06 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/832 TINKERPOP-1934 Bumped httpclient to 4.5.5 https://issues.apache.org/jira/browse/TINKERPOP-1934 Removed httpcore NOTICE entry as this more recent version does not contain that

Re: Code Freeze 3.2.8/3.3.2

2018-04-06 Thread Stephen Mallette
The vote threads are now closed up but we will wait until monday to finalize up the actual release. Have a good weekend everyone! On Tue, Mar 27, 2018 at 2:04 PM, Stephen Mallette wrote: > I think the second issue is resolve now with: > >

[RESULT][VOTE] TinkerPop 3.3.2 Release

2018-04-06 Thread Stephen Mallette
This vote is now closed with a total of 4 +1s, no +0s and no -1s. The results are: BINDING VOTES: +1 (4 -- Dylan Millikin, Daniel Kuppitz, Stephen Mallette, Jason Plurad) 0 (0) -1 (0) NON-BINDING VOTES: +1 (0) 0 (0) -1 (0) Thanks, Stephen On Fri, Apr 6, 2018 at 2:43 PM, Dylan Millikin

[GitHub] tinkerpop issue #831: TINKERPOP-1410 Removed test artifact of hadoop-gremlin

2018-04-06 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/831 VOTE: +1 ---

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428962#comment-16428962 ] ASF GitHub Bot commented on TINKERPOP-1410: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop issue #830: TINKERPOP-1143 Moved TraversalEngine to gremlin-test

2018-04-06 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/830 VOTE: +1 ---

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428807#comment-16428807 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user dkuppitz commented on the issue:

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428800#comment-16428800 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

2018-04-06 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/830#discussion_r179849183 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java --- @@ -362,7 +360,7 @@ private boolean

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428797#comment-16428797 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user dkuppitz commented on a diff in the

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

2018-04-06 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/830#discussion_r179848121 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java --- @@ -362,7 +360,7 @@ private boolean

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-06 Thread Dylan Millikin
Ran all tests from the php end. Everything passes. Actually added a couple more and those also pass. VOTE: +1 On Fri, Apr 6, 2018 at 9:29 AM, Jason Plurad wrote: > Validated the binaries, did several manual tests with the Gremlin Server + > Gremlin Console, looked over the

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428767#comment-16428767 ] ASF GitHub Bot commented on TINKERPOP-1410: --- GitHub user spmallette opened a pull request:

[GitHub] tinkerpop pull request #831: TINKERPOP-1410 Removed test artifact of hadoop-...

2018-04-06 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/831 TINKERPOP-1410 Removed test artifact of hadoop-gremlin https://issues.apache.org/jira/browse/TINKERPOP-1410 The hadoop-gremlin test artifact allowed us to re-use some classes in spark

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

2018-04-06 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/830#discussion_r179843523 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java --- @@ -362,7 +360,7 @@ private boolean

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428762#comment-16428762 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user spmallette commented on a diff in

[RESULT][VOTE] TinkerPop 3.2.8 Release

2018-04-06 Thread Ted Wilmes
This vote is now closed with a total of 4 +1s, no +0s and no -1s. The results are: BINDING VOTES: +1 (4 -- Ted Wilmes, Daniel Kuppitz, Stephen Mallette, Jason Plurad) 0 (0) -1 (0) NON-BINDING VOTES: +1 (0) 0 (0) -1 (0) Thank you very much, Ted Wilmes

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428669#comment-16428669 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user dkuppitz commented on a diff in the

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

2018-04-06 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/830#discussion_r179829888 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java --- @@ -362,7 +360,7 @@ private boolean

[jira] [Assigned] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

2018-04-06 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette reassigned TINKERPOP-1410: --- Assignee: stephen mallette Labels: breaking (was: )

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-06 Thread Jason Plurad
Validated the binaries, did several manual tests with the Gremlin Server + Gremlin Console, looked over the documentation. The instructions on the download page to verify with gpg manually are fine since the output does say "Good signature" even with the [unknown] suffix. VOTE: +1 On Wed, Apr