GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/914
Do not format and reparse eval timeout arg when evaluating request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek/incubator
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/914
I've pushed a fix for tests that used to send the Eval_timeout as an int
instead of a long, but also made the server robust in case an int is still
sent. Not sure if we want to do that
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/921
Add self loop example to Cycle Detection recipe.
Not sure if it is worth it but I figured out that self loops weren't
detected in the given example.
You can merge this pull request into
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r212996121
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,25 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r212996772
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,25 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213361478
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213372950
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213426961
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/923
TINKERPOP-2028: Register GremlinServerModule to GraphSON message seriâ¦
â¦alizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/923
Left the current behavior unchanged but deprecated the current method, in
favor of another `GraphSONMessageSerializer` constructor that gives the
opportunity to child classes of
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213448492
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/924
Add self loop example to Cycle Detection recipe.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek/incubator-tinkerpop
cycles-recipe
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/924
sorry - I messed up - shouldn't have opened that
---
Github user newkek closed the pull request at:
https://github.com/apache/tinkerpop/pull/924
---
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/923
The reason this is targeting master is because although I did not break
backward compatibility and put previous outdated methods as Deprecated I wasn't
sure what the strategy is here for ret
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/923
@spmallette I added the changelog entry, please let me know if it's
appropriate thanks
---
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/478
The issue with using a secondary thread pool that will start a new thread
for each Traversal execution would be more important when the Traversal is
backed by a RemoteConnection. Where each
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/478
I think the `promise()` method is more elegant as well, as it avoids adding
many new methods in the Traversal API
---
If your project is set up for it, you can reply to this email and have your
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/499
Indeed there seems to be some breaking changes in the protocol. It seems ok
for pure TinkerPop since the parsing code is updated accordingly but will cause
problems to implementors, just as a note
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r88769301
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -175,8 +177,30 @@ public
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r88769492
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -175,8 +177,30 @@ public
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r88769639
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -193,44 +217,46 @@ public
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r88769838
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -299,6 +325,7 @@ public void
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r88770063
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -459,9 +486,33 @@ public
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/499
I sneaked in and made a few comments I hope that's ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r89010143
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -153,13 +152,16 @@ public void
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r89010235
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -153,13 +152,16 @@ public void
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r89010812
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -153,13 +152,16 @@ public void
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r89014281
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -153,13 +152,16 @@ public void
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r89014561
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -153,13 +152,16 @@ public void
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/499
https://gist.github.com/newkek/bfc976712f1adcbe76bcea4e34435ea2 - the rest
doesn't change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/499
> If we do this, then we would have to change Edge back to the same model
to be consistent
Indeed.
> why change it back?
Because currently it is not cons
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/499
Thanks for the separate ticket, I'll put comments over there. So All the
following items (from the PR desc):
> - There was a GraphSON 2.0 issue with Edge properties. Changed to t
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/517
Fix numbers deserialization for GraphSON2.
Issue:
There was a small issue with `ObjectMapper` that was preventing one from
doing `objectMapper.readValue(jsonString, Integer.class/Double.class
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/523
Add ResponseMessage deserializer for GraphSON2.
Motivation:
`ResponseMessage` used to be deserialized manually via a method on
GraphSONMessageSerializerV2d0 (deserializeResponse). Which
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/585
@spmallette I actually had a fix slightly different in mind, I just tested
and it works and the tests pass, mind if I use that different solution?
---
If your project is set up for it, you can
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/586
TINKERPOP-1654: use deserializatinoContext in `typeFromId()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek/incubator-tinkerpop
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/585
Cool, thanks - #586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/351
TINKERPOP-1274: GraphSON 2.0.
https://issues.apache.org/jira/browse/TINKERPOP-1274
# Summary of the changes :
Implementation of a format for value types serialization which is
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
> tests are failing
Ah I changed something quickly this morning and did not run again those
tests. Will correct that.
Ok for the docs, will do.
---
If your project is set up for
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68951122
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/GraphSONMessageSerializerV2d0Test.java
---
@@ -0,0 +1,474
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68951292
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/GraphSONMessageSerializerV2d0Test.java
---
@@ -0,0 +1,474
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68956721
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68976685
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/GraphSONMessageSerializerV2d0Test.java
---
@@ -0,0 +1,474
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Yes that was introduced by the ce19704 (reference docs and Changelog)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
@spmallette
- I've written all the docs, please don't hesitate to correct them if
they're not written well.
- Updated the tests, parameterized them as much as possible, a
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Re-conflicts with Changelog against master..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69275891
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69276176
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69276332
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69283048
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69283289
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69288319
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69288856
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69314893
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69327810
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else if
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
> I thought that java integer would be implied.
Yes with the current PR serializing an Integer will result in no type
added. Serializing a Long or a Short will result in an explicit t
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
@spmallette yes, maybe some code will help explain.
```
ObjectMapper mapper =
GraphSONMapper.build().version(GraphSONVersion.V2_0).typeInfo
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Yes the `@class` bothered me a little as well, since now it doesn't really
describe a "Class". But I did not want to change, for consistency for GraphSON
v1.0 a
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Just pushed the change for `@class` to `@type`. All tests pass.
'twas a 1 line fix, isn't that wonderful.
---
If your project is set up for it, you can reply to this email and have
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Well, I agree we cannot prevent some parsers and drivers to read the whole
JSON content and check the created object only afterward. I would not recommend
it though, because it is not great for
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
@robertdale the format you suggest would lead to the same inconsistencies
as in GraphSON 1.0. Since the type is at the same level than the data itself,
whether the container is an Array or an
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/386
TINKERPOP-1274: GraphSON 2.0 [revised]
For context, a precise description is provided in the PR for the first
version of the fix: #351. Please see this first for initial context.
This PR
Github user newkek closed the pull request at:
https://github.com/apache/tinkerpop/pull/351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Closing this in favor of #386.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/386
Hey @okram ,
> 1. The term is "namespace" not "domain." In case that terminology is used
in the documentation and not just in the PR notes.
Ok, it's s
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/386
*NB: the conflicts for merge are caused by the CHANGELOG*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/386
A remark: @okram requested `TraversalExplanation` to be included in the
list of Graph objects. I've noticed that the current `TraversalExplanation`
Graphson serializer serializes a `Traversal
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/386
I just pushed corrected docs, and renamed everything "domain" to
"namespace". Waiting for more consensus to change the default gremlin namespace.
---
If your project is se
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/386#discussion_r75708714
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -54,6 +54,14
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/386#discussion_r75709109
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/MutableMetrics.java
---
@@ -42,6 +42,18 @@ public MutableMetrics
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/390
GraphSON 2.0 Deser tweaks and improvements
There's 2 commits:
- the first brings a massive improvement to the GraphSON 2.0
deserialization, avoiding a lot of useless copies done o
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/390
@PommeVerte I've seen indeed some issues on the Jackson GH issue tracker
that were looking like what I see with `Tree` but all were resolver in Jackson
2.7.6, and even when removing my
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/390
Seems like it is only on my machine... I think Stephen tried on the docker
image ?
Yes what I have seen so far is it happens at the moment we call
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/403
Fix InetAddress serialization with GraphSON 2.0.
InetAddress serialization/deserialization wasn't working with GraphSON 2.0.
"InetAddress" type has been added to the `
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/432
Fixed SerializerProvider for GraphSON 2.0.
Serialization was broken for unknown objects when creating multiple
instances of the GraphSONMapper with different GraphSON versions.
The issue is
76 matches
Mail list logo
