Re: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Henri Gomez
For now APR support is automatically detected and eventually used. So no problem for me to have APR and NIO. 2005/11/19, Bill Barker <[EMAIL PROTECTED]>: > > - Original Message - > From: "Remy Maucherat" <[EMAIL PROTECTED]> > To: "Tomcat Developers List" > Sent: Saturday, November 19, 20

svn commit: r345722 - in /tomcat/sandbox/java/org/apache/coyote/http11: InternalAprOutputBuffer.java InternalOutputBuffer.java

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 21:22:24 2005 New Revision: 345722 URL: http://svn.apache.org/viewcvs?rev=345722&view=rev Log: Some extra checks Modified: tomcat/sandbox/java/org/apache/coyote/http11/InternalAprOutputBuffer.java tomcat/sandbox/java/org/apache/coyote/http11/InternalOutputB

svn commit: r345721 - in /tomcat/sandbox/java/org/apache/coyote/http11: Http11AprProtocol.java Http11BaseProtocol.java

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 21:21:53 2005 New Revision: 345721 URL: http://svn.apache.org/viewcvs?rev=345721&view=rev Log: Remove duplicated code Modified: tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProtocol.java tomcat/sandbox/java/org/apache/coyote/http11/Http11BaseProtoc

svn commit: r345716 - in /tomcat/sandbox/java/org/apache/coyote/http11: Http11AprProcessor.java Http11BaseProtocol.java Http11Processor.java InternalAprInputBuffer.java InternalAprOutputBuffer.java In

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 20:45:01 2005 New Revision: 345716 URL: http://svn.apache.org/viewcvs?rev=345716&view=rev Log: Few minor cleanups ( imports, indentation ), add a parameter to parseRequestLine to match the apr version, expose the thread pool ( for standalone ). Modified: tomcat

DO NOT REPLY [Bug 37565] - isapi_redirect JK-1.2.15 unloads after one request

2005-11-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r345700 - /tomcat/sandbox/java/org/apache/coyote/http11/InternalAprOutputBuffer.java

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 17:23:40 2005 New Revision: 345700 URL: http://svn.apache.org/viewcvs?rev=345700&view=rev Log: Remove duplicated methods. Modified: tomcat/sandbox/java/org/apache/coyote/http11/InternalAprOutputBuffer.java Modified: tomcat/sandbox/java/org/apache/coyote/http1

Re: Labels in SVN ?

2005-11-19 Thread Costin Manolache
What I want is to be able to do "cvs diff -r my_label_before_sandbox_copy", so I can see what changed. I want to keep my experiments in the sandbox - instead of a branch. Costin On 11/19/05, Yoav Shapira <[EMAIL PROTECTED]> wrote: > Hi, > I'm not an SVN expert, but I understanding is you have tw

DO NOT REPLY [Bug 37565] - isapi_redirect JK-1.2.15 unloads after one request

2005-11-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37565] - isapi_redirect JK-1.2.15 unloads after one request

2005-11-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37565] New: - isapi_redirect JK-1.2.15 unloads after one request

2005-11-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Saturday, November 19, 2005 2:25 AM Subject: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?) I think we need to organize a co

Re: Labels in SVN ?

2005-11-19 Thread Yoav Shapira
Hi, I'm not an SVN expert, but I understanding is you have two options. The more basic option is to branch the directory and work in your branch, occassionally updating the tag label as you want. The relevant SVN commands are at http://svnbook.red-bean.com/en/1.1/svn-book.html#svn-ch-4-sect-4.4.2

svn commit: r345662 - /tomcat/sandbox/java/org/apache/coyote/http11/InternalAprInputBuffer.java

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 09:52:07 2005 New Revision: 345662 URL: http://svn.apache.org/viewcvs?rev=345662&view=rev Log: Remove duplicated methods. Modified: tomcat/sandbox/java/org/apache/coyote/http11/InternalAprInputBuffer.java Modified: tomcat/sandbox/java/org/apache/coyote/http11

Labels in SVN ?

2005-11-19 Thread Costin Manolache
Does anyone know what's the best way to put a small label in a subdir ( connectors/util and connectors/http11 ). I don't want to label anything else - I need this to track changes for the sandbox version. Is SVN tag the same as in cvs ? Costin -

svn commit: r345660 - in /tomcat/sandbox/java/org/apache/coyote/standalone: Main.java MessageWriter.java

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 09:46:43 2005 New Revision: 345660 URL: http://svn.apache.org/viewcvs?rev=345660&view=rev Log: Few comments and small changes to expose the mapper. Modified: tomcat/sandbox/java/org/apache/coyote/standalone/Main.java tomcat/sandbox/java/org/apache/coyote/st

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Costin Manolache
On 11/19/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > < > 1. Yes, it's how things should be done > > < > 2. No, it can be done better > > > > My opionion is (2). > > My opinion is 1. I will not participate in the design of the upcoming > Tomcat branch, then. Well, I

svn commit: r345659 - in /tomcat/sandbox/java/org/apache/tomcat/util/net: AprEndpoint.java SSLImplementation.java TcpConnection.java

2005-11-19 Thread costin
Author: costin Date: Sat Nov 19 09:44:11 2005 New Revision: 345659 URL: http://svn.apache.org/viewcvs?rev=345659&view=rev Log: - remove the hardcoded dependency between SSLImplementation and jsse. - add support for the native socket, in addition to Socket. A better solution may be to add a AprS

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Remy Maucherat
Costin Manolache wrote: < > 1. Yes, it's how things should be done < > 2. No, it can be done better My opionion is (2). My opinion is 1. I will not participate in the design of the upcoming Tomcat branch, then. Rémy - To

Re: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Costin Manolache
On 11/19/05, Yoav Shapira <[EMAIL PROTECTED]> wrote: > On a related note, we can add a server-highperformance.xml configuration file > that ships with Tomcat, and uses APR and whatever else we can think of to > increase perfdormance out of the box. This is similar to the multiple > httpd-XXX.conf

Re: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Mladen Turk
Yoav Shapira wrote: I too vote both, and the classical style as well. Besides Costin's reasoning, with which I largely agree, I have also been seeing more and more people use Java web servers as the front-end, no less. And I want to keep the 100% pure Java option available, preferably as the d

Re: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Yoav Shapira
Hi, > So here we go: > > I think the IO design for connectors used by Tomcat should be: > [ X ] NIO selectors, etc (this means 100% NIO) > [ X ] APR (this means 50% NIO, where NIO is only used for all the objects > exposed at the higher level) > I too vote both, and the classical style as well

svn commit: r345653 [2/2] - in /tomcat/sandbox/java/org/apache/tomcat/util/net: ./ res/

2005-11-19 Thread costin
Added: tomcat/sandbox/java/org/apache/tomcat/util/net/SSLSupport.java URL: http://svn.apache.org/viewcvs/tomcat/sandbox/java/org/apache/tomcat/util/net/SSLSupport.java?rev=345653&view=auto == --- tomcat/sandbox/java/org/ap

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Costin Manolache
> The question is: > > Do you think APR implementation, and the low leve APIs ( with all the > duplicate code, and the current abstractions, incliuding sendfile ) > are the right ones ? To clarify - this is not only about APR, but also *Endpoint, TcpConnectoin/TcpConectionHandler, util.buf, util.

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Costin Manolache
On 11/19/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Mladen Turk wrote: > > No. > > I would like that we accept in our (Tomcat) community much > > more pluralism, in a similar way the Apache httpd community > > does with mpm models. > > > > Neither blocking, APR or eventually NIO will ever be >

Re: [VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Costin Manolache
On 11/19/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > I think the IO design for connectors used by Tomcat should be: > [X] NIO selectors, etc (this means 100% NIO) > [X] APR (this means 50% NIO, where NIO is only used for all the objects > exposed at the higher level) > Obviously, I vote bo

Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-19 Thread Martin van den Bemt
Sorry for entering in this discussion.. Remy Maucherat wrote: Costin Manolache wrote: 'accepted' solution. The truth is, few people are using Java web servers, and it's not going to change. I'm curious to know how NIO is a well accepted solution for web servers, BTW. Can you eleborate on

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Remy Maucherat
Mladen Turk wrote: No. I would like that we accept in our (Tomcat) community much more pluralism, in a similar way the Apache httpd community does with mpm models. Neither blocking, APR or eventually NIO will ever be the best solution for a particular user needs. Blocking will outperform any sol

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Mladen Turk
Jess Holle wrote: Mladen Turk wrote: So, from my point of view I see this vote as useless, because anyone can create a connector using what ever technology he prefers. The only valid question would be, what to use as a default one, but that's a minor issue thought. As Mladen says, anyone ca

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Jess Holle
P.S. I strongly believe someone at Sun should take up the NIO vs. APR challenge and ensure that NIO outperforms APR in Tomcat usage. In other words, Sun should ensure that a pure Java networking stack is really best in class in real world usage. [Hopefully someone at Sun reads this and takes

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Jess Holle
Mladen Turk wrote: So, from my point of view I see this vote as useless, because anyone can create a connector using what ever technology he prefers. The only valid question would be, what to use as a default one, but that's a minor issue thought. As Mladen says, anyone can create a connector

Re: [VOTE] APR or NIO ?

2005-11-19 Thread Mladen Turk
Remy Maucherat wrote: Costin Manolache wrote: NIO is used AFAIK by Jetty and Resin, and probably others. And it's the 'standard' solution for select-like operations ( even if the standard is as usual not the best solution ). I think we need to organize a community vote then, so that I do not

[VOTE] APR or NIO ? (was:Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?)

2005-11-19 Thread Remy Maucherat
Costin Manolache wrote: NIO is used AFAIK by Jetty and Resin, and probably others. And it's the 'standard' solution for select-like operations ( even if the standard is as usual not the best solution ). Selects and stuff like that is the reason why I will vote against NIO, so I find all this q