RE: my proposal for re implement tomcat valves as filters

2009-04-02 Thread anas Ahmed
Mark Thomas wrote : Feedback: Good first draft. There are a coupe of areas I would like to see more detail on: 1. Impact of Servlet 3 and async processing. Lack of asynchronous support in the Servlet 2.5 specification has caused server vendors to devise workarounds by weaving

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread Henri Gomez
Le 30 mars 09 à 18:00, Mark Thomas ma...@apache.org a écrit : Henri Gomez wrote: Ain't those used for 5.5? You can however just remove them from the build. Other option is to copy them to the 5.5 and not referencing the connectors for those set of classes. Sorry - should have been clear. I

Re: Feedback on my project proposal

2009-04-02 Thread Rahul Saxena
JSR 196 can be implemented only at the service levelIs it true?? -- Rahul Saxena B.Tech Part III Computer Science and Engineering I.T. B.H.U. ,Varanasi Contact No.-09452196645

Re: Feedback on my project proposal

2009-04-02 Thread David Jencks
On Apr 1, 2009, at 9:20 PM, Rahul Saxena wrote: Is Tomcat currently supports JSR 196?? no. I've been planning to work on jsr 196 for tomcat but haven't had much time. I implemented support for jetty. Geronimo has a jsr 196 provider implementation but I haven't been able to pry the tck

Re: Feedback on my project proposal

2009-04-02 Thread David Jencks
On Apr 2, 2009, at 12:32 AM, Rahul Saxena wrote: JSR 196 can be implemented only at the service levelIs it true?? not sure exactly what you mean each web app needs something to do its authentication, whether it be a standard FORM/BASIC/DIGEST/ CLIENT_CERT auth thingy or a jsr 196

Re: Feedback on my project proposal

2009-04-02 Thread Rahul Saxena
If we define a generic servlet for a particular host and then allow servlets(of any application) in that particular host to implement that generic servlet and then I think we can supply the servlet context of this particular servlet to the correponding filter of that host . On Wed, Apr 1,

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread Mark Thomas
Henri Gomez wrote: May be being the Servlet/JSP RI didn't allow too much 'revolution'. Have you read the 3.0 spec draft? There is a fair amount of change. Whether it is good or not is a different question though. I read it. It's a new spec. Dot. May be being the RI prevents major

Re: Feedback on my project proposal

2009-04-02 Thread Rahul Saxena
As you said The auth thingy gets called once per request before the request gets to any filters or servlets.So it means that all the requests will pass through this auth thing and so it would be not be possible to use it for particular hosts or contexts??? On Thu, Apr 2, 2009 at 1:18 PM, David

Re: I Need Your Feedback on my project proposal

2009-04-02 Thread Mark Thomas
Xie Xiaodong wrote: Hello, Dear All, I have posted my revised proposal on the GSOC site for the project Convert current Tomcat valves to Servlet Filters. And I've successfully build the source code Mark provided, and delved myself into it. I'll add the deliverables and timescale to this

GSoC questions

2009-04-02 Thread muz.Payne
Hello, I want to join GSoC project titled Convert current Tomcat valves to Servlet Filters and I just want to ask you some questions about it. 1. Will the work include writing of JUnit tests? If yes, which version? (3, 4) 2. I read that Tomcat uses SVN version control system. Is there any

Some questions about the AccessLogValve

2009-04-02 Thread Xie Xiaodong
Hello, Dear All, I found that Double-Checked Locking Pattern are heavily used in AccessLogValve to get rid of race condition. But as far as I know, this pattern will not work in Java according to this article: http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html. I think this

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread Henri Gomez
May be being the RI prevents major evolution/révolution ? Tomcat isn't the RI and hasn't been for some time. Up to 2.5/2.1 ? Tomcat Light is a good idea but only costin works on it. If you like the idea, help him out. Why should we still get this kind of reply on Tomcat list ? ;-( I won't

DO NOT REPLY [Bug 46950] SSL renegotiation does not occur when resource with CLIENT-CERT auth is requested

2009-04-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46950 Andr an...@cabine.org changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread Mark Thomas
Henri Gomez wrote: May be being the RI prevents major evolution/révolution ? Tomcat isn't the RI and hasn't been for some time. Up to 2.5/2.1 ? Tomcat Light is a good idea but only costin works on it. If you like the idea, help him out. Why should we still get this kind of reply on

Re: my proposal for re implement tomcat valves as filters

2009-04-02 Thread Mark Thomas
anas Ahmed wrote: Mark Thomas wrote : Feedback: Good first draft. There are a coupe of areas I would like to see more detail on: 1. Impact of Servlet 3 and async processing. Lack of asynchronous support in the Servlet 2.5 specification has caused server vendors to devise

Re: Feedback on my project proposal

2009-04-02 Thread Mark Thomas
Rahul Saxena wrote: Could you clarify please? I don't understand your solution. If we define a generic servlet for a particular host and then allow servlets(of any application) in that particular host to implement that generic servlet Is generic servlet an interface? If so, we have no way of

Re: GSoC questions

2009-04-02 Thread Mark Thomas
muz.Payne wrote: Hello, I want to join GSoC project titled Convert current Tomcat valves to Servlet Filters and I just want to ask you some questions about it. Great. Welcome to the Tomcat dev community. 1. Will the work include writing of JUnit tests? If yes, which version? (3, 4)

Re: Some questions about the AccessLogValve

2009-04-02 Thread Mark Thomas
Xie Xiaodong wrote: Hello, Dear All, I found that Double-Checked Locking Pattern are heavily used in AccessLogValve to get rid of race condition. But as far as I know, this pattern will not work in Java according to this article:

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread Mladen Turk
Mark Thomas wrote: Asf has a great server framework, mina, but it's not used by Tc. I'm not sure building Tomcat on top of another framework is a good idea. If you have a PoC that shows otherwise that would be very interesting. Mina is also ASF and why not speak with the MINA team ? May be

Convert Valves 2 Servlet Filters

2009-04-02 Thread buddhi wickramarathne
1- What is the main idea behind converting Current working Valves to Servlet Filters. 2- What are the benifits from that work to the Tomcat. 3- What will be like Tomcat with having Filters than having Valves.(For what reason Valves should be converted to Filters)

Re: Convert Valves 2 Servlet Filters

2009-04-02 Thread Mark Thomas
buddhi wickramarathne wrote: 1- What is the main idea behind converting Current working Valves to Servlet Filters. Valves are Tomcat specific. Filters can be used with any container. 2- What are the benifits from that work to the Tomcat. Remove duplication. Valve pipeline is very similar to

svn commit: r761257 - /tomcat/trunk/java/org/apache/jasper/compiler/ELNode.java

2009-04-02 Thread markt
Author: markt Date: Thu Apr 2 11:58:51 2009 New Revision: 761257 URL: http://svn.apache.org/viewvc?rev=761257view=rev Log: Tabs - 8 spaces Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELNode.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELNode.java URL:

Re: I Need Your Feedback on my project proposal

2009-04-02 Thread Xie Xiaodong
Thank you very much for your valuable comments, Mark. I've revised my proposal according to your comments, and added the deliverables and time schedule part. Any more comments, feedback and criticism to my proposal are welcomed. 2009/4/2 Mark Thomas ma...@apache.org Xie Xiaodong wrote:

Re: Feedback on my project proposal

2009-04-02 Thread Rahul Saxena
It was a mistake I wrote servlet context of this particular servlet . Also as we have default host for a particular engine , we can have a default context for a particular host , then pass its servlet context to the filter , then can we map all servlets in this host to this filter or the

svn commit: r761336 - in /tomcat/trunk/java/org/apache/jasper/compiler: Compiler.java ELFunctionMapper.java Generator.java

2009-04-02 Thread markt
Author: markt Date: Thu Apr 2 16:21:00 2009 New Revision: 761336 URL: http://svn.apache.org/viewvc?rev=761336view=rev Log: Misc code clean-up. Remove unused parameters / exceptions etc. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java

svn commit: r761338 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java

2009-04-02 Thread markt
Author: markt Date: Thu Apr 2 16:22:13 2009 New Revision: 761338 URL: http://svn.apache.org/viewvc?rev=761338view=rev Log: Fix litmus test failure: MKCOL with weird body must fail with 415 (RFC2518:8.3.1) Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Modified:

Re: Some questions about the AccessLogValve

2009-04-02 Thread Xie Xiaodong
Hello, Mark, I am greatly with you. After I finish my proposal, I will check carefully what is the best way to solve this problem. 2009/4/2 Mark Thomas ma...@apache.org Xie Xiaodong wrote: Hello, Dear All, I found that Double-Checked Locking Pattern are heavily used in

DO NOT REPLY [Bug 46957] New: Memory leak: tags in JSPs don't release Page Context

2009-04-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46957 Summary: Memory leak: tags in JSPs don't release Page Context Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal

Re: GSoC questions

2009-04-02 Thread muz.Payne
markt-2 wrote: muz.Payne wrote: Hello, I want to join GSoC project titled Convert current Tomcat valves to Servlet Filters and I just want to ask you some questions about it. Great. Welcome to the Tomcat dev community. 1. Will the work include writing of JUnit tests? If yes,

Re: Feedback on my project proposal

2009-04-02 Thread Costin Manolache
I wouldn't be that concerned about configuration - tomcat can still instantiate the filter independent of web.xml, like it does with the valve. Or the filter could be used 'user-space', i.e. user adding the filter explicitly and not using the declarative security. One of the problems with tomcat

DO NOT REPLY [Bug 34110] The message SEVERE: Error listenerStart should be more explicit

2009-04-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=34110 --- Comment #3 from Dan Armbrust daniel.armbrust.l...@gmail.com 2009-04-02 13:48:36 PST --- I ran into this issue where tomcat was not giving me any information to go on with one of my webapps. After a long search, documented here:

DO NOT REPLY [Bug 34110] The message SEVERE: Error listenerStart should be more explicit

2009-04-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=34110 Dan Armbrust daniel.armbrust.l...@gmail.com changed: What|Removed |Added CC|

DO NOT REPLY [Bug 46958] New: manager XML interface hard-coded path in XSL transformation

2009-04-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46958 Summary: manager XML interface hard-coded path in XSL transformation Product: Tomcat 6 Version: 6.0.18 Platform: All OS/Version: All Status: NEW

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread William A. Rowe, Jr.
Henri Gomez wrote: If i recall the tomcat story (10 years). Today Sun has it's own implementation, Grizzly. Jboss forked tc code in it's own implémentation for AS. Spring Source embed it in it's DM server. It's disturbing that you fail to mention Geronimo altogether. If we can't have

Re: [Proposal] Remove older of the two BIO AJP connectors

2009-04-02 Thread Bill Barker
William A. Rowe, Jr. wr...@rowe-clan.net wrote in message news:49d55f2c.2030...@rowe-clan.net... Henri Gomez wrote: If i recall the tomcat story (10 years). Today Sun has it's own implementation, Grizzly. Jboss forked tc code in it's own implémentation for AS. Spring Source embed it in

Re: GSoC questions

2009-04-02 Thread buddhi wickramarathne
muz.Payne wrote I tried to connect to SVN repositories, but it do not work... create a folder in your local partition name it as u want check out with the url for the trunk to that folder What are user password? Are they anonymous, blank? no user name password need

Re: Feedback on my project proposal

2009-04-02 Thread Rahul Saxena
As you said An alternative would be to just define a small interface that allows the filter to populate ,does that mean defining an interface in the default context for that host , and the filter can be instantiated using servlet context for this default web app(context) and then allow users to

Re: Feedback on my project proposal

2009-04-02 Thread Costin Manolache
On Thu, Apr 2, 2009 at 10:08 PM, Rahul Saxena rahul.saxena.cs...@itbhu.ac.in wrote: As you said An alternative would be to just define a small interface that allows the filter to populate ,does that mean defining an interface in the default context for that host , and the filter can be