svn commit: r1231460 - /tomcat/trunk/res/rat/rat-excludes.txt

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sat Jan 14 08:22:49 2012 New Revision: 1231460 URL: http://svn.apache.org/viewvc?rev=1231460view=rev Log: Exclude several md5 files. Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL:

New unit tests for Authenticators and SingleSignOn

2012-01-14 Thread Brian Burch
I realise everyone will be busy on the 7.0.24 release, so don't let this distract you - it isn't urgent. Before I started developing my unit tests for SSO, I wrote a test class for NonLoginAuthenticator and BasicAuthenticator. This test class checks the behaviour of both authenticators when

svn commit: r1231461 - /tomcat/trunk/res/rat/rat-excludes.txt

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sat Jan 14 08:32:54 2012 New Revision: 1231461 URL: http://svn.apache.org/viewvc?rev=1231461view=rev Log: Update rat-excludes to exclude manifest files. Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL:

svn commit: r1231462 - in /tomcat/tc7.0.x/trunk: ./ res/rat/rat-excludes.txt

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sat Jan 14 08:47:45 2012 New Revision: 1231462 URL: http://svn.apache.org/viewvc?rev=1231462view=rev Log: Update rat-excludes file for Buildbot, porting recent changes from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed)

Re: svn commit: r1183612 [2/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-14 Thread markt
Filip Hanik - Dev Lists devli...@hanik.com wrote: Commits like this, make it very difficult to trace down changes in the SVN history. If you configure your diff tool to ignore whitespace (viewvc does this by default) this particular commit shows as a no-op. That and speed, are the main reasons

DO NOT REPLY [Bug 52467] New: Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 Bug #: 52467 Summary: Unable to open the service 'Tomcat7' when Monitor starts Product: Tomcat 7 Version: 7.0.23 Platform: PC Status: NEW

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 denixx baykin denixx.bay...@gmail.com changed: What|Removed |Added CC|

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 denixx baykin denixx.bay...@gmail.com changed: What|Removed |Added OS/Version|All |Windows 7

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 denixx baykin denixx.bay...@gmail.com changed: What|Removed |Added OS/Version||Windows 7

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 denixx baykin denixx.bay...@gmail.com changed: What|Removed |Added OS/Version||All ---

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com 2012-01-14 11:30:26 UTC --- (In reply to comment #0) Created attachment 28151 [details] How it looks on Win7 Russian On Windows Vista (I do not test Vista) and on Windows 7

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #3 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:29:25 UTC --- (In reply to comment #2) (In reply to comment #0) Created attachment 28151 [details] How it looks on Win7 Russian On Windows Vista (I do not

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #4 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:30:33 UTC --- Created attachment 28152 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28152 Installation options 0 -- Configure bugmail:

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #5 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:31:05 UTC --- Created attachment 28153 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28153 Installation options 1 -- Configure bugmail:

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #6 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:31:41 UTC --- Created attachment 28154 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28154 Installation options 2 -- Configure bugmail:

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #7 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:32:14 UTC --- Created attachment 28155 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28155 Installation options 3 -- Configure bugmail:

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #8 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:32:43 UTC --- Created attachment 28156 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28156 Installation options 4 -- Configure bugmail:

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #9 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:44:50 UTC --- On Installation options 3 image shown path starts with C:\Program Files\... I think it starts without error after installation because installer has

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #10 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:50:09 UTC --- And, finally, if link to Monitor have Run this program as an administrator checkbox enabled, Monitor do not starts. :( -- Configure bugmail:

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 --- Comment #11 from denixx baykin denixx.bay...@gmail.com 2012-01-14 13:51:03 UTC --- I mean Monitor do not starts automatically. It starts manually only. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email

Re: [SECURITY] Apache Tomcat and the hashtable collision DoS vulnerability

2012-01-14 Thread Christopher Schultz
All, On 12/29/11 3:25 PM, Christopher Schultz wrote: On 12/29/11 12:35 PM, Luke Meyer wrote: Worth noting that TreeMap makes all storage O(log n), so the normal case takes a hit in order to mitigate the worst case (i.e. malicious case). When n is small, though, O(n) ~= O(log n). I'd be

Re: svn commit: r1080719 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-01-14 Thread Mark Thomas
On 13/01/2012 22:04, Filip Hanik - Dev Lists wrote: I'm looking for a better reason for this change. What was the reasoning behind this limitation, as it breaks years of compatibility. Workaround is to point docBase to a directory. The reasoning was that the documentation said one thing (that

svn commit: r1231542 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestXxxEndpoint.java

2012-01-14 Thread markt
Author: markt Date: Sat Jan 14 18:13:00 2012 New Revision: 1231542 URL: http://svn.apache.org/viewvc?rev=1231542view=rev Log: Fix failing APR unit test since connectors were switched to bind to localhost for tests Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestXxxEndpoint.java

svn commit: r1231543 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread markt
Author: markt Date: Sat Jan 14 18:15:08 2012 New Revision: 1231543 URL: http://svn.apache.org/viewvc?rev=1231543view=rev Log: Add non-SSO test cases for BASIC and non-Login authenticators Patch provided by Brian Burch Added:

Re: New unit tests for Authenticators and SingleSignOn

2012-01-14 Thread Mark Thomas
On 14/01/2012 08:24, Brian Burch wrote: I realise everyone will be busy on the 7.0.24 release, so don't let this distract you - it isn't urgent. I had to fix a failing unit test so it was no bother. I've added this to trunk and will port it to 7.0.x once I have taken a closer look at it. The

DO NOT REPLY [Bug 52461] java.lang.IllegalArgumentException: URI scheme is not file is thrown in ContextConfig.getDefaultWebXmlFragment

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52461 --- Comment #2 from violet...@apache.org 2012-01-14 18:20:33 UTC --- Thank you! Violeta -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the

svn commit: r1231546 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/util/net/TestXxxEndpoint.java

2012-01-14 Thread markt
Author: markt Date: Sat Jan 14 18:21:18 2012 New Revision: 1231546 URL: http://svn.apache.org/viewvc?rev=1231546view=rev Log: Fix failing unit test now connectors are bound to localhost for tests Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1231547 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread markt
Author: markt Date: Sat Jan 14 18:22:02 2012 New Revision: 1231547 URL: http://svn.apache.org/viewvc?rev=1231547view=rev Log: Fix unused code warnings Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java Modified:

svn commit: r1231548 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java webapps/docs/changelog.xml

2012-01-14 Thread markt
Author: markt Date: Sat Jan 14 18:23:49 2012 New Revision: 1231548 URL: http://svn.apache.org/viewvc?rev=1231548view=rev Log: Add non-SSO test cases for BASIC and non-Login authenticators Patch provided by Brian Burch Added:

svn commit: r1231550 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread markt
Author: markt Date: Sat Jan 14 18:24:27 2012 New Revision: 1231550 URL: http://svn.apache.org/viewvc?rev=1231550view=rev Log: Fix warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

DO NOT REPLY [Bug 52467] Unable to open the service 'Tomcat7' when Monitor starts

2012-01-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52467 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: New unit tests for Authenticators and SingleSignOn

2012-01-14 Thread Brian Burch
On 15/01/12 04:16, Mark Thomas wrote: On 14/01/2012 08:24, Brian Burch wrote: I realise everyone will be busy on the 7.0.24 release, so don't let this distract you - it isn't urgent. I had to fix a failing unit test so it was no bother. Thanks very much, Mark. I've added this to trunk and

Re: svn commit: r1231550 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread Brian Burch
On 15/01/12 04:24, ma...@apache.org wrote: Author: markt Date: Sat Jan 14 18:24:27 2012 New Revision: 1231550 URL: http://svn.apache.org/viewvc?rev=1231550view=rev Log: Fix warnings Curious... I don't get any compiler warnings and checkstyle said it was OK. I presume your compiler didn't

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-14 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

svn commit: r1231620 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 03:54:17 2012 New Revision: 1231620 URL: http://svn.apache.org/viewvc?rev=1231620view=rev Log: In TestNonLoginAndBasicAuthenticator: Reduce visibility of methods that are not called from outside. Fix javadoc formatting. Modified:

svn commit: r1231621 - /tomcat/trunk/res/rat/rat-excludes.txt

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 04:14:39 2012 New Revision: 1231621 URL: http://svn.apache.org/viewvc?rev=1231621view=rev Log: Add several other manifests paths to rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL:

svn commit: r1231622 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 04:20:12 2012 New Revision: 1231622 URL: http://svn.apache.org/viewvc?rev=1231622view=rev Log: Merged revision 1231620 from tomcat/trunk: In TestNonLoginAndBasicAuthenticator: Reduce visibility of methods that are not called from outside. Fix javadoc formatting.

Re: svn commit: r1231550 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread Konstantin Kolinko
2012/1/15 Brian Burch br...@pingtoo.com: On 15/01/12 04:24, ma...@apache.org wrote: Author: markt Date: Sat Jan 14 18:24:27 2012 New Revision: 1231550 URL: http://svn.apache.org/viewvc?rev=1231550view=rev Log: Fix warnings Curious... I don't get any compiler warnings and checkstyle

svn commit: r1231623 - in /tomcat/tc7.0.x/trunk: ./ res/rat/rat-excludes.txt

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 04:32:20 2012 New Revision: 1231623 URL: http://svn.apache.org/viewvc?rev=1231623view=rev Log: Merged revision 1231621 from tomcat/trunk: Add several other manifests paths to rat-excludes.txt Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1231624 - /tomcat/trunk/build.xml

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 04:54:29 2012 New Revision: 1231624 URL: http://svn.apache.org/viewvc?rev=1231624view=rev Log: When building a Windows installer do not copy whole res folder to output/dist, but only the files that we need. I have noticed those unneeded files (manifest

svn commit: r1231625 - /tomcat/trunk/build.xml

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 05:11:42 2012 New Revision: 1231625 URL: http://svn.apache.org/viewvc?rev=1231625view=rev Log: When building a Windows installer apply fixcrlf only after all files has been copied. The difference is what line ends the INSTALLLICENSE and tomcat.nsi files will

svn commit: r1231626 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 05:17:17 2012 New Revision: 1231626 URL: http://svn.apache.org/viewvc?rev=1231626view=rev Log: Remove Javadoc for removed method. (Fixes javadoc compiler warning) Fix Javadoc formatting. (Thought there is still more to fix there). Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

2012-01-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2653 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1231630 - in /tomcat/trunk: build.xml res/License.rtf res/tomcat.nsi

2012-01-14 Thread kkolinko
Author: kkolinko Date: Sun Jan 15 05:53:59 2012 New Revision: 1231630 URL: http://svn.apache.org/viewvc?rev=1231630view=rev Log: Remove res/License.rtf The file that is actually shown by the Windows installer in res/INSTALLLICENSE. We do not need two license files here. The MUI_PAGE_LICENSE

buildbot success in ASF Buildbot on tomcat-trunk

2012-01-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2654 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-01-14 Thread Konstantin Kolinko
2012/1/15 build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at:  http://ci.apache.org/builders/tomcat-trunk/builds/2653 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu

Bug report for Tomcat 7 [2012/01/15]

2012-01-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2012/01/15]

2012-01-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2012/01/15]

2012-01-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2012/01/15]

2012-01-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2012/01/15]

2012-01-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2012/01/15]

2012-01-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned