Re: svn commit: r1494915 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/ test/org/apache/catalina/core/

Violeta Georgieva wrote: >2013/6/20 >> >> Author: markt >> Date: Thu Jun 20 10:38:49 2013 >> New Revision: 1494915 >> >> URL: http://svn.apache.org/r1494915 >> Log: >> Servlet 3.1 Implement the new deny-uncovered-http-methods element in >> server.xml That should have said web.xml >That's for t

Re: svn commit: r1494915 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/ test/org/apache/catalina/core/

2013/6/20 > > Author: markt > Date: Thu Jun 20 10:38:49 2013 > New Revision: 1494915 > > URL: http://svn.apache.org/r1494915 > Log: > Servlet 3.1 Implement the new deny-uncovered-http-methods element in server.xml > That's for the xml but what about annotations? We are processing them when loadin

svn commit: r1495218 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoEndpointBase.java

Author: markt Date: Thu Jun 20 22:29:54 2013 New Revision: 1495218 URL: http://svn.apache.org/r1495218 Log: Fix spacing Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoEndpointBase.java Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoEndpointBase.ja

[Bug 55120] ISA exception is thrown during application start when there is annotated ServerEndpoint POJO

https://issues.apache.org/bugzilla/show_bug.cgi?id=55120 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1495216 - in /tomcat/trunk: java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java test/org/apache/tomcat/websocket/pojo/

Author: markt Date: Thu Jun 20 22:24:25 2013 New Revision: 1495216 URL: http://svn.apache.org/r1495216 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55120 @OnOpen needs to support an optional EndpointConfig parameter. Based on a patch by Niki Dokovski. Modified: tomcat/trunk/jav

Re: [Bug 55102] New: Add ability to report time taken to prepare response

On 20.06.2013 23:22, Jeremy Boynes wrote: > On Jun 15, 2013, at 10:09 AM, bugzi...@apache.org wrote: > >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55102 >> Summary: Add ability to report time taken to prepare response >> >> Created attachment 30438 >> --> https://issues.apache

svn commit: r1495208 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

Author: markt Date: Thu Jun 20 21:58:25 2013 New Revision: 1495208 URL: http://svn.apache.org/r1495208 Log: Refactor in preparation for fixing BZ 55120 Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket

[Bug 55071] try finally catch structure masks original exception in JDBCRealm.getPassword()

https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 --- Comment #7 from Christopher Schultz --- I still think commit() should not be called. For the shared-connection of JDBCRealm to ever be put into auto-commit=false would be an enormous mistake, assuming any data modification was taking pl

Re: svn commit: r1495197 - /tomcat/trunk/java/org/apache/catalina/realm/JDBCRealm.java

Mark, On 6/20/13 5:34 PM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 20 21:34:09 2013 > New Revision: 1495197 > > URL: http://svn.apache.org/r1495197 > Log: > r1495154 incorrectly removed the commit > Restore the commit and clean the code up a little. > > Modified: > tomcat/trun

[Bug 55102] Add ability to report time taken to prepare response

https://issues.apache.org/bugzilla/show_bug.cgi?id=55102 --- Comment #2 from Mark Thomas --- Generally the patch looks good to me. It is missing documentation. Other than that I see no reason not to add it to trunk and 7.0.x. -- You are receiving this mail because: You are the assignee for the

[Bug 55071] try finally catch structure masks original exception in JDBCRealm.getPassword()

https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 --- Comment #6 from Mark Thomas --- Opps. My analysis assumed autoCommit == true which it doesn't. The commit is therefore required. I've restored it and cleaned up the code. -- You are receiving this mail because: You are the assignee fo

svn commit: r1495202 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/JDBCRealm.java

Author: markt Date: Thu Jun 20 21:38:59 2013 New Revision: 1495202 URL: http://svn.apache.org/r1495202 Log: r1495155 incorrectly removed the commit Restore the commit and clean the code up a little. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/JDBCRealm.java Modified: tomcat

Re: [Bug 55102] New: Add ability to report time taken to prepare response

On 20/06/2013 22:22, Jeremy Boynes wrote: > On Jun 15, 2013, at 10:09 AM, bugzi...@apache.org wrote: > >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55102 >> Summary: Add ability to report time taken to prepare response >> >> Created attachment 30438 >> --> https://issues.apache

svn commit: r1495197 - /tomcat/trunk/java/org/apache/catalina/realm/JDBCRealm.java

Author: markt Date: Thu Jun 20 21:34:09 2013 New Revision: 1495197 URL: http://svn.apache.org/r1495197 Log: r1495154 incorrectly removed the commit Restore the commit and clean the code up a little. Modified: tomcat/trunk/java/org/apache/catalina/realm/JDBCRealm.java Modified: tomcat/trunk/j

Re: [Bug 55102] New: Add ability to report time taken to prepare response

On Jun 15, 2013, at 10:09 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55102 > Summary: Add ability to report time taken to prepare response > > Created attachment 30438 > --> https://issues.apache.org/bugzilla/attachment.cgi?id=30438&action=edit

Re: svn commit: r1495155 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JDBCRealm.java webapps/docs/changelog.xml

On 20/06/2013 21:51, Konstantin Kolinko wrote: > 2013/6/21 : >> Author: markt >> Date: Thu Jun 20 20:04:03 2013 >> New Revision: 1495155 >> >> URL: http://svn.apache.org/r1495155 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 >> Remove unnecessary call to commit(). The rs.

Re: svn commit: r1495155 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JDBCRealm.java webapps/docs/changelog.xml

2013/6/21 : > Author: markt > Date: Thu Jun 20 20:04:03 2013 > New Revision: 1495155 > > URL: http://svn.apache.org/r1495155 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 > Remove unnecessary call to commit(). The rs.close() just above will commit > anything that needs to

[Bug 55101] BasicAuthenticator parser and associated unit tests

https://issues.apache.org/bugzilla/show_bug.cgi?id=55101 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1495169 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ test/org/apache/catalina/authenticator/ webapps/docs/

Author: markt Date: Thu Jun 20 20:36:08 2013 New Revision: 1495169 URL: http://svn.apache.org/r1495169 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55101 Make BASIC auth parsing more tolerant of whitespace. Added: tomcat/trunk/test/org/apache/catalina/authenticator/TestBasicAu

[Bug 55078] Configuring a DataSource Resource with dataSourceJNDI does not work as expected

https://issues.apache.org/bugzilla/show_bug.cgi?id=55078 Mark Thomas changed: What|Removed |Added Component|Catalina|jdbc-pool Version|trunk

[Bug 54756] EXCEPTION_ACCESS_VIOLATION with APR crashing Tomcat

https://issues.apache.org/bugzilla/show_bug.cgi?id=54756 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Bug 55071] try finally catch structure masks original exception in JDBCRealm.getPassword()

https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1495155 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JDBCRealm.java webapps/docs/changelog.xml

Author: markt Date: Thu Jun 20 20:04:03 2013 New Revision: 1495155 URL: http://svn.apache.org/r1495155 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 Remove unnecessary call to commit(). The rs.close() just above will commit anything that needs to be committed. Modified: t

svn commit: r1495154 - /tomcat/trunk/java/org/apache/catalina/realm/JDBCRealm.java

Author: markt Date: Thu Jun 20 20:01:07 2013 New Revision: 1495154 URL: http://svn.apache.org/r1495154 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55071 Remove unnecessary call to commit(). The rs.close() just above will commit anything that needs to be committed. Modified: t

[Bug 55017] Ability to configure RMI bind address

https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #14 from Mark Thomas --- I see what you mean. Fair enough. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail

[Bug 54503] SAML2 based single sign on

https://issues.apache.org/bugzilla/show_bug.cgi?id=54503 --- Comment #4 from Toby Hobson --- (In reply to Mark Thomas from comment #3) > That is a big patch. > > I have one immediate concern with the proposed patch with is the unknown > licensing of the new JAR file. > > Looking more broadly, I

[Bug 55017] Ability to configure RMI bind address

https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #13 from Alexey Noskov --- It's because I found no way to specify bind address when using SslRMIServerSocketFactory. -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 55017] Ability to configure RMI bind address

https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #12 from Mark Thomas --- Overall patch looks OK. One questions: Why are SSL and rmiBindAddress mutually exclusive? -- You are receiving this mail because: You are the assignee for the bug. ---

Re: CVE-2013-1571, VU#225657

On 20 June 2013 16:33, Christopher Schultz wrote: > Sebb, > > On 6/20/13 9:31 AM, sebb wrote: >> On 20 June 2013 14:16, Christopher Schultz >> wrote: >>> Sebb, >>> >>> On 6/19/13 4:26 AM, sebb wrote: On 19 June 2013 09:15, Mark Thomas wrote: > On 19/06/2013 00:42, Nick Williams wrote:

Re: CVE-2013-1571, VU#225657

Sebb, On 6/20/13 9:31 AM, sebb wrote: > On 20 June 2013 14:16, Christopher Schultz > wrote: >> Sebb, >> >> On 6/19/13 4:26 AM, sebb wrote: >>> On 19 June 2013 09:15, Mark Thomas wrote: On 19/06/2013 00:42, Nick Williams wrote: > > Oracle has announced a Javadoc vulnerability (CVE-2

[Bug 54745] Tomcat JarScanning does not work when Tomcat started with Java Web Start

https://issues.apache.org/bugzilla/show_bug.cgi?id=54745 --- Comment #4 from Nick Williams --- Excellent! Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr

svn commit: r1495047 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

Author: markt Date: Thu Jun 20 15:14:02 2013 New Revision: 1495047 URL: http://svn.apache.org/r1495047 Log: Fix indent Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java URL: http://

[Bug 54808] Add numberOfVersionsToKeep when undeployOldVersions is set to true

https://issues.apache.org/bugzilla/show_bug.cgi?id=54808 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54745] Tomcat JarScanning does not work when Tomcat started with Java Web Start

https://issues.apache.org/bugzilla/show_bug.cgi?id=54745 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1495046 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

Author: markt Date: Thu Jun 20 15:10:22 2013 New Revision: 1495046 URL: http://svn.apache.org/r1495046 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54745 Fix JarScanning when Tomcat is started via Java WebStart. Patch provided by Nick Williams. Modified: tomcat/tc7.0.x/trunk/

svn commit: r1495043 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

Author: markt Date: Thu Jun 20 15:07:55 2013 New Revision: 1495043 URL: http://svn.apache.org/r1495043 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54745 Fix JarScanning when Tomcat is started via Java WebStart. Patch provided by Nick Williams. Modified: tomcat/trunk/java/org/a

[Bug 54503] SAML2 based single sign on

https://issues.apache.org/bugzilla/show_bug.cgi?id=54503 --- Comment #3 from Mark Thomas --- That is a big patch. I have one immediate concern with the proposed patch with is the unknown licensing of the new JAR file. Looking more broadly, I think it would be worth (re-)considering adding JASPI

[Bug 54499] Implementation of Extensible EL Interpreter

https://issues.apache.org/bugzilla/show_bug.cgi?id=54499 --- Comment #7 from Mark Thomas --- I'm +0 to include this in trunk. What do other committers think? -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 53776] Multitenancy support for JDBCRealm

https://issues.apache.org/bugzilla/show_bug.cgi?id=53776 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53665] Minor JNDI Howto document enhancement concerning mail properties

https://issues.apache.org/bugzilla/show_bug.cgi?id=53665 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1495016 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/jndi-resources-howto.xml

Author: markt Date: Thu Jun 20 14:26:40 2013 New Revision: 1495016 URL: http://svn.apache.org/r1495016 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53665 Document when a javax.mail.Authenticator is configured. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x

svn commit: r1495015 - /tomcat/trunk/webapps/docs/jndi-resources-howto.xml

Author: markt Date: Thu Jun 20 14:24:34 2013 New Revision: 1495015 URL: http://svn.apache.org/r1495015 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53665 Document when a javax.mail.Authenticator is configured. Modified: tomcat/trunk/webapps/docs/jndi-resources-howto.xml Modifi

svn commit: r1494999 - in /tomcat/trunk: conf/context.xml webapps/docs/changelog.xml

Author: markt Date: Thu Jun 20 13:50:49 2013 New Revision: 1494999 URL: http://svn.apache.org/r1494999 Log: Make changes to global web.xml trigger reloads Modified: tomcat/trunk/conf/context.xml tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/conf/context.xml URL: http://

Re: CVE-2013-1571, VU#225657

On 20 June 2013 14:16, Christopher Schultz wrote: > Sebb, > > On 6/19/13 4:26 AM, sebb wrote: >> On 19 June 2013 09:15, Mark Thomas wrote: >>> On 19/06/2013 00:42, Nick Williams wrote: Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], VU#225657 [2]) whereby Javadoc g

svn commit: r1494982 - /tomcat/trunk/webapps/docs/changelog.xml

Author: markt Date: Thu Jun 20 13:28:16 2013 New Revision: 1494982 URL: http://svn.apache.org/r1494982 Log: Fix whitespace Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelo

svn commit: r1494978 - /tomcat/trunk/webapps/docs/changelog.xml

Author: markt Date: Thu Jun 20 13:25:03 2013 New Revision: 1494978 URL: http://svn.apache.org/r1494978 Log: Servlet 3.1 implementation is complete Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tru

svn commit: r1494975 - /tomcat/trunk/test/org/apache/catalina/deploy/TestSecurityConstraint.java

Author: markt Date: Thu Jun 20 13:20:08 2013 New Revision: 1494975 URL: http://svn.apache.org/r1494975 Log: Some more unit tests Modified: tomcat/trunk/test/org/apache/catalina/deploy/TestSecurityConstraint.java Modified: tomcat/trunk/test/org/apache/catalina/deploy/TestSecurityConstraint.j

svn commit: r1494974 - /tomcat/trunk/java/org/apache/catalina/deploy/SecurityConstraint.java

Author: markt Date: Thu Jun 20 13:19:54 2013 New Revision: 1494974 URL: http://svn.apache.org/r1494974 Log: Prevent duplicate deny constraints Modified: tomcat/trunk/java/org/apache/catalina/deploy/SecurityConstraint.java Modified: tomcat/trunk/java/org/apache/catalina/deploy/SecurityConstra

Re: CVE-2013-1571, VU#225657

Sebb, On 6/19/13 4:26 AM, sebb wrote: > On 19 June 2013 09:15, Mark Thomas wrote: >> On 19/06/2013 00:42, Nick Williams wrote: >>> >>> Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], >>> VU#225657 [2]) whereby Javadoc generated with Java 5, Java 6, or Java >>> 7 < 7u25 is vulnera

svn commit: r1494963 - /tomcat/trunk/test/org/apache/catalina/deploy/TestSecurityConstraint.java

Author: markt Date: Thu Jun 20 12:51:45 2013 New Revision: 1494963 URL: http://svn.apache.org/r1494963 Log: Some simple unit tests Modified: tomcat/trunk/test/org/apache/catalina/deploy/TestSecurityConstraint.java Modified: tomcat/trunk/test/org/apache/catalina/deploy/TestSecurityConstraint

buildbot failure in ASF Buildbot on tomcat-6-trunk

The Buildbot has detected a new failure on builder tomcat-6-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-6-trunk/builds/555 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

buildbot exception in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1244 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

buildbot exception in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4458 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1494951 - in /tomcat/trunk/java/org/apache/catalina: core/LocalStrings.properties core/StandardContext.java deploy/LocalStrings.properties deploy/SecurityConstraint.java

Author: markt Date: Thu Jun 20 12:27:08 2013 New Revision: 1494951 URL: http://svn.apache.org/r1494951 Log: Refactor with a view to adding some unit tests Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/core/StandardContex

svn commit: r1494930 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Thu Jun 20 11:17:51 2013 New Revision: 1494930 URL: http://svn.apache.org/r1494930 Log: Another copy/paste error Also need to protect any remaining patterns with only omitted methods. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomc

svn commit: r1494926 - /tomcat/trunk/webapps/examples/WEB-INF/web.xml

Author: markt Date: Thu Jun 20 11:03:54 2013 New Revision: 1494926 URL: http://svn.apache.org/r1494926 Log: Explicitly deny the uncovered methods in the examples Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml URL: http://svn.a

svn commit: r1494925 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Thu Jun 20 11:03:22 2013 New Revision: 1494925 URL: http://svn.apache.org/r1494925 Log: Fix some copy/paste errors Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL: htt

svn commit: r1494918 - /tomcat/trunk/webapps/examples/jsp/security/protected/index.jsp

Author: markt Date: Thu Jun 20 10:41:55 2013 New Revision: 1494918 URL: http://svn.apache.org/r1494918 Log: The form needs a submit button Modified: tomcat/trunk/webapps/examples/jsp/security/protected/index.jsp Modified: tomcat/trunk/webapps/examples/jsp/security/protected/index.jsp URL: h

svn commit: r1494915 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/ test/org/apache/catalina/core/

Author: markt Date: Thu Jun 20 10:38:49 2013 New Revision: 1494915 URL: http://svn.apache.org/r1494915 Log: Servlet 3.1 Implement the new deny-uncovered-http-methods element in server.xml Modified: tomcat/trunk/java/org/apache/catalina/Context.java tomcat/trunk/java/org/apache/catalina/co