Re: svn commit: r1803929 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2017-08-02 Thread Rainer Jung
Am 02.08.2017 um 23:33 schrieb ma...@apache.org: Author: markt Date: Wed Aug 2 21:33:52 2017 New Revision: 1803929 URL: http://svn.apache.org/viewvc?rev=1803929=rev Log: Add release date Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Modified:

[VOTE] Release Apache Tomcat 8.5.20

2017-08-02 Thread Mark Thomas
The proposed Apache Tomcat 8.5.20 release is now available for voting. The major changes compared to the 8.5.16 release are: - Enable TLS connectors to use Java key stores that contain multiple keys where each key has a separate password. Based on a patch by Frank Taffelt. - Make

[Bug 57767] Websocket client proprietary configuration

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #10 from Mark Thomas --- Add execute.validate=true to your build.properties file and run ant validate The configuration files are in res/checkstyle. Please open a new bugzilla enhancement for adding

[Bug 57767] Websocket client proprietary configuration

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #9 from J Fernandez --- Where can I learn more about CheckStyle? I assume, there is a formatting file involved. Also, I am interested in adding support for authentication, should I submit a patch to to this

svn commit: r20733 - in /dev/tomcat/tomcat-8/v8.5.20: ./ bin/ bin/embed/ bin/extras/ src/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 21:57:07 2017 New Revision: 20733 Log: Upload 8.5.20 for voting Added: dev/tomcat/tomcat-8/v8.5.20/ dev/tomcat/tomcat-8/v8.5.20/KEYS dev/tomcat/tomcat-8/v8.5.20/README.html dev/tomcat/tomcat-8/v8.5.20/RELEASE-NOTES

svn commit: r1803930 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_20: ./ build.properties.default webapps/docs/changelog.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 21:34:55 2017 New Revision: 1803930 URL: http://svn.apache.org/viewvc?rev=1803930=rev Log: Tag 8.5.20 Added: tomcat/tc8.5.x/tags/TOMCAT_8_5_20/ (props changed) - copied from r1803929, tomcat/tc8.5.x/trunk/ Modified:

svn commit: r1803929 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 21:33:52 2017 New Revision: 1803929 URL: http://svn.apache.org/viewvc?rev=1803929=rev Log: Add release date Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1803928 - /tomcat/tc8.5.x/tags/TOMCAT_8_5_20/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 21:32:59 2017 New Revision: 1803928 URL: http://svn.apache.org/viewvc?rev=1803928=rev Log: Need to re-tag Removed: tomcat/tc8.5.x/tags/TOMCAT_8_5_20/ - To unsubscribe, e-mail:

[VOTE] Release Apache Tomcat 9.0.0.M26

2017-08-02 Thread Mark Thomas
The proposed Apache Tomcat 9.0.0.M26 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 Note that the

svn commit: r1803927 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_20: ./ build.properties.default webapps/docs/changelog.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 21:28:05 2017 New Revision: 1803927 URL: http://svn.apache.org/viewvc?rev=1803927=rev Log: Tagging 8.5.20 Added: tomcat/tc8.5.x/tags/TOMCAT_8_5_20/ (props changed) - copied from r1803926, tomcat/tc8.5.x/trunk/ Modified:

RE: Default servlet regressions

2017-08-02 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: Default servlet regressions > It's nice to know that the EBCDIC->ShiftJIS conversion is now reliable. We actually do have customers that use that conversion (but perhaps not in Tomcat). - Chuck THIS

Re: Default servlet regressions

2017-08-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 8/2/17 4:35 PM, Mark Thomas wrote: > On 02/08/17 21:23, Christopher Schultz wrote: >> Mark, >> >> On 7/31/17 12:16 PM, Mark Thomas wrote: >>> On 30/07/17 19:04, Mark Thomas wrote: All, It looks like there is another

svn commit: r20732 - in /dev/tomcat/tomcat-9/v9.0.0.M26: ./ bin/ bin/embed/ bin/extras/ src/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 21:01:02 2017 New Revision: 20732 Log: Upload 9.0.0.M26 for a release vote Added: dev/tomcat/tomcat-9/v9.0.0.M26/ dev/tomcat/tomcat-9/v9.0.0.M26/KEYS dev/tomcat/tomcat-9/v9.0.0.M26/README.html dev/tomcat/tomcat-9/v9.0.0.M26/RELEASE-NOTES

svn commit: r1803923 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 20:53:05 2017 New Revision: 1803923 URL: http://svn.apache.org/viewvc?rev=1803923=rev Log: Increment version for next dev cycle Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default

Re: svn commit: r1803654 - in /tomcat/site/trunk: docs/migration-85.html xdocs/migration-85.xml

2017-08-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 8/2/17 8:19 AM, Konstantin Kolinko wrote: > 2017-08-01 18:34 GMT+03:00 : >> Author: schultz Date: Tue Aug 1 15:34:35 2017 New Revision: >> 1803654 >> >> URL: http://svn.apache.org/viewvc?rev=1803654=rev Log:

svn commit: r1803922 - /tomcat/site/trunk/docs/migration-85.html

2017-08-02 Thread schultz
Author: schultz Date: Wed Aug 2 20:45:34 2017 New Revision: 1803922 URL: http://svn.apache.org/viewvc?rev=1803922=rev Log: Fix typo and missing URL. Modified: tomcat/site/trunk/docs/migration-85.html Modified: tomcat/site/trunk/docs/migration-85.html URL:

svn commit: r1803921 - /tomcat/site/trunk/xdocs/migration-85.xml

2017-08-02 Thread schultz
Author: schultz Date: Wed Aug 2 20:44:25 2017 New Revision: 1803921 URL: http://svn.apache.org/viewvc?rev=1803921=rev Log: Fix typo and missing URL. Modified: tomcat/site/trunk/xdocs/migration-85.xml Modified: tomcat/site/trunk/xdocs/migration-85.xml URL:

svn commit: r20731 - in /release/tomcat: tomcat-8/v8.5.19/ tomcat-9/v9.0.0.M25/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 20:43:06 2017 New Revision: 20731 Log: Drop known bad releases from mirrors Removed: release/tomcat/tomcat-8/v8.5.19/ release/tomcat/tomcat-9/v9.0.0.M25/ - To unsubscribe, e-mail:

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark and João, On 8/2/17 3:38 AM, Mark Thomas wrote: > On 02/08/2017 00:02, João Paulo Lemes Machado wrote: >> Hi Mark. >> >> Did you take a look at my suggestion? > > Yes. I don't think the cost is worth the benefit. +1 So what if the class

Re: Default servlet regressions

2017-08-02 Thread Mark Thomas
On 02/08/17 21:23, Christopher Schultz wrote: > Mark, > > On 7/31/17 12:16 PM, Mark Thomas wrote: >> On 30/07/17 19:04, Mark Thomas wrote: >>> All, >>> >>> It looks like there is another regression in the Default >>> Servlet. >>> >>> While I think I have a patch for this, I'm currently leaning

[Bug 61369] Tomcat 8.5.16 vulnerable to CVE-2016-0793

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61369 --- Comment #5 from Christopher Schultz --- (In reply to Mark Thomas from comment #3) > The canonical path check is still required to enforce the required case > sensitivity. > > The Window APIs, most likely for

Re: Default servlet regressions

2017-08-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 7/31/17 12:16 PM, Mark Thomas wrote: > On 30/07/17 19:04, Mark Thomas wrote: >> All, >> >> It looks like there is another regression in the Default >> Servlet. >> >> While I think I have a patch for this, I'm currently leaning >> towards

svn commit: r1803915 - in /tomcat/tags/TOMCAT_9_0_0_M26: ./ build.properties.default webapps/docs/changelog.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 20:22:56 2017 New Revision: 1803915 URL: http://svn.apache.org/viewvc?rev=1803915=rev Log: Tag 9.0.0.M26 Added: tomcat/tags/TOMCAT_9_0_0_M26/ (props changed) - copied from r1803914, tomcat/trunk/ Modified:

svn commit: r1803914 - /tomcat/trunk/webapps/docs/changelog.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 20:21:24 2017 New Revision: 1803914 URL: http://svn.apache.org/viewvc?rev=1803914=rev Log: Fix odd UTF-8 character. jmx -> JMX Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

Re: Default servlet regressions

2017-08-02 Thread Mark Thomas
On 31/07/17 17:16, Mark Thomas wrote: > On 30/07/17 19:04, Mark Thomas wrote: >> All, >> >> It looks like there is another regression in the Default Servlet. >> >> While I think I have a patch for this, I'm currently leaning towards >> doing the following: >> >> - Announcing the 8.5.19 and

buildbot success in on tomcat-7-trunk

2017-08-02 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/836 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread Mark Thomas
On 02/08/17 20:18, João Paulo Lemes Machado wrote: > When you talk about the cost, do you mean backward compatibility? The time taken to do it, the duplicated code until the deprecated code can be removed, the cost of downstream users updating their code. All for a minimal maintenance benefit.

svn commit: r1803910 - in /tomcat/native/trunk/xdocs: index.xml news/2017.xml news/project.xml project.xml

2017-08-02 Thread csutherl
Author: csutherl Date: Wed Aug 2 19:29:35 2017 New Revision: 1803910 URL: http://svn.apache.org/viewvc?rev=1803910=rev Log: Update current version from 1.2.10 to 1.2.12, Add 2017 news page, Fix XML formatting, and add 8.5 doc link Added: tomcat/native/trunk/xdocs/news/2017.xml (with

svn commit: r1803908 - /tomcat/native/trunk/native/configure.in

2017-08-02 Thread wrowe
Author: wrowe Date: Wed Aug 2 19:27:58 2017 New Revision: 1803908 URL: http://svn.apache.org/viewvc?rev=1803908=rev Log: The tcn include files do not live in builddir, they are not generated. These live in the srcdir (other aliases would be forward references.) Modified:

svn commit: r1803907 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 19:26:17 2017 New Revision: 1803907 URL: http://svn.apache.org/viewvc?rev=1803907=rev Log: Fix build Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified:

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread João Paulo Lemes Machado
When you talk about the cost, do you mean backward compatibility? 2017-08-02 4:38 GMT-03:00 Mark Thomas : > On 02/08/2017 00:02, João Paulo Lemes Machado wrote: > > Hi Mark. > > > > Did you take a look at my suggestion? > > Yes. I don't think the cost is worth the benefit. > >

buildbot failure in on tomcat-7-trunk

2017-08-02 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/835 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 57767] Websocket client proprietary configuration

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1803906 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 19:07:56 2017 New Revision: 1803906 URL: http://svn.apache.org/viewvc?rev=1803906=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Add support to the WebSocket client for following redirects when attempting to establish a WebSocket connection.

svn commit: r1803904 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 19:01:26 2017 New Revision: 1803904 URL: http://svn.apache.org/viewvc?rev=1803904=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Add support to the WebSocket client for following redirects when attempting to establish a WebSocket connection.

svn commit: r1803902 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 18:56:21 2017 New Revision: 1803902 URL: http://svn.apache.org/viewvc?rev=1803902=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Add support to the WebSocket client for following redirects when attempting to establish a WebSocket connection.

svn commit: r1803901 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 18:55:44 2017 New Revision: 1803901 URL: http://svn.apache.org/viewvc?rev=1803901=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Add support to the WebSocket client for following redirects when attempting to establish a WebSocket connection.

[jira] [Created] (MTOMCAT-311) latest 3.0-SNAPSHOT is not on https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/maven/

2017-08-02 Thread laurent perez (JIRA)
laurent perez created MTOMCAT-311: - Summary: latest 3.0-SNAPSHOT is not on https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/maven/ Key: MTOMCAT-311 URL:

[Bug 61366] "Unable to find [comp]" when attempting to use JNDI datasource for JDBCStore session store

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61366 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 61369] Tomcat 8.5.16 vulnerable to CVE-2016-0793

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61369 Brett Schoppert changed: What|Removed |Added Resolution|--- |INVALID

svn commit: r1803832 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/session/JDBCStore.java webapps/docs/changelog.xml webapps/docs/config/manager.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 15:35:13 2017 New Revision: 1803832 URL: http://svn.apache.org/viewvc?rev=1803832=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61366 Add a new attribute, localDataSource, to the JDBCStore that allows the Store to be configured to use a DataSource

svn commit: r1803829 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/session/JDBCStore.java webapps/docs/changelog.xml webapps/docs/config/manager.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 15:32:53 2017 New Revision: 1803829 URL: http://svn.apache.org/viewvc?rev=1803829=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61366 Add a new attribute, localDataSource, to the JDBCStore that allows the Store to be configured to use a DataSource

[GitHub] tomcat pull request #71: Fix #61366 - Set the TCCL to that of the webapp con...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

svn commit: r1803828 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java webapps/docs/changelog.xml webapps/docs/config/manager.xml

2017-08-02 Thread markt
Author: markt Date: Wed Aug 2 15:31:42 2017 New Revision: 1803828 URL: http://svn.apache.org/viewvc?rev=1803828=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61366 Add a new attribute, localDataSource, to the JDBCStore that allows the Store to be configured to use a DataSource

[Bug 61372] error 500 NullPointerException when no user agent is specified

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61372 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 61372] New: error 500 NullPointerException when no user agent is specified

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61372 Bug ID: 61372 Summary: error 500 NullPointerException when no user agent is specified Product: Tomcat 7 Version: 7.0.75 Hardware: PC OS: Linux

svn commit: r1803817 - in /tomcat/native/trunk/native: libtcnative.dsp tcnative.dsp

2017-08-02 Thread wrowe
Author: wrowe Date: Wed Aug 2 13:18:11 2017 New Revision: 1803817 URL: http://svn.apache.org/viewvc?rev=1803817=rev Log: The addition of bb.c, os.c was missed from the .dsp project files Modified: tomcat/native/trunk/native/libtcnative.dsp tomcat/native/trunk/native/tcnative.dsp

Re: svn commit: r1803654 - in /tomcat/site/trunk: docs/migration-85.html xdocs/migration-85.xml

2017-08-02 Thread Konstantin Kolinko
2017-08-01 18:34 GMT+03:00 : > Author: schultz > Date: Tue Aug 1 15:34:35 2017 > New Revision: 1803654 > > URL: http://svn.apache.org/viewvc?rev=1803654=rev > Log: > Add note about HTTP reason phrase in Migration Guide. > > Modified: >

[Bug 61369] Tomcat 8.5.16 vulnerable to CVE-2016-0793

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61369 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

[Bug 61369] Tomcat 8.5.16 vulnerable to CVE-2016-0793

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61369 --- Comment #2 from Remy Maucherat --- The canonical path comparison is a last resort safety net. So it's still useful then, that's interesting. If you confirm the behavior, it seems we're good as is, the check is supposed to

[Bug 61369] Tomcat 8.5.16 vulnerable to CVE-2016-0793

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61369 Svetlin Zarev changed: What|Removed |Added CC|

[Bug 61369] Tomcat 8.5.16 vulnerable to CVE-2016-0793

2017-08-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61369 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread Mark Thomas
On 02/08/2017 00:02, João Paulo Lemes Machado wrote: > Hi Mark. > > Did you take a look at my suggestion? Yes. I don't think the cost is worth the benefit. Mark > > 2017-07-25 15:33 GMT-03:00 João Paulo Lemes Machado > : > >> Hi Mark, tanks for the comment. >> >>