Re: Migrating to git

2017-12-05 Thread Mohamed Abd ALLAH
+1 for git. +1 for Branches instead of tags. On Tue, Dec 5, 2017 at 9:05 PM, Huxing Zhang wrote: > Hi, > > I am +1 on migrating to git. I think this will help people easier to get > involved. > > One quick question to Plan A: > After migration to git, will the previous mirrors, e.g. > https://gi

Re: Migrating to git

2017-12-05 Thread Huxing Zhang
Hi, I am +1 on migrating to git. I think this will help people easier to get involved. One quick question to Plan A: After migration to git, will the previous mirrors, e.g. https://github.com/apache/tomcat70, be removed? We maintain an internal repository with selective tomcat versions, whic

svn commit: r1817248 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/ByteChunk.java test/org/apache/tomcat/util/buf/TestByteChunk.java

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 22:37:33 2017 New Revision: 1817248 URL: http://svn.apache.org/viewvc?rev=1817248&view=rev Log: Fix SpotBugs warning (rank <=16) serialization for ByteChunk Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java tomcat/trunk/test/org/apache/to

svn commit: r1817244 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 22:15:16 2017 New Revision: 1817244 URL: http://svn.apache.org/viewvc?rev=1817244&view=rev Log: Fix some SpotBugs (rank <=16) issues Mark in/out as transient since serialization is primarily used to expose values - e.g. via JMX. I did look at removing serialization

svn commit: r1817242 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 21:52:41 2017 New Revision: 1817242 URL: http://svn.apache.org/viewvc?rev=1817242&view=rev Log: Another follow-up to r1817240 Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: htt

[Bug 59179] HTTP Public Key Pinning (HPKP) for Tomcat

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59179 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

svn commit: r1817241 - /tomcat/trunk/java/org/apache/catalina/tribes/Member.java

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 21:50:48 2017 New Revision: 1817241 URL: http://svn.apache.org/viewvc?rev=1817241&view=rev Log: Follow-up to r1817240 Modified: tomcat/trunk/java/org/apache/catalina/tribes/Member.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/Member.java URL: htt

svn commit: r1817240 - in /tomcat/trunk/java/org/apache/catalina/tribes/tipis: AbstractReplicatedMap.java LazyReplicatedMap.java ReplicatedMap.java

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 21:50:00 2017 New Revision: 1817240 URL: http://svn.apache.org/viewvc?rev=1817240&view=rev Log: Fix remaining SpotBugs issues (rank <=16) in tribes Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java tomcat/trunk/java/org

[Bug 59179] HTTP Public Key Pinning (HPKP) for Tomcat

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59179 Christopher Schultz changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from Chr

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #16 from Mark Thomas --- Please move this to the users list. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: d

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #15 from Jesse --- That gives an InstanceNotFoundException, I can't find any Catalina:* objects. Even if that did return an object, could I gain direct access to the AbstractEndpoint instance that I want to call the methods against

Re: Migrating to git

2017-12-05 Thread Mark Thomas
On 05/12/17 20:43, Emmanuel Bourg wrote: > Le 05/12/2017 à 21:03, Mark Thomas a écrit : > >> and then migrate /trunk, /tags and /branches to git, leaving the rest in >> place. Most will stay there. Some components may move to git in the future. > > The goal is to put all Tomcat versions in the sa

Re: Migrating to git

2017-12-05 Thread Coty Sutherland
On Tue, Dec 5, 2017 at 3:43 PM, Emmanuel Bourg wrote: > Le 05/12/2017 à 21:03, Mark Thomas a écrit : > >> and then migrate /trunk, /tags and /branches to git, leaving the rest in >> place. Most will stay there. Some components may move to git in the future. > > The goal is to put all Tomcat versio

buildbot success in on tomcat-8-trunk

2017-12-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1197 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Migrating to git

2017-12-05 Thread Emmanuel Bourg
Le 05/12/2017 à 21:03, Mark Thomas a écrit : > and then migrate /trunk, /tags and /branches to git, leaving the rest in > place. Most will stay there. Some components may move to git in the future. The goal is to put all Tomcat versions in the same Git repository right? Would that make the svn ta

[GitHub] tomcat pull request #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-12-05 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/95 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223

2017-12-05 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/95 Thanks for the patch. There wasn't anything wrong with it but the more I thought about it, the more I thought that referencing the DTD directly was a better solution. ---

[Bug 61223] Enhance the documentation for mbeans-descriptors.xml

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61223 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1817230 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml webapps/docs/mbeans-descriptors-howto.xml

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 20:37:26 2017 New Revision: 1817230 URL: http://svn.apache.org/viewvc?rev=1817230&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223 Add the mbeans-descriptors.dtd file to the custom MBean documentation so users have a reference to use when const

svn commit: r1817229 - in /tomcat/tc8.0.x/trunk: ./ build.xml webapps/docs/changelog.xml webapps/docs/mbeans-descriptors-howto.xml

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 20:33:25 2017 New Revision: 1817229 URL: http://svn.apache.org/viewvc?rev=1817229&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223 Add the mbeans-descriptors.dtd file to the custom MBean documentation so users have a reference to use when const

svn commit: r1817228 - in /tomcat/tc8.5.x/trunk: ./ build.xml webapps/docs/changelog.xml webapps/docs/mbeans-descriptors-howto.xml

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 20:30:56 2017 New Revision: 1817228 URL: http://svn.apache.org/viewvc?rev=1817228&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223 Add the mbeans-descriptors.dtd file to the custom MBean documentation so users have a reference to use when const

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #14 from Mark Thomas --- Catalina:type=ThreadPool,name="http-nio-8080" -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #13 from Jesse --- I was able to see many tomcat mbeans using: ManagementFactory.getPlatformMBeanServer().queryNames(new ObjectName("Tomcat:*"), null) However I don't see any that look like they'd represent an endpoint in that lis

Migrating to git

2017-12-05 Thread Mark Thomas
Hi all, I've been doing some experiments to see how we might migrate from our current svn structure to git. It appears that git svn is able to follow directory moves so, with that in mind, I'd like to propose the following outline plan: Plan A == 0. Run plan past infra 1. Restructure svn 2.

svn commit: r1817223 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml webapps/docs/mbeans-descriptors-howto.xml

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 19:23:20 2017 New Revision: 1817223 URL: http://svn.apache.org/viewvc?rev=1817223&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223 Add the mbeans-descriptors.dtd file to the custom MBean documentation so users have a reference to use when const

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #12 from Christopher Schultz --- (In reply to Jesse from comment #11) > I'd rather not use JMX, I'm not totally familiar with JMX but wouldn't that > require me to enable JMX on a port in our application? You can use JMX within the

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #11 from Jesse --- I'd rather not use JMX, I'm not totally familiar with JMX but wouldn't that require me to enable JMX on a port in our application? If I can use JMX directly via the embedded tomcat without doing any tcp port type

[GitHub] tomcat issue #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223

2017-12-05 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/95 This is a partial fix. It only addresses the attributes of the mbean element. I'm wondering if, rather than duplicate the comments in the DTD file, if it would be simpler to copy the DTD to

[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762 --- Comment #10 from Mark Thomas --- Off the top of my head (I can check later if this doesn't work) you should be able to do this via JMX. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1817196 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2017-12-05 Thread markt
Author: markt Date: Tue Dec 5 13:32:21 2017 New Revision: 1817196 URL: http://svn.apache.org/viewvc?rev=1817196&view=rev Log: Update false positive list after DBCP update Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positive

svn commit: r1817166 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java

2017-12-05 Thread remm
Author: remm Date: Tue Dec 5 09:07:08 2017 New Revision: 1817166 URL: http://svn.apache.org/viewvc?rev=1817166&view=rev Log: - Don't use setHeader for the cookie header, the header copy is done before. - Use AJP auth mechanism to pass a userName that will be used again for auth. Modified: to